From f14ef661cd304760904f474ab0b9e20fab46d40e Mon Sep 17 00:00:00 2001 From: Anshul Riyal Date: Mon, 9 May 2022 01:17:58 +0530 Subject: [PATCH] Move Rails/LexicallyScopedActionFilter into separate TODO file Changelog: other --- .rubocop_todo.yml | 7 --- .../rails/lexically_scoped_action_filter.yml | 48 +++++++++++++++++++ 2 files changed, 48 insertions(+), 7 deletions(-) create mode 100644 .rubocop_todo/rails/lexically_scoped_action_filter.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 178311bbc954f6..d528053ca2ef9b 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -125,13 +125,6 @@ Rails/IndexWith: Rails/InverseOf: Enabled: false -# Offense count: 62 -# Configuration parameters: Include. -# Include: app/controllers/**/*.rb -Rails/LexicallyScopedActionFilter: - Enabled: false - - # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: Include. diff --git a/.rubocop_todo/rails/lexically_scoped_action_filter.yml b/.rubocop_todo/rails/lexically_scoped_action_filter.yml new file mode 100644 index 00000000000000..84b85f76c684a4 --- /dev/null +++ b/.rubocop_todo/rails/lexically_scoped_action_filter.yml @@ -0,0 +1,48 @@ +--- +Rails/LexicallyScopedActionFilter: + # Offense count: 73 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/controllers/admin/groups_controller.rb' + - 'app/controllers/clusters/base_controller.rb' + - 'app/controllers/clusters/clusters_controller.rb' + - 'app/controllers/concerns/enforces_two_factor_authentication.rb' + - 'app/controllers/concerns/integrations/actions.rb' + - 'app/controllers/concerns/multiple_boards_actions.rb' + - 'app/controllers/concerns/oauth_applications.rb' + - 'app/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support.rb' + - 'app/controllers/confirmations_controller.rb' + - 'app/controllers/dashboard_controller.rb' + - 'app/controllers/groups/group_members_controller.rb' + - 'app/controllers/groups/milestones_controller.rb' + - 'app/controllers/groups/runners_controller.rb' + - 'app/controllers/groups/uploads_controller.rb' + - 'app/controllers/groups_controller.rb' + - 'app/controllers/import/base_controller.rb' + - 'app/controllers/oauth/applications_controller.rb' + - 'app/controllers/passwords_controller.rb' + - 'app/controllers/projects/badges_controller.rb' + - 'app/controllers/projects/branches_controller.rb' + - 'app/controllers/projects/environments_controller.rb' + - 'app/controllers/projects/incidents_controller.rb' + - 'app/controllers/projects/issue_links_controller.rb' + - 'app/controllers/projects/issues_controller.rb' + - 'app/controllers/projects/labels_controller.rb' + - 'app/controllers/projects/merge_requests_controller.rb' + - 'app/controllers/projects/milestones_controller.rb' + - 'app/controllers/projects/notes_controller.rb' + - 'app/controllers/projects/pipelines_controller.rb' + - 'app/controllers/projects/project_members_controller.rb' + - 'app/controllers/projects/prometheus/alerts_controller.rb' + - 'app/controllers/projects/releases_controller.rb' + - 'app/controllers/projects/service_hook_logs_controller.rb' + - 'app/controllers/projects/snippets_controller.rb' + - 'app/controllers/projects/tags_controller.rb' + - 'app/controllers/projects/todos_controller.rb' + - 'app/controllers/projects/tree_controller.rb' + - 'app/controllers/projects/uploads_controller.rb' + - 'app/controllers/snippets/blobs_controller.rb' + - 'app/controllers/snippets/notes_controller.rb' + - 'app/controllers/snippets_controller.rb' + - 'app/controllers/uploads_controller.rb' -- GitLab