From 4a721b162e92c8050deeb23b647975db96e94ed4 Mon Sep 17 00:00:00 2001
From: Anshul Riyal <anshulriyal00@gmail.com>
Date: Mon, 9 May 2022 00:51:29 +0530
Subject: [PATCH] Move Rails/ActiveRecordCallbacksOrder into separate TODO file

Changelog: other
---
 .rubocop.yml                                  |  5 ++++
 .rubocop_todo.yml                             |  7 -----
 .../rails/active_record_callbacks_order.yml   | 28 +++++++++++++++++++
 3 files changed, 33 insertions(+), 7 deletions(-)
 create mode 100644 .rubocop_todo/rails/active_record_callbacks_order.yml

diff --git a/.rubocop.yml b/.rubocop.yml
index c99d3d0b6ab5ca..3bdccd69dbbfa2 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -243,6 +243,11 @@ Rails/ApplicationRecord:
     - ee/db/**/*.rb
     - ee/spec/**/*.rb
 
+Rails/ActiveRecordCallbacksOrder:
+  Include:
+    - app/models/**/*.rb
+    - ee/app/models/**/*.rb
+
 Cop/DefaultScope:
   Enabled: true
 
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 64ee60d7eb82a3..9fb8cd1dc50433 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -22,13 +22,6 @@ RSpec/PredicateMatcher:
 RSpec/RepeatedExampleGroupBody:
   Enabled: false
 
-# Offense count: 26
-# Cop supports --auto-correct.
-# Configuration parameters: Include.
-# Include: app/models/**/*.rb
-Rails/ActiveRecordCallbacksOrder:
-  Enabled: false
-
 # Offense count: 313
 # Configuration parameters: Include.
 # Include: db/migrate/*.rb
diff --git a/.rubocop_todo/rails/active_record_callbacks_order.yml b/.rubocop_todo/rails/active_record_callbacks_order.yml
new file mode 100644
index 00000000000000..9585a720c6ac18
--- /dev/null
+++ b/.rubocop_todo/rails/active_record_callbacks_order.yml
@@ -0,0 +1,28 @@
+---
+# Cop supports --auto-correct.
+Rails/ActiveRecordCallbacksOrder:
+  # Offense count: 30
+  # Temporarily disabled due to too many offenses
+  Enabled: false
+  Exclude:
+    - 'app/models/award_emoji.rb'
+    - 'app/models/ci/job_artifact.rb'
+    - 'app/models/gpg_key.rb'
+    - 'app/models/group.rb'
+    - 'app/models/issue.rb'
+    - 'app/models/key.rb'
+    - 'app/models/merge_request.rb'
+    - 'app/models/namespace.rb'
+    - 'app/models/namespace_statistics.rb'
+    - 'app/models/note.rb'
+    - 'app/models/pages_domain.rb'
+    - 'app/models/personal_access_token.rb'
+    - 'app/models/project.rb'
+    - 'app/models/prometheus_alert.rb'
+    - 'app/models/remote_mirror.rb'
+    - 'app/models/resource_label_event.rb'
+    - 'app/models/snippet_statistics.rb'
+    - 'app/models/upload.rb'
+    - 'app/models/user.rb'
+    - 'ee/app/models/dast_site_profile.rb'
+    - 'ee/app/models/geo_node.rb'
-- 
GitLab