From a972cd459128b0a719d84b0386abf5660c8accaf Mon Sep 17 00:00:00 2001 From: Anshul Riyal Date: Mon, 9 May 2022 00:27:23 +0530 Subject: [PATCH] Move Performance/ConstantRegexp into separate TODO file Changelog: other --- .rubocop_todo.yml | 5 --- .rubocop_todo/performance/constant_regexp.yml | 32 +++++++++++++++++++ 2 files changed, 32 insertions(+), 5 deletions(-) create mode 100644 .rubocop_todo/performance/constant_regexp.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 4d2477c199dd06..0944a352468a54 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -11,11 +11,6 @@ Gitlab/PolicyRuleBoolean: Exclude: - 'ee/app/policies/ee/identity_provider_policy.rb' -# Offense count: 41 -# Cop supports --auto-correct. -Performance/ConstantRegexp: - Enabled: false - # Offense count: 1428 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. diff --git a/.rubocop_todo/performance/constant_regexp.yml b/.rubocop_todo/performance/constant_regexp.yml new file mode 100644 index 00000000000000..fb2b7d6ef49e90 --- /dev/null +++ b/.rubocop_todo/performance/constant_regexp.yml @@ -0,0 +1,32 @@ +--- +# Cop supports --auto-correct. +Performance/ConstantRegexp: + # Offense count: 46 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/models/commit.rb' + - 'app/models/commit_range.rb' + - 'app/models/custom_emoji.rb' + - 'app/models/gpg_key.rb' + - 'app/models/merge_request.rb' + - 'app/models/project.rb' + - 'app/models/wiki.rb' + - 'ee/app/models/ee/epic.rb' + - 'lib/banzai/filter/custom_emoji_filter.rb' + - 'lib/gitlab/cleanup/project_uploads.rb' + - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' + - 'lib/gitlab/dependency_linker/base_linker.rb' + - 'lib/gitlab/dependency_linker/composer_json_linker.rb' + - 'lib/gitlab/dependency_linker/godeps_json_linker.rb' + - 'lib/gitlab/dependency_linker/podspec_linker.rb' + - 'lib/gitlab/git.rb' + - 'lib/gitlab/job_waiter.rb' + - 'lib/gitlab/metrics/dashboard/url.rb' + - 'lib/gitlab/path_regex.rb' + - 'lib/gitlab/regex.rb' + - 'scripts/perf/query_limiting_report.rb' + - 'scripts/validate_migration_schema' + - 'spec/models/concerns/token_authenticatable_spec.rb' + - 'spec/scripts/lib/glfm/update_specification_spec.rb' + - 'spec/services/notes/copy_service_spec.rb' -- GitLab