From 5ed072c3c1d9d4d7f81d6bd2ca5e683f48d9e03d Mon Sep 17 00:00:00 2001
From: Vitali Tatarintev <Kalastiuz@gmail.com>
Date: Tue, 3 May 2022 13:33:31 +0200
Subject: [PATCH] Move Style/IfInsideElse into separate TODO file

---
 .rubocop_todo.yml                      |  5 ---
 .rubocop_todo/style/if_inside_else.yml | 49 ++++++++++++++++++++++++++
 2 files changed, 49 insertions(+), 5 deletions(-)
 create mode 100644 .rubocop_todo/style/if_inside_else.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 37c5c2ed238996..4e633f4699c3c2 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -224,11 +224,6 @@ Style/HashAsLastArrayItem:
 Style/HashEachMethods:
   Enabled: false
 
-# Offense count: 34
-# Configuration parameters: AllowIfModifier.
-Style/IfInsideElse:
-  Enabled: false
-
 # Offense count: 64
 # Cop supports --auto-correct.
 Style/KeywordParametersOrder:
diff --git a/.rubocop_todo/style/if_inside_else.yml b/.rubocop_todo/style/if_inside_else.yml
new file mode 100644
index 00000000000000..fcddbae74fc05a
--- /dev/null
+++ b/.rubocop_todo/style/if_inside_else.yml
@@ -0,0 +1,49 @@
+---
+Style/IfInsideElse:
+  # Offense count: 43
+  # Temporarily disabled due to too many offenses
+  Enabled: false
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'app/controllers/passwords_controller.rb'
+    - 'app/finders/projects_finder.rb'
+    - 'app/finders/user_recent_events_finder.rb'
+    - 'app/helpers/diff_helper.rb'
+    - 'app/helpers/members_helper.rb'
+    - 'app/helpers/search_helper.rb'
+    - 'app/models/ci/build.rb'
+    - 'app/models/namespace.rb'
+    - 'app/presenters/project_presenter.rb'
+    - 'app/services/service_ping/build_payload_service.rb'
+    - 'app/services/system_notes/commit_service.rb'
+    - 'app/services/task_list_toggle_service.rb'
+    - 'app/services/user_project_access_changed_service.rb'
+    - 'app/uploaders/gitlab_uploader.rb'
+    - 'config/settings.rb'
+    - 'ee/app/controllers/ee/registrations/welcome_controller.rb'
+    - 'ee/app/controllers/groups/omniauth_callbacks_controller.rb'
+    - 'ee/app/models/ee/namespace.rb'
+    - 'ee/app/models/protected_environments/authorizable.rb'
+    - 'ee/app/policies/ee/group_policy.rb'
+    - 'ee/app/services/app_sec/dast/site_profiles/audit/update_service.rb'
+    - 'ee/app/services/deployments/approval_service.rb'
+    - 'ee/app/services/geo/framework_repository_sync_service.rb'
+    - 'ee/app/services/geo/repository_base_sync_service.rb'
+    - 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb'
+    - 'ee/app/services/vulnerability_external_issue_links/create_service.rb'
+    - 'ee/lib/gitlab/geo/base_batcher.rb'
+    - 'lib/api/projects.rb'
+    - 'lib/gitlab/auth.rb'
+    - 'lib/gitlab/conflict/file.rb'
+    - 'lib/gitlab/sql/pattern.rb'
+    - 'lib/gitlab/usage/service_ping/payload_keys_processor.rb'
+    - 'lib/tasks/gitlab/cleanup.rake'
+    - 'lib/tasks/gitlab/shell.rake'
+    - 'qa/qa/resource/protected_branch.rb'
+    - 'qa/qa/specs/helpers/feature_flag.rb'
+    - 'rubocop/cop/migration/add_limit_to_text_columns.rb'
+    - 'scripts/review_apps/automated_cleanup.rb'
+    - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb'
+    - 'spec/support/import_export/export_file_helper.rb'
+    - 'spec/support/shared_examples/finders/snippet_visibility_shared_examples.rb'
+    - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb'
-- 
GitLab