From f0b1eb2049d17d522154a46bfca345a1ad4a17d2 Mon Sep 17 00:00:00 2001 From: Vitali Tatarintev Date: Thu, 7 Apr 2022 12:04:37 +0200 Subject: [PATCH] Move Lint/ConstantDefinitionInBlock into separate TODO file --- .rubocop_todo.yml | 4 -- .../lint/constant_definition_in_block.yml | 53 +++++++++++++++++++ 2 files changed, 53 insertions(+), 4 deletions(-) create mode 100644 .rubocop_todo/lint/constant_definition_in_block.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d041ce385e3d35..9c0e0e558220ab 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -32,10 +32,6 @@ Layout/SpaceInLambdaLiteral: Layout/SpaceInsideParens: Enabled: false -# Offense count: 84 -Lint/ConstantDefinitionInBlock: - Enabled: false - # Offense count: 2 # Configuration parameters: AllowComments. Lint/EmptyFile: diff --git a/.rubocop_todo/lint/constant_definition_in_block.yml b/.rubocop_todo/lint/constant_definition_in_block.yml new file mode 100644 index 00000000000000..1ffea85dfb03f0 --- /dev/null +++ b/.rubocop_todo/lint/constant_definition_in_block.yml @@ -0,0 +1,53 @@ +--- +Lint/ConstantDefinitionInBlock: + # Offense count: 105 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/models/concerns/ignorable_columns.rb' + - 'app/models/concerns/partitioned_table.rb' + - 'app/workers/concerns/worker_context.rb' + - 'config/application.rb' + - 'config/initializers/direct_upload_support.rb' + - 'config/initializers/elastic_client_setup.rb' + - 'ee/app/models/concerns/ee/issuable_link.rb' + - 'ee/app/models/ee/application_setting.rb' + - 'ee/app/models/ee/ci/job_artifact.rb' + - 'ee/app/models/ee/ci/pipeline.rb' + - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/issue.rb' + - 'ee/app/models/ee/merge_request_diff.rb' + - 'ee/app/models/ee/plan.rb' + - 'ee/app/models/ee/project_import_state.rb' + - 'ee/app/models/ee/user.rb' + - 'ee/app/models/ee/vulnerability.rb' + - 'ee/app/presenters/ee/commit_status_presenter.rb' + - 'ee/app/services/ee/notes/quick_actions_service.rb' + - 'ee/lib/ee/api/search.rb' + - 'ee/lib/ee/gitlab/ci/status/build/failed.rb' + - 'ee/lib/gitlab/subscription_portal/clients/rest.rb' + - 'ee/lib/tasks/geo.rake' + - 'ee/spec/db/schema_support.rb' + - 'ee/spec/support/matchers/locked_schema.rb' + - 'lib/api/search.rb' + - 'lib/gitlab/quick_actions/issue_actions.rb' + - 'lib/tasks/cache.rake' + - 'lib/tasks/dev.rake' + - 'lib/tasks/gitlab/docs/compile_deprecations.rake' + - 'lib/tasks/gitlab/graphql.rake' + - 'lib/tasks/gitlab/refresh_project_statistics_build_artifacts_size.rake' + - 'lib/tasks/gitlab/snippets.rake' + - 'lib/tasks/gitlab/tw/codeowners.rake' + - 'lib/tasks/gitlab/update_templates.rake' + - 'lib/tasks/tanuki_emoji.rake' + - 'spec/db/schema_spec.rb' + - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' + - 'spec/lib/marginalia_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' + - 'spec/models/concerns/bulk_insert_safe_spec.rb' + - 'spec/models/concerns/bulk_insertable_associations_spec.rb' + - 'spec/models/concerns/triggerable_hooks_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb' + - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' -- GitLab