From 74fa4320a1e18ac905f188d684e7b3cb7b61f427 Mon Sep 17 00:00:00 2001 From: Vitali Tatarintev Date: Fri, 18 Mar 2022 11:16:34 +0100 Subject: [PATCH] Move Metrics/CyclomaticComplexity into separate TODO file --- .rubocop_todo.yml | 5 ---- .../metrics/cyclomatic_complexity.yml | 23 +++++++++++++++++++ 2 files changed, 23 insertions(+), 5 deletions(-) create mode 100644 .rubocop_todo/metrics/cyclomatic_complexity.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b600f2474c4891..45dc5864773b7a 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -125,11 +125,6 @@ Lint/StructNewOverride: Lint/UselessMethodDefinition: Enabled: false -# Offense count: 13 -# Configuration parameters: IgnoredMethods. -Metrics/CyclomaticComplexity: - Max: 25 - # Offense count: 14 # Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: diff --git a/.rubocop_todo/metrics/cyclomatic_complexity.yml b/.rubocop_todo/metrics/cyclomatic_complexity.yml new file mode 100644 index 00000000000000..71efe9d5a3a987 --- /dev/null +++ b/.rubocop_todo/metrics/cyclomatic_complexity.yml @@ -0,0 +1,23 @@ +--- +Metrics/CyclomaticComplexity: + Exclude: + - 'app/controllers/admin/application_settings_controller.rb' + - 'app/finders/deployments_finder.rb' + - 'app/helpers/button_helper.rb' + - 'app/helpers/nav/top_nav_helper.rb' + - 'app/models/concerns/issuable.rb' + - 'app/services/projects/create_service.rb' + - 'ee/app/controllers/ee/groups_controller.rb' + - 'ee/lib/elastic/latest/git_class_proxy.rb' + - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb' + - 'lib/banzai/filter/references/abstract_reference_filter.rb' + - 'lib/gitlab/conflict/file.rb' + - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' + - 'lib/gitlab/diff/parser.rb' + - 'lib/gitlab/utils/merge_hash.rb' + - 'lib/kramdown/parser/atlassian_document_format.rb' + - 'qa/qa/runtime/browser.rb' + - 'qa/qa/support/repeater.rb' + - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' + - 'sidekiq_cluster/cli.rb' + - 'spec/support/cycle_analytics_helpers/test_generation.rb' -- GitLab