diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d3b404c4bc2cdb65751fd6ff4d78f791d96c5b3a..0423141eeec87e519adae5ab9f979302af6b4646 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -379,13 +379,6 @@ Style/AccessorGrouping: Style/BarePercentLiterals: Enabled: false -# Offense count: 6 -# Cop supports --auto-correct. -Style/BisectedAttrAccessor: - Exclude: - - 'lib/system_check/base_check.rb' - - 'qa/qa/resource/api_fabricator.rb' - # Offense count: 42 # Cop supports --auto-correct. Style/CaseLikeIf: diff --git a/lib/system_check/base_check.rb b/lib/system_check/base_check.rb index c36cacbaf4f71ed715402ca4ffb68109e61c123f..ae3a9412e5cafc0360ff8fea4bc01ca669fa279a 100644 --- a/lib/system_check/base_check.rb +++ b/lib/system_check/base_check.rb @@ -64,20 +64,14 @@ def self.skip_reason call_or_return(@skip_reason) || 'skipped' end - # Define a reason why we skipped the SystemCheck (during runtime) + # Define or get a reason why we skipped the SystemCheck (during runtime) # # This is used when you need dynamic evaluation like when you have # multiple reasons why a check can fail # # @param [String] reason to be displayed - attr_writer :skip_reason - - # Skip reason defined during runtime - # - # This value have precedence over the one defined in the subclass - # - # @return [String] the reason - attr_reader :skip_reason + # @return [String] reason to be displayed + attr_accessor :skip_reason # Does the check support automatically repair routine? #