From a48689a29fbb85a22eeff4304f172f28431b7564 Mon Sep 17 00:00:00 2001 From: Vitali Tatarintev Date: Tue, 29 Mar 2022 10:53:09 +0200 Subject: [PATCH] Move Style/CombinableLoops into separate TODO file --- .rubocop_todo.yml | 14 -------------- .rubocop_todo/style/combinable_loops.yml | 10 ++++++++++ 2 files changed, 10 insertions(+), 14 deletions(-) create mode 100644 .rubocop_todo/style/combinable_loops.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a51e9cc1f7c322..757caa15bc9150 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -433,20 +433,6 @@ Style/BisectedAttrAccessor: Style/CaseLikeIf: Enabled: false -# Offense count: 13 -Style/CombinableLoops: - Exclude: - - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb' - - 'ee/lib/gitlab/audit/events/preloader.rb' - - 'ee/spec/finders/snippets_finder_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/remove_duplicate_cs_findings_spec.rb' - - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' - - 'spec/finders/packages/group_packages_finder_spec.rb' - - 'spec/migrations/cleanup_optimistic_locking_nulls_pt2_fixed_spec.rb' - - 'spec/migrations/cleanup_optimistic_locking_nulls_spec.rb' - - 'spec/requests/api/members_spec.rb' - - 'spec/support/shared_examples/features/protected_branches_access_control_ce_shared_examples.rb' - # Offense count: 5 # Cop supports --auto-correct. Style/EachWithObject: diff --git a/.rubocop_todo/style/combinable_loops.yml b/.rubocop_todo/style/combinable_loops.yml new file mode 100644 index 00000000000000..c8b8cbb979d696 --- /dev/null +++ b/.rubocop_todo/style/combinable_loops.yml @@ -0,0 +1,10 @@ +--- +Style/CombinableLoops: + Exclude: + - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb' + - 'ee/lib/gitlab/audit/events/preloader.rb' + - 'ee/spec/finders/snippets_finder_spec.rb' + - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' + - 'spec/finders/packages/group_packages_finder_spec.rb' + - 'spec/requests/api/members_spec.rb' + - 'spec/support/shared_examples/features/protected_branches_access_control_ce_shared_examples.rb' -- GitLab