From fd5987e7ff762dacc6a78f8b025635bd9058ae4c Mon Sep 17 00:00:00 2001
From: Siddharth Asthana <siddharthasthana31@gmail.com>
Date: Wed, 23 Feb 2022 05:02:12 +0530
Subject: [PATCH] Resolve Performance/DeleteSuffix rubocop offenses

Changelog: other
---
 .rubocop_todo.yml               | 10 ----------
 app/helpers/submodule_helper.rb |  2 +-
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index ac8afd5c00c282..64d3eb08d061f8 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -278,16 +278,6 @@ Performance/DeletePrefix:
     - 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb'
     - 'spec/support/helpers/test_env.rb'
 
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: SafeMultiline.
-Performance/DeleteSuffix:
-  Exclude:
-    - 'app/helpers/submodule_helper.rb'
-    - 'app/workers/concerns/application_worker.rb'
-    - 'ee/app/models/geo/upload_registry.rb'
-    - 'ee/app/workers/geo/file_download_dispatch_worker/attachment_job_finder.rb'
-
 # Offense count: 121
 Performance/MethodObjectAsBlock:
   Enabled: false
diff --git a/app/helpers/submodule_helper.rb b/app/helpers/submodule_helper.rb
index f1e0be3a622a6a..d3af6a00181cbc 100644
--- a/app/helpers/submodule_helper.rb
+++ b/app/helpers/submodule_helper.rb
@@ -32,7 +32,7 @@ def submodule_links_for_url(submodule_item_id, url, repository, old_submodule_it
 
       namespace.sub!(%r{\A/}, '')
       project.rstrip!
-      project.sub!(/\.git\z/, '')
+      project.delete_suffix!('.git')
 
       if self_url?(url, namespace, project)
         [
-- 
GitLab