diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ac8afd5c00c28220b365173feeb02ba7b63a5e8c..64d3eb08d061f82e6c61f22f44fc959ea145f873 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -278,16 +278,6 @@ Performance/DeletePrefix: - 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb' - 'spec/support/helpers/test_env.rb' -# Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: SafeMultiline. -Performance/DeleteSuffix: - Exclude: - - 'app/helpers/submodule_helper.rb' - - 'app/workers/concerns/application_worker.rb' - - 'ee/app/models/geo/upload_registry.rb' - - 'ee/app/workers/geo/file_download_dispatch_worker/attachment_job_finder.rb' - # Offense count: 121 Performance/MethodObjectAsBlock: Enabled: false diff --git a/app/helpers/submodule_helper.rb b/app/helpers/submodule_helper.rb index f1e0be3a622a6a50f99e3a4a0ce4e4a15a5f152a..d3af6a00181cbc7e75a53ed274ada13c08ad6106 100644 --- a/app/helpers/submodule_helper.rb +++ b/app/helpers/submodule_helper.rb @@ -32,7 +32,7 @@ def submodule_links_for_url(submodule_item_id, url, repository, old_submodule_it namespace.sub!(%r{\A/}, '') project.rstrip! - project.sub!(/\.git\z/, '') + project.delete_suffix!('.git') if self_url?(url, namespace, project) [