From c9b76d434fb86722d21710b584e372484e9fad7c Mon Sep 17 00:00:00 2001 From: David Kim Date: Wed, 8 Dec 2021 15:53:33 +1030 Subject: [PATCH] Set low urgency for slow code review web endpoints The list is based on https://gitlab.com/gitlab-org/gitlab/-/issues/346803 --- app/controllers/autocomplete_controller.rb | 2 ++ app/controllers/dashboard_controller.rb | 2 ++ .../groups/autocomplete_sources_controller.rb | 2 ++ app/controllers/groups_controller.rb | 1 + .../projects/autocomplete_sources_controller.rb | 2 ++ .../merge_requests/conflicts_controller.rb | 6 ++++++ .../projects/merge_requests/content_controller.rb | 5 +++++ .../merge_requests/creations_controller.rb | 9 +++++++++ .../projects/merge_requests/diffs_controller.rb | 7 +++++++ .../projects/merge_requests/drafts_controller.rb | 7 +++++++ .../projects/merge_requests_controller.rb | 15 +++++++++++++++ .../groups/merge_requests_controller.rb | 1 + 12 files changed, 59 insertions(+) diff --git a/app/controllers/autocomplete_controller.rb b/app/controllers/autocomplete_controller.rb index 5cb5690d72d834..c32a7f10aa4cb1 100644 --- a/app/controllers/autocomplete_controller.rb +++ b/app/controllers/autocomplete_controller.rb @@ -9,6 +9,8 @@ class AutocompleteController < ApplicationController feature_category :code_review, [:merge_request_target_branches] feature_category :continuous_delivery, [:deploy_keys_with_owners] + urgency :low, [:merge_request_target_branches] + def users group = Autocomplete::GroupFinder .new(current_user, project, params) diff --git a/app/controllers/dashboard_controller.rb b/app/controllers/dashboard_controller.rb index 8d7686a95fbcd4..2ecd17db487891 100644 --- a/app/controllers/dashboard_controller.rb +++ b/app/controllers/dashboard_controller.rb @@ -18,6 +18,8 @@ class DashboardController < Dashboard::ApplicationController feature_category :team_planning, [:issues, :issues_calendar] feature_category :code_review, [:merge_requests] + urgency :low, [:merge_requests] + def activity respond_to do |format| format.html diff --git a/app/controllers/groups/autocomplete_sources_controller.rb b/app/controllers/groups/autocomplete_sources_controller.rb index 82f8854bd2b34d..17cdcd9cb9b9ee 100644 --- a/app/controllers/groups/autocomplete_sources_controller.rb +++ b/app/controllers/groups/autocomplete_sources_controller.rb @@ -5,6 +5,8 @@ class Groups::AutocompleteSourcesController < Groups::ApplicationController feature_category :team_planning, [:issues, :labels, :milestones, :commands] feature_category :code_review, [:merge_requests] + urgency :low, [:merge_requests] + def members render json: ::Groups::ParticipantsService.new(@group, current_user).execute(target) end diff --git a/app/controllers/groups_controller.rb b/app/controllers/groups_controller.rb index c1f892d0ffca81..7f2b026b5b3bd1 100644 --- a/app/controllers/groups_controller.rb +++ b/app/controllers/groups_controller.rb @@ -60,6 +60,7 @@ class GroupsController < Groups::ApplicationController feature_category :importers, [:export, :download_export] urgency :high, [:unfoldered_environment_names] + urgency :low, [:merge_requests] def index redirect_to(current_user ? dashboard_groups_path : explore_groups_path) diff --git a/app/controllers/projects/autocomplete_sources_controller.rb b/app/controllers/projects/autocomplete_sources_controller.rb index 0d5f64c739cb5d..cf432cfb429ac5 100644 --- a/app/controllers/projects/autocomplete_sources_controller.rb +++ b/app/controllers/projects/autocomplete_sources_controller.rb @@ -8,6 +8,8 @@ class Projects::AutocompleteSourcesController < Projects::ApplicationController feature_category :users, [:members] feature_category :snippets, [:snippets] + urgency :low, [:merge_requests] + def members render json: ::Projects::ParticipantsService.new(@project, current_user).execute(target) end diff --git a/app/controllers/projects/merge_requests/conflicts_controller.rb b/app/controllers/projects/merge_requests/conflicts_controller.rb index a80388785049ae..76a233afa13822 100644 --- a/app/controllers/projects/merge_requests/conflicts_controller.rb +++ b/app/controllers/projects/merge_requests/conflicts_controller.rb @@ -5,6 +5,12 @@ class Projects::MergeRequests::ConflictsController < Projects::MergeRequests::Ap before_action :authorize_can_resolve_conflicts! + urgency :low, [ + :show, + :conflict_for_path, + :resolve_conflicts + ] + def show respond_to do |format| format.html do diff --git a/app/controllers/projects/merge_requests/content_controller.rb b/app/controllers/projects/merge_requests/content_controller.rb index 399745151b1d69..588fc85ff771d4 100644 --- a/app/controllers/projects/merge_requests/content_controller.rb +++ b/app/controllers/projects/merge_requests/content_controller.rb @@ -13,6 +13,11 @@ class Projects::MergeRequests::ContentController < Projects::MergeRequests::Appl FAST_POLLING_INTERVAL = 10.seconds.in_milliseconds SLOW_POLLING_INTERVAL = 5.minutes.in_milliseconds + urgency :low, [ + :widget, + :cached_widget + ] + def widget respond_to do |format| format.json do diff --git a/app/controllers/projects/merge_requests/creations_controller.rb b/app/controllers/projects/merge_requests/creations_controller.rb index ecc5ad1f84e790..beb179f584b3d8 100644 --- a/app/controllers/projects/merge_requests/creations_controller.rb +++ b/app/controllers/projects/merge_requests/creations_controller.rb @@ -10,6 +10,15 @@ class Projects::MergeRequests::CreationsController < Projects::MergeRequests::Ap before_action :apply_diff_view_cookie!, only: [:diffs, :diff_for_path] before_action :build_merge_request, except: [:create] + urgency :low, [ + :new, + :create, + :pipelines, + :diffs, + :branch_from, + :branch_to + ] + def new define_new_vars end diff --git a/app/controllers/projects/merge_requests/diffs_controller.rb b/app/controllers/projects/merge_requests/diffs_controller.rb index 388b27cdfa456d..32ca7d779d2973 100644 --- a/app/controllers/projects/merge_requests/diffs_controller.rb +++ b/app/controllers/projects/merge_requests/diffs_controller.rb @@ -14,6 +14,13 @@ class Projects::MergeRequests::DiffsController < Projects::MergeRequests::Applic after_action :track_viewed_diffs_events, only: [:diffs_batch] + urgency :low, [ + :show, + :diff_for_path, + :diffs_batch, + :diffs_metadata + ] + def show render_diffs end diff --git a/app/controllers/projects/merge_requests/drafts_controller.rb b/app/controllers/projects/merge_requests/drafts_controller.rb index 044d9f8b31fc2f..645720a08890ce 100644 --- a/app/controllers/projects/merge_requests/drafts_controller.rb +++ b/app/controllers/projects/merge_requests/drafts_controller.rb @@ -9,6 +9,13 @@ class Projects::MergeRequests::DraftsController < Projects::MergeRequests::Appli before_action :authorize_admin_draft!, only: [:update, :destroy] before_action :authorize_admin_draft!, if: -> { action_name == 'publish' && params[:id].present? } + urgency :low, [ + :create, + :update, + :destroy, + :publish + ] + def index drafts = prepare_notes_for_rendering(draft_notes) render json: DraftNoteSerializer.new(current_user: current_user).represent(drafts) diff --git a/app/controllers/projects/merge_requests_controller.rb b/app/controllers/projects/merge_requests_controller.rb index ccc34e2940ec77..97f54a564ca53e 100644 --- a/app/controllers/projects/merge_requests_controller.rb +++ b/app/controllers/projects/merge_requests_controller.rb @@ -71,6 +71,21 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo feature_category :continuous_integration, [:pipeline_status, :pipelines, :exposed_artifacts] urgency :high, [:export_csv] + urgency :low, [ + :index, + :show, + :commits, + :bulk_update, + :edit, + :update, + :cancel_auto_merge, + :merge, + :ci_environments_status, + :destroy, + :rebase, + :discussions, + :description_diff + ] def index @merge_requests = @issuables diff --git a/ee/app/controllers/groups/merge_requests_controller.rb b/ee/app/controllers/groups/merge_requests_controller.rb index f9bf7bfd2e6a8c..7c790b9b675e24 100644 --- a/ee/app/controllers/groups/merge_requests_controller.rb +++ b/ee/app/controllers/groups/merge_requests_controller.rb @@ -2,4 +2,5 @@ class Groups::MergeRequestsController < Groups::BulkUpdateController feature_category :code_review + urgency :low, [:bulk_update] end -- GitLab