From 45727000927eeff5842bc0c6a509b011d3b5dbb3 Mon Sep 17 00:00:00 2001 From: Miguel Rincon Date: Mon, 19 Jul 2021 16:28:48 +0200 Subject: [PATCH] Rename "runner list" app to "admin runners" This change renames runner app files from "runner list" to "admin runners" to accurately describe the feature. No user-facing changes are expected. --- app/assets/javascripts/pages/admin/runners/index/index.js | 4 ++-- .../admin_runners_app.vue} | 6 +++--- .../runner/{runner_list => admin_runners}/index.js | 6 +++--- .../runner/{runner_list => }/runner_search_utils.js | 2 +- app/views/admin/runners/index.html.haml | 2 +- .../admin_runners_app_spec.js} | 8 ++++---- .../runner/{runner_list => }/runner_search_utils_spec.js | 2 +- 7 files changed, 15 insertions(+), 15 deletions(-) rename app/assets/javascripts/runner/{runner_list/runner_list_app.vue => admin_runners/admin_runners_app.vue} (98%) rename app/assets/javascripts/runner/{runner_list => admin_runners}/index.js (84%) rename app/assets/javascripts/runner/{runner_list => }/runner_search_utils.js (99%) rename spec/frontend/runner/{runner_list/runner_list_app_spec.js => admin_runners/admin_runners_app_spec.js} (97%) rename spec/frontend/runner/{runner_list => }/runner_search_utils_spec.js (99%) diff --git a/app/assets/javascripts/pages/admin/runners/index/index.js b/app/assets/javascripts/pages/admin/runners/index/index.js index d5563470394be6..8e7861c300a701 100644 --- a/app/assets/javascripts/pages/admin/runners/index/index.js +++ b/app/assets/javascripts/pages/admin/runners/index/index.js @@ -2,7 +2,7 @@ import AdminRunnersFilteredSearchTokenKeys from '~/filtered_search/admin_runners import { FILTERED_SEARCH } from '~/pages/constants'; import initFilteredSearch from '~/pages/search/init_filtered_search'; import { initInstallRunner } from '~/pages/shared/mount_runner_instructions'; -import { initRunnerList } from '~/runner/runner_list'; +import { initAdminRunners } from '~/runner/admin_runners'; initFilteredSearch({ page: FILTERED_SEARCH.ADMIN_RUNNERS, @@ -13,5 +13,5 @@ initFilteredSearch({ initInstallRunner(); if (gon.features?.runnerListViewVueUi) { - initRunnerList(); + initAdminRunners(); } diff --git a/app/assets/javascripts/runner/runner_list/runner_list_app.vue b/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue similarity index 98% rename from app/assets/javascripts/runner/runner_list/runner_list_app.vue rename to app/assets/javascripts/runner/admin_runners/admin_runners_app.vue index 8d39243d609304..23ecee449a42e0 100644 --- a/app/assets/javascripts/runner/runner_list/runner_list_app.vue +++ b/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue @@ -9,15 +9,15 @@ import RunnerPagination from '../components/runner_pagination.vue'; import RunnerTypeHelp from '../components/runner_type_help.vue'; import { INSTANCE_TYPE, I18N_FETCH_ERROR } from '../constants'; import getRunnersQuery from '../graphql/get_runners.query.graphql'; -import { captureException } from '../sentry_utils'; import { fromUrlQueryToSearch, fromSearchToUrl, fromSearchToVariables, -} from './runner_search_utils'; +} from '../runner_search_utils'; +import { captureException } from '../sentry_utils'; export default { - name: 'RunnerListApp', + name: 'AdminRunnersApp', components: { RunnerFilteredSearchBar, RunnerList, diff --git a/app/assets/javascripts/runner/runner_list/index.js b/app/assets/javascripts/runner/admin_runners/index.js similarity index 84% rename from app/assets/javascripts/runner/runner_list/index.js rename to app/assets/javascripts/runner/admin_runners/index.js index 16616f00d1e3c3..1eec1019b7327a 100644 --- a/app/assets/javascripts/runner/runner_list/index.js +++ b/app/assets/javascripts/runner/admin_runners/index.js @@ -1,11 +1,11 @@ import Vue from 'vue'; import VueApollo from 'vue-apollo'; import createDefaultClient from '~/lib/graphql'; -import RunnerDetailsApp from './runner_list_app.vue'; +import AdminRunnersApp from './admin_runners_app.vue'; Vue.use(VueApollo); -export const initRunnerList = (selector = '#js-runner-list') => { +export const initAdminRunners = (selector = '#js-admin-runners') => { const el = document.querySelector(selector); if (!el) { @@ -32,7 +32,7 @@ export const initRunnerList = (selector = '#js-runner-list') => { runnerInstallHelpPage, }, render(h) { - return h(RunnerDetailsApp, { + return h(AdminRunnersApp, { props: { activeRunnersCount: parseInt(activeRunnersCount, 10), registrationToken, diff --git a/app/assets/javascripts/runner/runner_list/runner_search_utils.js b/app/assets/javascripts/runner/runner_search_utils.js similarity index 99% rename from app/assets/javascripts/runner/runner_list/runner_search_utils.js rename to app/assets/javascripts/runner/runner_search_utils.js index 9a0dc9c3a32b2c..65f75eb11ac50c 100644 --- a/app/assets/javascripts/runner/runner_list/runner_search_utils.js +++ b/app/assets/javascripts/runner/runner_search_utils.js @@ -16,7 +16,7 @@ import { PARAM_KEY_BEFORE, DEFAULT_SORT, RUNNER_PAGE_SIZE, -} from '../constants'; +} from './constants'; const getPaginationFromParams = (params) => { const page = parseInt(params[PARAM_KEY_PAGE], 10); diff --git a/app/views/admin/runners/index.html.haml b/app/views/admin/runners/index.html.haml index f9c52d9316b8ee..5dce44a787c0f8 100644 --- a/app/views/admin/runners/index.html.haml +++ b/app/views/admin/runners/index.html.haml @@ -2,7 +2,7 @@ - page_title _('Runners') - if Feature.enabled?(:runner_list_view_vue_ui, current_user, default_enabled: :yaml) - #js-runner-list{ data: { registration_token: Gitlab::CurrentSettings.runners_registration_token, runner_install_help_page: 'https://docs.gitlab.com/runner/install/', active_runners_count: @active_runners_count } } + #js-admin-runners{ data: { registration_token: Gitlab::CurrentSettings.runners_registration_token, runner_install_help_page: 'https://docs.gitlab.com/runner/install/', active_runners_count: @active_runners_count } } - else .row .col-sm-6 diff --git a/spec/frontend/runner/runner_list/runner_list_app_spec.js b/spec/frontend/runner/admin_runners/admin_runners_app_spec.js similarity index 97% rename from spec/frontend/runner/runner_list/runner_list_app_spec.js rename to spec/frontend/runner/admin_runners/admin_runners_app_spec.js index 54b7d1f1bdb9bb..2c28f10ca8e267 100644 --- a/spec/frontend/runner/runner_list/runner_list_app_spec.js +++ b/spec/frontend/runner/admin_runners/admin_runners_app_spec.js @@ -6,6 +6,7 @@ import waitForPromises from 'helpers/wait_for_promises'; import createFlash from '~/flash'; import { updateHistory } from '~/lib/utils/url_utility'; +import AdminRunnersApp from '~/runner/admin_runners/admin_runners_app.vue'; import RunnerFilteredSearchBar from '~/runner/components/runner_filtered_search_bar.vue'; import RunnerList from '~/runner/components/runner_list.vue'; import RunnerManualSetupHelp from '~/runner/components/runner_manual_setup_help.vue'; @@ -22,7 +23,6 @@ import { RUNNER_PAGE_SIZE, } from '~/runner/constants'; import getRunnersQuery from '~/runner/graphql/get_runners.query.graphql'; -import RunnerListApp from '~/runner/runner_list/runner_list_app.vue'; import { captureException } from '~/runner/sentry_utils'; import { runnersData, runnersDataPaginated } from '../mock_data'; @@ -40,7 +40,7 @@ jest.mock('~/lib/utils/url_utility', () => ({ const localVue = createLocalVue(); localVue.use(VueApollo); -describe('RunnerListApp', () => { +describe('AdminRunnersApp', () => { let wrapper; let mockRunnersQuery; let originalLocation; @@ -54,7 +54,7 @@ describe('RunnerListApp', () => { const createComponentWithApollo = ({ props = {}, mountFn = shallowMount } = {}) => { const handlers = [[getRunnersQuery, mockRunnersQuery]]; - wrapper = mountFn(RunnerListApp, { + wrapper = mountFn(AdminRunnersApp, { localVue, apolloProvider: createMockApollo(handlers), propsData: { @@ -197,7 +197,7 @@ describe('RunnerListApp', () => { it('error is reported to sentry', async () => { expect(captureException).toHaveBeenCalledWith({ error: new Error('Network error: Error!'), - component: 'RunnerListApp', + component: 'AdminRunnersApp', }); }); diff --git a/spec/frontend/runner/runner_list/runner_search_utils_spec.js b/spec/frontend/runner/runner_search_utils_spec.js similarity index 99% rename from spec/frontend/runner/runner_list/runner_search_utils_spec.js rename to spec/frontend/runner/runner_search_utils_spec.js index e7969676549a55..3a0c3abe7bd12c 100644 --- a/spec/frontend/runner/runner_list/runner_search_utils_spec.js +++ b/spec/frontend/runner/runner_search_utils_spec.js @@ -3,7 +3,7 @@ import { fromUrlQueryToSearch, fromSearchToUrl, fromSearchToVariables, -} from '~/runner/runner_list/runner_search_utils'; +} from '~/runner/runner_search_utils'; describe('search_params.js', () => { const examples = [ -- GitLab