From 42d4f00b22fe43a4b142ebcdb5d6675212bb59fc Mon Sep 17 00:00:00 2001
From: Coung Ngo <cngo@gitlab.com>
Date: Thu, 15 Apr 2021 15:33:52 +0100
Subject: [PATCH 1/2] Add author, assignee and label tokens to issues list
 refactor

Added behind `vue_issues_list` feature flag defaulted to off,
as part of an ongoing refactor from Haml.

https://gitlab.com/gitlab-org/gitlab/-/issues/322755
---
 .../components/issues_list_app.vue            | 151 +++++++++++-------
 .../javascripts/issues_list/constants.js      |  69 +++++++-
 app/assets/javascripts/issues_list/index.js   |   6 +-
 app/assets/javascripts/issues_list/utils.js   |  74 +++++++++
 app/helpers/issues_helper.rb                  |   3 +-
 .../components/issues_list_app_spec.js        |  72 ++++++---
 spec/frontend/issues_list/mock_data.js        |  26 +++
 spec/frontend/issues_list/utils_spec.js       |  54 +++++++
 spec/helpers/issues_helper_spec.rb            |   3 +-
 9 files changed, 379 insertions(+), 79 deletions(-)
 create mode 100644 app/assets/javascripts/issues_list/utils.js
 create mode 100644 spec/frontend/issues_list/mock_data.js
 create mode 100644 spec/frontend/issues_list/utils_spec.js

diff --git a/app/assets/javascripts/issues_list/components/issues_list_app.vue b/app/assets/javascripts/issues_list/components/issues_list_app.vue
index 57c5107fcbb358..3e6bf443034c1c 100644
--- a/app/assets/javascripts/issues_list/components/issues_list_app.vue
+++ b/app/assets/javascripts/issues_list/components/issues_list_app.vue
@@ -1,5 +1,6 @@
 <script>
 import { GlButton, GlEmptyState, GlIcon, GlLink, GlSprintf, GlTooltipDirective } from '@gitlab/ui';
+import fuzzaldrinPlus from 'fuzzaldrin-plus';
 import { toNumber } from 'lodash';
 import createFlash from '~/flash';
 import CsvImportExportButtons from '~/issuable/components/csv_import_export_buttons.vue';
@@ -7,50 +8,35 @@ import IssuableList from '~/issuable_list/components/issuable_list_root.vue';
 import { IssuableListTabs, IssuableStates } from '~/issuable_list/constants';
 import {
   CREATED_DESC,
+  i18n,
+  MAX_LIST_SIZE,
   PAGE_SIZE,
   RELATIVE_POSITION_ASC,
   sortOptions,
   sortParams,
 } from '~/issues_list/constants';
+import {
+  convertToApiParams,
+  convertToSearchQuery,
+  convertToUrlParams,
+  getFilterTokens,
+  getSortKey,
+} from '~/issues_list/utils';
 import axios from '~/lib/utils/axios_utils';
 import { convertObjectPropsToCamelCase, getParameterByName } from '~/lib/utils/common_utils';
-import { __, s__ } from '~/locale';
+import { __ } from '~/locale';
+import AuthorToken from '~/vue_shared/components/filtered_search_bar/tokens/author_token.vue';
+import LabelToken from '~/vue_shared/components/filtered_search_bar/tokens/label_token.vue';
 import eventHub from '../eventhub';
 import IssueCardTimeInfo from './issue_card_time_info.vue';
 
 export default {
   CREATED_DESC,
+  i18n,
   IssuableListTabs,
   PAGE_SIZE,
   sortOptions,
   sortParams,
-  i18n: {
-    calendarLabel: __('Subscribe to calendar'),
-    jiraIntegrationMessage: s__(
-      'JiraService|%{jiraDocsLinkStart}Enable the Jira integration%{jiraDocsLinkEnd} to view your Jira issues in GitLab.',
-    ),
-    jiraIntegrationSecondaryMessage: s__('JiraService|This feature requires a Premium plan.'),
-    jiraIntegrationTitle: s__('JiraService|Using Jira for issue tracking?'),
-    newIssueLabel: __('New issue'),
-    noClosedIssuesTitle: __('There are no closed issues'),
-    noOpenIssuesDescription: __('To keep this project going, create a new issue'),
-    noOpenIssuesTitle: __('There are no open issues'),
-    noIssuesSignedInDescription: __(
-      'Issues can be bugs, tasks or ideas to be discussed. Also, issues are searchable and filterable.',
-    ),
-    noIssuesSignedInTitle: __(
-      'The Issue Tracker is the place to add things that need to be improved or solved in a project',
-    ),
-    noIssuesSignedOutButtonText: __('Register / Sign In'),
-    noIssuesSignedOutDescription: __(
-      'The Issue Tracker is the place to add things that need to be improved or solved in a project. You can register or sign in to create issues for this project.',
-    ),
-    noIssuesSignedOutTitle: __('There are no issues to show'),
-    noSearchResultsDescription: __('To widen your search, change or remove filters above'),
-    noSearchResultsTitle: __('Sorry, your filter produced no results'),
-    reorderError: __('An error occurred while reordering issues.'),
-    rssLabel: __('Subscribe to RSS feed'),
-  },
   components: {
     CsvImportExportButtons,
     GlButton,
@@ -81,9 +67,6 @@ export default {
     exportCsvPath: {
       default: '',
     },
-    fullPath: {
-      default: '',
-    },
     hasIssues: {
       default: false,
     },
@@ -99,6 +82,12 @@ export default {
     newIssuePath: {
       default: '',
     },
+    projectId: {
+      default: '',
+    },
+    projectPath: {
+      default: '',
+    },
     rssPath: {
       default: '',
     },
@@ -112,27 +101,15 @@ export default {
   data() {
     const orderBy = getParameterByName('order_by');
     const sort = getParameterByName('sort');
-    const sortKey = Object.keys(sortParams).find(
-      (key) => sortParams[key].order_by === orderBy && sortParams[key].sort === sort,
-    );
-
-    const search = getParameterByName('search') || '';
-    const tokens = search.split(' ').map((searchWord) => ({
-      type: 'filtered-search-term',
-      value: {
-        data: searchWord,
-      },
-    }));
 
     return {
       exportCsvPathWithQuery: this.getExportCsvPathWithQuery(),
-      filters: sortParams[sortKey] || {},
-      filterTokens: tokens,
+      filterTokens: getFilterTokens(window.location.search),
       isLoading: false,
       issues: [],
       page: toNumber(getParameterByName('page')) || 1,
       showBulkEditSidebar: false,
-      sortKey: sortKey || CREATED_DESC,
+      sortKey: getSortKey(orderBy, sort) || CREATED_DESC,
       state: getParameterByName('state') || IssuableStates.Opened,
       totalIssues: 0,
     };
@@ -144,13 +121,46 @@ export default {
     isOpenTab() {
       return this.state === IssuableStates.Opened;
     },
+    apiFilterParams() {
+      return convertToApiParams(this.filterTokens);
+    },
+    urlFilterParams() {
+      return convertToUrlParams(this.filterTokens);
+    },
     searchQuery() {
-      return (
-        this.filterTokens
-          .map((searchTerm) => searchTerm.value.data)
-          .filter((searchWord) => Boolean(searchWord))
-          .join(' ') || undefined
-      );
+      return convertToSearchQuery(this.filterTokens) || undefined;
+    },
+    searchTokens() {
+      return [
+        {
+          type: 'author_username',
+          title: __('Author'),
+          icon: 'pencil',
+          token: AuthorToken,
+          dataType: 'user',
+          unique: true,
+          defaultAuthors: [],
+          fetchAuthors: this.fetchUsers,
+        },
+        {
+          type: 'assignee_username',
+          title: __('Assignee'),
+          icon: 'user',
+          token: AuthorToken,
+          dataType: 'user',
+          unique: true,
+          defaultAuthors: [],
+          fetchAuthors: this.fetchUsers,
+        },
+        {
+          type: 'labels',
+          title: __('Label'),
+          icon: 'labels',
+          token: LabelToken,
+          defaultLabels: [],
+          fetchLabels: this.fetchLabels,
+        },
+      ];
     },
     showPaginationControls() {
       return this.issues.length > 0;
@@ -169,7 +179,8 @@ export default {
         page: this.page,
         search: this.searchQuery,
         state: this.state,
-        ...this.filters,
+        ...sortParams[this.sortKey],
+        ...this.urlFilterParams,
       };
     },
   },
@@ -184,6 +195,34 @@ export default {
     eventHub.$off('issuables:toggleBulkEdit');
   },
   methods: {
+    fetchLabels(search) {
+      if (this.labelsCache) {
+        return search
+          ? Promise.resolve(fuzzaldrinPlus.filter(this.labelsCache, search, { key: 'title' }))
+          : Promise.resolve(this.labelsCache.slice(0, MAX_LIST_SIZE));
+      }
+
+      return axios
+        .get(`/${this.projectPath}/-/labels.json`, {
+          params: {
+            include_ancestor_groups: true,
+          },
+        })
+        .then(({ data }) => {
+          this.labelsCache = data;
+          return data.slice(0, MAX_LIST_SIZE);
+        });
+    },
+    fetchUsers(search) {
+      return axios.get('/-/autocomplete/users.json', {
+        params: {
+          active: true,
+          current_user: true,
+          project_id: this.projectId,
+          search,
+        },
+      });
+    },
     fetchIssues() {
       if (!this.hasIssues) {
         return undefined;
@@ -199,7 +238,8 @@ export default {
             search: this.searchQuery,
             state: this.state,
             with_labels_details: true,
-            ...this.filters,
+            ...sortParams[this.sortKey],
+            ...this.apiFilterParams,
           },
         })
         .then(({ data, headers }) => {
@@ -278,7 +318,6 @@ export default {
     },
     handleSort(value) {
       this.sortKey = value;
-      this.filters = sortParams[value];
       this.fetchIssues();
     },
   },
@@ -288,10 +327,10 @@ export default {
 <template>
   <issuable-list
     v-if="hasIssues"
-    :namespace="fullPath"
+    :namespace="projectPath"
     recent-searches-storage-key="issues"
     :search-input-placeholder="__('Search or filter results…')"
-    :search-tokens="[]"
+    :search-tokens="searchTokens"
     :initial-filter-value="filterTokens"
     :sort-options="$options.sortOptions"
     :initial-sort-by="sortKey"
diff --git a/app/assets/javascripts/issues_list/constants.js b/app/assets/javascripts/issues_list/constants.js
index f6f23af80ba40c..4a4608592013a6 100644
--- a/app/assets/javascripts/issues_list/constants.js
+++ b/app/assets/javascripts/issues_list/constants.js
@@ -1,4 +1,4 @@
-import { __ } from '~/locale';
+import { __, s__ } from '~/locale';
 
 // Maps sort order as it appears in the URL query to API `order_by` and `sort` params.
 const PRIORITY = 'priority';
@@ -53,6 +53,34 @@ export const availableSortOptionsJira = [
   },
 ];
 
+export const i18n = {
+  calendarLabel: __('Subscribe to calendar'),
+  jiraIntegrationMessage: s__(
+    'JiraService|%{jiraDocsLinkStart}Enable the Jira integration%{jiraDocsLinkEnd} to view your Jira issues in GitLab.',
+  ),
+  jiraIntegrationSecondaryMessage: s__('JiraService|This feature requires a Premium plan.'),
+  jiraIntegrationTitle: s__('JiraService|Using Jira for issue tracking?'),
+  newIssueLabel: __('New issue'),
+  noClosedIssuesTitle: __('There are no closed issues'),
+  noOpenIssuesDescription: __('To keep this project going, create a new issue'),
+  noOpenIssuesTitle: __('There are no open issues'),
+  noIssuesSignedInDescription: __(
+    'Issues can be bugs, tasks or ideas to be discussed. Also, issues are searchable and filterable.',
+  ),
+  noIssuesSignedInTitle: __(
+    'The Issue Tracker is the place to add things that need to be improved or solved in a project',
+  ),
+  noIssuesSignedOutButtonText: __('Register / Sign In'),
+  noIssuesSignedOutDescription: __(
+    'The Issue Tracker is the place to add things that need to be improved or solved in a project. You can register or sign in to create issues for this project.',
+  ),
+  noIssuesSignedOutTitle: __('There are no issues to show'),
+  noSearchResultsDescription: __('To widen your search, change or remove filters above'),
+  noSearchResultsTitle: __('Sorry, your filter produced no results'),
+  reorderError: __('An error occurred while reordering issues.'),
+  rssLabel: __('Subscribe to RSS feed'),
+};
+
 export const JIRA_IMPORT_SUCCESS_ALERT_HIDE_MAP_KEY = 'jira-import-success-alert-hide-map';
 
 export const BLOCKING_ISSUES_ASC = 'BLOCKING_ISSUES_ASC';
@@ -242,3 +270,42 @@ export const sortOptions = [
     },
   },
 ];
+
+export const MAX_LIST_SIZE = 10;
+
+export const FILTERED_SEARCH_TERM = 'filtered-search-term';
+export const OPERATOR_IS = '=';
+export const OPERATOR_IS_NOT = '!=';
+
+export const filters = {
+  author_username: {
+    apiParam: {
+      [OPERATOR_IS]: 'author_username',
+      [OPERATOR_IS_NOT]: 'not[author_username]',
+    },
+    urlParam: {
+      [OPERATOR_IS]: 'author_username',
+      [OPERATOR_IS_NOT]: 'not[author_username]',
+    },
+  },
+  assignee_username: {
+    apiParam: {
+      [OPERATOR_IS]: 'assignee_username',
+      [OPERATOR_IS_NOT]: 'not[assignee_username]',
+    },
+    urlParam: {
+      [OPERATOR_IS]: 'assignee_username[]',
+      [OPERATOR_IS_NOT]: 'not[assignee_username][]',
+    },
+  },
+  labels: {
+    apiParam: {
+      [OPERATOR_IS]: 'labels',
+      [OPERATOR_IS_NOT]: 'not[labels]',
+    },
+    urlParam: {
+      [OPERATOR_IS]: 'label_name[]',
+      [OPERATOR_IS_NOT]: 'not[label_name][]',
+    },
+  },
+};
diff --git a/app/assets/javascripts/issues_list/index.js b/app/assets/javascripts/issues_list/index.js
index 0b64df50691711..7594dcbe924bd8 100644
--- a/app/assets/javascripts/issues_list/index.js
+++ b/app/assets/javascripts/issues_list/index.js
@@ -81,7 +81,6 @@ export function initIssuesListApp() {
     emptyStateSvgPath,
     endpoint,
     exportCsvPath,
-    fullPath,
     hasBlockedIssuesFeature,
     hasIssuableHealthStatusFeature,
     hasIssues,
@@ -92,7 +91,9 @@ export function initIssuesListApp() {
     jiraIntegrationPath,
     maxAttachmentSize,
     newIssuePath,
+    projectId,
     projectImportJiraPath,
+    projectPath,
     rssPath,
     showNewIssueLink,
     signInPath,
@@ -108,7 +109,6 @@ export function initIssuesListApp() {
       canBulkUpdate: parseBoolean(canBulkUpdate),
       emptyStateSvgPath,
       endpoint,
-      fullPath,
       hasBlockedIssuesFeature: parseBoolean(hasBlockedIssuesFeature),
       hasIssuableHealthStatusFeature: parseBoolean(hasIssuableHealthStatusFeature),
       hasIssues: parseBoolean(hasIssues),
@@ -117,6 +117,8 @@ export function initIssuesListApp() {
       issuesPath,
       jiraIntegrationPath,
       newIssuePath,
+      projectId,
+      projectPath,
       rssPath,
       showNewIssueLink: parseBoolean(showNewIssueLink),
       signInPath,
diff --git a/app/assets/javascripts/issues_list/utils.js b/app/assets/javascripts/issues_list/utils.js
new file mode 100644
index 00000000000000..f470ccb5e06356
--- /dev/null
+++ b/app/assets/javascripts/issues_list/utils.js
@@ -0,0 +1,74 @@
+import { FILTERED_SEARCH_TERM, filters, sortParams } from '~/issues_list/constants';
+
+export const getSortKey = (orderBy, sort) =>
+  Object.keys(sortParams).find(
+    (key) => sortParams[key].order_by === orderBy && sortParams[key].sort === sort,
+  );
+
+const tokenTypes = Object.keys(filters);
+
+const urlParamKeys = tokenTypes.flatMap((key) => Object.values(filters[key].urlParam));
+
+const getTokenTypeFromUrlParamKey = (urlParamKey) =>
+  tokenTypes.find((key) => Object.values(filters[key].urlParam).includes(urlParamKey));
+
+const getOperatorFromUrlParamKey = (tokenType, urlParamKey) =>
+  Object.entries(filters[tokenType].urlParam).find(([, urlParam]) => urlParam === urlParamKey)[0];
+
+const convertToFilteredTokens = (locationSearch) =>
+  Array.from(new URLSearchParams(locationSearch).entries())
+    .filter(([key]) => urlParamKeys.includes(key))
+    .map(([key, data]) => {
+      const type = getTokenTypeFromUrlParamKey(key);
+      const operator = getOperatorFromUrlParamKey(type, key);
+      return {
+        type,
+        value: { data, operator },
+      };
+    });
+
+const convertToFilteredSearchTerms = (locationSearch) =>
+  new URLSearchParams(locationSearch)
+    .get('search')
+    ?.split(' ')
+    .map((word) => ({
+      type: FILTERED_SEARCH_TERM,
+      value: {
+        data: word,
+      },
+    })) || [];
+
+export const getFilterTokens = (locationSearch) => {
+  if (!locationSearch) {
+    return [];
+  }
+  const filterTokens = convertToFilteredTokens(locationSearch);
+  const searchTokens = convertToFilteredSearchTerms(locationSearch);
+  return filterTokens.concat(searchTokens);
+};
+
+export const convertToApiParams = (filterTokens) =>
+  filterTokens
+    .filter((token) => token.type !== FILTERED_SEARCH_TERM)
+    .reduce((acc, token) => {
+      const apiParam = filters[token.type].apiParam[token.value.operator];
+      return Object.assign(acc, {
+        [apiParam]: acc[apiParam] ? `${acc[apiParam]},${token.value.data}` : token.value.data,
+      });
+    }, {});
+
+export const convertToUrlParams = (filterTokens) =>
+  filterTokens
+    .filter((token) => token.type !== FILTERED_SEARCH_TERM)
+    .reduce((acc, token) => {
+      const urlParam = filters[token.type].urlParam[token.value.operator];
+      return Object.assign(acc, {
+        [urlParam]: acc[urlParam] ? acc[urlParam].concat(token.value.data) : [token.value.data],
+      });
+    }, {});
+
+export const convertToSearchQuery = (filterTokens) =>
+  filterTokens
+    .filter((token) => token.type === FILTERED_SEARCH_TERM && token.value.data)
+    .map((token) => token.value.data)
+    .join(' ');
diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 0a83e707412861..747950da41945c 100644
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -173,7 +173,6 @@ def issues_list_data(project, current_user, finder)
       empty_state_svg_path: image_path('illustrations/issues.svg'),
       endpoint: expose_path(api_v4_projects_issues_path(id: project.id)),
       export_csv_path: export_csv_project_issues_path(project),
-      full_path: project.full_path,
       has_issues: project_issues(project).exists?.to_s,
       import_csv_issues_path: import_csv_namespace_project_issues_path,
       is_signed_in: current_user.present?.to_s,
@@ -181,7 +180,9 @@ def issues_list_data(project, current_user, finder)
       jira_integration_path: help_page_url('user/project/integrations/jira', anchor: 'view-jira-issues'),
       max_attachment_size: number_to_human_size(Gitlab::CurrentSettings.max_attachment_size.megabytes),
       new_issue_path: new_project_issue_path(project, issue: { assignee_id: finder.assignee.try(:id), milestone_id: finder.milestones.first.try(:id) }),
+      project_id: project.id,
       project_import_jira_path: project_import_jira_path(project),
+      project_path: project.full_path,
       rss_path: url_for(safe_params.merge(rss_url_options)),
       show_new_issue_link: show_new_issue_link?(project).to_s,
       sign_in_path: new_user_session_path
diff --git a/spec/frontend/issues_list/components/issues_list_app_spec.js b/spec/frontend/issues_list/components/issues_list_app_spec.js
index 476804bda12dae..1e547fd897b3e3 100644
--- a/spec/frontend/issues_list/components/issues_list_app_spec.js
+++ b/spec/frontend/issues_list/components/issues_list_app_spec.js
@@ -3,12 +3,12 @@ import { mount, shallowMount } from '@vue/test-utils';
 import AxiosMockAdapter from 'axios-mock-adapter';
 import { TEST_HOST } from 'helpers/test_constants';
 import waitForPromises from 'helpers/wait_for_promises';
+import { filteredTokens, locationSearch } from 'jest/issues_list/mock_data';
 import createFlash from '~/flash';
 import CsvImportExportButtons from '~/issuable/components/csv_import_export_buttons.vue';
 import IssuableList from '~/issuable_list/components/issuable_list_root.vue';
 import { IssuableListTabs, IssuableStates } from '~/issuable_list/constants';
 import IssuesListApp from '~/issues_list/components/issues_list_app.vue';
-
 import {
   CREATED_DESC,
   PAGE_SIZE,
@@ -34,12 +34,13 @@ describe('IssuesListApp component', () => {
     emptyStateSvgPath: 'empty-state.svg',
     endpoint: 'api/endpoint',
     exportCsvPath: 'export/csv/path',
-    fullPath: 'path/to/project',
     hasIssues: true,
     isSignedIn: false,
     issuesPath: 'path/to/issues',
     jiraIntegrationPath: 'jira/integration/path',
     newIssuePath: 'new/issue/path',
+    projectId: '13',
+    projectPath: 'path/to/project',
     rssPath: 'rss/path',
     showImportButton: true,
     showNewIssueLink: true,
@@ -99,7 +100,7 @@ describe('IssuesListApp component', () => {
 
     it('renders', () => {
       expect(findIssuableList().props()).toMatchObject({
-        namespace: defaultProvide.fullPath,
+        namespace: defaultProvide.projectPath,
         recentSearchesStorageKey: 'issues',
         searchInputPlaceholder: 'Search or filter results…',
         sortOptions,
@@ -213,6 +214,19 @@ describe('IssuesListApp component', () => {
       });
     });
 
+    describe('search', () => {
+      it('is set from the url params', () => {
+        Object.defineProperty(window, 'location', {
+          writable: true,
+          value: { search: locationSearch },
+        });
+
+        wrapper = mountComponent();
+
+        expect(findIssuableList().props('urlParams')).toMatchObject({ search: 'find issues' });
+      });
+    });
+
     describe('sort', () => {
       it.each(Object.keys(sortParams))('is set as %s from the url params', (sortKey) => {
         Object.defineProperty(window, 'location', {
@@ -243,6 +257,19 @@ describe('IssuesListApp component', () => {
         expect(findIssuableList().props('currentTab')).toBe(initialState);
       });
     });
+
+    describe('filter tokens', () => {
+      it('is set from the url params', () => {
+        Object.defineProperty(window, 'location', {
+          writable: true,
+          value: { search: locationSearch },
+        });
+
+        wrapper = mountComponent();
+
+        expect(findIssuableList().props('initialFilterValue')).toEqual(filteredTokens);
+      });
+    });
   });
 
   describe('bulk edit', () => {
@@ -265,15 +292,13 @@ describe('IssuesListApp component', () => {
   describe('empty states', () => {
     describe('when there are issues', () => {
       describe('when search returns no results', () => {
-        beforeEach(async () => {
+        beforeEach(() => {
           Object.defineProperty(window, 'location', {
             writable: true,
-            value: { href: setUrlParams({ search: 'no results' }, TEST_HOST) },
+            value: { search: '?search=no+results' },
           });
 
           wrapper = mountComponent({ provide: { hasIssues: true } });
-
-          await waitForPromises();
         });
 
         it('shows empty state', () => {
@@ -418,7 +443,7 @@ describe('IssuesListApp component', () => {
       });
 
       it('fetches issues with expected params', () => {
-        expect(axiosMock.history.get[1].params).toEqual({
+        expect(axiosMock.history.get[1].params).toMatchObject({
           page,
           per_page: PAGE_SIZE,
           state,
@@ -525,21 +550,32 @@ describe('IssuesListApp component', () => {
     });
 
     describe('when "filter" event is emitted by IssuableList', () => {
-      beforeEach(async () => {
+      beforeEach(() => {
         wrapper = mountComponent();
 
-        const payload = [
-          { type: 'filtered-search-term', value: { data: 'no' } },
-          { type: 'filtered-search-term', value: { data: 'issues' } },
-        ];
-
-        findIssuableList().vm.$emit('filter', payload);
-
-        await waitForPromises();
+        findIssuableList().vm.$emit('filter', filteredTokens);
       });
 
       it('makes an API call to search for issues with the search term', () => {
-        expect(axiosMock.history.get[1].params).toMatchObject({ search: 'no issues' });
+        expect(axiosMock.history.get[1].params).toMatchObject({
+          author_username: 'homer',
+          'not[author_username]': 'marge',
+          assignee_username: 'bart',
+          'not[assignee_username]': 'lisa',
+          labels: 'cartoon,tv',
+          'not[labels]': 'live action,drama',
+        });
+      });
+
+      it('updates IssuableList with url params', () => {
+        expect(findIssuableList().props('urlParams')).toMatchObject({
+          author_username: ['homer'],
+          'not[author_username]': ['marge'],
+          'assignee_username[]': ['bart'],
+          'not[assignee_username][]': ['lisa'],
+          'label_name[]': ['cartoon', 'tv'],
+          'not[label_name][]': ['live action', 'drama'],
+        });
       });
     });
   });
diff --git a/spec/frontend/issues_list/mock_data.js b/spec/frontend/issues_list/mock_data.js
new file mode 100644
index 00000000000000..e036c26689cde9
--- /dev/null
+++ b/spec/frontend/issues_list/mock_data.js
@@ -0,0 +1,26 @@
+import { OPERATOR_IS, OPERATOR_IS_NOT } from '~/issues_list/constants';
+
+export const locationSearch = [
+  '?search=find+issues',
+  'author_username=homer',
+  'not[author_username]=marge',
+  'assignee_username[]=bart',
+  'not[assignee_username][]=lisa',
+  'label_name[]=cartoon',
+  'label_name[]=tv',
+  'not[label_name][]=live action',
+  'not[label_name][]=drama',
+].join('&');
+
+export const filteredTokens = [
+  { type: 'author_username', value: { data: 'homer', operator: OPERATOR_IS } },
+  { type: 'author_username', value: { data: 'marge', operator: OPERATOR_IS_NOT } },
+  { type: 'assignee_username', value: { data: 'bart', operator: OPERATOR_IS } },
+  { type: 'assignee_username', value: { data: 'lisa', operator: OPERATOR_IS_NOT } },
+  { type: 'labels', value: { data: 'cartoon', operator: OPERATOR_IS } },
+  { type: 'labels', value: { data: 'tv', operator: OPERATOR_IS } },
+  { type: 'labels', value: { data: 'live action', operator: OPERATOR_IS_NOT } },
+  { type: 'labels', value: { data: 'drama', operator: OPERATOR_IS_NOT } },
+  { type: 'filtered-search-term', value: { data: 'find' } },
+  { type: 'filtered-search-term', value: { data: 'issues' } },
+];
diff --git a/spec/frontend/issues_list/utils_spec.js b/spec/frontend/issues_list/utils_spec.js
new file mode 100644
index 00000000000000..31e4d4e5f458be
--- /dev/null
+++ b/spec/frontend/issues_list/utils_spec.js
@@ -0,0 +1,54 @@
+import { filteredTokens, locationSearch } from 'jest/issues_list/mock_data';
+import { sortParams } from '~/issues_list/constants';
+import {
+  convertToApiParams,
+  convertToSearchQuery,
+  convertToUrlParams,
+  getFilterTokens,
+  getSortKey,
+} from '~/issues_list/utils';
+
+describe('getSortKey', () => {
+  it.each(Object.keys(sortParams))('returns %s given the correct inputs', (sortKey) => {
+    const { order_by, sort } = sortParams[sortKey];
+    expect(getSortKey(order_by, sort)).toBe(sortKey);
+  });
+});
+
+describe('getFilterTokens', () => {
+  it('returns filtered tokens given "window.location.search"', () => {
+    expect(getFilterTokens(locationSearch)).toEqual(filteredTokens);
+  });
+});
+
+describe('convertToApiParams', () => {
+  it('returns api params given filtered tokens', () => {
+    expect(convertToApiParams(filteredTokens)).toEqual({
+      author_username: 'homer',
+      'not[author_username]': 'marge',
+      assignee_username: 'bart',
+      'not[assignee_username]': 'lisa',
+      labels: 'cartoon,tv',
+      'not[labels]': 'live action,drama',
+    });
+  });
+});
+
+describe('convertToUrlParams', () => {
+  it('returns url params given filtered tokens', () => {
+    expect(convertToUrlParams(filteredTokens)).toEqual({
+      author_username: ['homer'],
+      'not[author_username]': ['marge'],
+      'assignee_username[]': ['bart'],
+      'not[assignee_username][]': ['lisa'],
+      'label_name[]': ['cartoon', 'tv'],
+      'not[label_name][]': ['live action', 'drama'],
+    });
+  });
+});
+
+describe('convertToSearchQuery', () => {
+  it('returns search string given filtered tokens', () => {
+    expect(convertToSearchQuery(filteredTokens)).toBe('find issues');
+  });
+});
diff --git a/spec/helpers/issues_helper_spec.rb b/spec/helpers/issues_helper_spec.rb
index 21a01f349b5bfc..b18cecbca8a270 100644
--- a/spec/helpers/issues_helper_spec.rb
+++ b/spec/helpers/issues_helper_spec.rb
@@ -301,7 +301,6 @@
         empty_state_svg_path: '#',
         endpoint: expose_path(api_v4_projects_issues_path(id: project.id)),
         export_csv_path: export_csv_project_issues_path(project),
-        full_path: project.full_path,
         has_issues: project_issues(project).exists?.to_s,
         import_csv_issues_path: '#',
         is_signed_in: current_user.present?.to_s,
@@ -309,7 +308,9 @@
         jira_integration_path: help_page_url('user/project/integrations/jira', anchor: 'view-jira-issues'),
         max_attachment_size: number_to_human_size(Gitlab::CurrentSettings.max_attachment_size.megabytes),
         new_issue_path: new_project_issue_path(project, issue: { assignee_id: finder.assignee.id, milestone_id: finder.milestones.first.id }),
+        project_id: project.id,
         project_import_jira_path: project_import_jira_path(project),
+        project_path: project.full_path,
         rss_path: '#',
         show_new_issue_link: 'true',
         sign_in_path: new_user_session_path
-- 
GitLab


From 60b71ed40dda640b529b4905c221baa1ecfa82d6 Mon Sep 17 00:00:00 2001
From: Coung Ngo <cngo@gitlab.com>
Date: Tue, 20 Apr 2021 12:14:43 +0100
Subject: [PATCH 2/2] Get paths via backend

---
 .../components/issues_list_app.vue            | 28 ++++++-------------
 app/assets/javascripts/issues_list/index.js   |  6 ++--
 app/helpers/issues_helper.rb                  |  3 +-
 .../components/issues_list_app_spec.js        |  3 +-
 spec/helpers/issues_helper_spec.rb            |  3 +-
 5 files changed, 19 insertions(+), 24 deletions(-)

diff --git a/app/assets/javascripts/issues_list/components/issues_list_app.vue b/app/assets/javascripts/issues_list/components/issues_list_app.vue
index 3e6bf443034c1c..4b7b12f6b99b86 100644
--- a/app/assets/javascripts/issues_list/components/issues_list_app.vue
+++ b/app/assets/javascripts/issues_list/components/issues_list_app.vue
@@ -52,6 +52,9 @@ export default {
     GlTooltip: GlTooltipDirective,
   },
   inject: {
+    autocompleteUsersPath: {
+      default: '',
+    },
     calendarPath: {
       default: '',
     },
@@ -82,7 +85,7 @@ export default {
     newIssuePath: {
       default: '',
     },
-    projectId: {
+    projectLabelsPath: {
       default: '',
     },
     projectPath: {
@@ -202,26 +205,13 @@ export default {
           : Promise.resolve(this.labelsCache.slice(0, MAX_LIST_SIZE));
       }
 
-      return axios
-        .get(`/${this.projectPath}/-/labels.json`, {
-          params: {
-            include_ancestor_groups: true,
-          },
-        })
-        .then(({ data }) => {
-          this.labelsCache = data;
-          return data.slice(0, MAX_LIST_SIZE);
-        });
+      return axios.get(this.projectLabelsPath).then(({ data }) => {
+        this.labelsCache = data;
+        return data.slice(0, MAX_LIST_SIZE);
+      });
     },
     fetchUsers(search) {
-      return axios.get('/-/autocomplete/users.json', {
-        params: {
-          active: true,
-          current_user: true,
-          project_id: this.projectId,
-          search,
-        },
-      });
+      return axios.get(this.autocompleteUsersPath, { params: { search } });
     },
     fetchIssues() {
       if (!this.hasIssues) {
diff --git a/app/assets/javascripts/issues_list/index.js b/app/assets/javascripts/issues_list/index.js
index 7594dcbe924bd8..85b64be7718642 100644
--- a/app/assets/javascripts/issues_list/index.js
+++ b/app/assets/javascripts/issues_list/index.js
@@ -73,6 +73,7 @@ export function initIssuesListApp() {
   }
 
   const {
+    autocompleteUsersPath,
     calendarPath,
     canBulkUpdate,
     canEdit,
@@ -91,8 +92,8 @@ export function initIssuesListApp() {
     jiraIntegrationPath,
     maxAttachmentSize,
     newIssuePath,
-    projectId,
     projectImportJiraPath,
+    projectLabelsPath,
     projectPath,
     rssPath,
     showNewIssueLink,
@@ -105,6 +106,7 @@ export function initIssuesListApp() {
     // issue is fixed upstream in https://github.com/vuejs/vue-apollo/pull/1153
     apolloProvider: {},
     provide: {
+      autocompleteUsersPath,
       calendarPath,
       canBulkUpdate: parseBoolean(canBulkUpdate),
       emptyStateSvgPath,
@@ -117,7 +119,7 @@ export function initIssuesListApp() {
       issuesPath,
       jiraIntegrationPath,
       newIssuePath,
-      projectId,
+      projectLabelsPath,
       projectPath,
       rssPath,
       showNewIssueLink: parseBoolean(showNewIssueLink),
diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 747950da41945c..2296fe91fba8e7 100644
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -165,6 +165,7 @@ def issue_header_actions_data(project, issuable, current_user)
 
   def issues_list_data(project, current_user, finder)
     {
+      autocomplete_users_path: autocomplete_users_path(active: true, current_user: true, project_id: project.id, format: :json),
       calendar_path: url_for(safe_params.merge(calendar_url_options)),
       can_bulk_update: can?(current_user, :admin_issue, project).to_s,
       can_edit: can?(current_user, :admin_project, project).to_s,
@@ -180,8 +181,8 @@ def issues_list_data(project, current_user, finder)
       jira_integration_path: help_page_url('user/project/integrations/jira', anchor: 'view-jira-issues'),
       max_attachment_size: number_to_human_size(Gitlab::CurrentSettings.max_attachment_size.megabytes),
       new_issue_path: new_project_issue_path(project, issue: { assignee_id: finder.assignee.try(:id), milestone_id: finder.milestones.first.try(:id) }),
-      project_id: project.id,
       project_import_jira_path: project_import_jira_path(project),
+      project_labels_path: project_labels_path(project, include_ancestor_groups: true, format: :json),
       project_path: project.full_path,
       rss_path: url_for(safe_params.merge(rss_url_options)),
       show_new_issue_link: show_new_issue_link?(project).to_s,
diff --git a/spec/frontend/issues_list/components/issues_list_app_spec.js b/spec/frontend/issues_list/components/issues_list_app_spec.js
index 1e547fd897b3e3..65bdcc8d219d8c 100644
--- a/spec/frontend/issues_list/components/issues_list_app_spec.js
+++ b/spec/frontend/issues_list/components/issues_list_app_spec.js
@@ -29,6 +29,7 @@ describe('IssuesListApp component', () => {
   let wrapper;
 
   const defaultProvide = {
+    autocompleteUsersPath: 'autocomplete/users/path',
     calendarPath: 'calendar/path',
     canBulkUpdate: false,
     emptyStateSvgPath: 'empty-state.svg',
@@ -39,7 +40,7 @@ describe('IssuesListApp component', () => {
     issuesPath: 'path/to/issues',
     jiraIntegrationPath: 'jira/integration/path',
     newIssuePath: 'new/issue/path',
-    projectId: '13',
+    projectLabelsPath: 'project/labels/path',
     projectPath: 'path/to/project',
     rssPath: 'rss/path',
     showImportButton: true,
diff --git a/spec/helpers/issues_helper_spec.rb b/spec/helpers/issues_helper_spec.rb
index b18cecbca8a270..c4eb69d830725d 100644
--- a/spec/helpers/issues_helper_spec.rb
+++ b/spec/helpers/issues_helper_spec.rb
@@ -293,6 +293,7 @@
       allow(helper).to receive(:url_for).and_return('#')
 
       expected = {
+        autocomplete_users_path: autocomplete_users_path(active: true, current_user: true, project_id: project.id, format: :json),
         calendar_path: '#',
         can_bulk_update: 'true',
         can_edit: 'true',
@@ -308,8 +309,8 @@
         jira_integration_path: help_page_url('user/project/integrations/jira', anchor: 'view-jira-issues'),
         max_attachment_size: number_to_human_size(Gitlab::CurrentSettings.max_attachment_size.megabytes),
         new_issue_path: new_project_issue_path(project, issue: { assignee_id: finder.assignee.id, milestone_id: finder.milestones.first.id }),
-        project_id: project.id,
         project_import_jira_path: project_import_jira_path(project),
+        project_labels_path: project_labels_path(project, include_ancestor_groups: true, format: :json),
         project_path: project.full_path,
         rss_path: '#',
         show_new_issue_link: 'true',
-- 
GitLab