diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index b6898ebe6066d0b1f4c04075785bbcbd46a1a5e7..67dfeebaf7dea00cb214ef494dd4bc0168352720 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -44,7 +44,6 @@ Graphql/Descriptions: # WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/267606 FactoryBot/InlineAssociation: Exclude: - - 'ee/spec/factories/analytics/cycle_analytics/group_stages.rb' - 'ee/spec/factories/geo/event_log.rb' - 'ee/spec/factories/merge_request_blocks.rb' - 'ee/spec/factories/vulnerabilities/feedback.rb' @@ -57,8 +56,6 @@ FactoryBot/InlineAssociation: - 'spec/factories/go_modules.rb' - 'spec/factories/group_group_links.rb' - 'spec/factories/import_export_uploads.rb' - - 'spec/factories/uploads.rb' - - 'spec/factories/wiki_pages.rb' # WIP: See https://gitlab.com/gitlab-org/gitlab/-/issues/220040 Rails/SaveBang: diff --git a/ee/spec/factories/analytics/cycle_analytics/group_stages.rb b/ee/spec/factories/analytics/cycle_analytics/group_stages.rb index 640e76c2a673d855e00b14cc287ca466bf3a13f3..e154874f22f3a569e6ab6e02dc0a5a03cd8a1b72 100644 --- a/ee/spec/factories/analytics/cycle_analytics/group_stages.rb +++ b/ee/spec/factories/analytics/cycle_analytics/group_stages.rb @@ -7,6 +7,6 @@ end_event_identifier { Gitlab::Analytics::CycleAnalytics::StageEvents::MergeRequestMerged.identifier } group - value_stream { FactoryBot.build(:cycle_analytics_group_value_stream, group: group) } + value_stream { association(:cycle_analytics_group_value_stream, group: group) } end end