From ef60eaae19b110fcc104dd611a940fa8d6d24368 Mon Sep 17 00:00:00 2001 From: Dallas Reedy Date: Thu, 17 Dec 2020 17:07:51 -0800 Subject: [PATCH 1/3] Revert "Revert "Merge branch '290724-experiments-using-flipper-will-require-feature-flag-yml-files' into 'master'"" This reverts commit 1eb4aaa5bd837e3deca97c8fbd98d63f53df07ba. --- .../ci_notification_dot_experiment_percentage.yml | 8 ++++++++ .../contact_sales_btn_in_app_experiment_percentage.yml | 8 ++++++++ .../customize_homepage_experiment_percentage.yml | 8 ++++++++ .../default_to_issues_board_experiment_percentage.yml | 8 ++++++++ .../group_only_trials_experiment_percentage.yml | 8 ++++++++ ...embers_empty_group_version_a_experiment_percentage.yml | 8 ++++++++ ...bers_empty_project_version_a_experiment_percentage.yml | 8 ++++++++ .../invite_members_version_a_experiment_percentage.yml | 8 ++++++++ .../invite_members_version_b_experiment_percentage.yml | 8 ++++++++ .../experiment/jobs_empty_state_experiment_percentage.yml | 8 ++++++++ .../config}/feature_flags/experiment/null_hypothesis.yml | 0 .../onboarding_issues_experiment_percentage.yml | 8 ++++++++ ...move_known_trial_form_fields_experiment_percentage.yml | 8 ++++++++ ...istration_with_social_signin_experiment_percentage.yml | 8 ++++++++ .../trimmed_skip_trial_copy_experiment_percentage.yml | 8 ++++++++ .../upgrade_link_in_user_menu_a_experiment_percentage.yml | 8 ++++++++ lib/feature/shared.rb | 2 ++ lib/gitlab/experimentation/experiment.rb | 4 +++- spec/support/helpers/stub_experiments.rb | 4 ++++ 19 files changed, 129 insertions(+), 1 deletion(-) create mode 100644 ee/config/feature_flags/experiment/ci_notification_dot_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/contact_sales_btn_in_app_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/customize_homepage_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/default_to_issues_board_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/group_only_trials_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/invite_members_empty_group_version_a_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/invite_members_empty_project_version_a_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/invite_members_version_a_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/invite_members_version_b_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/jobs_empty_state_experiment_percentage.yml rename {config => ee/config}/feature_flags/experiment/null_hypothesis.yml (100%) create mode 100644 ee/config/feature_flags/experiment/onboarding_issues_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/remove_known_trial_form_fields_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/trial_registration_with_social_signin_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/trimmed_skip_trial_copy_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/upgrade_link_in_user_menu_a_experiment_percentage.yml diff --git a/ee/config/feature_flags/experiment/ci_notification_dot_experiment_percentage.yml b/ee/config/feature_flags/experiment/ci_notification_dot_experiment_percentage.yml new file mode 100644 index 00000000000000..3d6f70d2ce578f --- /dev/null +++ b/ee/config/feature_flags/experiment/ci_notification_dot_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: ci_notification_dot_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/27626 +rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/101 +milestone: '12.10' +type: experiment +group: group::expansion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/contact_sales_btn_in_app_experiment_percentage.yml b/ee/config/feature_flags/experiment/contact_sales_btn_in_app_experiment_percentage.yml new file mode 100644 index 00000000000000..80401523f53e96 --- /dev/null +++ b/ee/config/feature_flags/experiment/contact_sales_btn_in_app_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: contact_sales_btn_in_app_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38508 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/238207 +milestone: '13.3' +type: experiment +group: group::conversion +default_enabled: true diff --git a/ee/config/feature_flags/experiment/customize_homepage_experiment_percentage.yml b/ee/config/feature_flags/experiment/customize_homepage_experiment_percentage.yml new file mode 100644 index 00000000000000..eff0d2785eb448 --- /dev/null +++ b/ee/config/feature_flags/experiment/customize_homepage_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: customize_homepage_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/39348 +rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/187 +milestone: '13.4' +type: experiment +group: group::expansion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/default_to_issues_board_experiment_percentage.yml b/ee/config/feature_flags/experiment/default_to_issues_board_experiment_percentage.yml new file mode 100644 index 00000000000000..d4a695502f9450 --- /dev/null +++ b/ee/config/feature_flags/experiment/default_to_issues_board_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: default_to_issues_board_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43939 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/268298 +milestone: '13.5' +type: experiment +group: group::conversion +default_enabled: true diff --git a/ee/config/feature_flags/experiment/group_only_trials_experiment_percentage.yml b/ee/config/feature_flags/experiment/group_only_trials_experiment_percentage.yml new file mode 100644 index 00000000000000..e410eb08d01723 --- /dev/null +++ b/ee/config/feature_flags/experiment/group_only_trials_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: group_only_trials_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40564 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/258629 +milestone: '13.5' +type: experiment +group: group::conversion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/invite_members_empty_group_version_a_experiment_percentage.yml b/ee/config/feature_flags/experiment/invite_members_empty_group_version_a_experiment_percentage.yml new file mode 100644 index 00000000000000..6f8186a6888bc9 --- /dev/null +++ b/ee/config/feature_flags/experiment/invite_members_empty_group_version_a_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: invite_members_empty_group_version_a_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45689 +rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/280 +milestone: '13.6' +type: experiment +group: group::expansion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/invite_members_empty_project_version_a_experiment_percentage.yml b/ee/config/feature_flags/experiment/invite_members_empty_project_version_a_experiment_percentage.yml new file mode 100644 index 00000000000000..8b91ec9526ccb4 --- /dev/null +++ b/ee/config/feature_flags/experiment/invite_members_empty_project_version_a_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: invite_members_empty_project_version_a_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/49588 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/262014 +milestone: '13.7' +type: experiment +group: group::expansion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/invite_members_version_a_experiment_percentage.yml b/ee/config/feature_flags/experiment/invite_members_version_a_experiment_percentage.yml new file mode 100644 index 00000000000000..b284a0e2f78fca --- /dev/null +++ b/ee/config/feature_flags/experiment/invite_members_version_a_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: invite_members_version_a_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45689/ +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/219239 +milestone: '13.6' +type: experiment +group: group::expansion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/invite_members_version_b_experiment_percentage.yml b/ee/config/feature_flags/experiment/invite_members_version_b_experiment_percentage.yml new file mode 100644 index 00000000000000..069e740ba44089 --- /dev/null +++ b/ee/config/feature_flags/experiment/invite_members_version_b_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: invite_members_version_b_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43900 +rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/214 +milestone: '13.5' +type: experiment +group: group::expansion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/jobs_empty_state_experiment_percentage.yml b/ee/config/feature_flags/experiment/jobs_empty_state_experiment_percentage.yml new file mode 100644 index 00000000000000..33a15e28d445d0 --- /dev/null +++ b/ee/config/feature_flags/experiment/jobs_empty_state_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: jobs_empty_state_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48686 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/281054 +milestone: '13.7' +type: experiment +group: group::activation +default_enabled: false diff --git a/config/feature_flags/experiment/null_hypothesis.yml b/ee/config/feature_flags/experiment/null_hypothesis.yml similarity index 100% rename from config/feature_flags/experiment/null_hypothesis.yml rename to ee/config/feature_flags/experiment/null_hypothesis.yml diff --git a/ee/config/feature_flags/experiment/onboarding_issues_experiment_percentage.yml b/ee/config/feature_flags/experiment/onboarding_issues_experiment_percentage.yml new file mode 100644 index 00000000000000..7a8f3074d96c5e --- /dev/null +++ b/ee/config/feature_flags/experiment/onboarding_issues_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: onboarding_issues_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/31656/ +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/224515 +milestone: '13.0' +type: experiment +group: group::conversion +default_enabled: true diff --git a/ee/config/feature_flags/experiment/remove_known_trial_form_fields_experiment_percentage.yml b/ee/config/feature_flags/experiment/remove_known_trial_form_fields_experiment_percentage.yml new file mode 100644 index 00000000000000..72b49a0423546e --- /dev/null +++ b/ee/config/feature_flags/experiment/remove_known_trial_form_fields_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: remove_known_trial_form_fields_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45634/ +rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/281 +milestone: '13.7' +type: experiment +group: group::conversion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/trial_registration_with_social_signin_experiment_percentage.yml b/ee/config/feature_flags/experiment/trial_registration_with_social_signin_experiment_percentage.yml new file mode 100644 index 00000000000000..e0f224ae0c45f7 --- /dev/null +++ b/ee/config/feature_flags/experiment/trial_registration_with_social_signin_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: trial_registration_with_social_signin_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45633 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/262853 +milestone: '13.7' +type: experiment +group: group::conversion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/trimmed_skip_trial_copy_experiment_percentage.yml b/ee/config/feature_flags/experiment/trimmed_skip_trial_copy_experiment_percentage.yml new file mode 100644 index 00000000000000..6e6e4555a6b5b5 --- /dev/null +++ b/ee/config/feature_flags/experiment/trimmed_skip_trial_copy_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: trimmed_skip_trial_copy_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48110 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/284956 +milestone: '13.7' +type: experiment +group: group::conversion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/upgrade_link_in_user_menu_a_experiment_percentage.yml b/ee/config/feature_flags/experiment/upgrade_link_in_user_menu_a_experiment_percentage.yml new file mode 100644 index 00000000000000..e383e7040db39e --- /dev/null +++ b/ee/config/feature_flags/experiment/upgrade_link_in_user_menu_a_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: upgrade_link_in_user_menu_a_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/29428 +rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/126 +milestone: '13.0' +type: experiment +group: group::expansion +default_enabled: false diff --git a/lib/feature/shared.rb b/lib/feature/shared.rb index 17dfe26bd8276f..a3f02156d94b2c 100644 --- a/lib/feature/shared.rb +++ b/lib/feature/shared.rb @@ -57,6 +57,8 @@ module Shared default_enabled: false, example: <<-EOS experiment(:my_experiment, project: project, actor: current_user) { ...variant code... } + # or + Gitlab::Experimentation.in_experiment_group?(:my_experiment, subject: current_user) EOS } }.freeze diff --git a/lib/gitlab/experimentation/experiment.rb b/lib/gitlab/experimentation/experiment.rb index e594c3bedeb444..b9eda0cfc3163b 100644 --- a/lib/gitlab/experimentation/experiment.rb +++ b/lib/gitlab/experimentation/experiment.rb @@ -3,6 +3,8 @@ module Gitlab module Experimentation class Experiment + FEATURE_FLAG_SUFFIX = "_experiment_percentage" + attr_reader :key, :tracking_category, :use_backwards_compatible_subject_index def initialize(key, **params) @@ -10,7 +12,7 @@ def initialize(key, **params) @tracking_category = params[:tracking_category] @use_backwards_compatible_subject_index = params[:use_backwards_compatible_subject_index] - @experiment_percentage = Feature.get(:"#{key}_experiment_percentage").percentage_of_time_value # rubocop:disable Gitlab/AvoidFeatureGet + @experiment_percentage = Feature.get(:"#{key}#{FEATURE_FLAG_SUFFIX}").percentage_of_time_value # rubocop:disable Gitlab/AvoidFeatureGet end def active? diff --git a/spec/support/helpers/stub_experiments.rb b/spec/support/helpers/stub_experiments.rb index 247692d83ee3b0..9188bc704c1365 100644 --- a/spec/support/helpers/stub_experiments.rb +++ b/spec/support/helpers/stub_experiments.rb @@ -1,6 +1,8 @@ # frozen_string_literal: true module StubExperiments + SUFFIX = Gitlab::Experimentation::Experiment::FEATURE_FLAG_SUFFIX + # Stub Experiment with `key: true/false` # # @param [Hash] experiment where key is feature name and value is boolean whether active or not. @@ -11,6 +13,7 @@ def stub_experiment(experiments) allow(Gitlab::Experimentation).to receive(:active?).and_call_original experiments.each do |experiment_key, enabled| + Feature.persist_used!("#{experiment_key}#{SUFFIX}") allow(Gitlab::Experimentation).to receive(:active?).with(experiment_key) { enabled } end end @@ -25,6 +28,7 @@ def stub_experiment_for_subject(experiments) allow(Gitlab::Experimentation).to receive(:in_experiment_group?).and_call_original experiments.each do |experiment_key, enabled| + Feature.persist_used!("#{experiment_key}#{SUFFIX}") allow(Gitlab::Experimentation).to receive(:in_experiment_group?).with(experiment_key, anything) { enabled } end end -- GitLab From dafe999ca56f924f5567eabcfb480ae5f6cf3d11 Mon Sep 17 00:00:00 2001 From: Dallas Reedy Date: Thu, 17 Dec 2020 16:58:36 -0800 Subject: [PATCH 2/3] Fix for broken master due to unpersisted feature flags Works around the currently broken CI job by calling Feature.enabled?(...) inside Gitlab::Experimentation::Experiment#active? even though we're not actually making full use of it (yet). Also adds yaml definition files for a few more experiments that have been added to master since the original MR was reverted. --- ..._syntax_templates_experiment_percentage.yml | 8 ++++++++ ...lines_empty_state_experiment_percentage.yml | 8 ++++++++ ...ial_during_signup_experiment_percentage.yml | 8 ++++++++ ee/spec/requests/api/experiments_spec.rb | 2 ++ lib/gitlab/experimentation/experiment.rb | 18 +++++++++++++++--- .../gitlab/experimentation/experiment_spec.rb | 6 ++++-- spec/lib/gitlab/experimentation_spec.rb | 2 ++ spec/support/helpers/stub_experiments.rb | 12 ++++++++---- spec/support/helpers/stub_feature_flags.rb | 4 ++++ 9 files changed, 59 insertions(+), 9 deletions(-) create mode 100644 ee/config/feature_flags/experiment/ci_syntax_templates_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/pipelines_empty_state_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/trial_during_signup_experiment_percentage.yml diff --git a/ee/config/feature_flags/experiment/ci_syntax_templates_experiment_percentage.yml b/ee/config/feature_flags/experiment/ci_syntax_templates_experiment_percentage.yml new file mode 100644 index 00000000000000..3ed457acce8f1b --- /dev/null +++ b/ee/config/feature_flags/experiment/ci_syntax_templates_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: ci_syntax_templates_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48141 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/281057 +milestone: '13.8' +type: experiment +group: group::activation +default_enabled: false diff --git a/ee/config/feature_flags/experiment/pipelines_empty_state_experiment_percentage.yml b/ee/config/feature_flags/experiment/pipelines_empty_state_experiment_percentage.yml new file mode 100644 index 00000000000000..beb8e8a21c63e7 --- /dev/null +++ b/ee/config/feature_flags/experiment/pipelines_empty_state_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: pipelines_empty_state_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/47952 +rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/289 +milestone: '13.8' +type: experiment +group: group::activation +default_enabled: false diff --git a/ee/config/feature_flags/experiment/trial_during_signup_experiment_percentage.yml b/ee/config/feature_flags/experiment/trial_during_signup_experiment_percentage.yml new file mode 100644 index 00000000000000..543b48b6626507 --- /dev/null +++ b/ee/config/feature_flags/experiment/trial_during_signup_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: trial_during_signup_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45147/ +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/251231 +milestone: '13.8' +type: experiment +group: group::conversion +default_enabled: false diff --git a/ee/spec/requests/api/experiments_spec.rb b/ee/spec/requests/api/experiments_spec.rb index 535fd065230a6d..99f99a8ae3d46e 100644 --- a/ee/spec/requests/api/experiments_spec.rb +++ b/ee/spec/requests/api/experiments_spec.rb @@ -20,6 +20,8 @@ end before do + skip_feature_flags_yaml_validation + skip_default_enabled_yaml_check stub_const('Gitlab::Experimentation::EXPERIMENTS', experiments) Feature.enable_percentage_of_time('experiment_1_experiment_percentage', 10) Feature.disable('experiment_2_experiment_percentage') diff --git a/lib/gitlab/experimentation/experiment.rb b/lib/gitlab/experimentation/experiment.rb index b9eda0cfc3163b..36cd673a38fbce 100644 --- a/lib/gitlab/experimentation/experiment.rb +++ b/lib/gitlab/experimentation/experiment.rb @@ -11,11 +11,13 @@ def initialize(key, **params) @key = key @tracking_category = params[:tracking_category] @use_backwards_compatible_subject_index = params[:use_backwards_compatible_subject_index] - - @experiment_percentage = Feature.get(:"#{key}#{FEATURE_FLAG_SUFFIX}").percentage_of_time_value # rubocop:disable Gitlab/AvoidFeatureGet end def active? + # TODO: just touch a feature flag + # Temporary change, we will change `experiment_percentage` in future to `Feature.enabled? + Feature.enabled?(feature_flag_name, type: :experiment, default_enabled: :yaml) + ::Gitlab.dev_env_or_com? && experiment_percentage > 0 end @@ -27,7 +29,17 @@ def enabled_for_index?(index) private - attr_reader :experiment_percentage + def experiment_percentage + feature_flag.percentage_of_time_value + end + + def feature_flag + Feature.get(feature_flag_name) # rubocop:disable Gitlab/AvoidFeatureGet + end + + def feature_flag_name + :"#{key}#{FEATURE_FLAG_SUFFIX}" + end end end end diff --git a/spec/lib/gitlab/experimentation/experiment_spec.rb b/spec/lib/gitlab/experimentation/experiment_spec.rb index 7b1d1763010ed2..008e669959796b 100644 --- a/spec/lib/gitlab/experimentation/experiment_spec.rb +++ b/spec/lib/gitlab/experimentation/experiment_spec.rb @@ -14,8 +14,10 @@ end before do - feature = double('FeatureFlag', percentage_of_time_value: percentage ) - expect(Feature).to receive(:get).with(:experiment_key_experiment_percentage).and_return(feature) + skip_feature_flags_yaml_validation + skip_default_enabled_yaml_check + feature = double('FeatureFlag', percentage_of_time_value: percentage, enabled?: true) + allow(Feature).to receive(:get).with(:experiment_key_experiment_percentage).and_return(feature) end subject(:experiment) { described_class.new(:experiment_key, **params) } diff --git a/spec/lib/gitlab/experimentation_spec.rb b/spec/lib/gitlab/experimentation_spec.rb index a68c050d8296eb..b503960b8c78de 100644 --- a/spec/lib/gitlab/experimentation_spec.rb +++ b/spec/lib/gitlab/experimentation_spec.rb @@ -38,6 +38,8 @@ } }) + skip_feature_flags_yaml_validation + skip_default_enabled_yaml_check Feature.enable_percentage_of_time(:backwards_compatible_test_experiment_experiment_percentage, enabled_percentage) Feature.enable_percentage_of_time(:test_experiment_experiment_percentage, enabled_percentage) allow(Gitlab).to receive(:com?).and_return(true) diff --git a/spec/support/helpers/stub_experiments.rb b/spec/support/helpers/stub_experiments.rb index 9188bc704c1365..408d16a7c08d78 100644 --- a/spec/support/helpers/stub_experiments.rb +++ b/spec/support/helpers/stub_experiments.rb @@ -1,8 +1,6 @@ # frozen_string_literal: true module StubExperiments - SUFFIX = Gitlab::Experimentation::Experiment::FEATURE_FLAG_SUFFIX - # Stub Experiment with `key: true/false` # # @param [Hash] experiment where key is feature name and value is boolean whether active or not. @@ -13,7 +11,7 @@ def stub_experiment(experiments) allow(Gitlab::Experimentation).to receive(:active?).and_call_original experiments.each do |experiment_key, enabled| - Feature.persist_used!("#{experiment_key}#{SUFFIX}") + Feature.persist_used!("#{experiment_key}#{feature_flag_suffix}") allow(Gitlab::Experimentation).to receive(:active?).with(experiment_key) { enabled } end end @@ -28,8 +26,14 @@ def stub_experiment_for_subject(experiments) allow(Gitlab::Experimentation).to receive(:in_experiment_group?).and_call_original experiments.each do |experiment_key, enabled| - Feature.persist_used!("#{experiment_key}#{SUFFIX}") + Feature.persist_used!("#{experiment_key}#{feature_flag_suffix}") allow(Gitlab::Experimentation).to receive(:in_experiment_group?).with(experiment_key, anything) { enabled } end end + + private + + def feature_flag_suffix + Gitlab::Experimentation::Experiment::FEATURE_FLAG_SUFFIX + end end diff --git a/spec/support/helpers/stub_feature_flags.rb b/spec/support/helpers/stub_feature_flags.rb index 7f30a2a70cdf56..77f31169ecb9e7 100644 --- a/spec/support/helpers/stub_feature_flags.rb +++ b/spec/support/helpers/stub_feature_flags.rb @@ -66,4 +66,8 @@ def stub_feature_flag_gate(object) def skip_feature_flags_yaml_validation allow(Feature::Definition).to receive(:valid_usage!) end + + def skip_default_enabled_yaml_check + allow(Feature::Definition).to receive(:default_enabled?).and_return(false) + end end -- GitLab From 0ec768ada75bddf073765e8f0e2d2551f5073149 Mon Sep 17 00:00:00 2001 From: Dallas Reedy Date: Mon, 4 Jan 2021 10:49:26 -0800 Subject: [PATCH 3/3] Add yml files for two more experiments --- .../invite_members_new_dropdown_experiment_percentage.yml | 8 ++++++++ .../trial_onboarding_issues_experiment_percentage.yml | 8 ++++++++ 2 files changed, 16 insertions(+) create mode 100644 ee/config/feature_flags/experiment/invite_members_new_dropdown_experiment_percentage.yml create mode 100644 ee/config/feature_flags/experiment/trial_onboarding_issues_experiment_percentage.yml diff --git a/ee/config/feature_flags/experiment/invite_members_new_dropdown_experiment_percentage.yml b/ee/config/feature_flags/experiment/invite_members_new_dropdown_experiment_percentage.yml new file mode 100644 index 00000000000000..6fac63b381c604 --- /dev/null +++ b/ee/config/feature_flags/experiment/invite_members_new_dropdown_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: invite_members_new_dropdown_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50069 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/268129 +milestone: '13.8' +type: experiment +group: group::expansion +default_enabled: false diff --git a/ee/config/feature_flags/experiment/trial_onboarding_issues_experiment_percentage.yml b/ee/config/feature_flags/experiment/trial_onboarding_issues_experiment_percentage.yml new file mode 100644 index 00000000000000..4d31cce9a52b66 --- /dev/null +++ b/ee/config/feature_flags/experiment/trial_onboarding_issues_experiment_percentage.yml @@ -0,0 +1,8 @@ +--- +name: trial_onboarding_issues_experiment_percentage +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48052 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/276703 +milestone: '13.8' +type: experiment +group: group::conversion +default_enabled: false -- GitLab