From 29fe7eedfd763c5a59f3138412168b92d93d2a5e Mon Sep 17 00:00:00 2001
From: Peter Leitzen <pleitzen@gitlab.com>
Date: Thu, 19 Nov 2020 17:02:30 +0100
Subject: [PATCH] Fix cop FactoryBot/InlineAssociation for sent notification

---
 .rubocop_manual_todo.yml             | 1 -
 spec/factories/sent_notifications.rb | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml
index b96cc49e01d10a..05aff51ed6ac09 100644
--- a/.rubocop_manual_todo.yml
+++ b/.rubocop_manual_todo.yml
@@ -16,7 +16,6 @@ FactoryBot/InlineAssociation:
     - 'spec/factories/import_export_uploads.rb'
     - 'spec/factories/merge_requests.rb'
     - 'spec/factories/notes.rb'
-    - 'spec/factories/sent_notifications.rb'
     - 'spec/factories/uploads.rb'
     - 'spec/factories/wiki_pages.rb'
 
diff --git a/spec/factories/sent_notifications.rb b/spec/factories/sent_notifications.rb
index 11116af7dbbb08..f10a3235202ffd 100644
--- a/spec/factories/sent_notifications.rb
+++ b/spec/factories/sent_notifications.rb
@@ -4,7 +4,7 @@
   factory :sent_notification do
     project
     recipient { project.creator }
-    noteable { create(:issue, project: project) }
+    noteable { association(:issue, project: project) }
     reply_key { SentNotification.reply_key }
   end
 end
-- 
GitLab