From bf7eaae663d85aca989fbbba28bfc7b31466da3d Mon Sep 17 00:00:00 2001
From: Peter Leitzen <pleitzen@gitlab.com>
Date: Mon, 19 Oct 2020 13:53:19 +0200
Subject: [PATCH] Fix cop FactoryBot/InlineAssociation for prometheus_alert

---
 .rubocop_todo.yml                  | 1 -
 spec/factories/prometheus_alert.rb | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index ba6efce0e251a4..ad5989259807ae 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1309,7 +1309,6 @@ FactoryBot/InlineAssociation:
     - 'spec/factories/notes.rb'
     - 'spec/factories/packages.rb'
     - 'spec/factories/packages/package_file.rb'
-    - 'spec/factories/prometheus_alert.rb'
     - 'spec/factories/resource_label_events.rb'
     - 'spec/factories/resource_milestone_event.rb'
     - 'spec/factories/resource_state_event.rb'
diff --git a/spec/factories/prometheus_alert.rb b/spec/factories/prometheus_alert.rb
index 18cf1a20e0d1f3..ad3868c38edc44 100644
--- a/spec/factories/prometheus_alert.rb
+++ b/spec/factories/prometheus_alert.rb
@@ -7,11 +7,11 @@
     threshold { 1 }
 
     environment do |alert|
-      build(:environment, project: alert.project)
+      association(:environment, project: alert.project)
     end
 
     prometheus_metric do |alert|
-      build(:prometheus_metric, project: alert.project)
+      association(:prometheus_metric, project: alert.project)
     end
 
     trait :with_runbook_url do
-- 
GitLab