From 689538b5be926dea3e46c25290a0c9378ef2cf9e Mon Sep 17 00:00:00 2001
From: Samantha Ming <sming@gitlab.com>
Date: Mon, 5 Oct 2020 09:59:51 -0700
Subject: [PATCH] Ensure suggestion works for number text

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/224143
---
 .../javascripts/lib/utils/text_markdown.js      |  1 +
 ...3-suggestion-button-not-work-for-numbers.yml |  5 +++++
 spec/frontend/lib/utils/text_markdown_spec.js   | 17 +++++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 changelogs/unreleased/224143-suggestion-button-not-work-for-numbers.yml

diff --git a/app/assets/javascripts/lib/utils/text_markdown.js b/app/assets/javascripts/lib/utils/text_markdown.js
index f4c6e4e35849af..3daffbd572fa15 100644
--- a/app/assets/javascripts/lib/utils/text_markdown.js
+++ b/app/assets/javascripts/lib/utils/text_markdown.js
@@ -166,6 +166,7 @@ export function insertMarkdownText({
   let editorSelectionEnd;
   let lastNewLine;
   let textToInsert;
+  selected = selected.toString();
 
   if (editor) {
     const selectionRange = getEditorSelectionRange(editor);
diff --git a/changelogs/unreleased/224143-suggestion-button-not-work-for-numbers.yml b/changelogs/unreleased/224143-suggestion-button-not-work-for-numbers.yml
new file mode 100644
index 00000000000000..3a7e88b2ef1c96
--- /dev/null
+++ b/changelogs/unreleased/224143-suggestion-button-not-work-for-numbers.yml
@@ -0,0 +1,5 @@
+---
+title: Ensure suggestion works for number text
+merge_request: 44332
+author:
+type: fixed
diff --git a/spec/frontend/lib/utils/text_markdown_spec.js b/spec/frontend/lib/utils/text_markdown_spec.js
index 1aaae80dcdf3b4..fd8a66baa13eff 100644
--- a/spec/frontend/lib/utils/text_markdown_spec.js
+++ b/spec/frontend/lib/utils/text_markdown_spec.js
@@ -13,6 +13,23 @@ describe('init markdown', () => {
     textArea.parentNode.removeChild(textArea);
   });
 
+  describe('insertMarkdownText', () => {
+    it('will not error if selected text is a number', () => {
+      const selected = 2;
+
+      insertMarkdownText({
+        textArea,
+        text: '',
+        tag: '',
+        blockTag: null,
+        selected,
+        wrap: false,
+      });
+
+      expect(textArea.value).toBe(selected.toString());
+    });
+  });
+
   describe('textArea', () => {
     describe('without selection', () => {
       it('inserts the tag on an empty line', () => {
-- 
GitLab