diff --git a/app/assets/javascripts/lib/utils/text_markdown.js b/app/assets/javascripts/lib/utils/text_markdown.js index f4c6e4e35849af8c10701d547e652d3b0c151a34..3daffbd572fa15b7cc09df3540746f222537a785 100644 --- a/app/assets/javascripts/lib/utils/text_markdown.js +++ b/app/assets/javascripts/lib/utils/text_markdown.js @@ -166,6 +166,7 @@ export function insertMarkdownText({ let editorSelectionEnd; let lastNewLine; let textToInsert; + selected = selected.toString(); if (editor) { const selectionRange = getEditorSelectionRange(editor); diff --git a/changelogs/unreleased/224143-suggestion-button-not-work-for-numbers.yml b/changelogs/unreleased/224143-suggestion-button-not-work-for-numbers.yml new file mode 100644 index 0000000000000000000000000000000000000000..3a7e88b2ef1c968c5270911636dcb01b5cef89cd --- /dev/null +++ b/changelogs/unreleased/224143-suggestion-button-not-work-for-numbers.yml @@ -0,0 +1,5 @@ +--- +title: Ensure suggestion works for number text +merge_request: 44332 +author: +type: fixed diff --git a/spec/frontend/lib/utils/text_markdown_spec.js b/spec/frontend/lib/utils/text_markdown_spec.js index 1aaae80dcdf3b479150546d93939e565a6a28cf4..fd8a66baa13eff4bdc6301d1b41355143be1c444 100644 --- a/spec/frontend/lib/utils/text_markdown_spec.js +++ b/spec/frontend/lib/utils/text_markdown_spec.js @@ -13,6 +13,23 @@ describe('init markdown', () => { textArea.parentNode.removeChild(textArea); }); + describe('insertMarkdownText', () => { + it('will not error if selected text is a number', () => { + const selected = 2; + + insertMarkdownText({ + textArea, + text: '', + tag: '', + blockTag: null, + selected, + wrap: false, + }); + + expect(textArea.value).toBe(selected.toString()); + }); + }); + describe('textArea', () => { describe('without selection', () => { it('inserts the tag on an empty line', () => {