diff --git a/ee/spec/lib/security/scan_result_policies/policy_violation_details_spec.rb b/ee/spec/lib/security/scan_result_policies/policy_violation_details_spec.rb index cc50a4a396d8ed2b46d998f4e1cc3f8c006e6d2f..54926a6663b385ee7c46c314926026d17c12e927 100644 --- a/ee/spec/lib/security/scan_result_policies/policy_violation_details_spec.rb +++ b/ee/spec/lib/security/scan_result_policies/policy_violation_details_spec.rb @@ -276,15 +276,16 @@ def build_violation_details(policy, data, status = :failed) scan_result_policy_read: policy2) end + let(:policy3_rule) { create(:approval_policy_rule) } let(:warn_mode_policy_rule) { create(:approval_policy_rule, security_policy: warn_mode_db_policy) } before do create(:scan_result_policy_violation, project: project, merge_request: merge_request, - scan_result_policy_read: policy3) + scan_result_policy_read: policy3, approval_policy_rule: policy3_rule) create(:report_approver_rule, :scan_finding, merge_request: merge_request, - scan_result_policy_read: policy3, name: 'Other') + scan_result_policy_read: policy3, approval_policy_rule: policy3_rule, name: 'Other') create(:report_approver_rule, :scan_finding, merge_request: merge_request, - scan_result_policy_read: policy3, name: 'Other 2') + scan_result_policy_read: policy3, approval_policy_rule: policy3_rule, name: 'Other 2') create(:scan_result_policy_violation, project: project, merge_request: merge_request, scan_result_policy_read: policy_warn_mode, approval_policy_rule: warn_mode_policy_rule) end @@ -327,17 +328,19 @@ def build_violation_details(policy, data, status = :failed) describe '#fail_open_policies' do subject(:fail_open_policies) { details.fail_open_policies } + let(:policy3_rule) { create(:approval_policy_rule) } + before do create(:scan_result_policy_violation, :failed, project: project, merge_request: merge_request, scan_result_policy_read: policy1) create(:scan_result_policy_violation, :failed, project: project, merge_request: merge_request, scan_result_policy_read: policy2) create(:scan_result_policy_violation, :warn, project: project, merge_request: merge_request, - scan_result_policy_read: policy3) + scan_result_policy_read: policy3, approval_policy_rule: policy3_rule) create(:report_approver_rule, :scan_finding, merge_request: merge_request, - scan_result_policy_read: policy3, name: 'Other') + scan_result_policy_read: policy3, approval_policy_rule: policy3_rule, name: 'Other') create(:report_approver_rule, :scan_finding, merge_request: merge_request, - scan_result_policy_read: policy3, name: 'Other 2') + scan_result_policy_read: policy3, approval_policy_rule: policy3_rule, name: 'Other 2') create(:scan_result_policy_violation, :warn, project: project, merge_request: merge_request, scan_result_policy_read: policy_warn_mode, approval_policy_rule: warn_mode_policy_rule) end