From 5832d72e6632de3e25372b8d816616d0f0cbaa59 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 27 Nov 2025 10:03:30 +0530 Subject: [PATCH 01/74] Updated the Static-analysis for artifacts repo download --- .gitlab/ci/static-analysis.gitlab-ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index d0c0dd38918f69..54d1738d431f6d 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -2,8 +2,10 @@ extends: - .default-retry - .default-before_script + - .repo-from-artifacts stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] variables: SETUP_DB: "false" ENABLE_SPRING: "1" @@ -19,6 +21,7 @@ static-analysis: - .static-analysis:rules:static-analysis - .use-pg16 needs: + - !reference [.repo-from-artifacts, needs] - job: cache:ruby-gems optional: true - job: cache:node-modules -- GitLab From 17ef8a25d781737e92bffbaf75b83aa7327c5578 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 1 Dec 2025 14:55:27 +0530 Subject: [PATCH 02/74] Updated the static analysis gitlab CI/CD --- .gitlab/ci/static-analysis.gitlab-ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 54d1738d431f6d..72e2155240f75d 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -54,7 +54,9 @@ generate-apollo-graphql-schema: image: name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:apollo entrypoint: [""] - needs: ['graphql-schema-dump'] + needs: + - ['graphql-schema-dump'] + - !reference [.repo-from-artifacts, needs] variables: USE_BUNDLE_INSTALL: "false" script: @@ -142,6 +144,7 @@ haml-lint: needs: - job: cache:ruby-gems optional: true + - !reference [.repo-from-artifacts, needs] script: - bundle exec haml-lint --parallel artifacts: @@ -158,6 +161,7 @@ rubocop: needs: - job: detect-tests optional: true + - !reference [.repo-from-artifacts, needs] variables: RUBOCOP_TARGET_FILES: "tmp/rubocop_target_files.txt" script: -- GitLab From 7ddb076e9e98de58e03b5bc60591fe0f529f7fe4 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 1 Dec 2025 15:03:09 +0530 Subject: [PATCH 03/74] Fix the linting error --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 72e2155240f75d..5ff233b48a5a6b 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -54,7 +54,7 @@ generate-apollo-graphql-schema: image: name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:apollo entrypoint: [""] - needs: + needs: - ['graphql-schema-dump'] - !reference [.repo-from-artifacts, needs] variables: -- GitLab From ee5eb3c49206bde51663ae423ab7bf6b7830b909 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 1 Dec 2025 15:26:31 +0530 Subject: [PATCH 04/74] commented repo-from-artifacts download to check metrics --- .gitlab/ci/static-analysis.gitlab-ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 5ff233b48a5a6b..030b12e40b7cc0 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -2,10 +2,10 @@ extends: - .default-retry - .default-before_script - - .repo-from-artifacts + # - .repo-from-artifacts stage: lint needs: - - !reference [.repo-from-artifacts, needs] + # - !reference [.repo-from-artifacts, needs] variables: SETUP_DB: "false" ENABLE_SPRING: "1" @@ -21,7 +21,7 @@ static-analysis: - .static-analysis:rules:static-analysis - .use-pg16 needs: - - !reference [.repo-from-artifacts, needs] + # - !reference [.repo-from-artifacts, needs] - job: cache:ruby-gems optional: true - job: cache:node-modules @@ -56,7 +56,7 @@ generate-apollo-graphql-schema: entrypoint: [""] needs: - ['graphql-schema-dump'] - - !reference [.repo-from-artifacts, needs] + # - !reference [.repo-from-artifacts, needs] variables: USE_BUNDLE_INSTALL: "false" script: @@ -144,7 +144,7 @@ haml-lint: needs: - job: cache:ruby-gems optional: true - - !reference [.repo-from-artifacts, needs] + # - !reference [.repo-from-artifacts, needs] script: - bundle exec haml-lint --parallel artifacts: @@ -161,7 +161,7 @@ rubocop: needs: - job: detect-tests optional: true - - !reference [.repo-from-artifacts, needs] + # - !reference [.repo-from-artifacts, needs] variables: RUBOCOP_TARGET_FILES: "tmp/rubocop_target_files.txt" script: -- GitLab From 0edeeb501b3bbb2935f0c21f7d2bb05ecdb8c9b1 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 1 Dec 2025 15:55:34 +0530 Subject: [PATCH 05/74] removed the commented artifacts download --- .gitlab/ci/static-analysis.gitlab-ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 030b12e40b7cc0..5ff233b48a5a6b 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -2,10 +2,10 @@ extends: - .default-retry - .default-before_script - # - .repo-from-artifacts + - .repo-from-artifacts stage: lint needs: - # - !reference [.repo-from-artifacts, needs] + - !reference [.repo-from-artifacts, needs] variables: SETUP_DB: "false" ENABLE_SPRING: "1" @@ -21,7 +21,7 @@ static-analysis: - .static-analysis:rules:static-analysis - .use-pg16 needs: - # - !reference [.repo-from-artifacts, needs] + - !reference [.repo-from-artifacts, needs] - job: cache:ruby-gems optional: true - job: cache:node-modules @@ -56,7 +56,7 @@ generate-apollo-graphql-schema: entrypoint: [""] needs: - ['graphql-schema-dump'] - # - !reference [.repo-from-artifacts, needs] + - !reference [.repo-from-artifacts, needs] variables: USE_BUNDLE_INSTALL: "false" script: @@ -144,7 +144,7 @@ haml-lint: needs: - job: cache:ruby-gems optional: true - # - !reference [.repo-from-artifacts, needs] + - !reference [.repo-from-artifacts, needs] script: - bundle exec haml-lint --parallel artifacts: @@ -161,7 +161,7 @@ rubocop: needs: - job: detect-tests optional: true - # - !reference [.repo-from-artifacts, needs] + - !reference [.repo-from-artifacts, needs] variables: RUBOCOP_TARGET_FILES: "tmp/rubocop_target_files.txt" script: -- GitLab From 6fc105185f512fc2d14f9486181960dc22afcb54 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 2 Dec 2025 12:57:04 +0530 Subject: [PATCH 06/74] updated docs and qa yaml of stage lint --- .gitlab/ci/docs.gitlab-ci.yml | 32 ++++++++++++++++++++++---------- .gitlab/ci/qa.gitlab-ci.yml | 5 +++++ 2 files changed, 27 insertions(+), 10 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index e7979ccb02e090..3361641d26747b 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -2,6 +2,7 @@ extends: - .default-retry - .docs:rules:review-docs + - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-alpine stage: review needs: [] @@ -59,7 +60,8 @@ docs-lint markdown: - .docs:rules:docs-lint - .docs-markdown-lint-image stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] script: - | cat << EOF >> .markdownlint-cli2.yaml @@ -86,7 +88,8 @@ docs-lint mermaid: - .docs-markdown-lint-image - .yarn-cache stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh - yarn_install_script @@ -97,7 +100,8 @@ docs code_quality: - .reports:rules:docs_code_quality - .docs-markdown-lint-image stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] dependencies: [] allow_failure: true script: @@ -116,7 +120,8 @@ docs hugo_build: - .default-retry - .docs:rules:docs-all-lint stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] dependencies: [] variables: DOCS_BRANCH: "main" @@ -167,7 +172,8 @@ docs-lint links: - .docs:rules:docs-lint - .docs-markdown-lint-image stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] before_script: - source scripts/utils.sh script: @@ -185,6 +191,7 @@ docs-lint deprecations-and-removals: needs: - job: cache:ruby-gems optional: true + - !reference [.repo-from-artifacts, needs] script: - bundle exec rake gitlab:docs:check_deprecations # - bundle exec rake gitlab:docs:check_windows @@ -195,7 +202,8 @@ docs-lint redirects: extends: - .default-retry - .docs:rules:redirect-check - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] before_script: - source scripts/utils.sh script: ./scripts/lint-docs-redirects.rb @@ -206,7 +214,8 @@ docs-i18n-lint markdown: - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh - install_gitlab_gem @@ -218,7 +227,8 @@ docs-i18n-lint links: - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] when: manual allow_failure: true before_script: @@ -233,7 +243,8 @@ docs-i18n-lint japanese-vale: - .docs:rules:docs-i18n-lint-japanese - .docs-markdown-lint-image stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] variables: LANGUAGE_CODE: "ja-jp" LANGUAGE_NAME: "Japanese" @@ -250,7 +261,8 @@ docs-i18n-lint paths: - .docs-markdown-lint-image allow_failure: true stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh - install_gitlab_gem diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 03ca93a15fb0eb..6676e902f344cc 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -3,6 +3,7 @@ - .with-ruby-slim-image - .default-retry - .qa-cache + - .repo-from-artifacts stage: test needs: [] variables: @@ -77,6 +78,8 @@ qa:metadata-lint: - .needs-e2e-gem-cache - .qa:rules:metadata-lint stage: lint + needs: + - !reference [.repo-from-artifacts, needs] variables: # Disable warnings in browserslist which can break on backports # https://github.com/browserslist/browserslist/blob/a287ec6/node.js#L367-L384 @@ -98,6 +101,8 @@ qa:selectors: - .needs-e2e-gem-cache - .qa:rules:selectors stage: lint + needs: + - !reference [.repo-from-artifacts, needs] script: - bundle exec bin/qa Test::Sanity::Selectors -- GitLab From 35ae6891ed1ec2f5f9d03f8aad9bd01ecf8b4a0e Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 2 Dec 2025 13:56:04 +0530 Subject: [PATCH 07/74] fix the liniting issue removed trailing space --- .gitlab/ci/docs.gitlab-ci.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 3361641d26747b..4452e071871dd1 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -60,7 +60,7 @@ docs-lint markdown: - .docs:rules:docs-lint - .docs-markdown-lint-image stage: lint - needs: + needs: - !reference [.repo-from-artifacts, needs] script: - | @@ -88,7 +88,7 @@ docs-lint mermaid: - .docs-markdown-lint-image - .yarn-cache stage: lint - needs: + needs: - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh @@ -100,7 +100,7 @@ docs code_quality: - .reports:rules:docs_code_quality - .docs-markdown-lint-image stage: lint - needs: + needs: - !reference [.repo-from-artifacts, needs] dependencies: [] allow_failure: true @@ -120,7 +120,7 @@ docs hugo_build: - .default-retry - .docs:rules:docs-all-lint stage: lint - needs: + needs: - !reference [.repo-from-artifacts, needs] dependencies: [] variables: @@ -172,7 +172,7 @@ docs-lint links: - .docs:rules:docs-lint - .docs-markdown-lint-image stage: lint - needs: + needs: - !reference [.repo-from-artifacts, needs] before_script: - source scripts/utils.sh @@ -202,7 +202,7 @@ docs-lint redirects: extends: - .default-retry - .docs:rules:redirect-check - needs: + needs: - !reference [.repo-from-artifacts, needs] before_script: - source scripts/utils.sh @@ -214,7 +214,7 @@ docs-i18n-lint markdown: - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image stage: lint - needs: + needs: - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh @@ -227,7 +227,7 @@ docs-i18n-lint links: - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image stage: lint - needs: + needs: - !reference [.repo-from-artifacts, needs] when: manual allow_failure: true @@ -243,7 +243,7 @@ docs-i18n-lint japanese-vale: - .docs:rules:docs-i18n-lint-japanese - .docs-markdown-lint-image stage: lint - needs: + needs: - !reference [.repo-from-artifacts, needs] variables: LANGUAGE_CODE: "ja-jp" @@ -261,7 +261,7 @@ docs-i18n-lint paths: - .docs-markdown-lint-image allow_failure: true stage: lint - needs: + needs: - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh -- GitLab From 19ac6f3ed319006eaa470a7e6e00b6080ee68810 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 2 Dec 2025 13:57:32 +0530 Subject: [PATCH 08/74] fix qa:orchestrator-lint job --- .gitlab/ci/qa.gitlab-ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 6676e902f344cc..ba0d1aa67ed193 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -111,9 +111,12 @@ qa:orchestrator-lint: - .qa-orchestrator-job-base - .needs-orchestrator-gem-cache - .qa:rules:gitlab-orchestrator + - .repo-from-artifacts stage: lint script: - bundle exec rubocop + needs: + - !reference [.repo-from-artifacts, needs] qa:orchestrator-rspec: extends: -- GitLab From a273d338fd98daf0909e0d0f38e5e829377d551e Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 2 Dec 2025 14:04:29 +0530 Subject: [PATCH 09/74] Updated e2e-test-pipeline-generate job --- .gitlab/ci/setup.gitlab-ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitlab/ci/setup.gitlab-ci.yml b/.gitlab/ci/setup.gitlab-ci.yml index b22bf8b5ad30c4..7abd82e616eddf 100644 --- a/.gitlab/ci/setup.gitlab-ci.yml +++ b/.gitlab/ci/setup.gitlab-ci.yml @@ -203,7 +203,10 @@ e2e-test-pipeline-generate: - .needs-e2e-gem-cache - .predictive-job - .qa:rules:determine-e2e-tests + - .repo-from-artifacts stage: prepare + needs: + - !reference [.repo-from-artifacts, needs] variables: COLORIZED_LOGS: "true" GENERATED_PIPELINE_PATH: "${CI_PROJECT_DIR}/qa/tmp" -- GitLab From f954c63679356584f3b81e758bab27028591dfd3 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 2 Dec 2025 14:23:41 +0530 Subject: [PATCH 10/74] fix: qa:orchestrator-rspec job --- .gitlab/ci/qa.gitlab-ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index ba0d1aa67ed193..1089df666d2508 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -123,6 +123,9 @@ qa:orchestrator-rspec: - .qa-orchestrator-job-base - .needs-orchestrator-gem-cache - .qa:rules:gitlab-orchestrator + - .repo-from-artifacts + needs: + - !reference [.repo-from-artifacts, needs] stage: test script: - bundle exec rspec --force-color -- GitLab From 102d6cdd977b88cee44005eb8104ec2b25dced1a Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 2 Dec 2025 15:14:06 +0530 Subject: [PATCH 11/74] Updated docs artifacts download --- .gitlab/ci/docs.gitlab-ci.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 4452e071871dd1..effeb7705e5c36 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -59,6 +59,7 @@ docs-lint markdown: - .default-retry - .docs:rules:docs-lint - .docs-markdown-lint-image + - .repo-from-artifacts stage: lint needs: - !reference [.repo-from-artifacts, needs] @@ -87,6 +88,7 @@ docs-lint mermaid: - .docs:rules:docs-lint - .docs-markdown-lint-image - .yarn-cache + - .repo-from-artifacts stage: lint needs: - !reference [.repo-from-artifacts, needs] @@ -99,6 +101,7 @@ docs code_quality: extends: - .reports:rules:docs_code_quality - .docs-markdown-lint-image + - .repo-from-artifacts stage: lint needs: - !reference [.repo-from-artifacts, needs] @@ -119,6 +122,7 @@ docs hugo_build: extends: - .default-retry - .docs:rules:docs-all-lint + - .repo-from-artifacts stage: lint needs: - !reference [.repo-from-artifacts, needs] @@ -171,6 +175,7 @@ docs-lint links: extends: - .docs:rules:docs-lint - .docs-markdown-lint-image + - .repo-from-artifacts stage: lint needs: - !reference [.repo-from-artifacts, needs] @@ -202,6 +207,7 @@ docs-lint redirects: extends: - .default-retry - .docs:rules:redirect-check + - .repo-from-artifacts needs: - !reference [.repo-from-artifacts, needs] before_script: @@ -213,6 +219,7 @@ docs-i18n-lint markdown: - .default-retry - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image + - .repo-from-artifacts stage: lint needs: - !reference [.repo-from-artifacts, needs] @@ -242,6 +249,7 @@ docs-i18n-lint japanese-vale: - .default-retry - .docs:rules:docs-i18n-lint-japanese - .docs-markdown-lint-image + - .repo-from-artifacts stage: lint needs: - !reference [.repo-from-artifacts, needs] @@ -259,6 +267,7 @@ docs-i18n-lint paths: - .default-retry - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image + - .repo-from-artifacts allow_failure: true stage: lint needs: -- GitLab From da07036646d76ff6343f2d9c23b5426ae353691d Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 2 Dec 2025 15:28:57 +0530 Subject: [PATCH 12/74] Updated docs hugo_build job --- .gitlab/ci/docs.gitlab-ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index effeb7705e5c36..d7cc58114f8ac6 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -122,10 +122,7 @@ docs hugo_build: extends: - .default-retry - .docs:rules:docs-all-lint - - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] dependencies: [] variables: DOCS_BRANCH: "main" -- GitLab From 48d214b2232512dd600ee8ea645192a7ad8b232d Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 4 Dec 2025 18:26:43 +0530 Subject: [PATCH 13/74] Updated the docs code_quality job --- .gitlab/ci/docs.gitlab-ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index d7cc58114f8ac6..67126e7c679455 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -103,8 +103,7 @@ docs code_quality: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + needs: [] dependencies: [] allow_failure: true script: -- GitLab From bb180ca616b2a178db3916d5b520220e1e289ddd Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 8 Dec 2025 15:40:14 +0530 Subject: [PATCH 14/74] Updated job docs-lint mermaid --- .gitlab/ci/docs.gitlab-ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 67126e7c679455..f90ea4add764e9 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -90,8 +90,7 @@ docs-lint mermaid: - .yarn-cache - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + needs: [] script: - source ./scripts/utils.sh - yarn_install_script -- GitLab From 9059cf611f551574b8390c0a3f05e9316439e980 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 8 Dec 2025 15:43:28 +0530 Subject: [PATCH 15/74] Updated job docs-i18n-lint paths:to download artifacts repo --- .gitlab/ci/docs.gitlab-ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index f90ea4add764e9..fbd07ec79a2a90 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -265,8 +265,7 @@ docs-i18n-lint paths: - .repo-from-artifacts allow_failure: true stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + needs: [] script: - source ./scripts/utils.sh - install_gitlab_gem -- GitLab From 0392ac006cf3d287e9d9af74031692c8871058d9 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Fri, 12 Dec 2025 17:34:18 +0530 Subject: [PATCH 16/74] Fixed job e2e-test-pipeline-generate --- .gitlab/ci/setup.gitlab-ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.gitlab/ci/setup.gitlab-ci.yml b/.gitlab/ci/setup.gitlab-ci.yml index 7abd82e616eddf..4020054cceefe2 100644 --- a/.gitlab/ci/setup.gitlab-ci.yml +++ b/.gitlab/ci/setup.gitlab-ci.yml @@ -203,10 +203,8 @@ e2e-test-pipeline-generate: - .needs-e2e-gem-cache - .predictive-job - .qa:rules:determine-e2e-tests - - .repo-from-artifacts + # - .repo-from-artifacts stage: prepare - needs: - - !reference [.repo-from-artifacts, needs] variables: COLORIZED_LOGS: "true" GENERATED_PIPELINE_PATH: "${CI_PROJECT_DIR}/qa/tmp" -- GitLab From 0575646298c85bb81392e24028962b3049491fdc Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Fri, 12 Dec 2025 17:38:45 +0530 Subject: [PATCH 17/74] Removed commented lines --- .gitlab/ci/setup.gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab/ci/setup.gitlab-ci.yml b/.gitlab/ci/setup.gitlab-ci.yml index 4020054cceefe2..b22bf8b5ad30c4 100644 --- a/.gitlab/ci/setup.gitlab-ci.yml +++ b/.gitlab/ci/setup.gitlab-ci.yml @@ -203,7 +203,6 @@ e2e-test-pipeline-generate: - .needs-e2e-gem-cache - .predictive-job - .qa:rules:determine-e2e-tests - # - .repo-from-artifacts stage: prepare variables: COLORIZED_LOGS: "true" -- GitLab From d88ac3a1057851ab0dcd956a712cbe9f059f5add Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Fri, 12 Dec 2025 21:52:06 +0530 Subject: [PATCH 18/74] Updated jobs qa:orchestrator-lint --- .gitlab/ci/docs.gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index fbd07ec79a2a90..116115025b3ff8 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -90,7 +90,8 @@ docs-lint mermaid: - .yarn-cache - .repo-from-artifacts stage: lint - needs: [] + needs: + - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh - yarn_install_script -- GitLab From 7650594a9098c9767de6f92a98105d3505b9ce43 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Fri, 12 Dec 2025 21:55:21 +0530 Subject: [PATCH 19/74] Commented refrence for repo_from_artifacts --- .gitlab/ci/qa.gitlab-ci.yml | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 1089df666d2508..d50d3822b53ad2 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -101,8 +101,8 @@ qa:selectors: - .needs-e2e-gem-cache - .qa:rules:selectors stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + # needs: + # - !reference [.repo-from-artifacts, needs] script: - bundle exec bin/qa Test::Sanity::Selectors @@ -111,21 +111,17 @@ qa:orchestrator-lint: - .qa-orchestrator-job-base - .needs-orchestrator-gem-cache - .qa:rules:gitlab-orchestrator - - .repo-from-artifacts stage: lint script: - bundle exec rubocop - needs: - - !reference [.repo-from-artifacts, needs] + # needs: + # - !reference [.repo-from-artifacts, needs] qa:orchestrator-rspec: extends: - .qa-orchestrator-job-base - .needs-orchestrator-gem-cache - .qa:rules:gitlab-orchestrator - - .repo-from-artifacts - needs: - - !reference [.repo-from-artifacts, needs] stage: test script: - bundle exec rspec --force-color -- GitLab From 1d163f87dc41f35977d4b70ec60cd534c4ad13d0 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Fri, 12 Dec 2025 22:14:52 +0530 Subject: [PATCH 20/74] Commented need black for .qa-job-base --- .gitlab/ci/docs.gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 116115025b3ff8..4b3f0f63eca321 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -5,7 +5,7 @@ - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-alpine stage: review - needs: [] + # needs: [] variables: GIT_DEPTH: 1 # By default, deploy the Review App using the `main` branch of the `gitlab-org/technical-writing/docs-gitlab-com` project -- GitLab From b539d793b01dcb2f038d771063cd5af5f34bcb01 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Fri, 12 Dec 2025 22:15:17 +0530 Subject: [PATCH 21/74] Commented need block --- .gitlab/ci/qa.gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index d50d3822b53ad2..955c6da8603fe8 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -5,7 +5,7 @@ - .qa-cache - .repo-from-artifacts stage: test - needs: [] + # needs: [] variables: USE_BUNDLE_INSTALL: "false" BUNDLE_GEMFILE: "Gemfile" -- GitLab From 85ccb5b11d0152a8bfd4679231da4ce3d9c3d69d Mon Sep 17 00:00:00 2001 From: Pranshu Sharma Date: Mon, 15 Dec 2025 12:07:38 +0530 Subject: [PATCH 22/74] Removes needs section of qa:metadata-lint job --- .gitlab/ci/qa.gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 955c6da8603fe8..dbe018ef7e796c 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -78,8 +78,6 @@ qa:metadata-lint: - .needs-e2e-gem-cache - .qa:rules:metadata-lint stage: lint - needs: - - !reference [.repo-from-artifacts, needs] variables: # Disable warnings in browserslist which can break on backports # https://github.com/browserslist/browserslist/blob/a287ec6/node.js#L367-L384 -- GitLab From f8a054d71263cb44b3e42ac6887c7e183b23b010 Mon Sep 17 00:00:00 2001 From: Pranshu Sharma Date: Mon, 15 Dec 2025 12:08:16 +0530 Subject: [PATCH 23/74] Add .repo-from-artifacts for docs-lint deprecations-and-removals job --- .gitlab/ci/docs.gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 4b3f0f63eca321..d579d497b6763c 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -188,6 +188,7 @@ docs-lint deprecations-and-removals: - .ruby-cache - .default-before_script - .docs:rules:deprecations-and-removals + - .repo-from-artifacts stage: lint needs: - job: cache:ruby-gems -- GitLab From 9aa0f2a7a10b4b85193102635efbee14599645f0 Mon Sep 17 00:00:00 2001 From: Pranshu Sharma Date: Mon, 15 Dec 2025 12:08:35 +0530 Subject: [PATCH 24/74] Added .repo-from-artifacts --- .gitlab/ci/static-analysis.gitlab-ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 5ff233b48a5a6b..d6b5a72e1d6f9c 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -20,8 +20,7 @@ static-analysis: - .static-analysis-cache - .static-analysis:rules:static-analysis - .use-pg16 - needs: - - !reference [.repo-from-artifacts, needs] + - .repo-from-artifacts - job: cache:ruby-gems optional: true - job: cache:node-modules -- GitLab From 77321b68c00dddfedf6df6f34f28f148b96e0857 Mon Sep 17 00:00:00 2001 From: Pranshu Sharma Date: Mon, 15 Dec 2025 12:11:08 +0530 Subject: [PATCH 25/74] Removes need section for static-analysis-base --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index d6b5a72e1d6f9c..32f576333228fb 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -4,8 +4,6 @@ - .default-before_script - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] variables: SETUP_DB: "false" ENABLE_SPRING: "1" -- GitLab From 765d5bfb6376dcb5bf1550fde0349edd9a3592fd Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 12:14:48 +0530 Subject: [PATCH 26/74] Updated the jobs of stage lint by removing need section --- .gitlab/ci/docs.gitlab-ci.yml | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 4b3f0f63eca321..cb5ea48920a526 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -103,7 +103,7 @@ docs code_quality: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - needs: [] + # needs: [] dependencies: [] allow_failure: true script: @@ -173,8 +173,8 @@ docs-lint links: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + # needs: + # - !reference [.repo-from-artifacts, needs] before_script: - source scripts/utils.sh script: @@ -204,8 +204,8 @@ docs-lint redirects: - .default-retry - .docs:rules:redirect-check - .repo-from-artifacts - needs: - - !reference [.repo-from-artifacts, needs] + # needs: + # - !reference [.repo-from-artifacts, needs] before_script: - source scripts/utils.sh script: ./scripts/lint-docs-redirects.rb @@ -217,8 +217,8 @@ docs-i18n-lint markdown: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + # needs: + # - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh - install_gitlab_gem @@ -229,9 +229,10 @@ docs-i18n-lint links: - .default-retry - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image + - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + # needs: + # - !reference [.repo-from-artifacts, needs] when: manual allow_failure: true before_script: @@ -247,8 +248,8 @@ docs-i18n-lint japanese-vale: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + # needs: + # - !reference [.repo-from-artifacts, needs] variables: LANGUAGE_CODE: "ja-jp" LANGUAGE_NAME: "Japanese" @@ -266,7 +267,7 @@ docs-i18n-lint paths: - .repo-from-artifacts allow_failure: true stage: lint - needs: [] + # needs: [] script: - source ./scripts/utils.sh - install_gitlab_gem -- GitLab From 5193643b878c990f9306c05519fa9c0055324852 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 12:20:13 +0530 Subject: [PATCH 27/74] Updated static-analysis CI file by removing needs section --- .gitlab/ci/static-analysis.gitlab-ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 32f576333228fb..a59b93192cf531 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -4,6 +4,8 @@ - .default-before_script - .repo-from-artifacts stage: lint + # needs: + # - !reference [.repo-from-artifacts, needs] variables: SETUP_DB: "false" ENABLE_SPRING: "1" @@ -18,7 +20,8 @@ static-analysis: - .static-analysis-cache - .static-analysis:rules:static-analysis - .use-pg16 - - .repo-from-artifacts + needs: + # - !reference [.repo-from-artifacts, needs] - job: cache:ruby-gems optional: true - job: cache:node-modules -- GitLab From 9cb421d96ac2512397a5be73ff69f7c2bc85a0a8 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 13:42:44 +0530 Subject: [PATCH 28/74] Added repo-from-artifacts for stage lint jobs --- .gitlab/ci/qa.gitlab-ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index dbe018ef7e796c..b6c8954b59a92a 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -77,6 +77,7 @@ qa:metadata-lint: - .qa-job-base - .needs-e2e-gem-cache - .qa:rules:metadata-lint + - .repo-from-artifacts stage: lint variables: # Disable warnings in browserslist which can break on backports @@ -98,6 +99,7 @@ qa:selectors: - .qa-job-base - .needs-e2e-gem-cache - .qa:rules:selectors + - .repo-from-artifacts stage: lint # needs: # - !reference [.repo-from-artifacts, needs] @@ -109,6 +111,7 @@ qa:orchestrator-lint: - .qa-orchestrator-job-base - .needs-orchestrator-gem-cache - .qa:rules:gitlab-orchestrator + - .repo-from-artifacts stage: lint script: - bundle exec rubocop -- GitLab From b82c8d2bb5d212d969929a72c7f06c66b4260dd5 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 22:18:37 +0530 Subject: [PATCH 29/74] Updated static-analysis job with repo artifgacts download --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index a59b93192cf531..9bf3bdcd714d37 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -20,6 +20,7 @@ static-analysis: - .static-analysis-cache - .static-analysis:rules:static-analysis - .use-pg16 + - .repo-from-artifacts needs: # - !reference [.repo-from-artifacts, needs] - job: cache:ruby-gems @@ -219,6 +220,7 @@ rails-next-dependency-check: extends: - .ruby-cache - .rails:rules:rails-next-dependency-check + - .repo-from-artifacts variables: BUNDLE_GEMFILE: Gemfile.next script: -- GitLab From 35388444c5fcdcbc28fc0faeeebddd8a155f1ad3 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 22:27:08 +0530 Subject: [PATCH 30/74] Removed artifacts download from .qa-job-base --- .gitlab/ci/qa.gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index ec3b3adb712d91..d7636f8da3d24c 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -3,7 +3,7 @@ - .with-ruby-slim-image - .default-retry - .qa-cache - - .repo-from-artifacts + # - .repo-from-artifacts stage: test # needs: [] variables: -- GitLab From 44785594310496f3002cd2613f4bb42720d7e67d Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 22:27:42 +0530 Subject: [PATCH 31/74] Updated yaml-lint jobs --- .gitlab/ci/yaml.gitlab-ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitlab/ci/yaml.gitlab-ci.yml b/.gitlab/ci/yaml.gitlab-ci.yml index 70816705bfeb19..3e1a783b11e71b 100644 --- a/.gitlab/ci/yaml.gitlab-ci.yml +++ b/.gitlab/ci/yaml.gitlab-ci.yml @@ -5,6 +5,7 @@ lint-yaml: extends: - .default-retry - .yaml-lint:rules + - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint needs: [] @@ -19,6 +20,7 @@ lint-pipeline-yaml: extends: - .default-retry - .lint-pipeline-yaml:rules + - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint needs: [] @@ -31,6 +33,7 @@ lint-metrics-yaml: extends: - .default-retry - .lint-metrics-yaml:rules + - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint needs: [] -- GitLab From 45aa17e001597e09c2dd7a0d8da8316de9cc7b45 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 22:34:09 +0530 Subject: [PATCH 32/74] commented needs [] --- .gitlab/ci/yaml.gitlab-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab/ci/yaml.gitlab-ci.yml b/.gitlab/ci/yaml.gitlab-ci.yml index 3e1a783b11e71b..09dff34fe1a1e5 100644 --- a/.gitlab/ci/yaml.gitlab-ci.yml +++ b/.gitlab/ci/yaml.gitlab-ci.yml @@ -8,7 +8,7 @@ lint-yaml: - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint - needs: [] + # needs: [] script: - yamllint --strict -f colored . @@ -23,7 +23,7 @@ lint-pipeline-yaml: - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint - needs: [] + # needs: [] variables: LINT_PATHS: .gitlab-ci.yml .gitlab/ci lib/gitlab/ci/templates data/deprecations data/whats_new script: @@ -36,7 +36,7 @@ lint-metrics-yaml: - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint - needs: [] + # needs: [] variables: LINT_PATHS: config/metrics script: -- GitLab From c094755c33c8d8af227f6fad3f28fb045409d041 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 22:52:46 +0530 Subject: [PATCH 33/74] Updated .static-analysis-base --- .gitlab/ci/static-analysis.gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 73241979ff367a..59d3cb8f86ffe3 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -2,7 +2,7 @@ extends: - .default-retry - .default-before_script - - .repo-from-artifacts + # - .repo-from-artifacts stage: lint # needs: # - !reference [.repo-from-artifacts, needs] @@ -265,6 +265,7 @@ semgrep-appsec-custom-rules: stage: lint extends: - .semgrep-appsec-custom-rules:rules + - .repo-from-artifacts rules: - if: $CI_MERGE_REQUEST_DRAFT == "true" when: never -- GitLab From ba3711ab3373037b7184c5ed2d48e4c6c9d96492 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 22:53:46 +0530 Subject: [PATCH 34/74] Updated docs job of stage lint --- .gitlab/ci/docs.gitlab-ci.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 84b6ced4a93a48..3d591f4230c5ee 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -45,8 +45,8 @@ docs-lint markdown: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + # needs: + # - !reference [.repo-from-artifacts, needs] script: - | cat << EOF >> .markdownlint-cli2.yaml @@ -74,8 +74,8 @@ docs-lint mermaid: - .yarn-cache - .repo-from-artifacts stage: lint - needs: - - !reference [.repo-from-artifacts, needs] + # needs: + # - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh - yarn_install_script @@ -105,6 +105,7 @@ docs hugo_build: extends: - .default-retry - .docs:rules:docs-all-lint + - .repo-from-artifacts stage: lint dependencies: [] variables: @@ -177,7 +178,7 @@ docs-lint deprecations-and-removals: needs: - job: cache:ruby-gems optional: true - - !reference [.repo-from-artifacts, needs] + # - !reference [.repo-from-artifacts, needs] script: - bundle exec rake gitlab:docs:check_deprecations # - bundle exec rake gitlab:docs:check_windows -- GitLab From 2870a1f3ba342ed5848c850b570f0f6719c56f51 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 23:20:34 +0530 Subject: [PATCH 35/74] Updated .static-analysis-base --- .gitlab/ci/static-analysis.gitlab-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 59d3cb8f86ffe3..858339668e9a78 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -4,8 +4,8 @@ - .default-before_script # - .repo-from-artifacts stage: lint - # needs: - # - !reference [.repo-from-artifacts, needs] + needs: + - !reference [.repo-from-artifacts, needs] variables: SETUP_DB: "false" ENABLE_SPRING: "1" @@ -20,7 +20,7 @@ static-analysis: - .static-analysis-cache - .static-analysis:rules:static-analysis - .use-pg16 - - .repo-from-artifacts + # - .repo-from-artifacts needs: # - !reference [.repo-from-artifacts, needs] - job: cache:ruby-gems -- GitLab From d1e9db89c6bcf755edea20bd49e0bd0a04cfefe1 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 23:46:55 +0530 Subject: [PATCH 36/74] Added artifacts download for docs hugo_build job --- .gitlab/ci/docs.gitlab-ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 3d591f4230c5ee..b8ade455022da0 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -105,7 +105,9 @@ docs hugo_build: extends: - .default-retry - .docs:rules:docs-all-lint - - .repo-from-artifacts + # - .repo-from-artifacts + needs: + - !reference [.repo-from-artifacts, needs] stage: lint dependencies: [] variables: -- GitLab From e36c5e1a1e97c1890f7bdf9f449d5a31087782d3 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 23:54:22 +0530 Subject: [PATCH 37/74] Fix: remove commented lines --- .gitlab/ci/docs.gitlab-ci.yml | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index b8ade455022da0..db446072b0b2c5 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -45,8 +45,6 @@ docs-lint markdown: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - # needs: - # - !reference [.repo-from-artifacts, needs] script: - | cat << EOF >> .markdownlint-cli2.yaml @@ -74,8 +72,6 @@ docs-lint mermaid: - .yarn-cache - .repo-from-artifacts stage: lint - # needs: - # - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh - yarn_install_script @@ -160,8 +156,6 @@ docs-lint links: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - # needs: - # - !reference [.repo-from-artifacts, needs] before_script: - source scripts/utils.sh script: @@ -180,7 +174,6 @@ docs-lint deprecations-and-removals: needs: - job: cache:ruby-gems optional: true - # - !reference [.repo-from-artifacts, needs] script: - bundle exec rake gitlab:docs:check_deprecations # - bundle exec rake gitlab:docs:check_windows @@ -192,8 +185,6 @@ docs-lint redirects: - .default-retry - .docs:rules:redirect-check - .repo-from-artifacts - # needs: - # - !reference [.repo-from-artifacts, needs] before_script: - source scripts/utils.sh script: ./scripts/lint-docs-redirects.rb @@ -205,8 +196,6 @@ docs-i18n-lint markdown: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - # needs: - # - !reference [.repo-from-artifacts, needs] script: - source ./scripts/utils.sh - install_gitlab_gem @@ -219,8 +208,6 @@ docs-i18n-lint links: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - # needs: - # - !reference [.repo-from-artifacts, needs] when: manual allow_failure: true before_script: @@ -236,8 +223,6 @@ docs-i18n-lint japanese-vale: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - # needs: - # - !reference [.repo-from-artifacts, needs] variables: LANGUAGE_CODE: "ja-jp" LANGUAGE_NAME: "Japanese" @@ -255,7 +240,6 @@ docs-i18n-lint paths: - .repo-from-artifacts allow_failure: true stage: lint - # needs: [] script: - source ./scripts/utils.sh - install_gitlab_gem -- GitLab From d55a82733b090e3b89bb484393e992a37ed736c4 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Mon, 15 Dec 2025 23:56:43 +0530 Subject: [PATCH 38/74] Fix remove commented lines from qa lint jobs --- .gitlab/ci/qa.gitlab-ci.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index d7636f8da3d24c..03fae85ef88ed4 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -3,9 +3,7 @@ - .with-ruby-slim-image - .default-retry - .qa-cache - # - .repo-from-artifacts stage: test - # needs: [] variables: USE_BUNDLE_INSTALL: "false" BUNDLE_GEMFILE: "Gemfile" @@ -101,8 +99,6 @@ qa:selectors: - .qa:rules:selectors - .repo-from-artifacts stage: lint - # needs: - # - !reference [.repo-from-artifacts, needs] script: - bundle exec bin/qa Test::Sanity::Selectors @@ -115,8 +111,6 @@ qa:orchestrator-lint: stage: lint script: - bundle exec rubocop - # needs: - # - !reference [.repo-from-artifacts, needs] qa:orchestrator-rspec: extends: -- GitLab From 3f9d74486cc2b28b22e606513e28640e7fa9d881 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 12:38:13 +0530 Subject: [PATCH 39/74] Updated .qa-job-base with repo artifacts download --- .gitlab/ci/qa.gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 03fae85ef88ed4..416ab146b3c34f 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -3,6 +3,7 @@ - .with-ruby-slim-image - .default-retry - .qa-cache + - .repo-from-artifacts stage: test variables: USE_BUNDLE_INSTALL: "false" -- GitLab From 5b2789fc85d54f1a46e3b7fda0f131d7744e16ed Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 12:43:03 +0530 Subject: [PATCH 40/74] Fix: removed commented lines --- .gitlab/ci/docs.gitlab-ci.yml | 2 -- .gitlab/ci/yaml.gitlab-ci.yml | 3 --- 2 files changed, 5 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index db446072b0b2c5..82e3047ce309a6 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -5,7 +5,6 @@ - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-alpine stage: review - # needs: [] variables: GIT_DEPTH: 1 # By default, deploy the Review App using the `main` branch of the `gitlab-org/technical-writing/docs-gitlab-com` project @@ -83,7 +82,6 @@ docs code_quality: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint - # needs: [] dependencies: [] allow_failure: true script: diff --git a/.gitlab/ci/yaml.gitlab-ci.yml b/.gitlab/ci/yaml.gitlab-ci.yml index 09dff34fe1a1e5..2d5e08436f2d3c 100644 --- a/.gitlab/ci/yaml.gitlab-ci.yml +++ b/.gitlab/ci/yaml.gitlab-ci.yml @@ -8,7 +8,6 @@ lint-yaml: - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint - # needs: [] script: - yamllint --strict -f colored . @@ -23,7 +22,6 @@ lint-pipeline-yaml: - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint - # needs: [] variables: LINT_PATHS: .gitlab-ci.yml .gitlab/ci lib/gitlab/ci/templates data/deprecations data/whats_new script: @@ -36,7 +34,6 @@ lint-metrics-yaml: - .repo-from-artifacts image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint - # needs: [] variables: LINT_PATHS: config/metrics script: -- GitLab From ebe7538b2d8bb81f7dfc07934badd52ba3d417f0 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 12:46:02 +0530 Subject: [PATCH 41/74] Testing qa jobs --- .gitlab/ci/qa.gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 416ab146b3c34f..06690903c58787 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -98,7 +98,7 @@ qa:selectors: - .qa-job-base - .needs-e2e-gem-cache - .qa:rules:selectors - - .repo-from-artifacts + # - .repo-from-artifacts stage: lint script: - bundle exec bin/qa Test::Sanity::Selectors @@ -108,7 +108,7 @@ qa:orchestrator-lint: - .qa-orchestrator-job-base - .needs-orchestrator-gem-cache - .qa:rules:gitlab-orchestrator - - .repo-from-artifacts + # - .repo-from-artifacts stage: lint script: - bundle exec rubocop -- GitLab From 79ade76104e740006ba76768494e43bb5d969776 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 12:53:59 +0530 Subject: [PATCH 42/74] Updated qa jobs --- .gitlab/ci/qa.gitlab-ci.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 06690903c58787..03fae85ef88ed4 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -3,7 +3,6 @@ - .with-ruby-slim-image - .default-retry - .qa-cache - - .repo-from-artifacts stage: test variables: USE_BUNDLE_INSTALL: "false" @@ -98,7 +97,7 @@ qa:selectors: - .qa-job-base - .needs-e2e-gem-cache - .qa:rules:selectors - # - .repo-from-artifacts + - .repo-from-artifacts stage: lint script: - bundle exec bin/qa Test::Sanity::Selectors @@ -108,7 +107,7 @@ qa:orchestrator-lint: - .qa-orchestrator-job-base - .needs-orchestrator-gem-cache - .qa:rules:gitlab-orchestrator - # - .repo-from-artifacts + - .repo-from-artifacts stage: lint script: - bundle exec rubocop -- GitLab From 37275d3274b5fed82b91858e78d64512e8274aab Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 13:35:34 +0530 Subject: [PATCH 43/74] Fix : Remove commented lines --- .gitlab/ci/docs.gitlab-ci.yml | 3 --- .gitlab/ci/static-analysis.gitlab-ci.yml | 4 ---- 2 files changed, 7 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 82e3047ce309a6..fbd6da5b3a7fd3 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -99,9 +99,6 @@ docs hugo_build: extends: - .default-retry - .docs:rules:docs-all-lint - # - .repo-from-artifacts - needs: - - !reference [.repo-from-artifacts, needs] stage: lint dependencies: [] variables: diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 858339668e9a78..f9ea7b6f5a5fb9 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -2,10 +2,8 @@ extends: - .default-retry - .default-before_script - # - .repo-from-artifacts stage: lint needs: - - !reference [.repo-from-artifacts, needs] variables: SETUP_DB: "false" ENABLE_SPRING: "1" @@ -20,9 +18,7 @@ static-analysis: - .static-analysis-cache - .static-analysis:rules:static-analysis - .use-pg16 - # - .repo-from-artifacts needs: - # - !reference [.repo-from-artifacts, needs] - job: cache:ruby-gems optional: true - job: cache:node-modules -- GitLab From 8d36f6fbc57ae6296eb6a5ecd1373a45a95894c1 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 14:40:22 +0530 Subject: [PATCH 44/74] Removing needs section --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index f9ea7b6f5a5fb9..897a4dbf32cc44 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -3,7 +3,6 @@ - .default-retry - .default-before_script stage: lint - needs: variables: SETUP_DB: "false" ENABLE_SPRING: "1" @@ -53,7 +52,6 @@ generate-apollo-graphql-schema: entrypoint: [""] needs: - ['graphql-schema-dump'] - - !reference [.repo-from-artifacts, needs] variables: USE_BUNDLE_INSTALL: "false" script: -- GitLab From cf041edc200ba5cf6141bf2a93ae814fe9674275 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 15:42:29 +0530 Subject: [PATCH 45/74] Updated ping-appsec-for-sast-findings job --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 897a4dbf32cc44..90f3dbe7256f72 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -360,6 +360,7 @@ ping-appsec-for-sast-findings: image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}alpine:latest extends: - .ping-appsec-for-sast-findings:rules + - .repo-from-artifacts rules: - if: $CI_MERGE_REQUEST_DRAFT == "true" when: never @@ -396,6 +397,7 @@ check-deprecated-files: extends: - .static-analysis-base - .static-analysis:rules:check-deprecated-files + - .repo-from-artifacts variables: USE_BUNDLE_INSTALL: "false" script: -- GitLab From 2f10ebd4c359f445b2063451eb921d19aa3abe3a Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 16:06:04 +0530 Subject: [PATCH 46/74] Fix: pipeline linitng error --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 90f3dbe7256f72..bbf6891c3f05c9 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -360,7 +360,7 @@ ping-appsec-for-sast-findings: image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}alpine:latest extends: - .ping-appsec-for-sast-findings:rules - - .repo-from-artifacts + - .repo-from-artifacts rules: - if: $CI_MERGE_REQUEST_DRAFT == "true" when: never -- GitLab From 84a225de89f3d896e00456c81598ab6f84ced2e3 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 16:19:31 +0530 Subject: [PATCH 47/74] Updated static-analysis job --- .gitlab/ci/static-analysis.gitlab-ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index bbf6891c3f05c9..d775dc21ac9bf6 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -17,6 +17,7 @@ static-analysis: - .static-analysis-cache - .static-analysis:rules:static-analysis - .use-pg16 + - .repo-from-artifacts needs: - job: cache:ruby-gems optional: true @@ -24,6 +25,7 @@ static-analysis: optional: true - job: db:setup pg16 optional: true + - clone-gitlab-repo parallel: 2 variables: SETUP_DB: "true" @@ -38,6 +40,7 @@ static-verification-with-database: - .rubocop-job-cache - .static-analysis:rules:static-verification-with-database - .use-pg16 + - .repo-from-artifacts script: - bundle exec rake lint:static_verification_with_database variables: @@ -47,6 +50,7 @@ generate-apollo-graphql-schema: extends: - .static-analysis-base - .frontend:rules:default-frontend-jobs + - .repo-from-artifacts image: name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:apollo entrypoint: [""] @@ -136,6 +140,7 @@ haml-lint: - .static-analysis-base - .ruby-cache - .static-analysis:rules:haml-lint + - .repo-from-artifacts needs: - job: cache:ruby-gems optional: true -- GitLab From 8cdb4cf15dc2dc69ccf8a344845aa049bb7a7e1c Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 19:52:30 +0530 Subject: [PATCH 48/74] Added needs - clone-gitlab-repo --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index d775dc21ac9bf6..0cb34883b06933 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -56,6 +56,7 @@ generate-apollo-graphql-schema: entrypoint: [""] needs: - ['graphql-schema-dump'] + - clone-gitlab-repo variables: USE_BUNDLE_INSTALL: "false" script: @@ -375,6 +376,7 @@ ping-appsec-for-sast-findings: BOT_USER_ID: 19650678 needs: - semgrep-appsec-custom-rules + - clone-gitlab-repo script: - apk update - apk add ruby -- GitLab From d92c221b8333e81eb030101187a4748abcffea0a Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 20:23:21 +0530 Subject: [PATCH 49/74] Updated stage lint based jobs --- .gitlab/ci/docs.gitlab-ci.yml | 5 +++++ .gitlab/ci/static-analysis.gitlab-ci.yml | 3 +++ 2 files changed, 8 insertions(+) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index fbd6da5b3a7fd3..030a192730aad2 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -82,6 +82,8 @@ docs code_quality: - .docs-markdown-lint-image - .repo-from-artifacts stage: lint + needs: + - clone-gitlab-repo dependencies: [] allow_failure: true script: @@ -99,8 +101,11 @@ docs hugo_build: extends: - .default-retry - .docs:rules:docs-all-lint + - .repo-from-artifacts stage: lint dependencies: [] + needs: + - clone-gitlab-repo variables: DOCS_BRANCH: "main" before_script: diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 0cb34883b06933..e4975f13ec3ec4 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -159,6 +159,7 @@ rubocop: - .static-analysis-base - .rubocop-job-cache-push - .static-analysis:rules:rubocop + - .repo-from-artifacts needs: - job: detect-tests optional: true @@ -190,6 +191,7 @@ rubocop-docs: - .static-analysis-base - .rubocop-job-cache - .docs:rules:docs-lint + - .repo-from-artifacts script: - bundle exec rubocop --only Gitlab/DocumentationLinks/Link @@ -243,6 +245,7 @@ feature-flags-usage: - .ruby-cache # this jobs is a non optional needs for rspec:feature-flags job so it should use same rule to ensure it is present - .rails:rules:rspec-feature-flags + - .repo-from-artifacts script: - fail_on_warnings bundle exec rubocop --only Gitlab/MarkUsedFeatureFlags --cache false artifacts: -- GitLab From db40b86c3eb6975e7cc55e692686e1fad54e48f5 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 20:31:42 +0530 Subject: [PATCH 50/74] Updated docs hugo_build job --- .gitlab/ci/docs.gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 030a192730aad2..2011c8f348a042 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -108,6 +108,7 @@ docs hugo_build: - clone-gitlab-repo variables: DOCS_BRANCH: "main" + CI_FETCH_REPO_GIT_STRATEGY: none before_script: # Check if this a release branch, which would be the case for a backport. # If this is a backport MR, we need to checkout the appropriate version -- GitLab From 863eccc41694c50654e426059154738e235028c5 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 20:52:06 +0530 Subject: [PATCH 51/74] Removes dependency from docs hugo_build job --- .gitlab/ci/docs.gitlab-ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 2011c8f348a042..fe0433eaaea66d 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -103,12 +103,11 @@ docs hugo_build: - .docs:rules:docs-all-lint - .repo-from-artifacts stage: lint - dependencies: [] needs: - clone-gitlab-repo variables: DOCS_BRANCH: "main" - CI_FETCH_REPO_GIT_STRATEGY: none + # CI_FETCH_REPO_GIT_STRATEGY: none before_script: # Check if this a release branch, which would be the case for a backport. # If this is a backport MR, we need to checkout the appropriate version -- GitLab From d881a674ec90334d5372c4c44d41226dc1b0f059 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 20:56:31 +0530 Subject: [PATCH 52/74] Remove dependency block from docs code_quality job --- .gitlab/ci/docs.gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index fe0433eaaea66d..7b56d9669e604f 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -84,7 +84,6 @@ docs code_quality: stage: lint needs: - clone-gitlab-repo - dependencies: [] allow_failure: true script: - vale --output=doc/.vale/vale-json.tmpl --minAlertLevel warning doc > gl-code-quality-report-docs.json || exit_code=$? -- GitLab From b893119236963eb2e21c018bc8c73fc793f22e7f Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 21:04:12 +0530 Subject: [PATCH 53/74] Updated semgrep-appsec-custom-rules job --- .gitlab/ci/static-analysis.gitlab-ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index e4975f13ec3ec4..2f66550147f63d 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -274,7 +274,8 @@ semgrep-appsec-custom-rules: when: never - !reference [.semgrep-appsec-custom-rules:rules, rules] image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}returntocorp/semgrep:1.99.0 - needs: [] + needs: + - clone-gitlab-repo script: - git clone $CUSTOM_RULES_REPOSITORY sast-custom-rules - | @@ -358,6 +359,7 @@ templates-shellcheck: - .default-retry - .ruby-cache - .use-pg17 + - .repo-from-artifacts stage: lint needs: - setup-test-env -- GitLab From a612ff2f4ef6f0d2d1c4a25da9f20c7a305d6e38 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 21:04:35 +0530 Subject: [PATCH 54/74] Updated secret_detection job --- .gitlab/ci/reports.gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab/ci/reports.gitlab-ci.yml b/.gitlab/ci/reports.gitlab-ci.yml index 7b87ceaf875349..485045f03ca46c 100644 --- a/.gitlab/ci/reports.gitlab-ci.yml +++ b/.gitlab/ci/reports.gitlab-ci.yml @@ -39,6 +39,8 @@ semgrep-sast: secret_detection: rules: !reference [".reports:rules:secret_detection", rules] + extends: + - .repo-from-artifacts dependency-scanning: extends: -- GitLab From 82cbb550ac9f3fb32182ba62ebc1e1ebbb189153 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 21:08:58 +0530 Subject: [PATCH 55/74] Cleanup: Removed refrence section from lint stage jobs --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 2f66550147f63d..51cab1a5fb4404 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -145,7 +145,6 @@ haml-lint: needs: - job: cache:ruby-gems optional: true - - !reference [.repo-from-artifacts, needs] script: - bundle exec haml-lint --parallel artifacts: @@ -163,7 +162,6 @@ rubocop: needs: - job: detect-tests optional: true - - !reference [.repo-from-artifacts, needs] variables: RUBOCOP_TARGET_FILES: "tmp/rubocop_target_files.txt" script: -- GitLab From e8c541be37339075ade5f0389b3bb390c516f575 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Tue, 16 Dec 2025 21:14:21 +0530 Subject: [PATCH 56/74] Cleanup removing commented lines --- .gitlab/ci/docs.gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 7b56d9669e604f..d6880aae3b7aec 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -106,7 +106,6 @@ docs hugo_build: - clone-gitlab-repo variables: DOCS_BRANCH: "main" - # CI_FETCH_REPO_GIT_STRATEGY: none before_script: # Check if this a release branch, which would be the case for a backport. # If this is a backport MR, we need to checkout the appropriate version -- GitLab From db94c8e54664b8c0dcadd392c928ef39612331c8 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Wed, 17 Dec 2025 13:03:32 +0530 Subject: [PATCH 57/74] Added clone-gitlab-repo to lint jobs --- .gitlab/ci/static-analysis.gitlab-ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 51cab1a5fb4404..4e301e380713db 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -145,6 +145,7 @@ haml-lint: needs: - job: cache:ruby-gems optional: true + - clone-gitlab-repo script: - bundle exec haml-lint --parallel artifacts: @@ -162,6 +163,7 @@ rubocop: needs: - job: detect-tests optional: true + - clone-gitlab-repo variables: RUBOCOP_TARGET_FILES: "tmp/rubocop_target_files.txt" script: @@ -361,6 +363,7 @@ templates-shellcheck: stage: lint needs: - setup-test-env + - clone-gitlab-repo script: - bundle exec scripts/lint_templates_bash.rb -- GitLab From 700e5ece867eaf2b261094db2012a26faea95727 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Wed, 17 Dec 2025 13:26:34 +0530 Subject: [PATCH 58/74] Updated secret_detection job --- .gitlab/ci/reports.gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab/ci/reports.gitlab-ci.yml b/.gitlab/ci/reports.gitlab-ci.yml index 485045f03ca46c..7b87ceaf875349 100644 --- a/.gitlab/ci/reports.gitlab-ci.yml +++ b/.gitlab/ci/reports.gitlab-ci.yml @@ -39,8 +39,6 @@ semgrep-sast: secret_detection: rules: !reference [".reports:rules:secret_detection", rules] - extends: - - .repo-from-artifacts dependency-scanning: extends: -- GitLab From a063268f204e888fc5569821740562b36e6fe586 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Wed, 17 Dec 2025 13:27:33 +0530 Subject: [PATCH 59/74] Updated eslint job to use repo-from-artifacts download --- .gitlab/ci/static-analysis.gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 4e301e380713db..39a8baa775e93b 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -95,6 +95,7 @@ eslint: extends: - .eslint-base - .frontend:rules:eslint-default + - .repo-from-artifacts script: - yarn run lint:eslint:all --format gitlab artifacts: -- GitLab From 21c65c31b3e6fdc42e5341dbc568ab5dec0a4626 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Wed, 17 Dec 2025 13:59:48 +0530 Subject: [PATCH 60/74] Updated check-deprecated-files job to use repo-artifacts --- .gitlab/ci/static-analysis.gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 39a8baa775e93b..7884d35febc559 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -411,7 +411,6 @@ check-deprecated-files: extends: - .static-analysis-base - .static-analysis:rules:check-deprecated-files - - .repo-from-artifacts variables: USE_BUNDLE_INSTALL: "false" script: -- GitLab From 08a1f48ef506cca67c9f322874556dc2e4d569e6 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Wed, 17 Dec 2025 16:21:48 +0530 Subject: [PATCH 61/74] Added new base job artifact-repo-download --- .gitlab/ci/global.gitlab-ci.yml | 6 ++++++ .gitlab/ci/static-analysis.gitlab-ci.yml | 24 ++++++++++++------------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 7e67ff2faea5d9..4a3722501e2a70 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -35,6 +35,12 @@ - job: clone-gitlab-repo optional: true # Optional so easier to switch in between +.artifact-repo-download: + extends: + - .repo-from-artifacts + needs: + - clone-gitlab-repo + .production: variables: RAILS_ENV: "production" diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 7884d35febc559..e64b3063697e39 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -17,7 +17,7 @@ static-analysis: - .static-analysis-cache - .static-analysis:rules:static-analysis - .use-pg16 - - .repo-from-artifacts + - .artifact-repo-download needs: - job: cache:ruby-gems optional: true @@ -40,7 +40,7 @@ static-verification-with-database: - .rubocop-job-cache - .static-analysis:rules:static-verification-with-database - .use-pg16 - - .repo-from-artifacts + - .artifact-repo-download script: - bundle exec rake lint:static_verification_with_database variables: @@ -50,7 +50,7 @@ generate-apollo-graphql-schema: extends: - .static-analysis-base - .frontend:rules:default-frontend-jobs - - .repo-from-artifacts + - .artifact-repo-download image: name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:apollo entrypoint: [""] @@ -95,7 +95,7 @@ eslint: extends: - .eslint-base - .frontend:rules:eslint-default - - .repo-from-artifacts + - .artifact-repo-download script: - yarn run lint:eslint:all --format gitlab artifacts: @@ -142,7 +142,7 @@ haml-lint: - .static-analysis-base - .ruby-cache - .static-analysis:rules:haml-lint - - .repo-from-artifacts + - .artifact-repo-download needs: - job: cache:ruby-gems optional: true @@ -160,7 +160,7 @@ rubocop: - .static-analysis-base - .rubocop-job-cache-push - .static-analysis:rules:rubocop - - .repo-from-artifacts + - .artifact-repo-download needs: - job: detect-tests optional: true @@ -192,7 +192,7 @@ rubocop-docs: - .static-analysis-base - .rubocop-job-cache - .docs:rules:docs-lint - - .repo-from-artifacts + - .artifact-repo-download script: - bundle exec rubocop --only Gitlab/DocumentationLinks/Link @@ -223,7 +223,7 @@ rails-next-dependency-check: extends: - .ruby-cache - .rails:rules:rails-next-dependency-check - - .repo-from-artifacts + - .artifact-repo-download variables: BUNDLE_GEMFILE: Gemfile.next script: @@ -246,7 +246,7 @@ feature-flags-usage: - .ruby-cache # this jobs is a non optional needs for rspec:feature-flags job so it should use same rule to ensure it is present - .rails:rules:rspec-feature-flags - - .repo-from-artifacts + - .artifact-repo-download script: - fail_on_warnings bundle exec rubocop --only Gitlab/MarkUsedFeatureFlags --cache false artifacts: @@ -269,7 +269,7 @@ semgrep-appsec-custom-rules: stage: lint extends: - .semgrep-appsec-custom-rules:rules - - .repo-from-artifacts + - .artifact-repo-download rules: - if: $CI_MERGE_REQUEST_DRAFT == "true" when: never @@ -360,7 +360,7 @@ templates-shellcheck: - .default-retry - .ruby-cache - .use-pg17 - - .repo-from-artifacts + - .artifact-repo-download stage: lint needs: - setup-test-env @@ -373,7 +373,7 @@ ping-appsec-for-sast-findings: image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}alpine:latest extends: - .ping-appsec-for-sast-findings:rules - - .repo-from-artifacts + - .artifact-repo-download rules: - if: $CI_MERGE_REQUEST_DRAFT == "true" when: never -- GitLab From 20902113e95b69a1f7b54715a01a85027fd6f0ff Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Wed, 17 Dec 2025 16:28:46 +0530 Subject: [PATCH 62/74] Updated all the lint stage jobs to use .artifact-repo-download --- .gitlab/ci/docs.gitlab-ci.yml | 24 ++++++++++++------------ .gitlab/ci/qa.gitlab-ci.yml | 6 +++--- .gitlab/ci/yaml.gitlab-ci.yml | 6 +++--- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index d6880aae3b7aec..80748da318ce59 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -2,7 +2,7 @@ extends: - .default-retry - .docs:rules:review-docs - - .repo-from-artifacts + - .artifact-repo-download image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-alpine stage: review variables: @@ -42,7 +42,7 @@ docs-lint markdown: - .default-retry - .docs:rules:docs-lint - .docs-markdown-lint-image - - .repo-from-artifacts + - .artifact-repo-download stage: lint script: - | @@ -69,7 +69,7 @@ docs-lint mermaid: - .docs:rules:docs-lint - .docs-markdown-lint-image - .yarn-cache - - .repo-from-artifacts + - .artifact-repo-download stage: lint script: - source ./scripts/utils.sh @@ -80,7 +80,7 @@ docs code_quality: extends: - .reports:rules:docs_code_quality - .docs-markdown-lint-image - - .repo-from-artifacts + - .artifact-repo-download stage: lint needs: - clone-gitlab-repo @@ -100,7 +100,7 @@ docs hugo_build: extends: - .default-retry - .docs:rules:docs-all-lint - - .repo-from-artifacts + - .artifact-repo-download stage: lint needs: - clone-gitlab-repo @@ -152,7 +152,7 @@ docs-lint links: extends: - .docs:rules:docs-lint - .docs-markdown-lint-image - - .repo-from-artifacts + - .artifact-repo-download stage: lint before_script: - source scripts/utils.sh @@ -167,7 +167,7 @@ docs-lint deprecations-and-removals: - .ruby-cache - .default-before_script - .docs:rules:deprecations-and-removals - - .repo-from-artifacts + - .artifact-repo-download stage: lint needs: - job: cache:ruby-gems @@ -182,7 +182,7 @@ docs-lint redirects: extends: - .default-retry - .docs:rules:redirect-check - - .repo-from-artifacts + - .artifact-repo-download before_script: - source scripts/utils.sh script: ./scripts/lint-docs-redirects.rb @@ -192,7 +192,7 @@ docs-i18n-lint markdown: - .default-retry - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image - - .repo-from-artifacts + - .artifact-repo-download stage: lint script: - source ./scripts/utils.sh @@ -204,7 +204,7 @@ docs-i18n-lint links: - .default-retry - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image - - .repo-from-artifacts + - .artifact-repo-download stage: lint when: manual allow_failure: true @@ -219,7 +219,7 @@ docs-i18n-lint japanese-vale: - .default-retry - .docs:rules:docs-i18n-lint-japanese - .docs-markdown-lint-image - - .repo-from-artifacts + - .artifact-repo-download stage: lint variables: LANGUAGE_CODE: "ja-jp" @@ -235,7 +235,7 @@ docs-i18n-lint paths: - .default-retry - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image - - .repo-from-artifacts + - .artifact-repo-download allow_failure: true stage: lint script: diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 03fae85ef88ed4..0ca833d0eeecd0 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -75,7 +75,7 @@ qa:metadata-lint: - .qa-job-base - .needs-e2e-gem-cache - .qa:rules:metadata-lint - - .repo-from-artifacts + - .artifact-repo-download stage: lint variables: # Disable warnings in browserslist which can break on backports @@ -97,7 +97,7 @@ qa:selectors: - .qa-job-base - .needs-e2e-gem-cache - .qa:rules:selectors - - .repo-from-artifacts + - .artifact-repo-download stage: lint script: - bundle exec bin/qa Test::Sanity::Selectors @@ -107,7 +107,7 @@ qa:orchestrator-lint: - .qa-orchestrator-job-base - .needs-orchestrator-gem-cache - .qa:rules:gitlab-orchestrator - - .repo-from-artifacts + - .artifact-repo-download stage: lint script: - bundle exec rubocop diff --git a/.gitlab/ci/yaml.gitlab-ci.yml b/.gitlab/ci/yaml.gitlab-ci.yml index 2d5e08436f2d3c..cbf058f0569071 100644 --- a/.gitlab/ci/yaml.gitlab-ci.yml +++ b/.gitlab/ci/yaml.gitlab-ci.yml @@ -5,7 +5,7 @@ lint-yaml: extends: - .default-retry - .yaml-lint:rules - - .repo-from-artifacts + - .artifact-repo-download image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint script: @@ -19,7 +19,7 @@ lint-pipeline-yaml: extends: - .default-retry - .lint-pipeline-yaml:rules - - .repo-from-artifacts + - .artifact-repo-download image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint variables: @@ -31,7 +31,7 @@ lint-metrics-yaml: extends: - .default-retry - .lint-metrics-yaml:rules - - .repo-from-artifacts + - .artifact-repo-download image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint variables: -- GitLab From b8eb74925ccf2f7c29b88f47906160e220d94858 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 13:48:15 +0530 Subject: [PATCH 63/74] updated docs hugo build comment need --- .gitlab/ci/docs.gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 80748da318ce59..b207518714f3f3 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -102,8 +102,8 @@ docs hugo_build: - .docs:rules:docs-all-lint - .artifact-repo-download stage: lint - needs: - - clone-gitlab-repo + # needs: + # - clone-gitlab-repo variables: DOCS_BRANCH: "main" before_script: -- GitLab From 43c46888f64d0b864af2a5129946be6298b47008 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 13:54:28 +0530 Subject: [PATCH 64/74] Debug docs hugo build --- .gitlab/ci/docs.gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index b207518714f3f3..b54d5de1077aca 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -100,7 +100,8 @@ docs hugo_build: extends: - .default-retry - .docs:rules:docs-all-lint - - .artifact-repo-download + # - .artifact-repo-download + - .repo-from-artifacts stage: lint # needs: # - clone-gitlab-repo -- GitLab From 3a53dc7711e2e9004ece6edcfdc6ae713f5b95fc Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 15:21:01 +0530 Subject: [PATCH 65/74] Added new base job .lint-base --- .gitlab/ci/global.gitlab-ci.yml | 10 ++-------- .gitlab/ci/rails/shared.gitlab-ci.yml | 8 ++++++++ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 4a3722501e2a70..5ba57c67af00c6 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -29,17 +29,11 @@ .repo-from-artifacts: variables: GIT_STRATEGY: "${CI_FETCH_REPO_GIT_STRATEGY}" - needs: # If the job extending this also defines `needs`, make sure to update # its `needs` to include `clone-gitlab-repo` because it'll be overridden. - - job: clone-gitlab-repo - optional: true # Optional so easier to switch in between + needs: clone-gitlab-repo + -.artifact-repo-download: - extends: - - .repo-from-artifacts - needs: - - clone-gitlab-repo .production: variables: diff --git a/.gitlab/ci/rails/shared.gitlab-ci.yml b/.gitlab/ci/rails/shared.gitlab-ci.yml index 9aa58abdb03b47..928a38e7744871 100644 --- a/.gitlab/ci/rails/shared.gitlab-ci.yml +++ b/.gitlab/ci/rails/shared.gitlab-ci.yml @@ -9,6 +9,7 @@ include: - if: $CI_MERGE_REQUEST_IID when: manual allow_failure: true + ####################### # rspec job base specs @@ -349,6 +350,13 @@ include: # rspec job base specs ###################### +.lint-base: + extends: + - .repo-from-artifacts + - .default-retry + stage: lint + + ############################ # rspec job parallel configs # Adjusting these parallel job counts has an impact on the -- GitLab From bd40ca6ac60aa61db32b2ae45f1d9d379b631283 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 15:22:42 +0530 Subject: [PATCH 66/74] Updated job .lint-base in stage lint jobs --- .gitlab/ci/docs.gitlab-ci.yml | 27 ++++++++++++------------ .gitlab/ci/qa.gitlab-ci.yml | 6 +++--- .gitlab/ci/static-analysis.gitlab-ci.yml | 27 ++++++++++++------------ .gitlab/ci/templates/gem.gitlab-ci.yml | 3 +-- .gitlab/ci/yaml.gitlab-ci.yml | 6 +++--- 5 files changed, 33 insertions(+), 36 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index b54d5de1077aca..880b12c8cee02b 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -2,7 +2,7 @@ extends: - .default-retry - .docs:rules:review-docs - - .artifact-repo-download + - .lint-base image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-alpine stage: review variables: @@ -42,7 +42,7 @@ docs-lint markdown: - .default-retry - .docs:rules:docs-lint - .docs-markdown-lint-image - - .artifact-repo-download + - .lint-base stage: lint script: - | @@ -69,7 +69,7 @@ docs-lint mermaid: - .docs:rules:docs-lint - .docs-markdown-lint-image - .yarn-cache - - .artifact-repo-download + - .lint-base stage: lint script: - source ./scripts/utils.sh @@ -80,10 +80,9 @@ docs code_quality: extends: - .reports:rules:docs_code_quality - .docs-markdown-lint-image - - .artifact-repo-download + - .lint-base stage: lint - needs: - - clone-gitlab-repo + allow_failure: true script: - vale --output=doc/.vale/vale-json.tmpl --minAlertLevel warning doc > gl-code-quality-report-docs.json || exit_code=$? @@ -100,7 +99,7 @@ docs hugo_build: extends: - .default-retry - .docs:rules:docs-all-lint - # - .artifact-repo-download + - .lint-base - .repo-from-artifacts stage: lint # needs: @@ -153,7 +152,7 @@ docs-lint links: extends: - .docs:rules:docs-lint - .docs-markdown-lint-image - - .artifact-repo-download + - .lint-base stage: lint before_script: - source scripts/utils.sh @@ -168,7 +167,7 @@ docs-lint deprecations-and-removals: - .ruby-cache - .default-before_script - .docs:rules:deprecations-and-removals - - .artifact-repo-download + - .lint-base stage: lint needs: - job: cache:ruby-gems @@ -183,7 +182,7 @@ docs-lint redirects: extends: - .default-retry - .docs:rules:redirect-check - - .artifact-repo-download + - .lint-base before_script: - source scripts/utils.sh script: ./scripts/lint-docs-redirects.rb @@ -193,7 +192,7 @@ docs-i18n-lint markdown: - .default-retry - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image - - .artifact-repo-download + - .lint-base stage: lint script: - source ./scripts/utils.sh @@ -205,7 +204,7 @@ docs-i18n-lint links: - .default-retry - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image - - .artifact-repo-download + - .lint-base stage: lint when: manual allow_failure: true @@ -220,7 +219,7 @@ docs-i18n-lint japanese-vale: - .default-retry - .docs:rules:docs-i18n-lint-japanese - .docs-markdown-lint-image - - .artifact-repo-download + - .lint-base stage: lint variables: LANGUAGE_CODE: "ja-jp" @@ -236,7 +235,7 @@ docs-i18n-lint paths: - .default-retry - .docs:rules:docs-i18n-lint - .docs-markdown-lint-image - - .artifact-repo-download + - .lint-base allow_failure: true stage: lint script: diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 0ca833d0eeecd0..7542e8204879a7 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -75,7 +75,7 @@ qa:metadata-lint: - .qa-job-base - .needs-e2e-gem-cache - .qa:rules:metadata-lint - - .artifact-repo-download + - .lint-base stage: lint variables: # Disable warnings in browserslist which can break on backports @@ -97,7 +97,7 @@ qa:selectors: - .qa-job-base - .needs-e2e-gem-cache - .qa:rules:selectors - - .artifact-repo-download + - .lint-base stage: lint script: - bundle exec bin/qa Test::Sanity::Selectors @@ -107,7 +107,7 @@ qa:orchestrator-lint: - .qa-orchestrator-job-base - .needs-orchestrator-gem-cache - .qa:rules:gitlab-orchestrator - - .artifact-repo-download + - .lint-base stage: lint script: - bundle exec rubocop diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index e64b3063697e39..92c9c2f336361e 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -17,7 +17,7 @@ static-analysis: - .static-analysis-cache - .static-analysis:rules:static-analysis - .use-pg16 - - .artifact-repo-download + - .lint-base needs: - job: cache:ruby-gems optional: true @@ -40,7 +40,7 @@ static-verification-with-database: - .rubocop-job-cache - .static-analysis:rules:static-verification-with-database - .use-pg16 - - .artifact-repo-download + - .lint-base script: - bundle exec rake lint:static_verification_with_database variables: @@ -50,7 +50,7 @@ generate-apollo-graphql-schema: extends: - .static-analysis-base - .frontend:rules:default-frontend-jobs - - .artifact-repo-download + - .lint-base image: name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:apollo entrypoint: [""] @@ -95,7 +95,7 @@ eslint: extends: - .eslint-base - .frontend:rules:eslint-default - - .artifact-repo-download + - .lint-base script: - yarn run lint:eslint:all --format gitlab artifacts: @@ -142,7 +142,7 @@ haml-lint: - .static-analysis-base - .ruby-cache - .static-analysis:rules:haml-lint - - .artifact-repo-download + - .lint-base needs: - job: cache:ruby-gems optional: true @@ -160,7 +160,7 @@ rubocop: - .static-analysis-base - .rubocop-job-cache-push - .static-analysis:rules:rubocop - - .artifact-repo-download + - .lint-base needs: - job: detect-tests optional: true @@ -192,7 +192,7 @@ rubocop-docs: - .static-analysis-base - .rubocop-job-cache - .docs:rules:docs-lint - - .artifact-repo-download + - .lint-base script: - bundle exec rubocop --only Gitlab/DocumentationLinks/Link @@ -223,7 +223,7 @@ rails-next-dependency-check: extends: - .ruby-cache - .rails:rules:rails-next-dependency-check - - .artifact-repo-download + - .lint-base variables: BUNDLE_GEMFILE: Gemfile.next script: @@ -246,7 +246,7 @@ feature-flags-usage: - .ruby-cache # this jobs is a non optional needs for rspec:feature-flags job so it should use same rule to ensure it is present - .rails:rules:rspec-feature-flags - - .artifact-repo-download + - .lint-base script: - fail_on_warnings bundle exec rubocop --only Gitlab/MarkUsedFeatureFlags --cache false artifacts: @@ -269,14 +269,13 @@ semgrep-appsec-custom-rules: stage: lint extends: - .semgrep-appsec-custom-rules:rules - - .artifact-repo-download + - .lint-base rules: - if: $CI_MERGE_REQUEST_DRAFT == "true" when: never - !reference [.semgrep-appsec-custom-rules:rules, rules] image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}returntocorp/semgrep:1.99.0 - needs: - - clone-gitlab-repo + script: - git clone $CUSTOM_RULES_REPOSITORY sast-custom-rules - | @@ -360,7 +359,7 @@ templates-shellcheck: - .default-retry - .ruby-cache - .use-pg17 - - .artifact-repo-download + - .lint-base stage: lint needs: - setup-test-env @@ -373,7 +372,7 @@ ping-appsec-for-sast-findings: image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}alpine:latest extends: - .ping-appsec-for-sast-findings:rules - - .artifact-repo-download + - .lint-base rules: - if: $CI_MERGE_REQUEST_DRAFT == "true" when: never diff --git a/.gitlab/ci/templates/gem.gitlab-ci.yml b/.gitlab/ci/templates/gem.gitlab-ci.yml index 87aafacd2a6224..520bb9b21e3734 100644 --- a/.gitlab/ci/templates/gem.gitlab-ci.yml +++ b/.gitlab/ci/templates/gem.gitlab-ci.yml @@ -35,8 +35,7 @@ spec: gems $[[inputs.gem_name]]: extends: ".gems:rules:$[[inputs.gem_name]]" - needs: - - clone-gitlab-repo + trigger: include: "$[[inputs.gem_path_prefix]]$[[inputs.gem_name]]/.gitlab-ci.yml" strategy: depend diff --git a/.gitlab/ci/yaml.gitlab-ci.yml b/.gitlab/ci/yaml.gitlab-ci.yml index cbf058f0569071..b47fd4755d7c8f 100644 --- a/.gitlab/ci/yaml.gitlab-ci.yml +++ b/.gitlab/ci/yaml.gitlab-ci.yml @@ -5,7 +5,7 @@ lint-yaml: extends: - .default-retry - .yaml-lint:rules - - .artifact-repo-download + - .lint-base image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint script: @@ -19,7 +19,7 @@ lint-pipeline-yaml: extends: - .default-retry - .lint-pipeline-yaml:rules - - .artifact-repo-download + - .lint-base image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint variables: @@ -31,7 +31,7 @@ lint-metrics-yaml: extends: - .default-retry - .lint-metrics-yaml:rules - - .artifact-repo-download + - .lint-base image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}pipelinecomponents/yamllint:latest stage: lint variables: -- GitLab From 160a08f8cdd49ca93b2d4bc45f7d621aa58d4402 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 15:36:58 +0530 Subject: [PATCH 67/74] Updated .review-docs jobs --- .gitlab/ci/docs.gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 880b12c8cee02b..8bc2e794036a7f 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -2,7 +2,7 @@ extends: - .default-retry - .docs:rules:review-docs - - .lint-base + # - .lint-base image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-alpine stage: review variables: -- GitLab From c1de2607cb607972d21ce6f5235368ab7a59401d Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 15:41:59 +0530 Subject: [PATCH 68/74] Updated .repo-from-artifacts need section --- .gitlab/ci/global.gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 5ba57c67af00c6..b109014e0dce6c 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -31,7 +31,8 @@ GIT_STRATEGY: "${CI_FETCH_REPO_GIT_STRATEGY}" # If the job extending this also defines `needs`, make sure to update # its `needs` to include `clone-gitlab-repo` because it'll be overridden. - needs: clone-gitlab-repo + needs: + - clone-gitlab-repo -- GitLab From e0555b9ce3ee22ec8c20f6157334cbaa31087bd9 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 16:02:38 +0530 Subject: [PATCH 69/74] Fix pipeline liniting error --- .gitlab/ci/docs.gitlab-ci.yml | 1 - .gitlab/ci/global.gitlab-ci.yml | 6 ++---- .gitlab/ci/rails/shared.gitlab-ci.yml | 3 +-- .gitlab/ci/static-analysis.gitlab-ci.yml | 1 - 4 files changed, 3 insertions(+), 8 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 8bc2e794036a7f..48af9de00dfad2 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -82,7 +82,6 @@ docs code_quality: - .docs-markdown-lint-image - .lint-base stage: lint - allow_failure: true script: - vale --output=doc/.vale/vale-json.tmpl --minAlertLevel warning doc > gl-code-quality-report-docs.json || exit_code=$? diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index b109014e0dce6c..df722cd508d9ee 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -31,10 +31,8 @@ GIT_STRATEGY: "${CI_FETCH_REPO_GIT_STRATEGY}" # If the job extending this also defines `needs`, make sure to update # its `needs` to include `clone-gitlab-repo` because it'll be overridden. - needs: - - clone-gitlab-repo - - + needs: + - clone-gitlab-repo .production: variables: diff --git a/.gitlab/ci/rails/shared.gitlab-ci.yml b/.gitlab/ci/rails/shared.gitlab-ci.yml index 928a38e7744871..210e511f95bc16 100644 --- a/.gitlab/ci/rails/shared.gitlab-ci.yml +++ b/.gitlab/ci/rails/shared.gitlab-ci.yml @@ -8,8 +8,7 @@ include: allow_failure: true - if: $CI_MERGE_REQUEST_IID when: manual - allow_failure: true - + allow_failure: true ####################### # rspec job base specs diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 92c9c2f336361e..51a0afad231ce2 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -275,7 +275,6 @@ semgrep-appsec-custom-rules: when: never - !reference [.semgrep-appsec-custom-rules:rules, rules] image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}returntocorp/semgrep:1.99.0 - script: - git clone $CUSTOM_RULES_REPOSITORY sast-custom-rules - | -- GitLab From de61628b579e4303a4ea3eff2bd78f778fabdadb Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 16:12:57 +0530 Subject: [PATCH 70/74] Fix linting error --- .gitlab/ci/rails/shared.gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/ci/rails/shared.gitlab-ci.yml b/.gitlab/ci/rails/shared.gitlab-ci.yml index 210e511f95bc16..b743b75f77d78a 100644 --- a/.gitlab/ci/rails/shared.gitlab-ci.yml +++ b/.gitlab/ci/rails/shared.gitlab-ci.yml @@ -8,7 +8,7 @@ include: allow_failure: true - if: $CI_MERGE_REQUEST_IID when: manual - allow_failure: true + allow_failure: true ####################### # rspec job base specs -- GitLab From 7ff2ca4178159844bd0a141dc3e2c20365f05ba8 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 16:14:35 +0530 Subject: [PATCH 71/74] Updated gem.gitlab-ci.yml --- .gitlab/ci/templates/gem.gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab/ci/templates/gem.gitlab-ci.yml b/.gitlab/ci/templates/gem.gitlab-ci.yml index 520bb9b21e3734..87aafacd2a6224 100644 --- a/.gitlab/ci/templates/gem.gitlab-ci.yml +++ b/.gitlab/ci/templates/gem.gitlab-ci.yml @@ -35,7 +35,8 @@ spec: gems $[[inputs.gem_name]]: extends: ".gems:rules:$[[inputs.gem_name]]" - + needs: + - clone-gitlab-repo trigger: include: "$[[inputs.gem_path_prefix]]$[[inputs.gem_name]]/.gitlab-ci.yml" strategy: depend -- GitLab From 73604d8a25dc79a99827a5d3796dff586daf8921 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 16:16:07 +0530 Subject: [PATCH 72/74] Fix remove commented lines --- .gitlab/ci/docs.gitlab-ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 48af9de00dfad2..229984f13dd5ed 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -2,7 +2,6 @@ extends: - .default-retry - .docs:rules:review-docs - # - .lint-base image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-alpine stage: review variables: @@ -101,8 +100,6 @@ docs hugo_build: - .lint-base - .repo-from-artifacts stage: lint - # needs: - # - clone-gitlab-repo variables: DOCS_BRANCH: "main" before_script: -- GitLab From 22686c511bd96b2632e0ee2004e93175c19d53d3 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 16:58:33 +0530 Subject: [PATCH 73/74] Removed .repo-from-artifacts from stage lint jobs --- .gitlab/ci/docs.gitlab-ci.yml | 1 - .gitlab/ci/static-analysis.gitlab-ci.yml | 6 ------ 2 files changed, 7 deletions(-) diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 229984f13dd5ed..112a9f4f1affb8 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -98,7 +98,6 @@ docs hugo_build: - .default-retry - .docs:rules:docs-all-lint - .lint-base - - .repo-from-artifacts stage: lint variables: DOCS_BRANCH: "main" diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 51a0afad231ce2..fa2f7dc0ee474b 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -25,7 +25,6 @@ static-analysis: optional: true - job: db:setup pg16 optional: true - - clone-gitlab-repo parallel: 2 variables: SETUP_DB: "true" @@ -56,7 +55,6 @@ generate-apollo-graphql-schema: entrypoint: [""] needs: - ['graphql-schema-dump'] - - clone-gitlab-repo variables: USE_BUNDLE_INSTALL: "false" script: @@ -146,7 +144,6 @@ haml-lint: needs: - job: cache:ruby-gems optional: true - - clone-gitlab-repo script: - bundle exec haml-lint --parallel artifacts: @@ -164,7 +161,6 @@ rubocop: needs: - job: detect-tests optional: true - - clone-gitlab-repo variables: RUBOCOP_TARGET_FILES: "tmp/rubocop_target_files.txt" script: @@ -362,7 +358,6 @@ templates-shellcheck: stage: lint needs: - setup-test-env - - clone-gitlab-repo script: - bundle exec scripts/lint_templates_bash.rb @@ -381,7 +376,6 @@ ping-appsec-for-sast-findings: BOT_USER_ID: 19650678 needs: - semgrep-appsec-custom-rules - - clone-gitlab-repo script: - apk update - apk add ruby -- GitLab From 6fef7074fb5c08974d51f1f064248c1471d267c0 Mon Sep 17 00:00:00 2001 From: pranshusharma Date: Thu, 18 Dec 2025 17:03:38 +0530 Subject: [PATCH 74/74] Updated comment for LINT STAGE job base specs --- .gitlab/ci/rails/shared.gitlab-ci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.gitlab/ci/rails/shared.gitlab-ci.yml b/.gitlab/ci/rails/shared.gitlab-ci.yml index b743b75f77d78a..a1f12c443ca89a 100644 --- a/.gitlab/ci/rails/shared.gitlab-ci.yml +++ b/.gitlab/ci/rails/shared.gitlab-ci.yml @@ -346,16 +346,17 @@ include: - .use-pg17 stage: test needs: ["setup-test-env"] -# rspec job base specs -###################### +# LINT STAGE job base specs +###################### .lint-base: extends: - .repo-from-artifacts - .default-retry stage: lint - +# rspec job base specs +###################### ############################ # rspec job parallel configs # Adjusting these parallel job counts has an impact on the -- GitLab