From d4e39f8fab6a7a0593d60ae844892861ed3ee765 Mon Sep 17 00:00:00 2001 From: Auto-quarantining bot Date: Mon, 8 Sep 2025 03:44:20 +0000 Subject: [PATCH] Quarantine a flaky test The `` Adding a Note when the user has permission creating Notes in reply to a discussion when the user has permission to create notes on the discussion when discussion is not on the noteable checks noteable and discussion noteable `` test matches one of the following conditions: 1. has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures is at or above 95 percentile, indicating unusually high failure count. 2. has ~"severity::1" label set, which means the number of reported failures [spiked and exceeded its daily threshold](https://gitlab.com/gitlab-org/ruby/gems/gitlab_quality-test_tooling/-/blob/c9bc10536b1f8d2d4a03c3e0b6099a40fe67ad26/lib/gitlab_quality/test_tooling/report/concerns/issue_reports.rb#L51). This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule the associated issue to improve the test - close the merge request in favor of another merge request to delete the test Please follow the [Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/testing/flaky-tests/#flaky-tests-management-process) to help us increase `master` stability. Please let us know your feedback in the [Engineering Productivity issue tracker](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues). Related to https://gitlab.com/gitlab-org/gitlab/-/issues/558896. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) in [CI](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/jobs/11272332041) using the `Keeps::QuarantineFlakyTests` keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- spec/requests/api/graphql/mutations/notes/create/note_spec.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spec/requests/api/graphql/mutations/notes/create/note_spec.rb b/spec/requests/api/graphql/mutations/notes/create/note_spec.rb index 2e4e50dbaf084c..1f222515ed21fd 100644 --- a/spec/requests/api/graphql/mutations/notes/create/note_spec.rb +++ b/spec/requests/api/graphql/mutations/notes/create/note_spec.rb @@ -62,7 +62,8 @@ def mutation_response let(:discussion) { create(:discussion_note, project: project).to_discussion } context 'when discussion is not on the noteable' do - it 'checks noteable and discussion noteable' do + it 'checks noteable and discussion noteable', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/558896' do expect(noteable.id).not_to eq(discussion.noteable_id) end -- GitLab