diff --git a/.rubocop_todo/api/description_success_response.yml b/.rubocop_todo/api/description_success_response.yml index acd0757dab0d116b4eaa4afb27c347411f6b0c06..c3c43bc805932345061f184988acd0575624d047 100644 --- a/.rubocop_todo/api/description_success_response.yml +++ b/.rubocop_todo/api/description_success_response.yml @@ -1,3 +1,4 @@ +--- API/DescriptionSuccessResponse: Details: grace period Exclude: diff --git a/.rubocop_todo/database/avoid_using_connection_execute.yml b/.rubocop_todo/database/avoid_using_connection_execute.yml index 59cc319eadfdabf68da7ed5182327dceb73156a7..a8a405fcea4272947dfb3ce79b23278a88c5548e 100644 --- a/.rubocop_todo/database/avoid_using_connection_execute.yml +++ b/.rubocop_todo/database/avoid_using_connection_execute.yml @@ -9,7 +9,6 @@ Database/AvoidUsingConnectionExecute: - 'app/models/merge_request/metrics.rb' - 'app/models/namespaces/descendants.rb' - 'app/models/postgresql/replication_slot.rb' - - 'app/models/project_group_link.rb' - 'app/models/trending_project.rb' - 'ee/app/models/concerns/geo/verification_state.rb' - 'ee/app/models/dora/daily_metrics.rb' diff --git a/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml index 8d01d13fe89d93b69eb8010a8b99d3a18cf318c6..73cf7667c3e8027133651fb441274f57effd6b7c 100644 --- a/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml +++ b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml @@ -42,7 +42,6 @@ Gitlab/AvoidGitlabInstanceChecks: - 'ee/app/models/ci/minutes/additional_pack.rb' - 'ee/app/models/ee/application_setting.rb' - 'ee/app/models/ee/member.rb' - - 'ee/app/models/ee/project_statistics.rb' - 'ee/app/models/ee/user.rb' - 'ee/app/policies/ee/global_policy.rb' - 'ee/app/policies/ee/group_policy.rb' @@ -50,7 +49,6 @@ Gitlab/AvoidGitlabInstanceChecks: - 'ee/app/serializers/ee/issue_sidebar_basic_entity.rb' - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' - 'ee/app/services/gitlab_subscriptions/activate_service.rb' - - 'ee/app/services/gitlab_subscriptions/add_on_purchases/create_service.rb' - 'ee/app/workers/ee/ci/build_finished_worker.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' - 'ee/config/initializers/gitlab_suggested_reviewers_secret.rb' diff --git a/.rubocop_todo/gitlab/feature_flag_without_actor.yml b/.rubocop_todo/gitlab/feature_flag_without_actor.yml index 35ed8033b0fb09f93fd7b3041893073fd97b26c0..22472d1e445923874a3922d9d2ddd23317695eda 100644 --- a/.rubocop_todo/gitlab/feature_flag_without_actor.yml +++ b/.rubocop_todo/gitlab/feature_flag_without_actor.yml @@ -7,7 +7,6 @@ Gitlab/FeatureFlagWithoutActor: - 'app/controllers/explore/projects_controller.rb' - 'app/controllers/projects/settings/integrations_controller.rb' - 'app/controllers/repositories/git_http_controller.rb' - - 'app/finders/abuse_reports_finder.rb' - 'app/graphql/types/namespace_type.rb' - 'app/graphql/types/project_type.rb' - 'app/helpers/auto_devops_helper.rb' @@ -28,7 +27,6 @@ Gitlab/FeatureFlagWithoutActor: - 'app/models/project_setting.rb' - 'app/models/repository.rb' - 'app/models/user.rb' - - 'app/serializers/admin/abuse_report_entity.rb' - 'app/serializers/web_ide_terminal_entity.rb' - 'app/services/ci/register_job_service.rb' - 'app/services/concerns/measurable.rb' @@ -50,7 +48,6 @@ Gitlab/FeatureFlagWithoutActor: - 'app/workers/container_registry/cleanup_worker.rb' - 'app/workers/container_registry/record_data_repair_detail_worker.rb' - 'app/workers/database/batched_background_migration/execution_worker.rb' - - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/database/monitor_locked_tables_worker.rb' - 'app/workers/loose_foreign_keys/cleanup_worker.rb' - 'app/workers/packages/debian/cleanup_dangling_package_files_worker.rb' diff --git a/.rubocop_todo/gitlab/no_code_coverage_comment.yml b/.rubocop_todo/gitlab/no_code_coverage_comment.yml index 60a6e80635485ea6754e3139c40aaa1e19666bb6..168884603c80744c9a66702bdce1536d22eeee0b 100644 --- a/.rubocop_todo/gitlab/no_code_coverage_comment.yml +++ b/.rubocop_todo/gitlab/no_code_coverage_comment.yml @@ -2,7 +2,6 @@ Gitlab/NoCodeCoverageComment: Exclude: - 'app/services/ci/job_artifacts/destroy_batch_service.rb' - - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'ee/app/models/concerns/geo/replicable_model.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'lib/gitlab/cleanup/personal_access_tokens.rb' diff --git a/.rubocop_todo/gitlab/saas_feature_available_outside_ee.yml b/.rubocop_todo/gitlab/saas_feature_available_outside_ee.yml index 6508b3232eb10efff3c2c845f1775cfd8974da22..feda6ede113a2e669ffbfe07ca077303a22a5b7c 100644 --- a/.rubocop_todo/gitlab/saas_feature_available_outside_ee.yml +++ b/.rubocop_todo/gitlab/saas_feature_available_outside_ee.yml @@ -1,4 +1,3 @@ --- Gitlab/SaasFeatureAvailableOutsideEe: Details: grace period - Exclude: diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 59577965274cbdf97cf8314f82d9a6132c47ada5..4764b84655c94c83f4c86a0c0b159cb80060df96 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -196,7 +196,6 @@ Gitlab/StrongMemoizeAttr: - 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb' - 'app/workers/container_registry/delete_container_repository_worker.rb' - 'app/workers/database/batched_background_migration/execution_worker.rb' - - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/error_tracking_issue_link_worker.rb' - 'app/workers/merge_request_cleanup_refs_worker.rb' - 'app/workers/packages/cleanup/execute_policy_worker.rb' diff --git a/.rubocop_todo/layout/class_structure.yml b/.rubocop_todo/layout/class_structure.yml index 4619a7749eeae03c881605e54e303e7688bc39c1..00d4a26a21f4e4e18032adc44768ac0207e5f652 100644 --- a/.rubocop_todo/layout/class_structure.yml +++ b/.rubocop_todo/layout/class_structure.yml @@ -63,7 +63,6 @@ Layout/ClassStructure: - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/mattermost.rb' - - 'app/models/integrations/prometheus.rb' - 'app/models/integrations/zentao.rb' - 'app/models/issue.rb' - 'app/models/jira_connect/public_key.rb' @@ -244,7 +243,6 @@ Layout/ClassStructure: - 'lib/backup/database_configuration.rb' - 'lib/banzai/filter/asset_proxy_filter.rb' - 'lib/banzai/filter/emoji_filter.rb' - - 'lib/banzai/filter/references/abstract_reference_filter.rb' - 'lib/banzai/filter/references/commit_range_reference_filter.rb' - 'lib/bitbucket/representation/base.rb' - 'lib/bitbucket_server/representation/base.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 2fa26b847c639778204cd1dc8d0a086fa9a18fca..78ba91c43a817341039658954205019bdb729590 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -189,9 +189,9 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/saml_providers_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' + - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/banzai/filter/issuable_reference_expansion_filter_spec.rb' - 'ee/spec/lib/ee/banzai/issuable_extractor_spec.rb' - - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_design_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/group_member_builder_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 327912afadbda25d78f92f8e81476a84a948b822..affb490603ec8642179be36a8a85f9a1ac6ca6a3 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -27,7 +27,6 @@ Layout/LineEndStringConcatenationIndentation: - 'app/services/uploads/destroy_service.rb' - 'app/services/users/deactivate_service.rb' - 'app/services/users/email_verification/validate_token_service.rb' - - 'app/workers/clusters/applications/deactivate_integration_worker.rb' - 'app/workers/integrations/irker_worker.rb' - 'app/workers/issuable/related_links_create_worker.rb' - 'app/workers/run_pipeline_schedule_worker.rb' @@ -167,7 +166,6 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/spec/controllers/projects/deploy_keys_controller_spec.rb' - 'ee/spec/features/admin/admin_emails_spec.rb' - 'ee/spec/features/admin/licenses/admin_adds_license_spec.rb' - - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb' - 'ee/spec/features/groups/contribution_analytics_spec.rb' - 'ee/spec/features/groups/group_overview_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index a7bc856b68f1d982c9e33da4dbc8fffbf6587b37..53793fa4353a8d946cf4a4c4f9267a1a4ddf06d0 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -111,7 +111,6 @@ Layout/LineLength: - 'app/models/integrations/datadog.rb' - 'app/models/integrations/drone_ci.rb' - 'app/models/integrations/jenkins.rb' - - 'app/models/integrations/prometheus.rb' - 'app/models/integrations/zentao.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' @@ -336,7 +335,6 @@ Layout/LineLength: - 'app/workers/concerns/limited_capacity/worker.rb' - 'app/workers/concerns/project_import_options.rb' - 'app/workers/concerns/worker_attributes.rb' - - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/error_tracking_issue_link_worker.rb' - 'app/workers/gitlab/import/stuck_import_job.rb' - 'app/workers/gitlab/jira_import/stage/import_attachments_worker.rb' @@ -855,13 +853,18 @@ Layout/LineLength: - 'ee/spec/controllers/admin/projects_controller_spec.rb' - 'ee/spec/controllers/admin/users_controller_spec.rb' - 'ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb' + - 'ee/spec/controllers/ee/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/analytics/cycle_analytics/summary_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/issues_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/merge_requests_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/mirrors_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/pipelines_controller_spec.rb' - 'ee/spec/controllers/ee/projects_controller_spec.rb' - 'ee/spec/controllers/ee/uploads_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/tasks_by_type_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' - - 'ee/spec/controllers/ee/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/groups/groups_controller_spec.rb' - 'ee/spec/controllers/groups/insights_controller_spec.rb' - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb' @@ -870,14 +873,9 @@ Layout/LineLength: - 'ee/spec/controllers/oauth/applications_controller_spec.rb' - 'ee/spec/controllers/oauth/geo_auth_controller_spec.rb' - 'ee/spec/controllers/operations_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/issues_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/merge_requests_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/mirrors_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/pipelines_controller_spec.rb' - 'ee/spec/controllers/projects/protected_environments_controller_spec.rb' - 'ee/spec/controllers/projects/push_rules_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerabilities_controller_spec.rb' @@ -972,6 +970,9 @@ Layout/LineLength: - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' + - 'ee/spec/finders/ee/snippets_finder_spec.rb' + - 'ee/spec/finders/ee/template_finder_spec.rb' + - 'ee/spec/finders/ee/users_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/group_projects_finder_spec.rb' - 'ee/spec/finders/incident_management/escalation_policies_finder_spec.rb' @@ -988,20 +989,18 @@ Layout/LineLength: - 'ee/spec/finders/notes_finder_spec.rb' - 'ee/spec/finders/productivity_analytics_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' - - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - - 'ee/spec/finders/ee/snippets_finder_spec.rb' - - 'ee/spec/finders/ee/template_finder_spec.rb' - - 'ee/spec/finders/ee/users_finder_spec.rb' - 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/epic.rb' - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' - 'ee/spec/frontend/fixtures/project_quality_summary.rb' + - 'ee/spec/graphql/ee/mutations/issues/create_spec.rb' - 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/project_issues_resolver_spec.rb' - 'ee/spec/graphql/ee/types/board_type_spec.rb' + - 'ee/spec/graphql/ee/types/issue_type_spec.rb' - 'ee/spec/graphql/ee/types/merge_request_type_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - 'ee/spec/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' @@ -1018,7 +1017,6 @@ Layout/LineLength: - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb' - 'ee/spec/graphql/mutations/instance_security_dashboard/add_project_spec.rb' - 'ee/spec/graphql/mutations/instance_security_dashboard/remove_project_spec.rb' - - 'ee/spec/graphql/ee/mutations/issues/create_spec.rb' - 'ee/spec/graphql/mutations/issues/promote_to_epic_spec.rb' - 'ee/spec/graphql/mutations/issues/set_epic_spec.rb' - 'ee/spec/graphql/mutations/issues/set_escalation_policy_spec.rb' @@ -1055,7 +1053,6 @@ Layout/LineLength: - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' - 'ee/spec/graphql/types/dast_site_profile_type_spec.rb' - 'ee/spec/graphql/types/epic_sort_enum_spec.rb' - - 'ee/spec/graphql/ee/types/issue_type_spec.rb' - 'ee/spec/graphql/types/project_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_details/file_location_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_report_type_enum_spec.rb' @@ -1063,26 +1060,26 @@ Layout/LineLength: - 'ee/spec/graphql/types/vulnerability_type_spec.rb' - 'ee/spec/helpers/admin/emails_helper_spec.rb' - 'ee/spec/helpers/analytics/code_review_helper_spec.rb' - - 'ee/spec/helpers/ee/application_helper_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/compliance_management/compliance_framework/group_settings_helper_spec.rb' + - 'ee/spec/helpers/ee/application_helper_spec.rb' - 'ee/spec/helpers/ee/branches_helper_spec.rb' - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/integrations_helper_spec.rb' + - 'ee/spec/helpers/ee/notes_helper_spec.rb' - 'ee/spec/helpers/ee/operations_helper_spec.rb' - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' - 'ee/spec/helpers/groups/security_features_helper_spec.rb' - - 'ee/spec/helpers/ee/notes_helper_spec.rb' - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb' - 'ee/spec/helpers/push_rules_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' @@ -1093,9 +1090,7 @@ Layout/LineLength: - 'ee/spec/lib/analytics/productivity_analytics_request_params_spec.rb' - 'ee/spec/lib/audit/details_spec.rb' - 'ee/spec/lib/banzai/filter/jira_private_image_link_filter_spec.rb' - - 'ee/spec/lib/ee/banzai/filter/references/epic_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/iterations_cadence_reference_filter_spec.rb' - - 'ee/spec/lib/ee/banzai/filter/references/label_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb' @@ -1105,6 +1100,8 @@ Layout/LineLength: - 'ee/spec/lib/ee/api/entities/deployment_extended_spec.rb' - 'ee/spec/lib/ee/api/entities/vulnerability_export_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' + - 'ee/spec/lib/ee/banzai/filter/references/epic_reference_filter_spec.rb' + - 'ee/spec/lib/ee/banzai/filter/references/label_reference_filter_spec.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' @@ -1505,7 +1502,6 @@ Layout/LineLength: - 'ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/data_loader_service_spec.rb' - - 'ee/spec/services/ee/analytics/cycle_analytics/stages/list_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/bulk_delete_service_spec.rb' - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/bulk_find_or_create_service_spec.rb' @@ -1553,6 +1549,7 @@ Layout/LineLength: - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb' - 'ee/spec/services/ee/allowed_email_domains/update_service_spec.rb' + - 'ee/spec/services/ee/analytics/cycle_analytics/stages/list_service_spec.rb' - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - 'ee/spec/services/ee/boards/lists/max_limits_spec.rb' @@ -1853,7 +1850,6 @@ Layout/LineLength: - 'lib/backup.rb' - 'lib/backup/gitaly_backup.rb' - 'lib/banzai/filter/references/external_issue_reference_filter.rb' - - 'lib/banzai/filter/references/milestone_reference_filter.rb' - 'lib/banzai/filter/references/reference_filter.rb' - 'lib/banzai/filter/references/vulnerability_reference_filter.rb' - 'lib/banzai/filter/spaced_link_filter.rb' @@ -2165,7 +2161,6 @@ Layout/LineLength: - 'qa/qa/ee/page/group/settings/saml_sso.rb' - 'qa/qa/ee/page/merge_request/show.rb' - 'qa/qa/ee/page/project/job/show.rb' - - 'qa/qa/ee/page/project/secure/security_dashboard.rb' - 'qa/qa/ee/page/project/secure/show.rb' - 'qa/qa/flow/sign_up.rb' - 'qa/qa/git/repository.rb' @@ -2173,7 +2168,6 @@ Layout/LineLength: - 'qa/qa/page/dashboard/snippet/index.rb' - 'qa/qa/page/group/settings/package_registries.rb' - 'qa/qa/page/merge_request/new.rb' - - 'qa/qa/page/project/import/repo_by_url.rb' - 'qa/qa/page/project/registry/show.rb' - 'qa/qa/page/project/settings/protected_branches.rb' - 'qa/qa/resource/file.rb' @@ -3063,7 +3057,6 @@ Layout/LineLength: - 'spec/lib/gitlab/metrics/web_transaction_spec.rb' - 'spec/lib/gitlab/middleware/go_spec.rb' - 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb' - - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb' - 'spec/lib/gitlab/middleware/multipart_spec.rb' - 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb' - 'spec/lib/gitlab/middleware/speedscope_spec.rb' @@ -3146,7 +3139,6 @@ Layout/LineLength: - 'spec/lib/gitlab/workhorse_spec.rb' - 'spec/lib/gitlab/x509/certificate_spec.rb' - 'spec/lib/gitlab/x509/signature_spec.rb' - - 'spec/lib/gitlab_spec.rb' - 'spec/lib/google_api/cloud_platform/client_spec.rb' - 'spec/lib/kramdown/kramdown_spec.rb' - 'spec/lib/kramdown/parser/atlassian_document_format_spec.rb' @@ -3252,7 +3244,6 @@ Layout/LineLength: - 'spec/models/integrations/drone_ci_spec.rb' - 'spec/models/integrations/emails_on_push_spec.rb' - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/integrations/prometheus_spec.rb' - 'spec/models/issue_spec.rb' - 'spec/models/jira_import_state_spec.rb' - 'spec/models/key_spec.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index eac4906c811311112dac66411f28c174610a142c..1a5b7bdd3f8bd6aaccfddb240b305a6ac2bc1938 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -168,7 +168,6 @@ Lint/UnusedBlockArgument: - 'lib/api/helpers/container_registry_helpers.rb' - 'lib/api/helpers/snippets_helpers.rb' - 'lib/atlassian/jira_connect/serializers/repository_entity.rb' - - 'lib/banzai/filter/references/abstract_reference_filter.rb' - 'lib/banzai/filter/spaced_link_filter.rb' - 'lib/banzai/issuable_extractor.rb' - 'lib/container_registry/client.rb' @@ -247,9 +246,7 @@ Lint/UnusedBlockArgument: - 'spec/factories/ci/pipelines.rb' - 'spec/factories/ci/processable.rb' - 'spec/factories/ci/runners.rb' - - 'spec/factories/clusters/clusters.rb' - 'spec/factories/clusters/platforms/kubernetes.rb' - - 'spec/factories/clusters/providers/gcp.rb' - 'spec/factories/commit_statuses.rb' - 'spec/factories/container_repositories.rb' - 'spec/factories/deployments.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index 78f0f48aeff2b526a0c2d287ba74e90f0522b2ae..a86dece8116c9f742e6f588e35af0474a8ed229c 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -100,7 +100,6 @@ Lint/UnusedMethodArgument: - 'app/models/external_issue.rb' - 'app/models/group.rb' - 'app/models/integrations/buildkite.rb' - - 'app/models/integrations/prometheus.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' - 'app/models/label_note.rb' @@ -434,7 +433,6 @@ Lint/UnusedMethodArgument: - 'qa/qa/service/kubernetes_cluster.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb' - - 'qa/qa/support/wait_for_requests.rb' - 'qa/spec/resource/base_spec.rb' - 'rubocop/cop/gitlab/finder_with_find_by.rb' - 'rubocop/cop/migration/safer_boolean_column.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index a30758d621cc9324baa2ba7ac572d4d63a1f2013..c6d8228195b6e0341f7b6b237193c7dfbb6c6438 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -91,7 +91,6 @@ Naming/HeredocDelimiterNaming: - 'spec/services/ci/create_pipeline_service/parameter_content_spec.rb' - 'spec/services/ci/create_pipeline_service/rules_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - - 'spec/services/ci/create_web_ide_terminal_service_spec.rb' - 'spec/services/ci/parse_dotenv_artifact_service_spec.rb' - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - 'spec/services/cloud_seed/google_cloud/generate_pipeline_service_spec.rb' diff --git a/.rubocop_todo/performance/string_identifier_argument.yml b/.rubocop_todo/performance/string_identifier_argument.yml index d067d03315a966bc65495a84bc0a35f374a22e03..9aed8f73b2e449dd108111b511cca00fd4802b60 100644 --- a/.rubocop_todo/performance/string_identifier_argument.yml +++ b/.rubocop_todo/performance/string_identifier_argument.yml @@ -189,7 +189,6 @@ Performance/StringIdentifierArgument: - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' - 'spec/support/shared_examples/database_health_status_indicators/prometheus_alert_based_shared_examples.rb' - 'spec/support/shared_examples/graphql/container_expiration_policy_shared_examples.rb' - - 'spec/support/shared_examples/lib/banzai/filters/reference_filter_shared_examples.rb' - 'spec/support/shared_examples/models/active_record_enum_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/cascading_namespace_setting_shared_examples.rb' diff --git a/.rubocop_todo/rails/date.yml b/.rubocop_todo/rails/date.yml index 88a021a136b49340e56fb0d3f10afdc1e9e7c882..a00d9c7cfaeb5caf7adcca6f85d7dc72d509feb0 100644 --- a/.rubocop_todo/rails/date.yml +++ b/.rubocop_todo/rails/date.yml @@ -5,7 +5,6 @@ Rails/Date: - 'app/controllers/users_controller.rb' - 'app/finders/issues_finder.rb' - 'app/helpers/emails_helper.rb' - - 'app/mailers/emails/members.rb' - 'app/mailers/emails/shared.rb' - 'app/models/ci/build.rb' - 'app/models/concerns/ignorable_columns.rb' @@ -147,7 +146,6 @@ Rails/Date: - 'spec/lib/gitlab/internal_events_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/total_count_metric_spec.rb' - 'spec/lib/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' - - 'spec/mailers/notify_spec.rb' - 'spec/models/ci/catalog/resources/version_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/milestoneish_spec.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 33c38ad5882d63f995ced3865eec3c8acb419488..bd7bd9cfec5e00d902674da252b3c52cefa98706 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -24,8 +24,8 @@ Rails/Pluck: - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'ee/spec/controllers/ee/autocomplete_controller_spec.rb' - 'ee/spec/controllers/countries_controller_spec.rb' + - 'ee/spec/controllers/ee/autocomplete_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' diff --git a/.rubocop_todo/rspec/be_eq.yml b/.rubocop_todo/rspec/be_eq.yml index dc1ea0363f3b9a4d7a9bfb6516762583ff66c145..42f7cb4cfa327229b71bbb4d4a8d95aee19a86c8 100644 --- a/.rubocop_todo/rspec/be_eq.yml +++ b/.rubocop_todo/rspec/be_eq.yml @@ -7,20 +7,20 @@ RSpec/BeEq: - 'ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb' - 'ee/spec/controllers/concerns/routable_actions_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/blob_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/pages_controller_spec.rb' - - 'ee/spec/controllers/ee/registrations_controller_spec.rb' - - 'ee/spec/controllers/groups/contribution_analytics_controller_spec.rb' - - 'ee/spec/controllers/groups/saml_group_links_controller_spec.rb' - 'ee/spec/controllers/ee/ldap/omniauth_callbacks_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/blob_controller_spec.rb' - 'ee/spec/controllers/ee/projects/imports_controller_spec.rb' - 'ee/spec/controllers/ee/projects/issues_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/merge_requests_controller_spec.rb' - 'ee/spec/controllers/ee/projects/mirrors_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/pages_controller_spec.rb' - 'ee/spec/controllers/ee/projects/settings/operations_controller_spec.rb' - 'ee/spec/controllers/ee/projects/settings/repository_controller_spec.rb' - 'ee/spec/controllers/ee/projects_controller_spec.rb' + - 'ee/spec/controllers/ee/registrations_controller_spec.rb' + - 'ee/spec/controllers/groups/contribution_analytics_controller_spec.rb' + - 'ee/spec/controllers/groups/saml_group_links_controller_spec.rb' - 'ee/spec/features/admin/admin_emails_spec.rb' - 'ee/spec/features/admin/users/users_spec.rb' - 'ee/spec/features/groups/settings/reporting_spec.rb' @@ -56,15 +56,15 @@ RSpec/BeEq: - 'ee/spec/helpers/ee/graph_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' + - 'ee/spec/helpers/ee/kerberos_helper_spec.rb' - 'ee/spec/helpers/ee/merge_requests_helper_spec.rb' + - 'ee/spec/helpers/ee/preferences_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/ee/protected_branches_helper_spec.rb' - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' - - 'ee/spec/helpers/ee/kerberos_helper_spec.rb' - 'ee/spec/helpers/manual_quarterly_co_term_banner_helper_spec.rb' - - 'ee/spec/helpers/ee/preferences_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/users_helper_spec.rb' @@ -93,7 +93,6 @@ RSpec/BeEq: - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/command_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/abilities_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/project_config_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/yaml_processor/result_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/wiki_repo_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/personal_access_tokens/expiry_date_calculator_spec.rb' @@ -375,9 +374,11 @@ RSpec/BeEq: - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - 'ee/spec/services/ee/members/destroy_service_spec.rb' - 'ee/spec/services/ee/members/groups/creator_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/merge_service_spec.rb' - 'ee/spec/services/ee/namespace_settings/assign_attributes_service_spec.rb' - 'ee/spec/services/ee/users/build_service_spec.rb' - 'ee/spec/services/ee/work_items/import_csv_service_spec.rb' + - 'ee/spec/services/ee/work_items/update_service_spec.rb' - 'ee/spec/services/epic_issues/destroy_service_spec.rb' - 'ee/spec/services/geo/node_create_service_spec.rb' - 'ee/spec/services/geo/node_update_service_spec.rb' @@ -401,7 +402,6 @@ RSpec/BeEq: - 'ee/spec/services/iterations/cadences/create_service_spec.rb' - 'ee/spec/services/llm/internal/completion_service_spec.rb' - 'ee/spec/services/merge_requests/create_from_vulnerability_data_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/merge_service_spec.rb' - 'ee/spec/services/merge_requests/mergeability/check_approved_service_spec.rb' - 'ee/spec/services/merge_requests/mergeability/check_blocked_by_other_mrs_service_spec.rb' - 'ee/spec/services/merge_requests/mergeability/check_external_status_checks_passed_service_spec.rb' @@ -442,7 +442,6 @@ RSpec/BeEq: - 'ee/spec/services/vulnerabilities/security_finding/create_merge_request_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/work_items/callbacks/weight_spec.rb' - - 'ee/spec/services/ee/work_items/update_service_spec.rb' - 'ee/spec/support/analytics/cycle_analytics/flow_metrics_examples.rb' - 'ee/spec/support/shared_examples/lib/code_suggestions/task_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/elastic/limited_indexing_shared_examples.rb' @@ -917,7 +916,6 @@ RSpec/BeEq: - 'spec/lib/gitlab/web_hooks/recursion_detection_spec.rb' - 'spec/lib/gitlab/xml_converter_spec.rb' - 'spec/lib/gitlab/zentao/client_spec.rb' - - 'spec/lib/gitlab_spec.rb' - 'spec/lib/import/bulk_imports/common/transformers/source_user_member_attributes_transformer_spec.rb' - 'spec/lib/import/bulk_imports/ephemeral_data_spec.rb' - 'spec/lib/import/bulk_imports/source_users_mapper_spec.rb' @@ -1037,7 +1035,6 @@ RSpec/BeEq: - 'spec/models/integrations/jenkins_spec.rb' - 'spec/models/integrations/jira_cloud_app_spec.rb' - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/integrations/prometheus_spec.rb' - 'spec/models/integrations/zentao_tracker_data_spec.rb' - 'spec/models/issue_spec.rb' - 'spec/models/jira_connect_installation_spec.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index 97e5bc936a6b7d4745d30eb25cfacbaca094f00c..73e347195ce476a2f62a9cf48596dbb5e073c3b5 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -6,8 +6,17 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/controllers/ee/groups/settings/ci_cd_controller_spec.rb' - 'ee/spec/controllers/ee/groups/usage_quotas_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/ee/projects/autocomplete_sources_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/environments_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/merge_requests_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/pipelines_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/repositories_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/settings/ci_cd_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/settings/operations_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/settings/repository_controller_spec.rb' + - 'ee/spec/controllers/ee/projects_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/coverage_reports_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/repository_analytics_controller_spec.rb' @@ -24,31 +33,22 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/controllers/groups/seat_usage_controller_spec.rb' - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' - 'ee/spec/controllers/groups/todos_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/projects/analytics/issues_analytics_controller_spec.rb' - 'ee/spec/controllers/projects/analytics/merge_request_analytics_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/environments_controller_spec.rb' - 'ee/spec/controllers/projects/incident_management/escalation_policies_controller_spec.rb' - 'ee/spec/controllers/projects/incident_management/oncall_schedules_controller_spec.rb' - 'ee/spec/controllers/projects/insights_controller_spec.rb' - 'ee/spec/controllers/projects/issue_links_controller_spec.rb' - 'ee/spec/controllers/projects/iterations_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/merge_requests_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/pipelines_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/repositories_controller_spec.rb' - 'ee/spec/controllers/projects/requirements_management/requirements_controller_spec.rb' - 'ee/spec/controllers/projects/security/dashboard_controller_spec.rb' - 'ee/spec/controllers/projects/security/scanned_resources_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerabilities/notes_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerabilities_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerability_report_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/settings/ci_cd_controller_spec.rb' - 'ee/spec/controllers/projects/settings/integrations_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/settings/operations_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/settings/repository_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - - 'ee/spec/controllers/ee/projects_controller_spec.rb' - 'ee/spec/controllers/security/projects_controller_spec.rb' - 'ee/spec/features/admin/admin_sends_notification_spec.rb' - 'ee/spec/features/analytics/code_analytics_spec.rb' @@ -132,6 +132,7 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/finders/ee/ci/daily_build_group_report_results_finder_spec.rb' - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' + - 'ee/spec/finders/ee/snippets_finder_spec.rb' - 'ee/spec/finders/ee/work_items/work_items_finder_spec.rb' - 'ee/spec/finders/epics/cross_hierarchy_ancestors_finder_spec.rb' - 'ee/spec/finders/epics/cross_hierarchy_children_finder_spec.rb' @@ -141,14 +142,17 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/finders/incident_management/oncall_schedules_finder_spec.rb' - 'ee/spec/finders/iterations/cadences_finder_spec.rb' - 'ee/spec/finders/iterations_finder_spec.rb' - - 'ee/spec/finders/ee/snippets_finder_spec.rb' - 'ee/spec/frontend/fixtures/analytics/charts.rb' - 'ee/spec/frontend/fixtures/analytics/contributions_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' - 'ee/spec/graphql/ee/mutations/boards/issues/issue_move_list_spec.rb' + - 'ee/spec/graphql/ee/mutations/issues/update_spec.rb' + - 'ee/spec/graphql/ee/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/project_issues_resolver_spec.rb' + - 'ee/spec/graphql/ee/types/ci/pipeline_type_spec.rb' - 'ee/spec/graphql/ee/types/group_type_spec.rb' + - 'ee/spec/graphql/ee/types/issue_type_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/destroy_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' @@ -181,7 +185,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/graphql/mutations/instance_security_dashboard/add_project_spec.rb' - 'ee/spec/graphql/mutations/issues/promote_to_epic_spec.rb' - 'ee/spec/graphql/mutations/issues/set_epic_spec.rb' - - 'ee/spec/graphql/ee/mutations/issues/update_spec.rb' - 'ee/spec/graphql/mutations/projects/set_compliance_framework_spec.rb' - 'ee/spec/graphql/mutations/projects/set_locked_spec.rb' - 'ee/spec/graphql/mutations/requirements_management/create_requirement_spec.rb' @@ -195,7 +198,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/graphql/resolvers/boards/epic_boards_resolvers_spec.rb' - 'ee/spec/graphql/resolvers/boards/epic_list_resolver_spec.rb' - 'ee/spec/graphql/resolvers/boards/epic_lists_resolvers_spec.rb' - - 'ee/spec/graphql/ee/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/resolvers/dast_site_validation_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epic_ancestors_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epic_issues_resolver_spec.rb' @@ -220,11 +222,9 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - 'ee/spec/graphql/types/asset_type_spec.rb' - 'ee/spec/graphql/types/boards/board_epic_type_spec.rb' - - 'ee/spec/graphql/ee/types/ci/pipeline_type_spec.rb' - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' - 'ee/spec/graphql/types/dast_site_validation_type_spec.rb' - 'ee/spec/graphql/types/instance_security_dashboard_type_spec.rb' - - 'ee/spec/graphql/ee/types/issue_type_spec.rb' - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' - 'ee/spec/graphql/types/project_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_evidence_source_type_spec.rb' @@ -240,9 +240,9 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/merge_requests_helper_spec.rb' - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/tree_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' @@ -892,7 +892,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/timeboxes_helper_spec.rb' - 'spec/helpers/tree_helper_spec.rb' - - 'spec/helpers/users/group_callouts_helper_spec.rb' - 'spec/helpers/web_hooks/web_hooks_helper_spec.rb' - 'spec/lib/api/entities/release_spec.rb' - 'spec/lib/api/helpers/packages_helpers_spec.rb' @@ -972,7 +971,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/requests/api/bulk_imports_spec.rb' - 'spec/requests/api/ci/pipeline_schedules_spec.rb' - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' - - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - 'spec/requests/api/commits_spec.rb' - 'spec/requests/api/container_repositories_spec.rb' - 'spec/requests/api/deploy_keys_spec.rb' diff --git a/.rubocop_todo/rspec/contain_exactly.yml b/.rubocop_todo/rspec/contain_exactly.yml index f66be180b4835f9420190229a1840f798bf19e76..e1b8b14627fbcd25e2c843b4e2827d82eb2c0a18 100644 --- a/.rubocop_todo/rspec/contain_exactly.yml +++ b/.rubocop_todo/rspec/contain_exactly.yml @@ -4,6 +4,7 @@ RSpec/ContainExactly: Exclude: - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/finders/billed_users_finder_spec.rb' + - 'ee/spec/finders/ee/users_finder_spec.rb' - 'ee/spec/finders/ee/work_items/work_items_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/incident_management/escalation_rules_finder_spec.rb' @@ -11,7 +12,6 @@ RSpec/ContainExactly: - 'ee/spec/finders/licenses_finder_spec.rb' - 'ee/spec/finders/security/project_security_exclusions_finder_spec.rb' - 'ee/spec/finders/security/scan_result_policies/findings_finder_spec.rb' - - 'ee/spec/finders/ee/users_finder_spec.rb' - 'ee/spec/finders/work_items/widgets/filters/requirement_legacy_spec.rb' - 'ee/spec/graphql/resolvers/iterations_resolver_spec.rb' - 'ee/spec/graphql/types/ai/message_role_enum_spec.rb' @@ -34,7 +34,6 @@ RSpec/ContainExactly: - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - 'ee/spec/helpers/projects/learn_gitlab_helper_spec.rb' - 'ee/spec/lib/ee/api/entities/issue_spec.rb' - - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/create_cross_database_associations_spec.rb' - 'ee/spec/lib/gitlab/code_owners/file_spec.rb' - 'ee/spec/models/approval_project_rule_spec.rb' @@ -118,7 +117,6 @@ RSpec/ContainExactly: - 'spec/helpers/releases_helper_spec.rb' - 'spec/keeps/helpers/milestones_spec.rb' - 'spec/lib/atlassian/jira_connect/serializers/deployment_entity_spec.rb' - - 'spec/lib/gitlab/application_context_spec.rb' - 'spec/lib/gitlab/background_migration/redis/backfill_project_pipeline_status_ttl_spec.rb' - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb' - 'spec/lib/gitlab/ci/variables/builder/group_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index e92215769067a2d622325375626c0de029c47b35..b15ba88f5ec4bc49c87825d2c8358fc49ae3c7b8 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -8,10 +8,18 @@ RSpec/ContextWording: - 'ee/spec/controllers/admin/users_controller_spec.rb' - 'ee/spec/controllers/ee/autocomplete_controller_spec.rb' - 'ee/spec/controllers/ee/dashboard_controller_spec.rb' + - 'ee/spec/controllers/ee/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/ee/groups/variables_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' + - 'ee/spec/controllers/ee/ldap/omniauth_callbacks_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/imports_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/issues_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/merge_requests/creations_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/merge_requests_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/mirrors_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/pipelines_controller_spec.rb' - 'ee/spec/controllers/ee/projects/settings/operations_controller_spec.rb' - 'ee/spec/controllers/ee/projects/settings/repository_controller_spec.rb' - 'ee/spec/controllers/ee/projects_controller_spec.rb' @@ -24,7 +32,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' - 'ee/spec/controllers/groups/epics/notes_controller_spec.rb' - 'ee/spec/controllers/groups/epics_controller_spec.rb' - - 'ee/spec/controllers/ee/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/groups/groups_controller_spec.rb' - 'ee/spec/controllers/groups/hooks_controller_spec.rb' - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb' @@ -32,21 +39,14 @@ RSpec/ContextWording: - 'ee/spec/controllers/groups/saml_providers_controller_spec.rb' - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' - 'ee/spec/controllers/groups/sso_controller_spec.rb' - - 'ee/spec/controllers/ee/ldap/omniauth_callbacks_controller_spec.rb' - 'ee/spec/controllers/oauth/applications_controller_spec.rb' - 'ee/spec/controllers/oauth/geo_auth_controller_spec.rb' - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/imports_controller_spec.rb' - 'ee/spec/controllers/projects/incident_management/escalation_policies_controller_spec.rb' - 'ee/spec/controllers/projects/incident_management/oncall_schedules_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/issues_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/merge_requests/creations_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/merge_requests_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/mirrors_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/pipelines_controller_spec.rb' - 'ee/spec/controllers/projects/push_rules_controller_spec.rb' - 'ee/spec/controllers/projects/requirements_management/requirements_controller_spec.rb' - 'ee/spec/controllers/projects/settings/integrations_controller_spec.rb' @@ -157,6 +157,8 @@ RSpec/ContextWording: - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' + - 'ee/spec/finders/ee/snippets_finder_spec.rb' + - 'ee/spec/finders/ee/template_finder_spec.rb' - 'ee/spec/finders/ee/user_recent_events_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/geo_node_finder_spec.rb' @@ -174,13 +176,15 @@ RSpec/ContextWording: - 'ee/spec/finders/scim_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - - 'ee/spec/finders/ee/snippets_finder_spec.rb' - - 'ee/spec/finders/ee/template_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' - 'ee/spec/frontend/fixtures/search.rb' + - 'ee/spec/graphql/ee/mutations/issues/create_spec.rb' + - 'ee/spec/graphql/ee/mutations/issues/update_spec.rb' - 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb' + - 'ee/spec/graphql/ee/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' + - 'ee/spec/graphql/ee/types/issue_type_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/headers/create_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' @@ -200,8 +204,6 @@ RSpec/ContextWording: - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/create_spec.rb' - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb' - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb' - - 'ee/spec/graphql/ee/mutations/issues/create_spec.rb' - - 'ee/spec/graphql/ee/mutations/issues/update_spec.rb' - 'ee/spec/graphql/mutations/projects/set_compliance_framework_spec.rb' - 'ee/spec/graphql/mutations/releases/update_spec.rb' - 'ee/spec/graphql/mutations/security_policy/assign_security_policy_project_spec.rb' @@ -209,7 +211,6 @@ RSpec/ContextWording: - 'ee/spec/graphql/mutations/security_policy/create_security_policy_project_spec.rb' - 'ee/spec/graphql/resolvers/admin/cloud_licenses/subscription_future_entries_resolver_spec.rb' - 'ee/spec/graphql/resolvers/boards/board_list_epics_resolver_spec.rb' - - 'ee/spec/graphql/ee/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/oncall_schedule_resolver_spec.rb' - 'ee/spec/graphql/resolvers/instance_security_dashboard/projects_resolver_spec.rb' @@ -221,16 +222,15 @@ RSpec/ContextWording: - 'ee/spec/graphql/types/global_id_type_spec.rb' - 'ee/spec/graphql/types/incident_management/escalation_rule_input_type_spec.rb' - 'ee/spec/graphql/types/incident_management/oncall_rotation_date_input_type_spec.rb' - - 'ee/spec/graphql/ee/types/issue_type_spec.rb' - 'ee/spec/graphql/types/project_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_type_spec.rb' - - 'ee/spec/helpers/ee/application_helper_spec.rb' - - 'ee/spec/helpers/ee/boards_helper_spec.rb' - 'ee/spec/helpers/compliance_management/compliance_framework/group_settings_helper_spec.rb' + - 'ee/spec/helpers/ee/application_helper_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' + - 'ee/spec/helpers/ee/boards_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/issuables_helper_spec.rb' @@ -247,7 +247,6 @@ RSpec/ContextWording: - 'ee/spec/initializers/1_settings_spec.rb' - 'ee/spec/initializers/session_store_spec.rb' - 'ee/spec/lib/audit/details_spec.rb' - - 'ee/spec/lib/ee/banzai/filter/references/epic_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb' - 'ee/spec/lib/banzai/reference_parser/iteration_parser_spec.rb' @@ -258,6 +257,7 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb' - 'ee/spec/lib/ee/api/helpers/variables_helpers_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' + - 'ee/spec/lib/ee/banzai/filter/references/epic_reference_filter_spec.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' @@ -1901,7 +1901,6 @@ RSpec/ContextWording: - 'spec/models/integrations/every_integration_spec.rb' - 'spec/models/integrations/jenkins_spec.rb' - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/integrations/prometheus_spec.rb' - 'spec/models/internal_id_spec.rb' - 'spec/models/issue/metrics_spec.rb' - 'spec/models/issue_assignee_spec.rb' diff --git a/.rubocop_todo/rspec/example_without_description.yml b/.rubocop_todo/rspec/example_without_description.yml index e671d67675a9dd29508429fa1c30ed22ea3c99eb..ab4e689db6f052b5707352b39a33a1fb29047a1c 100644 --- a/.rubocop_todo/rspec/example_without_description.yml +++ b/.rubocop_todo/rspec/example_without_description.yml @@ -12,7 +12,6 @@ RSpec/ExampleWithoutDescription: - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' - - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - 'ee/spec/finders/security/related_pipelines_finder_spec.rb' - 'ee/spec/finders/security/scan_result_policies/findings_finder_spec.rb' - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' @@ -299,7 +298,6 @@ RSpec/ExampleWithoutDescription: - 'spec/lib/gitlab/ci/config/external/file/template_spec.rb' - 'spec/lib/gitlab/ci/jwt_base_spec.rb' - 'spec/lib/gitlab/ci/pipeline/duration_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb' - 'spec/lib/gitlab/ci/variables/collection/item_spec.rb' - 'spec/lib/gitlab/circuit_breaker/notifier_spec.rb' diff --git a/.rubocop_todo/rspec/excessive_docstring_spacing.yml b/.rubocop_todo/rspec/excessive_docstring_spacing.yml index 6873fbdd0c9f07dbf7c879d4f2d0640c67597691..9b26069adf3524494bed955df139078d13a896ae 100644 --- a/.rubocop_todo/rspec/excessive_docstring_spacing.yml +++ b/.rubocop_todo/rspec/excessive_docstring_spacing.yml @@ -13,7 +13,6 @@ RSpec/ExcessiveDocstringSpacing: - 'ee/spec/lib/gitlab/checks/integrations/git_guardian_check_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb' - 'ee/spec/models/approval_merge_request_rule_spec.rb' - - 'ee/spec/models/ee/label_link_spec.rb' - 'ee/spec/models/ee/project_spec.rb' - 'ee/spec/models/saml_provider_spec.rb' - 'ee/spec/models/vulnerabilities/finding_spec.rb' @@ -42,7 +41,6 @@ RSpec/ExcessiveDocstringSpacing: - 'spec/helpers/users_helper_spec.rb' - 'spec/lib/banzai/filter/inline_diff_filter_spec.rb' - 'spec/lib/banzai/filter/syntax_highlight_filter_spec.rb' - - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/feature_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index d087606ae52b01caf384d9bc55db6e54c0700d4d..d63671d2054be4aeb3bc0233a94c2e1af814930d 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -9,14 +9,14 @@ RSpec/ExpectInHook: - 'ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' + - 'ee/spec/finders/ee/template_finder_spec.rb' - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - - 'ee/spec/finders/ee/template_finder_spec.rb' - 'ee/spec/graphql/mutations/gitlab_subscriptions/activate_spec.rb' - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/kerberos_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' @@ -279,7 +279,6 @@ RSpec/ExpectInHook: - 'spec/requests/api/issues/post_projects_issues_spec.rb' - 'spec/requests/api/issues/put_projects_issues_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/npm_project_packages_spec.rb' - 'spec/requests/api/project_debian_distributions_spec.rb' - 'spec/requests/api/project_packages_spec.rb' - 'spec/requests/api/projects_spec.rb' @@ -360,7 +359,6 @@ RSpec/ExpectInHook: - 'spec/services/user_project_access_changed_service_spec.rb' - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - 'spec/support/shared_examples/csp.rb' - - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/database/reestablished_connection_stack_shared_examples.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index c8a41f1addc32c108731cc0c2453acd54876cc67..5e72de7852c8c2b6a45bd5d90c4293c6bc4fc233 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -9,12 +9,12 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/components/namespaces/storage/namespace_limit/project_pre_enforcement_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/namespace_limit/subgroup_pre_enforcement_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/namespace_limit/user_pre_enforcement_alert_component_spec.rb' - - 'ee/spec/helpers/ee/application_helper_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - - 'ee/spec/helpers/ee/boards_helper_spec.rb' - 'ee/spec/helpers/compliance_management/compliance_framework/group_settings_helper_spec.rb' - 'ee/spec/helpers/ee/admin/identities_helper_spec.rb' + - 'ee/spec/helpers/ee/application_helper_spec.rb' - 'ee/spec/helpers/ee/blob_helper_spec.rb' + - 'ee/spec/helpers/ee/boards_helper_spec.rb' - 'ee/spec/helpers/ee/branches_helper_spec.rb' - 'ee/spec/helpers/ee/ci/pipeline_editor_helper_spec.rb' - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' @@ -31,9 +31,12 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/helpers/ee/issuables_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' - 'ee/spec/helpers/ee/labels_helper_spec.rb' + - 'ee/spec/helpers/ee/markup_helper_spec.rb' - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' + - 'ee/spec/helpers/ee/notes_helper_spec.rb' - 'ee/spec/helpers/ee/operations_helper_spec.rb' - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' @@ -48,13 +51,10 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/helpers/incident_management/escalation_policy_helper_spec.rb' - 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb' - 'ee/spec/helpers/manual_quarterly_co_term_banner_helper_spec.rb' - - 'ee/spec/helpers/ee/markup_helper_spec.rb' - - 'ee/spec/helpers/ee/notes_helper_spec.rb' - 'ee/spec/helpers/path_locks_helper_spec.rb' - 'ee/spec/helpers/prevent_forking_helper_spec.rb' - 'ee/spec/helpers/projects/learn_gitlab_helper_spec.rb' - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb' - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' @@ -179,7 +179,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/views/groups/hook_logs/show.html.haml_spec.rb' - 'ee/spec/views/groups/hooks/edit.html.haml_spec.rb' - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - - 'ee/spec/views/groups/settings/_remove.html.haml_spec.rb' - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/layouts/group.html.haml_spec.rb' @@ -288,7 +287,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/helpers/timeboxes_helper_spec.rb' - 'spec/helpers/tree_helper_spec.rb' - 'spec/helpers/users/callouts_helper_spec.rb' - - 'spec/helpers/users/group_callouts_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - 'spec/helpers/version_check_helper_spec.rb' - 'spec/helpers/web_hooks/web_hooks_helper_spec.rb' diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index f8e9fba4776586c85b978f5f13813a36fa2dd19c..0afd44793064443ba3a6ce9f16c9ab68c6b38cdd 100644 --- a/.rubocop_todo/rspec/feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -28,7 +28,10 @@ RSpec/FeatureCategory: - 'ee/spec/finders/ee/ci/daily_build_group_report_results_finder_spec.rb' - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/fork_targets_finder_spec.rb' + - 'ee/spec/finders/ee/snippets_finder_spec.rb' + - 'ee/spec/finders/ee/template_finder_spec.rb' - 'ee/spec/finders/ee/user_recent_events_finder_spec.rb' + - 'ee/spec/finders/ee/users_finder_spec.rb' - 'ee/spec/finders/epics/cross_hierarchy_ancestors_finder_spec.rb' - 'ee/spec/finders/epics/cross_hierarchy_children_finder_spec.rb' - 'ee/spec/finders/gpg_keys_finder_spec.rb' @@ -46,11 +49,8 @@ RSpec/FeatureCategory: - 'ee/spec/finders/productivity_analytics_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' - 'ee/spec/finders/security/vulnerability_feedbacks_finder_spec.rb' - - 'ee/spec/finders/ee/snippets_finder_spec.rb' - 'ee/spec/finders/status_page/incident_comments_finder_spec.rb' - 'ee/spec/finders/status_page/incidents_finder_spec.rb' - - 'ee/spec/finders/ee/template_finder_spec.rb' - - 'ee/spec/finders/ee/users_finder_spec.rb' - 'ee/spec/frontend/fixtures/analytics/charts.rb' - 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb' - 'ee/spec/frontend/fixtures/analytics/value_streams.rb' @@ -71,7 +71,10 @@ RSpec/FeatureCategory: - 'ee/spec/frontend/fixtures/search.rb' - 'ee/spec/graphql/ee/mutations/boards/issues/issue_move_list_spec.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' + - 'ee/spec/graphql/ee/mutations/boards/update_spec.rb' - 'ee/spec/graphql/ee/mutations/concerns/mutations/resolves_issuable_spec.rb' + - 'ee/spec/graphql/ee/mutations/issues/create_spec.rb' + - 'ee/spec/graphql/ee/mutations/issues/update_spec.rb' - 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' @@ -86,7 +89,9 @@ RSpec/FeatureCategory: - 'ee/spec/graphql/ee/types/compliance_management/compliance_framework_type_spec.rb' - 'ee/spec/graphql/ee/types/environment_type_spec.rb' - 'ee/spec/graphql/ee/types/issuable_type_spec.rb' + - 'ee/spec/graphql/ee/types/issue_connection_type_spec.rb' - 'ee/spec/graphql/ee/types/issue_sort_enum_spec.rb' + - 'ee/spec/graphql/ee/types/issue_type_spec.rb' - 'ee/spec/graphql/ee/types/milestone_type_spec.rb' - 'ee/spec/graphql/ee/types/mutation_type_spec.rb' - 'ee/spec/graphql/ee/types/notes/noteable_interface_spec.rb' @@ -101,7 +106,6 @@ RSpec/FeatureCategory: - 'ee/spec/graphql/mutations/boards/epic_lists/update_spec.rb' - 'ee/spec/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' - 'ee/spec/graphql/mutations/boards/update_epic_user_preferences_spec.rb' - - 'ee/spec/graphql/ee/mutations/boards/update_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/create_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb' @@ -129,14 +133,12 @@ RSpec/FeatureCategory: - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb' - 'ee/spec/graphql/mutations/instance_security_dashboard/add_project_spec.rb' - 'ee/spec/graphql/mutations/instance_security_dashboard/remove_project_spec.rb' - - 'ee/spec/graphql/ee/mutations/issues/create_spec.rb' - 'ee/spec/graphql/mutations/issues/promote_to_epic_spec.rb' - 'ee/spec/graphql/mutations/issues/set_assignees_spec.rb' - 'ee/spec/graphql/mutations/issues/set_epic_spec.rb' - 'ee/spec/graphql/mutations/issues/set_escalation_policy_spec.rb' - 'ee/spec/graphql/mutations/issues/set_iteration_spec.rb' - 'ee/spec/graphql/mutations/issues/set_weight_spec.rb' - - 'ee/spec/graphql/ee/mutations/issues/update_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/accept_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/set_assignees_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/set_reviewers_spec.rb' @@ -249,8 +251,6 @@ RSpec/FeatureCategory: - 'ee/spec/graphql/types/incident_management/oncall_schedule_type_spec.rb' - 'ee/spec/graphql/types/incident_management/oncall_shift_type_spec.rb' - 'ee/spec/graphql/types/instance_security_dashboard_type_spec.rb' - - 'ee/spec/graphql/ee/types/issue_connection_type_spec.rb' - - 'ee/spec/graphql/ee/types/issue_type_spec.rb' - 'ee/spec/graphql/types/iteration_type_spec.rb' - 'ee/spec/graphql/types/iterations/cadence_type_spec.rb' - 'ee/spec/graphql/types/json_string_type_spec.rb' @@ -334,21 +334,25 @@ RSpec/FeatureCategory: - 'ee/spec/graphql/types/work_items/widgets/progress_type_spec.rb' - 'ee/spec/helpers/admin/emails_helper_spec.rb' - 'ee/spec/helpers/analytics/code_review_helper_spec.rb' - - 'ee/spec/helpers/ee/application_helper_spec.rb' - - 'ee/spec/helpers/ee/boards_helper_spec.rb' - 'ee/spec/helpers/ee/access_tokens_helper_spec.rb' - 'ee/spec/helpers/ee/admin/identities_helper_spec.rb' + - 'ee/spec/helpers/ee/application_helper_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' + - 'ee/spec/helpers/ee/boards_helper_spec.rb' - 'ee/spec/helpers/ee/ci/pipeline_editor_helper_spec.rb' - 'ee/spec/helpers/ee/events_helper_spec.rb' - 'ee/spec/helpers/ee/export_helper_spec.rb' - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/graph_helper_spec.rb' - 'ee/spec/helpers/ee/hooks_helper_spec.rb' + - 'ee/spec/helpers/ee/kerberos_helper_spec.rb' - 'ee/spec/helpers/ee/labels_helper_spec.rb' + - 'ee/spec/helpers/ee/markup_helper_spec.rb' + - 'ee/spec/helpers/ee/notes_helper_spec.rb' - 'ee/spec/helpers/ee/operations_helper_spec.rb' - 'ee/spec/helpers/ee/profiles_helper_spec.rb' - 'ee/spec/helpers/ee/projects/incidents_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' @@ -361,14 +365,10 @@ RSpec/FeatureCategory: - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' - 'ee/spec/helpers/groups/ldap_sync_helper_spec.rb' - 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb' - - 'ee/spec/helpers/ee/kerberos_helper_spec.rb' - 'ee/spec/helpers/manual_quarterly_co_term_banner_helper_spec.rb' - - 'ee/spec/helpers/ee/markup_helper_spec.rb' - - 'ee/spec/helpers/ee/notes_helper_spec.rb' - 'ee/spec/helpers/path_locks_helper_spec.rb' - 'ee/spec/helpers/prevent_forking_helper_spec.rb' - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/project_members_helper_spec.rb' - 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb' - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' @@ -389,13 +389,7 @@ RSpec/FeatureCategory: - 'ee/spec/lib/api/entities/protected_environments/approval_rule_spec.rb' - 'ee/spec/lib/api/entities/protected_environments/deploy_access_level_spec.rb' - 'ee/spec/lib/banzai/filter/jira_private_image_link_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - - 'ee/spec/lib/ee/banzai/filter/references/label_reference_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb' - - 'ee/spec/lib/ee/banzai/issuable_extractor_spec.rb' - - 'ee/spec/lib/ee/banzai/reference_parser/epic_parser_spec.rb' - 'ee/spec/lib/banzai/reference_parser/iteration_parser_spec.rb' - - 'ee/spec/lib/ee/banzai/reference_parser/vulnerability_parser_spec.rb' - 'ee/spec/lib/container_registry/client_spec.rb' - 'ee/spec/lib/ee/api/entities/analytics/code_review/merge_request_spec.rb' - 'ee/spec/lib/ee/api/entities/analytics/group_activity_spec.rb' @@ -412,7 +406,11 @@ RSpec/FeatureCategory: - 'ee/spec/lib/ee/api/helpers/scim_pagination_spec.rb' - 'ee/spec/lib/ee/api/helpers/variables_helpers_spec.rb' - 'ee/spec/lib/ee/api/support/git_access_actor_spec.rb' + - 'ee/spec/lib/ee/banzai/filter/references/label_reference_filter_spec.rb' - 'ee/spec/lib/ee/banzai/filter/sanitization_filter_spec.rb' + - 'ee/spec/lib/ee/banzai/issuable_extractor_spec.rb' + - 'ee/spec/lib/ee/banzai/reference_parser/epic_parser_spec.rb' + - 'ee/spec/lib/ee/banzai/reference_parser/vulnerability_parser_spec.rb' - 'ee/spec/lib/ee/bulk_imports/projects/stage_spec.rb' - 'ee/spec/lib/ee/event_filter_spec.rb' - 'ee/spec/lib/ee/feature_spec.rb' @@ -724,7 +722,6 @@ RSpec/FeatureCategory: - 'ee/spec/models/gitlab/seat_link_data_spec.rb' - 'ee/spec/models/gitlab_subscriptions/upcoming_reconciliation_spec.rb' - 'ee/spec/models/group_merge_request_approval_setting_spec.rb' - - 'ee/spec/models/group_wiki_repository_spec.rb' - 'ee/spec/models/historical_data_spec.rb' - 'ee/spec/models/incident_management/escalation_rule_spec.rb' - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb' @@ -1058,16 +1055,7 @@ RSpec/FeatureCategory: - 'spec/controllers/dashboard/snippets_controller_spec.rb' - 'spec/controllers/explore/snippets_controller_spec.rb' - 'spec/controllers/google_api/authorizations_controller_spec.rb' - - 'spec/controllers/groups/application_controller_spec.rb' - - 'spec/controllers/groups/avatars_controller_spec.rb' - - 'spec/controllers/groups/boards_controller_spec.rb' - - 'spec/controllers/groups/dependency_proxies_controller_spec.rb' - - 'spec/controllers/groups/imports_controller_spec.rb' - - 'spec/controllers/groups/packages_controller_spec.rb' - - 'spec/controllers/groups/releases_controller_spec.rb' - 'spec/controllers/groups/settings/repository_controller_spec.rb' - - 'spec/controllers/groups/shared_projects_controller_spec.rb' - - 'spec/controllers/groups/variables_controller_spec.rb' - 'spec/controllers/health_check_controller_spec.rb' - 'spec/controllers/help_controller_spec.rb' - 'spec/controllers/invites_controller_spec.rb' @@ -1132,7 +1120,6 @@ RSpec/FeatureCategory: - 'spec/features/admin/dashboard_spec.rb' - 'spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'spec/features/projects/members/anonymous_user_sees_members_spec.rb' - - 'spec/features/reportable_note/commit_spec.rb' - 'spec/features/user_sorts_things_spec.rb' - 'spec/finders/access_requests_finder_spec.rb' - 'spec/finders/admin/plans_finder_spec.rb' @@ -1156,7 +1143,6 @@ RSpec/FeatureCategory: - 'spec/finders/cluster_ancestors_finder_spec.rb' - 'spec/finders/clusters/agent_tokens_finder_spec.rb' - 'spec/finders/clusters/agents_finder_spec.rb' - - 'spec/finders/clusters/knative_services_finder_spec.rb' - 'spec/finders/clusters/kubernetes_namespace_finder_spec.rb' - 'spec/finders/clusters_finder_spec.rb' - 'spec/finders/concerns/finder_methods_spec.rb' @@ -2542,7 +2528,6 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/middleware/handle_ip_spoof_attack_error_spec.rb' - 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb' - 'spec/lib/gitlab/middleware/memory_report_spec.rb' - - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb' - 'spec/lib/gitlab/middleware/multipart_spec.rb' - 'spec/lib/gitlab/middleware/query_analyzer_spec.rb' - 'spec/lib/gitlab/middleware/rack_multipart_tempfile_factory_spec.rb' @@ -2990,7 +2975,6 @@ RSpec/FeatureCategory: - 'spec/models/concerns/presentable_spec.rb' - 'spec/models/concerns/project_api_compatibility_spec.rb' - 'spec/models/concerns/project_features_compatibility_spec.rb' - - 'spec/models/concerns/prometheus_adapter_spec.rb' - 'spec/models/concerns/reactive_caching_spec.rb' - 'spec/models/concerns/redactable_spec.rb' - 'spec/models/concerns/redis_cacheable_spec.rb' @@ -3061,7 +3045,6 @@ RSpec/FeatureCategory: - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - 'spec/models/integrations/chat_message/push_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - - 'spec/models/integrations/packagist_spec.rb' - 'spec/models/internal_id_spec.rb' - 'spec/models/issuable_severity_spec.rb' - 'spec/models/issue/email_spec.rb' @@ -3127,7 +3110,6 @@ RSpec/FeatureCategory: - 'spec/models/projects/topic_spec.rb' - 'spec/models/protectable_dropdown_spec.rb' - 'spec/models/push_event_payload_spec.rb' - - 'spec/models/push_event_spec.rb' - 'spec/models/raw_usage_data_spec.rb' - 'spec/models/redirect_route_spec.rb' - 'spec/models/releases/evidence_spec.rb' @@ -3143,7 +3125,6 @@ RSpec/FeatureCategory: - 'spec/models/snippet_input_action_spec.rb' - 'spec/models/snippet_repository_spec.rb' - 'spec/models/snippet_statistics_spec.rb' - - 'spec/models/spam_log_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - 'spec/models/subscription_spec.rb' - 'spec/models/suggestion_spec.rb' @@ -3164,7 +3145,6 @@ RSpec/FeatureCategory: - 'spec/models/users_star_project_spec.rb' - 'spec/models/users_statistics_spec.rb' - 'spec/models/web_ide_terminal_spec.rb' - - 'spec/models/webauthn_registration_spec.rb' - 'spec/models/wiki_directory_spec.rb' - 'spec/models/work_items/widgets/assignees_spec.rb' - 'spec/models/work_items/widgets/base_spec.rb' @@ -3661,7 +3641,6 @@ RSpec/FeatureCategory: - 'spec/views/projects/_flash_messages.html.haml_spec.rb' - 'spec/views/projects/_home_panel.html.haml_spec.rb' - 'spec/views/projects/blob/_viewer.html.haml_spec.rb' - - 'spec/views/projects/branches/index.html.haml_spec.rb' - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb' - 'spec/views/projects/commits/show.html.haml_spec.rb' - 'spec/views/projects/diffs/_viewer.html.haml_spec.rb' @@ -3683,7 +3662,6 @@ RSpec/FeatureCategory: - 'spec/views/projects/settings/ci_cd/_autodevops_form.html.haml_spec.rb' - 'spec/views/projects/settings/integrations/edit.html.haml_spec.rb' - 'spec/views/projects/settings/operations/show.html.haml_spec.rb' - - 'spec/views/projects/tags/index.html.haml_spec.rb' - 'spec/views/shared/_label_row.html.haml_spec.rb' - 'spec/views/shared/_milestones_sort_dropdown.html.haml_spec.rb' - 'spec/views/shared/gitlab_version/_security_patch_upgrade_alert.html.haml_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index c359616d8a959ef17cd4be96ef6548811a9a9816..518af7fb83c4806da9ef049b8f39d5502f3dcdfd 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -2,10 +2,10 @@ RSpec/InstanceVariable: Exclude: - 'ee/spec/controllers/admin/geo/settings_controller_spec.rb' + - 'ee/spec/controllers/ee/passwords_controller_spec.rb' - 'ee/spec/controllers/ee/sessions_controller_spec.rb' - 'ee/spec/controllers/groups/groups_controller_spec.rb' - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb' - - 'ee/spec/controllers/ee/passwords_controller_spec.rb' - 'ee/spec/features/markdown/markdown_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/epic.rb' @@ -13,8 +13,8 @@ RSpec/InstanceVariable: - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' - 'ee/spec/helpers/ee/issuables_helper_spec.rb' - - 'ee/spec/helpers/ee/wiki_helper_spec.rb' - 'ee/spec/helpers/ee/notes_helper_spec.rb' + - 'ee/spec/helpers/ee/wiki_helper_spec.rb' - 'ee/spec/helpers/search_helper_spec.rb' - 'ee/spec/lib/gitlab/reference_extractor_spec.rb' - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml index 815f641768b4cd4be3076a8a1f5a3bb24cd96397..23c31fa63568311601921712f616f266910fbbf6 100644 --- a/.rubocop_todo/rspec/named_subject.yml +++ b/.rubocop_todo/rspec/named_subject.yml @@ -8,13 +8,20 @@ RSpec/NamedSubject: - 'ee/spec/controllers/admin/identities_controller_spec.rb' - 'ee/spec/controllers/admin/projects_controller_spec.rb' - 'ee/spec/controllers/admin/users_controller_spec.rb' - - 'ee/spec/controllers/ee/autocomplete_controller_spec.rb' - 'ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb' + - 'ee/spec/controllers/ee/autocomplete_controller_spec.rb' + - 'ee/spec/controllers/ee/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/ee/groups/settings/ci_cd_controller_spec.rb' - 'ee/spec/controllers/ee/groups/variables_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' - 'ee/spec/controllers/ee/omniauth_callbacks_controller_spec.rb' + - 'ee/spec/controllers/ee/passwords_controller_spec.rb' - 'ee/spec/controllers/ee/profiles/preferences_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/analytics/cycle_analytics/summary_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/environments_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/issues_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/merge_requests/creations_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/merge_requests_controller_spec.rb' - 'ee/spec/controllers/ee/projects/settings/ci_cd_controller_spec.rb' - 'ee/spec/controllers/ee/projects/settings/repository_controller_spec.rb' - 'ee/spec/controllers/ee/projects_controller_spec.rb' @@ -26,7 +33,6 @@ RSpec/NamedSubject: - 'ee/spec/controllers/groups/analytics/repository_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/tasks_by_type_controller_spec.rb' - 'ee/spec/controllers/groups/epics_controller_spec.rb' - - 'ee/spec/controllers/ee/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/groups/groups_controller_spec.rb' - 'ee/spec/controllers/groups/insights_controller_spec.rb' - 'ee/spec/controllers/groups/issues_controller_spec.rb' @@ -36,13 +42,7 @@ RSpec/NamedSubject: - 'ee/spec/controllers/groups/saml_providers_controller_spec.rb' - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' - 'ee/spec/controllers/groups/security/merge_commit_reports_controller_spec.rb' - - 'ee/spec/controllers/ee/passwords_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/analytics/cycle_analytics/summary_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/environments_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/issues_controller_spec.rb' - 'ee/spec/controllers/projects/iterations_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/merge_requests/creations_controller_spec.rb' - - 'ee/spec/controllers/ee/projects/merge_requests_controller_spec.rb' - 'ee/spec/controllers/projects/protected_environments_controller_spec.rb' - 'ee/spec/controllers/projects/quality/test_cases_controller_spec.rb' - 'ee/spec/controllers/projects/requirements_management/requirements_controller_spec.rb' @@ -52,7 +52,6 @@ RSpec/NamedSubject: - 'ee/spec/controllers/sitemap_controller_spec.rb' - 'ee/spec/db/production/license_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - - 'ee/spec/features/user_sees_marketing_header_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/finders/analytics/cycle_analytics/stage_finder_spec.rb' - 'ee/spec/finders/app_sec/fuzzing/coverage/corpuses_finder_spec.rb' @@ -65,6 +64,7 @@ RSpec/NamedSubject: - 'ee/spec/finders/dast_scanner_profiles_finder_spec.rb' - 'ee/spec/finders/dast_site_profiles_finder_spec.rb' - 'ee/spec/finders/dast_site_validations_finder_spec.rb' + - 'ee/spec/finders/ee/snippets_finder_spec.rb' - 'ee/spec/finders/gpg_keys_finder_spec.rb' - 'ee/spec/finders/group_saml_identity_finder_spec.rb' - 'ee/spec/finders/groups_finder_spec.rb' @@ -78,12 +78,17 @@ RSpec/NamedSubject: - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - 'ee/spec/finders/security/vulnerability_feedbacks_finder_spec.rb' - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - - 'ee/spec/finders/ee/snippets_finder_spec.rb' + - 'ee/spec/graphql/ee/graphql_triggers_spec.rb' - 'ee/spec/graphql/ee/mutations/boards/issues/issue_move_list_spec.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' + - 'ee/spec/graphql/ee/mutations/boards/update_spec.rb' - 'ee/spec/graphql/ee/mutations/ci/job_token_scope/add_project_spec.rb' + - 'ee/spec/graphql/ee/mutations/issues/update_spec.rb' + - 'ee/spec/graphql/ee/resolvers/clusters/agents_resolver_spec.rb' + - 'ee/spec/graphql/ee/resolvers/user_discussions_count_resolver_spec.rb' + - 'ee/spec/graphql/ee/resolvers/user_notes_count_resolver_spec.rb' + - 'ee/spec/graphql/ee/types/ci/pipeline_type_spec.rb' - 'ee/spec/graphql/ee/types/group_type_spec.rb' - - 'ee/spec/graphql/ee/graphql_triggers_spec.rb' - 'ee/spec/graphql/mutations/ai/action_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/create_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/destroy_spec.rb' @@ -93,7 +98,6 @@ RSpec/NamedSubject: - 'ee/spec/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - 'ee/spec/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' - - 'ee/spec/graphql/ee/mutations/boards/update_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/create_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb' - 'ee/spec/graphql/mutations/dast/profiles/create_spec.rb' @@ -120,7 +124,6 @@ RSpec/NamedSubject: - 'ee/spec/graphql/mutations/issues/set_epic_spec.rb' - 'ee/spec/graphql/mutations/issues/set_iteration_spec.rb' - 'ee/spec/graphql/mutations/issues/set_weight_spec.rb' - - 'ee/spec/graphql/ee/mutations/issues/update_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/set_reviewers_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/update_approval_rules_spec.rb' - 'ee/spec/graphql/mutations/releases/update_spec.rb' @@ -140,17 +143,13 @@ RSpec/NamedSubject: - 'ee/spec/graphql/mutations/vulnerabilities/revert_to_detected_spec.rb' - 'ee/spec/graphql/resolvers/app_sec/fuzzing/coverage/corpuses_resolver_spec.rb' - 'ee/spec/graphql/resolvers/boards/epic_list_resolver_spec.rb' - - 'ee/spec/graphql/ee/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/oncall_shifts_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/oncall_users_resolver_spec.rb' - 'ee/spec/graphql/resolvers/product_analytics/state_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb' - - 'ee/spec/graphql/ee/resolvers/user_discussions_count_resolver_spec.rb' - - 'ee/spec/graphql/ee/resolvers/user_notes_count_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities/issue_links_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' - 'ee/spec/graphql/types/asset_type_spec.rb' - - 'ee/spec/graphql/ee/types/ci/pipeline_type_spec.rb' - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' - 'ee/spec/graphql/types/project_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_evidence_source_type_spec.rb' @@ -174,13 +173,13 @@ RSpec/NamedSubject: - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' + - 'ee/spec/helpers/ee/kerberos_helper_spec.rb' - 'ee/spec/helpers/ee/merge_requests_helper_spec.rb' - 'ee/spec/helpers/ee/operations_helper_spec.rb' - 'ee/spec/helpers/ee/projects/incidents_helper_spec.rb' - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/groups/ldap_sync_helper_spec.rb' - - 'ee/spec/helpers/ee/kerberos_helper_spec.rb' - 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb' - 'ee/spec/helpers/secrets_helper_spec.rb' - 'ee/spec/helpers/users_helper_spec.rb' @@ -210,8 +209,6 @@ RSpec/NamedSubject: - 'ee/spec/lib/audit_events/strategies/group_external_destination_strategy_spec.rb' - 'ee/spec/lib/audit_events/strategies/instance/google_cloud_logging_destination_strategy_spec.rb' - 'ee/spec/lib/audit_events/strategies/instance_external_destination_strategy_spec.rb' - - 'ee/spec/lib/ee/banzai/reference_parser/epic_parser_spec.rb' - - 'ee/spec/lib/ee/banzai/reference_parser/vulnerability_parser_spec.rb' - 'ee/spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/epics_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_cadences_pipeline_spec.rb' @@ -230,6 +227,8 @@ RSpec/NamedSubject: - 'ee/spec/lib/ee/api/helpers/notes_helpers_spec.rb' - 'ee/spec/lib/ee/api/helpers/scim_pagination_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' + - 'ee/spec/lib/ee/banzai/reference_parser/epic_parser_spec.rb' + - 'ee/spec/lib/ee/banzai/reference_parser/vulnerability_parser_spec.rb' - 'ee/spec/lib/ee/bulk_imports/groups/stage_spec.rb' - 'ee/spec/lib/ee/bulk_imports/projects/stage_spec.rb' - 'ee/spec/lib/ee/feature_spec.rb' @@ -392,7 +391,6 @@ RSpec/NamedSubject: - 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/sitemap_file_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/url_extractor_spec.rb' - - 'ee/spec/lib/gitlab/spdx/catalogue_spec.rb' - 'ee/spec/lib/gitlab/status_page/filter/image_filter_spec.rb' - 'ee/spec/lib/gitlab/status_page/pipeline/post_process_pipeline_spec.rb' - 'ee/spec/lib/gitlab/status_page_spec.rb' @@ -407,7 +405,6 @@ RSpec/NamedSubject: - 'ee/spec/lib/omni_auth/strategies/kerberos_spec.rb' - 'ee/spec/lib/product_analytics/settings_spec.rb' - 'ee/spec/lib/projects/project_changes_auditor_spec.rb' - - 'ee/spec/lib/repositories/project_push_rules_changes_auditor_spec.rb' - 'ee/spec/lib/sidebars/groups/menus/epics_menu_spec.rb' - 'ee/spec/lib/sidebars/groups/menus/work_item_epics_menu_spec.rb' - 'ee/spec/lib/sidebars/user_settings/menus/profile_billing_menu_spec.rb' @@ -720,7 +717,6 @@ RSpec/NamedSubject: - 'ee/spec/serializers/vulnerability_entity_spec.rb' - 'ee/spec/serializers/vulnerability_note_entity_spec.rb' - 'ee/spec/services/admin/email_service_spec.rb' - - 'ee/spec/services/ee/analytics/cycle_analytics/stages/list_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service_spec.rb' - 'ee/spec/services/analytics/devops_adoption/snapshots/calculate_and_save_service_spec.rb' @@ -793,6 +789,7 @@ RSpec/NamedSubject: - 'ee/spec/services/ee/admin/set_feature_flag_service_spec.rb' - 'ee/spec/services/ee/alert_management/alerts/update_service_spec.rb' - 'ee/spec/services/ee/allowed_email_domains/update_service_spec.rb' + - 'ee/spec/services/ee/analytics/cycle_analytics/stages/list_service_spec.rb' - 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb' - 'ee/spec/services/ee/ci/job_artifacts/create_service_spec.rb' - 'ee/spec/services/ee/ci/job_artifacts/destroy_all_expired_service_spec.rb' @@ -834,6 +831,7 @@ RSpec/NamedSubject: - 'ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb' - 'ee/spec/services/ee/users/build_service_spec.rb' - 'ee/spec/services/ee/work_items/import_csv_service_spec.rb' + - 'ee/spec/services/ee/work_items/update_service_spec.rb' - 'ee/spec/services/elastic/metrics_update_service_spec.rb' - 'ee/spec/services/epic_issues/destroy_service_spec.rb' - 'ee/spec/services/epic_issues/update_service_spec.rb' @@ -939,7 +937,6 @@ RSpec/NamedSubject: - 'ee/spec/services/vulnerabilities/update_service_spec.rb' - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - - 'ee/spec/services/ee/work_items/update_service_spec.rb' - 'ee/spec/support/shared_contexts/audit_event_not_licensed_shared_context.rb' - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - 'ee/spec/tasks/gitlab/license_rake_spec.rb' @@ -1529,7 +1526,6 @@ RSpec/NamedSubject: - 'spec/lib/gitlab/background_migration/redis/backfill_project_pipeline_status_ttl_spec.rb' - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/bitbucket_import/parallel_importer_spec.rb' - - 'spec/lib/gitlab/blame_spec.rb' - 'spec/lib/gitlab/branch_push_merge_commit_analyzer_spec.rb' - 'spec/lib/gitlab/bullet/exclusions_spec.rb' - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' @@ -2694,7 +2690,6 @@ RSpec/NamedSubject: - 'spec/serializers/user_entity_spec.rb' - 'spec/serializers/web_ide_terminal_serializer_spec.rb' - 'spec/services/admin/abuse_reports/moderate_user_service_spec.rb' - - 'spec/services/admin/abuse_reports/update_service_spec.rb' - 'spec/services/admin/set_feature_flag_service_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - 'spec/services/applications/create_service_spec.rb' @@ -2726,7 +2721,6 @@ RSpec/NamedSubject: - 'spec/services/ci/create_pipeline_service/dry_run_spec.rb' - 'spec/services/ci/create_pipeline_service/environment_spec.rb' - 'spec/services/ci/create_pipeline_service/parameter_content_spec.rb' - - 'spec/services/ci/create_web_ide_terminal_service_spec.rb' - 'spec/services/ci/deployments/destroy_service_spec.rb' - 'spec/services/ci/destroy_secure_file_service_spec.rb' - 'spec/services/ci/drop_pipeline_service_spec.rb' diff --git a/.rubocop_todo/rspec/no_expectation_example.yml b/.rubocop_todo/rspec/no_expectation_example.yml index 54ee8cd25f068dc29b8973a42551413aae3825df..62e39003325e0533598c4de35d2a50874a6e5d78 100644 --- a/.rubocop_todo/rspec/no_expectation_example.yml +++ b/.rubocop_todo/rspec/no_expectation_example.yml @@ -104,7 +104,6 @@ RSpec/NoExpectationExample: - 'spec/lib/gitlab/x509/certificate_spec.rb' - 'spec/lib/gitlab/x509/commit_sigstore_spec.rb' - 'spec/lib/google_api/cloud_platform/client_spec.rb' - - 'spec/mailers/notify_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/appearance_spec.rb' - 'spec/models/ci/build_spec.rb' diff --git a/.rubocop_todo/rspec/receive_messages.yml b/.rubocop_todo/rspec/receive_messages.yml index 67648d601b99dd283f0222b68a829c49ee88efa2..c0100c02a75362421390e0913e46a26cf73feeec 100644 --- a/.rubocop_todo/rspec/receive_messages.yml +++ b/.rubocop_todo/rspec/receive_messages.yml @@ -23,18 +23,17 @@ RSpec/ReceiveMessages: - 'ee/spec/helpers/ee/ide_helper_spec.rb' - 'ee/spec/helpers/ee/issuables_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' + - 'ee/spec/helpers/ee/nav/new_dropdown_helper_spec.rb' - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/helpers/gitlab_subscriptions/trials_helper_spec.rb' - 'ee/spec/helpers/groups/security_features_helper_spec.rb' - 'ee/spec/helpers/license_monitoring_helper_spec.rb' - - 'ee/spec/helpers/ee/nav/new_dropdown_helper_spec.rb' - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - 'ee/spec/helpers/tree_helper_spec.rb' - 'ee/spec/helpers/trial_registrations_helper_spec.rb' - 'ee/spec/helpers/users/identity_verification_helper_spec.rb' - - 'ee/spec/helpers/users_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - 'ee/spec/lib/arkose/verify_response_spec.rb' - 'ee/spec/lib/audit_events/strategies/external_destination_strategy_spec.rb' @@ -178,7 +177,6 @@ RSpec/ReceiveMessages: - 'qa/spec/page/logging_spec.rb' - 'qa/spec/resource/base_spec.rb' - 'qa/spec/resource/events/project_spec.rb' - - 'qa/spec/scenario/template_spec.rb' - 'qa/spec/support/page_error_checker_spec.rb' - 'qa/spec/support/wait_for_requests_spec.rb' - 'qa/spec/tools/test_resources_data_processor_spec.rb' @@ -330,7 +328,6 @@ RSpec/ReceiveMessages: - 'spec/lib/gitlab/x509/tag_sigstore_spec.rb' - 'spec/lib/gitlab/x509/tag_spec.rb' - 'spec/lib/gitlab_edition_spec.rb' - - 'spec/lib/gitlab_spec.rb' - 'spec/lib/google_api/auth_spec.rb' - 'spec/lib/omni_auth/strategies/bitbucket_spec.rb' - 'spec/lib/sidebars/menu_spec.rb' diff --git a/.rubocop_todo/rspec/redundant_metatag_type.yml b/.rubocop_todo/rspec/redundant_metatag_type.yml index 82e0cf3d9496e660a0164a7d0c60697bf74c636e..9a2f965a68890ea1b01b35a334092a519763cd8c 100644 --- a/.rubocop_todo/rspec/redundant_metatag_type.yml +++ b/.rubocop_todo/rspec/redundant_metatag_type.yml @@ -16,7 +16,6 @@ RSpec/RedundantMetatagType: - 'ee/spec/components/gitlab_subscriptions/trials/ultimate/trial_form_component_spec.rb' - 'ee/spec/components/gitlab_subscriptions/trials/ultimate/trial_form_with_errors_component_spec.rb' - 'ee/spec/components/gitlab_subscriptions/trials/welcome/trial_form_component_spec.rb' - - 'ee/spec/components/namespaces/block_seat_overages/all_seats_used_alert_component_spec.rb' - 'ee/spec/components/namespaces/combined_storage_users/non_owner_alert_component_spec.rb' - 'ee/spec/components/namespaces/combined_storage_users/owner_alert_component_spec.rb' - 'ee/spec/components/namespaces/free_user_cap/enforcement_alert_component_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml index 60226aa0813fac62846052ede975470b4cc82a59..2114c38344d6d672fe6b27efea7e3bcc6dfcaa85 100644 --- a/.rubocop_todo/rspec/repeated_example_group_description.yml +++ b/.rubocop_todo/rspec/repeated_example_group_description.yml @@ -32,7 +32,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/helpers/admin/user_actions_helper_spec.rb' - 'spec/helpers/dropdowns_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' - - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' - 'spec/lib/gitlab/auth/atlassian/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/blocked_user_tracker_spec.rb' diff --git a/.rubocop_todo/rspec/verified_double_reference.yml b/.rubocop_todo/rspec/verified_double_reference.yml index d3fc595952a3bbce39ae453e7e7f4ee7d6f4b0ab..f3eaf131be702deafbe9289b3dfba43701ad1296 100644 --- a/.rubocop_todo/rspec/verified_double_reference.yml +++ b/.rubocop_todo/rspec/verified_double_reference.yml @@ -3,7 +3,6 @@ RSpec/VerifiedDoubleReference: Exclude: - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' - - 'ee/spec/features/merge_request/user_sees_security_policy_rules_licence_compliance_spec.rb' - 'ee/spec/features/projects/google_cloud/artifact_registry_spec.rb' - 'ee/spec/features/projects/integrations/google_cloud_platform/user_activates_artifact_management_spec.rb' - 'ee/spec/helpers/groups/sso_helper_spec.rb' @@ -81,7 +80,6 @@ RSpec/VerifiedDoubleReference: - 'qa/spec/service/shellout_spec.rb' - 'qa/spec/specs/allure_report_spec.rb' - 'qa/spec/specs/runner_spec.rb' - - 'qa/spec/support/formatters/test_metrics_formatter_spec.rb' - 'qa/spec/support/helpers/masker_spec.rb' - 'qa/spec/tools/ci/code_paths_mapping_spec.rb' - 'spec/benchmarks/banzai_benchmark.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index a66e5818ca5ae4475db01d1ff032c14ff87b8d7a..6a46d4d808670b69a5383c2bd8a41d25b4e09840 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -6,10 +6,10 @@ RSpec/VerifiedDoubles: - 'ee/spec/db/production/license_spec.rb' - 'ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb' - 'ee/spec/features/profiles/account_spec.rb' + - 'ee/spec/finders/ee/template_finder_spec.rb' - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - - 'ee/spec/finders/ee/template_finder_spec.rb' - 'ee/spec/graphql/mutations/dast_scanner_profiles/create_spec.rb' - 'ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb' - 'ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb' @@ -24,9 +24,9 @@ RSpec/VerifiedDoubles: - 'ee/spec/graphql/resolvers/vulnerabilities/details_resolver_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' + - 'ee/spec/helpers/ee/kerberos_helper_spec.rb' - 'ee/spec/helpers/ee/license_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - - 'ee/spec/helpers/ee/kerberos_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' diff --git a/.rubocop_todo/sidekiq/enforce_database_health_signal_deferral.yml b/.rubocop_todo/sidekiq/enforce_database_health_signal_deferral.yml index b8b9dff179db0b96cedcd3e67cde927ebf25f26f..f083401a7df51c160b15c3184bca5ff4e1a47a16 100644 --- a/.rubocop_todo/sidekiq/enforce_database_health_signal_deferral.yml +++ b/.rubocop_todo/sidekiq/enforce_database_health_signal_deferral.yml @@ -38,7 +38,6 @@ Sidekiq/EnforceDatabaseHealthSignalDeferral: - 'app/workers/container_registry/delete_container_repository_worker.rb' - 'app/workers/container_registry/record_data_repair_detail_worker.rb' - 'app/workers/counters/cleanup_refresh_worker.rb' - - 'app/workers/database/background_operation/cron_enqueue_worker.rb' - 'app/workers/dependency_proxy/cleanup_blob_worker.rb' - 'app/workers/dependency_proxy/cleanup_manifest_worker.rb' - 'app/workers/design_management/copy_design_collection_worker.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 67434e80bf2f4aee5d6f0912014ae3dc0692fa88..15e44ce82199c41d5c38ad2963a43910ffc356fa 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -20,7 +20,6 @@ Style/FormatString: - 'app/helpers/timeboxes_helper.rb' - 'app/helpers/tree_helper.rb' - 'app/helpers/users_helper.rb' - - 'app/mailers/emails/members.rb' - 'app/mailers/emails/pages_domains.rb' - 'app/mailers/emails/profile.rb' - 'app/models/application_setting_implementation.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 9c41badce22e137466642bd1e290810cf1a976ba..4587587a824086b88bf69fc91e09e1521c23d291 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -9,7 +9,6 @@ Style/GuardClause: - 'app/controllers/concerns/authenticates_with_two_factor.rb' - 'app/controllers/concerns/creates_commit.rb' - 'app/controllers/concerns/cycle_analytics_params.rb' - - 'app/controllers/concerns/enforces_admin_authentication.rb' - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - 'app/controllers/concerns/impersonation.rb' - 'app/controllers/import/gitea_controller.rb' @@ -205,7 +204,6 @@ Style/GuardClause: - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - 'ee/app/models/approval_merge_request_rule_source.rb' - 'ee/app/models/concerns/app_sec/dast/buildable.rb' - - 'ee/app/models/concerns/elastic/application_versioned_search.rb' - 'ee/app/models/dast/profile.rb' - 'ee/app/models/dast_site.rb' - 'ee/app/models/dast_site_profile.rb' diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml index aee3ee85e5b2fc69fbd9290bae69998f2391e8e8..52a05c40775f224bf60fef3bae96117291caae4a 100644 --- a/.rubocop_todo/style/inline_disable_annotation.yml +++ b/.rubocop_todo/style/inline_disable_annotation.yml @@ -169,7 +169,6 @@ Style/InlineDisableAnnotation: - 'app/graphql/types/base_enum.rb' - 'app/graphql/types/blame/blame_type.rb' - 'app/graphql/types/blame/commit_data_type.rb' - - 'app/graphql/types/blame/groups_type.rb' - 'app/graphql/types/blob_viewer_type.rb' - 'app/graphql/types/board_list_type.rb' - 'app/graphql/types/boards/board_issue_input_base_type.rb' @@ -726,7 +725,6 @@ Style/InlineDisableAnnotation: - 'app/workers/database/batched_background_migration/ci_database_worker.rb' - 'app/workers/database/batched_background_migration/ci_execution_worker.rb' - 'app/workers/database/batched_background_migration/main_execution_worker.rb' - - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/database/batched_background_migration_worker.rb' - 'app/workers/database/ci_namespace_mirrors_consistency_check_worker.rb' - 'app/workers/database/ci_project_mirrors_consistency_check_worker.rb' diff --git a/.rubocop_todo/style/mutable_constant.yml b/.rubocop_todo/style/mutable_constant.yml index 528562252918b8201f065f8fdb94345c3d9f5f93..8d274ea7fcf89548b7fa9c546372d0db6772b6b5 100644 --- a/.rubocop_todo/style/mutable_constant.yml +++ b/.rubocop_todo/style/mutable_constant.yml @@ -12,7 +12,6 @@ Style/MutableConstant: - 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_statistics.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/statistics/update_service.rb' - - 'lib/banzai/filter/references/abstract_reference_filter.rb' - 'lib/banzai/filter/spaced_link_filter.rb' - 'lib/gitlab/cleanup/project_upload_file_finder.rb' - 'lib/gitlab/counters/buffered_counter.rb' diff --git a/.rubocop_todo/style/numbered_parameters.yml b/.rubocop_todo/style/numbered_parameters.yml index 8d8c6a1b0d2b81a08a8517298b29b6c9dc2bdec1..adf22635c00169099b379434ac6cd7700573898d 100644 --- a/.rubocop_todo/style/numbered_parameters.yml +++ b/.rubocop_todo/style/numbered_parameters.yml @@ -28,7 +28,6 @@ Style/NumberedParameters: - 'ee/spec/models/vulnerabilities/statistic_spec.rb' - 'ee/spec/services/quick_actions/interpret_service_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_remediations_spec.rb' - - 'lib/api/entities/hook.rb' - 'lib/api/helpers/web_hooks_helpers.rb' - 'lib/api/hooks/url_variables.rb' - 'lib/error_tracking/sentry_client/issue.rb' diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml index b5d4dc3482e1364b348b8985abde091f8727d7a9..47201bb2753f0e0d8db981dd1e8184abf525fbc8 100644 --- a/.rubocop_todo/style/redundant_parentheses.yml +++ b/.rubocop_todo/style/redundant_parentheses.yml @@ -23,7 +23,6 @@ Style/RedundantParentheses: - 'qa/qa/page/base.rb' - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/requests/lfs_locks_api_spec.rb' - - 'spec/spec_helper.rb' - 'spec/support/helpers/database/duplicate_indexes.rb' - 'spec/support/helpers/login_helpers.rb' - 'tooling/lib/tooling/helm3_client.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 068269cfaad84dd2d4709945dd1f7f71fb6406dc..52b0f3db1776e46741a39a67c0c8f788c1a4b126 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -133,7 +133,6 @@ Style/RedundantSelf: - 'app/workers/concerns/limited_capacity/worker.rb' - 'app/workers/concerns/project_start_import.rb' - 'app/workers/concerns/reenqueuer.rb' - - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/group_import_worker.rb' - 'app/workers/project_export_worker.rb' - 'config/initializers/active_record_keyset_pagination.rb' @@ -161,7 +160,6 @@ Style/RedundantSelf: - 'ee/app/models/ee/user.rb' - 'ee/app/models/gitlab_subscription.rb' - 'ee/app/models/gitlab_subscriptions/upcoming_reconciliation.rb' - - 'ee/app/models/group_wiki_repository.rb' - 'ee/app/models/iteration.rb' - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/license.rb' diff --git a/app/assets/javascripts/boards/components/board_card_inner.vue b/app/assets/javascripts/boards/components/board_card_inner.vue index dd4a817bee44fe5472fcdebacfb01fa00c950f48..245677bc9966593ff70732c72558903e671bd888 100644 --- a/app/assets/javascripts/boards/components/board_card_inner.vue +++ b/app/assets/javascripts/boards/components/board_card_inner.vue @@ -1,9 +1,11 @@ '; + const result = processEmojiInTitle(title); + + expect(result).toContain('data-name="dog"'); // emoji should render + expect(result).toContain('<em>test</em>'); // HTML should be escaped + expect(result).toContain('<script>alert(1)</script>'); // script should be escaped + expect(result).not.toContain(''); // no actual HTML tags + expect(result).not.toContain('')).toBe( + '<script>alert("XSS")</script>', + ); + }); + + it('handles empty string input', () => { + expect(htmlEncode('')).toBe(''); + }); + + it('handles undefined input with default parameter', () => { + expect(htmlEncode()).toBe(''); + }); + + it('preserves whitespace and newlines', () => { + expect(htmlEncode('Hello\nWorld')).toBe('Hello\nWorld'); + expect(htmlEncode('Hello\tWorld')).toBe('Hello\tWorld'); + expect(htmlEncode(' Hello World ')).toBe(' Hello World '); + }); + + it('handles complex HTML-like structures', () => { + const input = + 'Page & Title' + + '

Hello "World"!

'; + const expected = + '<html><head><title>Page & Title</title><' + + '/head><body><p class="text">Hello "World"!<' + + '/p></body></html>'; + expect(htmlEncode(input)).toBe(expected); + }); + + it('handles JavaScript code snippets', () => { + const input = 'if (x < 5 && y > 10) { alert("Hello & Goodbye"); }'; + const expected = + 'if (x < 5 && y > 10) { alert("Hello & Goodbye"); }'; + expect(htmlEncode(input)).toBe(expected); + }); + + it('handles SQL injection attempts', () => { + const input = "'; DROP TABLE users; --"; + const expected = ''; DROP TABLE users; --'; + expect(htmlEncode(input)).toBe(expected); + }); + + it('handles XSS attack vectors', () => { + const xssVectors = [ + '', + '', + '', + '', + ]; + + xssVectors.forEach((vector) => { + const encoded = htmlEncode(vector); + expect(encoded).not.toContain(' { + expect(htmlEncode('Hello 世界 & "Universe"')).toBe('Hello 世界 & "Universe"'); + expect(htmlEncode('Café & "Restaurant"')).toBe('Café & "Restaurant"'); + expect(htmlEncode('🚀 < 🌟')).toBe('🚀 < 🌟'); + }); + }); +});