From fdf33ff81b3bab7da6a3d8aa10cd74c69580c49a Mon Sep 17 00:00:00 2001 From: Lohit Peesapati Date: Wed, 24 Sep 2025 23:21:33 +0530 Subject: [PATCH] =?UTF-8?q?[RSpec=20random=20order]=20Processed=201=20spec?= =?UTF-8?q?s:=20all=20failed=20=E2=9D=8C?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## RSpec Order Dependency Check Results Processed 1 spec files from `spec/support/rspec_order_todo.yml`: - **0 specs passed** and can now run in random order ✅ - **1 specs failed** and were moved to `spec/support/rspec_order_failures.yml` ❌ _None in this batch_ ### ❌ Failed specs with bisect analysis (1): - `ee/spec/controllers/admin/projects_controller_spec.rb` - **Bisect**: ✅ `rspec './ee/spec/controllers/admin/projects_controller_spec.rb[1:1:1:1:2:1]' --seed 20250924 --format documentation` ### 📊 Progress Summary: - **Processed this batch**: 1 specs - **Passed (can run randomly)**: 0 specs - **Failed (moved to failure list)**: 1 specs - **Remaining in TODO**: 7971 specs - **TODO list cleanup**: Removed 1 processed entries ### 🐛 Debugging Failed Specs: For specs that failed the order dependency check, use the provided bisect commands to: 1. **Reproduce the issue**: Run the minimal reproduction command 2. **Identify dependencies**: See which other specs are needed to make it pass 3. **Fix the root cause**: Remove shared state or add proper cleanup 4. **Re-test**: Run the spec again to verify the fix --- **Related to**: #407877 > The order dependency checks were performed using `scripts/rspec_check_order_dependence`. Bisect analysis was run on failed specs to provide debugging information. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) locally using the `Keeps::RspecOrderChecker` keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- spec/support/rspec_order_failures.yml | 2 ++ spec/support/rspec_order_todo.yml | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 spec/support/rspec_order_failures.yml diff --git a/spec/support/rspec_order_failures.yml b/spec/support/rspec_order_failures.yml new file mode 100644 index 00000000000000..944453311cd440 --- /dev/null +++ b/spec/support/rspec_order_failures.yml @@ -0,0 +1,2 @@ +--- +- './ee/spec/controllers/admin/projects_controller_spec.rb' diff --git a/spec/support/rspec_order_todo.yml b/spec/support/rspec_order_todo.yml index e8da228a05999a..ab29da1b8abd7c 100644 --- a/spec/support/rspec_order_todo.yml +++ b/spec/support/rspec_order_todo.yml @@ -4,7 +4,6 @@ # See https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#test-order. # --- -- './ee/spec/controllers/admin/projects_controller_spec.rb' - './ee/spec/controllers/ee/groups_controller_spec.rb' - './ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - './ee/spec/controllers/groups/contribution_analytics_controller_spec.rb' -- GitLab