diff --git a/changelogs/unreleased/add_missing_add_index_rubocop_spec.yml b/changelogs/unreleased/add_missing_add_index_rubocop_spec.yml new file mode 100644 index 0000000000000000000000000000000000000000..b1ae864ae358a9c2bbb90cc142200486bcfc94bf --- /dev/null +++ b/changelogs/unreleased/add_missing_add_index_rubocop_spec.yml @@ -0,0 +1,5 @@ +--- +title: add missing test for add_index rubocop rule +merge_request: 20464 +author: Eric Thomas +type: other diff --git a/spec/rubocop/cop/migration/add_index_spec.rb b/spec/rubocop/cop/migration/add_index_spec.rb new file mode 100644 index 0000000000000000000000000000000000000000..0c3f87e5bf86c6452e12219ce0033d5b44794ade --- /dev/null +++ b/spec/rubocop/cop/migration/add_index_spec.rb @@ -0,0 +1,39 @@ +# frozen_string_literal: true + +require 'spec_helper' + +require 'rubocop' +require 'rubocop/rspec/support' + +require_relative '../../../../rubocop/cop/migration/add_index' + +describe RuboCop::Cop::Migration::AddIndex do + include CopHelper + + subject(:cop) { described_class.new } + + context 'in migration' do + before do + allow(cop).to receive(:in_migration?).and_return(true) + end + + it 'registers an offense when add_index is used' do + expect_offense(<<~PATTERN.strip_indent) + def change + add_index :table, :column + ^^^^^^^^^ `add_index` requires downtime, use `add_concurrent_index` instead + end + PATTERN + end + end + + context 'outside of migration' do + it 'registers no offense' do + expect_no_offenses(<<~PATTERN.strip_indent) + def change + add_index :table, :column + end + PATTERN + end + end +end