From 67b5773afb6d146f1de8e2dca3392fea6ab50707 Mon Sep 17 00:00:00 2001 From: Vanessa Otto Date: Tue, 9 Sep 2025 13:04:36 +0200 Subject: [PATCH 1/3] Rename errors to messages --- .../components/errors_alert.stories.js | 4 ++-- .../vue_shared/components/errors_alert.vue | 24 +++++++++---------- .../components/ai_catalog_agent_form.vue | 2 +- .../components/ai_catalog_flow_form.vue | 2 +- .../ai/catalog/pages/ai_catalog_agents.vue | 2 +- .../catalog/pages/ai_catalog_agents_run.vue | 2 +- .../ai/catalog/pages/ai_catalog_flows.vue | 2 +- .../pages/flows/ai_flows.vue | 2 +- .../components/ai_catalog_agent_form_spec.js | 4 ++-- .../components/ai_catalog_flow_form_spec.js | 4 ++-- .../pages/ai_catalog_agents_run_spec.js | 4 ++-- .../catalog/pages/ai_catalog_agents_spec.js | 10 ++++---- .../ai/catalog/pages/ai_catalog_flows_spec.js | 12 +++++----- .../pages/flows/ai_flows_spec.js | 4 ++-- .../components/errors_alert_spec.js | 18 +++++++------- 15 files changed, 48 insertions(+), 48 deletions(-) diff --git a/app/assets/javascripts/vue_shared/components/errors_alert.stories.js b/app/assets/javascripts/vue_shared/components/errors_alert.stories.js index e23ce665f17144..b6ceb76f06ba09 100644 --- a/app/assets/javascripts/vue_shared/components/errors_alert.stories.js +++ b/app/assets/javascripts/vue_shared/components/errors_alert.stories.js @@ -6,7 +6,7 @@ export default { }; const defaultArgs = { - errors: ['The item could not be created.'], + messages: ['The item could not be created.'], }; const Template = (args, { argTypes }) => ({ @@ -23,7 +23,7 @@ Default.args = { export const ErrorsList = Template.bind({}); ErrorsList.args = { ...defaultArgs, - errors: ['The item could not be created.', 'The item could not be updated.'], + messages: ['The item could not be created.', 'The item could not be updated.'], }; export const WithTitle = Template.bind({}); diff --git a/app/assets/javascripts/vue_shared/components/errors_alert.vue b/app/assets/javascripts/vue_shared/components/errors_alert.vue index b5dd8a219cfff3..c9f359362f0c6b 100644 --- a/app/assets/javascripts/vue_shared/components/errors_alert.vue +++ b/app/assets/javascripts/vue_shared/components/errors_alert.vue @@ -12,12 +12,12 @@ export default { required: false, default: '', }, - errors: { + messages: { type: Array, required: false, default: () => [], }, - scrollOnError: { + scrollOnMessage: { type: Boolean, required: false, default: true, @@ -29,14 +29,14 @@ export default { }, }, computed: { - hasErrors() { - return this.errors.length > 0; + hasMessages() { + return this.messages.length > 0; }, }, watch: { - errors() { - // Watch for changes in errors and scroll into focus when errors are present - if (this.scrollOnError && this.hasErrors) { + messages() { + // Watch for changes in messages and scroll into focus when messages are present + if (this.scrollOnMessage && this.hasMessages) { this.scrollToAlert(); } }, @@ -56,19 +56,19 @@ export default {