From 51dd0f49c1d935bd800c98e87a2b2a182054a9c7 Mon Sep 17 00:00:00 2001 From: safwanuahmed Date: Fri, 4 Jul 2025 09:05:19 -0400 Subject: [PATCH] cleanup specs --- .../ee/types/clusters/agent_type_spec.rb | 56 ------------------- .../workspaces_agent_config_type_spec.rb | 31 ---------- 2 files changed, 87 deletions(-) diff --git a/ee/spec/graphql/ee/types/clusters/agent_type_spec.rb b/ee/spec/graphql/ee/types/clusters/agent_type_spec.rb index 0b7d537973997c..95287dc358b4bd 100644 --- a/ee/spec/graphql/ee/types/clusters/agent_type_spec.rb +++ b/ee/spec/graphql/ee/types/clusters/agent_type_spec.rb @@ -65,60 +65,4 @@ end end end - - describe 'workspaces_agent_config' do - let_it_be(:group) { create(:group) } - let_it_be(:project) { create(:project, group: group) } - let_it_be(:user) { create(:user) } - let_it_be(:cluster_agent) { create(:cluster_agent, project: project) } - let_it_be(:workspaces_agent_config) do - create(:workspaces_agent_config, cluster_agent_id: cluster_agent.id, project_id: project.id) - end - - let_it_be(:namespace_cluster_agent_mapping) do - create(:namespace_cluster_agent_mapping, agent: cluster_agent, namespace: group) - end - - let_it_be(:query) do - %( - query { - namespace(fullPath: "#{group.full_path}") { - remoteDevelopmentClusterAgents(filter: AVAILABLE) { - nodes { - workspacesAgentConfig { - workspacesPerUserQuota - } - } - } - } - } - ) - end - - before_all do - project.add_owner(user) - end - - before do - stub_licensed_features(remote_development: true) - end - - subject(:workspaces_agent_config_result) do - result = GitlabSchema.execute(query, context: { current_user: current_user }).as_json - result.dig('data', 'namespace', 'remoteDevelopmentClusterAgents', 'nodes', 0, 'workspacesAgentConfig') - end - - context 'when user is logged in' do - let(:current_user) { user } - let(:expected_workspaces_per_user_quota) do - workspaces_agent_config.workspaces_per_user_quota - end - - it 'returns associated workspaces agent config' do - expect(workspaces_agent_config_result).to eq( - 'workspacesPerUserQuota' => expected_workspaces_per_user_quota - ) - end - end - end end diff --git a/ee/spec/graphql/types/remote_development/workspaces_agent_config_type_spec.rb b/ee/spec/graphql/types/remote_development/workspaces_agent_config_type_spec.rb index 10020ede3c816c..d8710b35cc7260 100644 --- a/ee/spec/graphql/types/remote_development/workspaces_agent_config_type_spec.rb +++ b/ee/spec/graphql/types/remote_development/workspaces_agent_config_type_spec.rb @@ -18,35 +18,4 @@ specify { expect(described_class).to have_graphql_fields(fields) } specify { expect(described_class).to require_graphql_authorizations(:read_workspaces_agent_config) } - - describe 'workspaces_agent_config' do - let_it_be(:group) { create(:group) } - - let_it_be(:query) do - %( - query { - namespace(fullPath: "#{group.full_path}") { - remoteDevelopmentClusterAgents(filter: AVAILABLE) { - nodes { - workspacesAgentConfig { - workspacesPerUserQuota - } - } - } - } - } - ) - end - - subject(:workspaces_agent_config_result) do - result = GitlabSchema.execute(query, context: { current_user: current_user }).as_json - result.dig('data', 'namespace', 'remoteDevelopmentClusterAgents', 'nodes', 0, 'workspacesAgentConfig') - end - - context 'when user is not logged in' do - let(:current_user) { nil } - - it { is_expected.to be_nil } - end - end end -- GitLab