From 82567ec7d8d49676c9a9a27a41af6067dbbdcd54 Mon Sep 17 00:00:00 2001 From: Annabel Dunstone Gray Date: Fri, 27 Jun 2025 10:01:42 -0600 Subject: [PATCH] Use open and reopen instead of unresolve for threads Changelog: changed --- .../batch_comments/mixins/resolved_status.js | 4 +- .../behaviors/shortcuts/keybindings.js | 4 +- .../design_notes/design_discussion.vue | 2 +- .../notes/components/discussion_counter.vue | 2 +- .../notes/components/note_form.vue | 2 +- .../javascripts/notes/mixins/resolvable.js | 2 +- .../components/checks/constants.js | 2 +- .../checks/unresolved_discussions.vue | 2 +- .../design_notes/design_discussion.vue | 2 +- .../components/notes/work_item_add_note.vue | 2 +- .../notes/work_item_comment_form.vue | 2 +- app/views/shared/issuable/_form.html.haml | 2 +- doc/api/discussions.md | 6 +-- .../visual_studio_code/_index.md | 2 +- doc/tutorials/merge_requests/homepage.md | 2 +- doc/tutorials/reviews/_index.md | 4 +- doc/user/discussions/_index.md | 2 +- doc/user/group/manage.md | 2 +- doc/user/project/issues/design_management.md | 4 +- doc/user/project/merge_requests/_index.md | 20 ++++---- .../merge_requests/approvals/_index.md | 2 +- .../project/merge_requests/reviews/_index.md | 10 ++-- doc/user/shortcuts.md | 4 +- locale/gitlab.pot | 48 +++++++++---------- ...dd_batch_comments_in_merge_request_spec.rb | 2 +- ...e_for_discussions_in_merge_request_spec.rb | 4 +- ...single_discussion_in_merge_request_spec.rb | 4 +- .../merge_request/batch_comments_spec.rb | 2 +- ...diff_notes_and_discussions_resolve_spec.rb | 38 +++++++-------- .../user_sees_discussions_navigation_spec.rb | 4 +- ...epending_on_unresolved_discussions_spec.rb | 2 +- .../user_suggests_changes_on_diff_spec.rb | 4 +- .../design_notes/design_discussion_spec.js | 4 +- .../notes/components/note_actions_spec.js | 2 +- .../components/checks/message_spec.js | 2 +- .../checks/unresolved_discussions_spec.js | 6 +-- .../design_notes/design_discussion_spec.js | 4 +- 37 files changed, 106 insertions(+), 106 deletions(-) diff --git a/app/assets/javascripts/batch_comments/mixins/resolved_status.js b/app/assets/javascripts/batch_comments/mixins/resolved_status.js index da7c7809bedf7f..35ed283666d5a7 100644 --- a/app/assets/javascripts/batch_comments/mixins/resolved_status.js +++ b/app/assets/javascripts/batch_comments/mixins/resolved_status.js @@ -39,9 +39,9 @@ export default { ? s__('MergeRequests|Thread stays resolved') : s__('MergeRequests|Thread will be resolved'); } else if (discussionResolved) { - message = s__('MergeRequests|Thread will be unresolved'); + message = s__('MergeRequests|Thread will be open'); } else if (this.$options.showStaysResolved) { - message = s__('MergeRequests|Thread stays unresolved'); + message = s__('MergeRequests|Thread stays open'); } return message; diff --git a/app/assets/javascripts/behaviors/shortcuts/keybindings.js b/app/assets/javascripts/behaviors/shortcuts/keybindings.js index 4ff55cc27bd861..1597cbc2dd9ca8 100644 --- a/app/assets/javascripts/behaviors/shortcuts/keybindings.js +++ b/app/assets/javascripts/behaviors/shortcuts/keybindings.js @@ -489,13 +489,13 @@ export const MR_TOGGLE_REVIEW = { export const MR_NEXT_UNRESOLVED_DISCUSSION = { id: 'mergeRequests.nextUnresolvedDiscussion', - description: __('Next unresolved thread'), + description: __('Next open thread'), defaultKeys: ['n'], }; export const MR_PREVIOUS_UNRESOLVED_DISCUSSION = { id: 'mergeRequests.previousUnresolvedDiscussion', - description: __('Previous unresolved thread'), + description: __('Previous open thread'), defaultKeys: ['p'], }; diff --git a/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue b/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue index 282163b4b2e174..da38a8440318e1 100644 --- a/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue +++ b/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue @@ -137,7 +137,7 @@ export default { }, resolveCheckboxText() { return this.discussion.resolved - ? s__('DesignManagement|Unresolve thread') + ? s__('DesignManagement|Reopen thread') : s__('DesignManagement|Resolve thread'); }, firstNote() { diff --git a/app/assets/javascripts/notes/components/discussion_counter.vue b/app/assets/javascripts/notes/components/discussion_counter.vue index def8af83b91954..9127241b0e7fb3 100644 --- a/app/assets/javascripts/notes/components/discussion_counter.vue +++ b/app/assets/javascripts/notes/components/discussion_counter.vue @@ -142,7 +142,7 @@ export default { />