hi
- TEXT + html = engine.render('# hi') - expect(engine.render('# hi')).to eq expected + fragment = Nokogiri::HTML.fragment(html) + expect(fragment.css('h1').first['data-sourcepos']).to eq('1:1-1:4') end it 'turns off sourcepos' do engine = described_class.new({ no_sourcepos: true }) - expected = <<~TEXT -hi
- TEXT + html = engine.render('# hi') - expect(engine.render('# hi')).to eq expected + fragment = Nokogiri::HTML.fragment(html) + expect(fragment.css('h1').first['data-sourcepos']).to be_nil end it 'turns off header anchors' do engine = described_class.new({ no_header_anchors: true, no_sourcepos: true }) - expected = <<~TEXT + expected = <<~HTMLhi
- TEXT + HTML expect(engine.render('# hi')).to eq expected end it 'turns off autolinking' do engine = described_class.new({ autolink: false, no_sourcepos: true }) - expected = <<~TEXT + expected = <<~HTMLhttp://example.com
- TEXT + HTML expect(engine.render('http://example.com')).to eq expected end it 'returns proper inline sourcepos' do engine = described_class.new({}) - expected = <<~TEXT + expected = <<~HTMLcode
http://example.com emphasis $x + y$
- TEXT + HTML expect(engine.render('http://example.com _emphasis_ $x + y$')).to eq expected end @@ -66,9 +64,9 @@ shared_examples 'enables placeholder rendering by default' do it 'processes %{} syntax as placeholders' do engine = described_class.new({ project: project_reference, no_sourcepos: true }) - expected = <<~TEXT + expected = <<~HTML%{test}
- TEXT + HTML expect(engine.render('%{test}')).to eq expected end @@ -84,18 +82,18 @@ it 'turns off placeholder detection when :disable_placeholders' do engine = described_class.new({ disable_placeholders: true, project: project, no_sourcepos: true }) - expected = <<~TEXT + expected = <<~HTML%{test}
- TEXT + HTML expect(engine.render('%{test}')).to eq expected end it 'turns off placeholder detection when :broadcast_message_placeholders' do engine = described_class.new({ broadcast_message_placeholders: true, project: project, no_sourcepos: true }) - expected = <<~TEXT + expected = <<~HTML%{test}
- TEXT + HTML expect(engine.render('%{test}')).to eq expected end @@ -104,9 +102,9 @@ stub_feature_flags(markdown_placeholders: false) engine = described_class.new({ project: project, no_sourcepos: true }) - expected = <<~TEXT + expected = <<~HTML%{test}
- TEXT + HTML expect(engine.render('%{test}')).to eq expected end diff --git a/spec/lib/banzai/filter/placeholders_post_filter_spec.rb b/spec/lib/banzai/filter/placeholders_post_filter_spec.rb index cbde1df2cdb91e6330487e1333fcbf8bbcb25017..47bb1899eae99269d1fc00290504c0c94b3d9e26 100644 --- a/spec/lib/banzai/filter/placeholders_post_filter_spec.rb +++ b/spec/lib/banzai/filter/placeholders_post_filter_spec.rb @@ -284,28 +284,25 @@ def expect_replaces_placeholder(markdown, expected) it 'does not allow project_title in a link href' do markdown = '[test](%{gitlab_server}/%{project_title}/foo.png)' expected = '' + 'data-placeholder="%25%7Bgitlab_server%7D/%25%7Bproject_title%7D/foo.png" ' \ + 'data-canonical-src="%25%7Bgitlab_server%7D/%25%7Bproject_title%7D/foo.png">test' expect(run_pipeline(markdown)).to eq expected end it 'does not recognize unknown placeholder in a link href' do markdown = '[test](%{gitlab_server}/%{foo}/foo.png)' - expected = '' + expected = '' expect(run_pipeline(markdown)).to eq expected end - it 'does not allow placeholders in link text (parser limitation)' do + it 'allows placeholders in link text' do markdown = '[%{gitlab_server}](%{gitlab_server})' - expected = '' + expected = '' expect(run_pipeline(markdown)).to eq expected end @@ -336,9 +333,9 @@ def expect_replaces_placeholder(markdown, expected) it 'generates the correct attributes' do markdown = '' expected = "
![](\"https://#{Gitlab.config.gitlab.host}/#{project.path}/foo.png\")
![](\"https://#{Gitlab.config.gitlab.host}/%{project_title}/foo.png\")
![](\"https:///#{project.path}/foo.png\")
)
+ describe 'heading anchors' do
+ it 'allows id property on headings' do
+ exp = %q()
act = filter(exp)
expect(act.to_html).to eq exp
end
- it 'removes id property for non-anchor links' do
- exp = %q()
- act = filter(%q())
-
- expect(act.to_html).to eq exp
- end
-
it 'removes id property for non-user-content links' do
- exp = %q()
- act = filter(%q())
+ act = filter(%q())
+ exp = %q()
expect(act.to_html).to eq exp
end
diff --git a/spec/lib/banzai/filter/table_of_contents_tag_filter_spec.rb b/spec/lib/banzai/filter/table_of_contents_tag_filter_spec.rb
index 6eee6950f1faf7b04a5ccf3a24670811a1c29059..b996d2112e405907e5dd17c7b226e3cb82aa2283 100644
--- a/spec/lib/banzai/filter/table_of_contents_tag_filter_spec.rb
+++ b/spec/lib/banzai/filter/table_of_contents_tag_filter_spec.rb
@@ -69,7 +69,7 @@
doc = pipeline_filter("this [[_toc_]]\n\n# Foo")
expect(doc.to_html).to include('this _toc_')
- expect(doc.to_html).to include('Foo')
+ expect(doc.to_html).to include('>Foo