From 1e12513b180ca04955567d5f2530f1b38565525e Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Tue, 4 Feb 2025 18:21:59 -0700
Subject: [PATCH 1/8] Add events and metrics to track when reviewers are
 selected

---
 .../user_selects_reviewer_from_mr_sidebar.yml | 19 ++++++++++++++++
 ..._reviewer_from_mr_sidebar_after_search.yml | 19 ++++++++++++++++
 ..._user_selects_reviewer_from_mr_sidebar.yml | 22 +++++++++++++++++++
 ..._reviewer_from_mr_sidebar_after_search.yml | 22 +++++++++++++++++++
 4 files changed, 82 insertions(+)
 create mode 100644 config/events/user_selects_reviewer_from_mr_sidebar.yml
 create mode 100644 config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml
 create mode 100644 config/metrics/counts_all/count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar.yml
 create mode 100644 config/metrics/counts_all/count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar_after_search.yml

diff --git a/config/events/user_selects_reviewer_from_mr_sidebar.yml b/config/events/user_selects_reviewer_from_mr_sidebar.yml
new file mode 100644
index 00000000000000..37bc2342c91052
--- /dev/null
+++ b/config/events/user_selects_reviewer_from_mr_sidebar.yml
@@ -0,0 +1,19 @@
+---
+description: User selects a reviewer from the merge request reviewers sidebar
+internal_events: true
+action: user_selects_reviewer_from_mr_sidebar
+identifiers:
+- project
+- namespace
+- user
+additional_properties:
+  value:
+    description: List position of the selected user
+product_group: code_review
+product_categories:
+- code_review_workflow
+milestone: '17.9'
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/180307
+tiers:
+- premium
+- ultimate
diff --git a/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml b/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml
new file mode 100644
index 00000000000000..3dffff50784de5
--- /dev/null
+++ b/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml
@@ -0,0 +1,19 @@
+---
+description: User selects a reviewer from the merge request reviewers sidebar after they have entered a search query and the list has updated
+internal_events: true
+action: user_selects_reviewer_from_mr_sidebar_after_search
+identifiers:
+- project
+- namespace
+- user
+additional_properties:
+  value:
+    description: List position of the selected user
+product_group: code_review
+product_categories:
+- code_review_workflow
+milestone: '17.9'
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/180307
+tiers:
+- premium
+- ultimate
diff --git a/config/metrics/counts_all/count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar.yml b/config/metrics/counts_all/count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar.yml
new file mode 100644
index 00000000000000..4b8f671757c85d
--- /dev/null
+++ b/config/metrics/counts_all/count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar.yml
@@ -0,0 +1,22 @@
+---
+key_path: redis_hll_counters.count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar
+description: Count of unique users who selected a reviewer from the MR reviewer sidebar
+product_group: code_review
+product_categories:
+- code_review_workflow
+performance_indicator_type: []
+value_type: number
+status: active
+milestone: '17.9'
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/180307
+time_frame:
+- 28d
+- 7d
+data_source: internal_events
+data_category: optional
+tiers:
+- premium
+- ultimate
+events:
+- name: user_selects_reviewer_from_mr_sidebar
+  unique: user.id
diff --git a/config/metrics/counts_all/count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar_after_search.yml b/config/metrics/counts_all/count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar_after_search.yml
new file mode 100644
index 00000000000000..177a5c8fd18f84
--- /dev/null
+++ b/config/metrics/counts_all/count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar_after_search.yml
@@ -0,0 +1,22 @@
+---
+key_path: redis_hll_counters.count_distinct_user_id_from_user_selects_reviewer_from_mr_sidebar_after_search
+description: Count of unique users who selected a reviewer from the MR reviewer sidebar after filtering the reviewer list with a custom search
+product_group: code_review
+product_categories:
+- code_review_workflow
+performance_indicator_type: []
+value_type: number
+status: active
+milestone: '17.9'
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/180307
+time_frame:
+- 28d
+- 7d
+data_source: internal_events
+data_category: optional
+tiers:
+- premium
+- ultimate
+events:
+- name: user_selects_reviewer_from_mr_sidebar_after_search
+  unique: user.id
-- 
GitLab


From 02e9b04fe9946fdd2ef5c0821fa80f9a865db78a Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Thu, 6 Feb 2025 20:41:48 -0700
Subject: [PATCH 2/8] Send a tracking event with the position of the selected
 reviewer

---
 .../reviewers/reviewer_dropdown.vue           | 55 +++++++++++++++----
 1 file changed, 44 insertions(+), 11 deletions(-)

diff --git a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
index 18d97de2084dd6..553727a360c52f 100644
--- a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
+++ b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
@@ -1,7 +1,8 @@
 <script>
-import { debounce } from 'lodash';
+import { debounce, difference } from 'lodash';
 import { GlCollapsibleListbox, GlButton, GlAvatar, GlIcon } from '@gitlab/ui';
 import { __ } from '~/locale';
+import { InternalEvents } from '~/tracking';
 import { DEFAULT_DEBOUNCE_AND_THROTTLE_MS } from '~/lib/utils/constants';
 import { TYPENAME_MERGE_REQUEST } from '~/graphql_shared/constants';
 import { convertToGraphQLId } from '~/graphql_shared/utils';
@@ -10,6 +11,10 @@ import InviteMembersTrigger from '~/invite_members/components/invite_members_tri
 import UpdateReviewers from './update_reviewers.vue';
 import userPermissionsQuery from './queries/user_permissions.query.graphql';
 
+function toUsernames(reviewers) {
+  return reviewers.map((reviewer) => reviewer.username);
+}
+
 export default {
   apollo: {
     userPermissions: {
@@ -31,6 +36,7 @@ export default {
     UpdateReviewers,
     InviteMembersTrigger,
   },
+  mixins: [InternalEvents.mixin()],
   inject: ['projectPath', 'issuableId', 'issuableIid', 'directlyInviteMembers'],
   props: {
     users: {
@@ -54,14 +60,25 @@ export default {
       search: '',
       searching: false,
       fetchedUsers: [],
-      currentSelectedReviewers: this.selectedReviewers.map((r) => r.username),
+      currentSelectedReviewers: toUsernames(this.selectedReviewers),
       userPermissions: {},
     };
   },
   computed: {
+    usersForList() {
+      let users;
+
+      if (this.fetchedUsers.length) {
+        users = this.fetchedUsers;
+      } else {
+        users = this.users;
+      }
+
+      return users;
+    },
     mappedUsers() {
       const items = [];
-      let users;
+      const users = this.usersForList;
 
       if (this.selectedReviewersToShow.length && !this.search) {
         items.push({
@@ -70,12 +87,6 @@ export default {
         });
       }
 
-      if (this.fetchedUsers.length) {
-        users = this.fetchedUsers;
-      } else {
-        users = this.users;
-      }
-
       items.push({
         textSrOnly: true,
         text: __('Users'),
@@ -96,7 +107,7 @@ export default {
   },
   watch: {
     selectedReviewers(newVal) {
-      this.currentSelectedReviewers = newVal.map((r) => r.username);
+      this.currentSelectedReviewers = toUsernames(newVal);
     },
   },
   created() {
@@ -142,6 +153,28 @@ export default {
     removeAllReviewers() {
       this.currentSelectedReviewers = [];
     },
+    processReviewers(update) {
+      const telemetryEvent = this.search
+        ? 'user_selects_reviewer_from_mr_sidebar_after_search'
+        : 'user_selects_reviewer_from_mr_sidebar';
+      const previousUsernames = toUsernames(this.selectedReviewers);
+      const listUsernames = toUsernames(this.usersForList);
+      // Reviewers are always shown first if they are in the list,
+      // so we should exclude them for when we check the position
+      const selectableList = difference(listUsernames, previousUsernames);
+      const additions = difference(this.currentSelectedReviewers, previousUsernames);
+
+      additions.forEach((added) => {
+        // Convert from 0- to 1-index
+        const listPosition = selectableList.findIndex((user) => user === added) + 1;
+
+        this.trackEvent(telemetryEvent, {
+          value: listPosition,
+        });
+      });
+
+      update();
+    },
   },
   i18n: {
     selectReviewer: __('Select reviewer'),
@@ -170,7 +203,7 @@ export default {
         :searching="searching"
         @search="debouncedFetchAutocompleteUsers"
         @shown="shownDropdown"
-        @hidden="updateReviewers"
+        @hidden="processReviewers(updateReviewers)"
         @reset="removeAllReviewers"
       >
         <template #toggle>
-- 
GitLab


From 42b5e738c319ad5a8dc1cf21b8afdb62e510600d Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Thu, 6 Feb 2025 21:40:21 -0700
Subject: [PATCH 3/8] Test sending tracking events when selecting reviewers

---
 .../reviewers/reviewer_dropdown_spec.js       | 61 +++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js b/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js
index 278469da99ea32..04e741730f4763 100644
--- a/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js
+++ b/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js
@@ -209,6 +209,67 @@ describe('Reviewer dropdown component', () => {
         }),
       );
     });
+
+    describe('tracking when the dropdown is closed', () => {
+      let trackingSpy;
+
+      beforeEach(async () => {
+        createComponent(true, {
+          users: [createMockUser(), createMockUser({ id: 2, name: 'Nonadmin', username: 'bob' })],
+        });
+
+        await waitForPromises();
+
+        trackingSpy = mockTracking(undefined, window.document, jest.spyOn);
+      });
+
+      it('tracks which position any selected users were in as a telemetry event', () => {
+        findDropdown().vm.$emit('select', ['root']);
+        findDropdown().vm.$emit('hidden');
+
+        expect(trackingSpy).toHaveBeenCalledWith(
+          undefined,
+          'user_selects_reviewer_from_mr_sidebar',
+          expect.objectContaining({
+            value: 1,
+          }),
+        );
+      });
+
+      it('tracks which position any selected users were in - discounting already selected reviewers - as a telemetry event', async () => {
+        createComponent(true, {
+          users: [createMockUser(), createMockUser({ id: 2, name: 'Nonadmin', username: 'bob' })],
+          selectedReviewers: [createMockUser()],
+        });
+
+        await waitForPromises();
+
+        findDropdown().vm.$emit('select', ['bob']);
+        findDropdown().vm.$emit('hidden');
+
+        expect(trackingSpy).toHaveBeenCalledWith(
+          undefined,
+          'user_selects_reviewer_from_mr_sidebar',
+          expect.objectContaining({
+            value: 1,
+          }),
+        );
+      });
+
+      it('tracks which position any selected users were in after a search as a telemetry event', () => {
+        findDropdown().vm.$emit('search', 'bob');
+        findDropdown().vm.$emit('select', ['bob']);
+        findDropdown().vm.$emit('hidden');
+
+        expect(trackingSpy).toHaveBeenCalledWith(
+          undefined,
+          'user_selects_reviewer_from_mr_sidebar_after_search',
+          expect.objectContaining({
+            value: 2,
+          }),
+        );
+      });
+    });
   });
 
   describe('when users are passed as a prop', () => {
-- 
GitLab


From d416a7e1699cc55cf1cf117c6893979a6de33d2a Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Mon, 10 Feb 2025 14:19:14 -0700
Subject: [PATCH 4/8] Move telemetry tracking out to a separate method

(from MR review)
---
 .../components/reviewers/reviewer_dropdown.vue            | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
index 553727a360c52f..709f937d8c1968 100644
--- a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
+++ b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
@@ -153,7 +153,7 @@ export default {
     removeAllReviewers() {
       this.currentSelectedReviewers = [];
     },
-    processReviewers(update) {
+    trackReviewersSelectEvent() {
       const telemetryEvent = this.search
         ? 'user_selects_reviewer_from_mr_sidebar_after_search'
         : 'user_selects_reviewer_from_mr_sidebar';
@@ -172,8 +172,10 @@ export default {
           value: listPosition,
         });
       });
-
-      update();
+    },
+    processReviewers(updateReviewers) {
+      this.trackReviewersSelectEvent();
+      updateReviewers();
     },
   },
   i18n: {
-- 
GitLab


From d8b40783934c18e9ef4b16b1c6981fb5ddd1a832 Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Mon, 10 Feb 2025 15:09:24 -0700
Subject: [PATCH 5/8] Add total list count to the reported event data

---
 .../merge_requests/components/reviewers/reviewer_dropdown.vue  | 1 +
 config/events/user_selects_reviewer_from_mr_sidebar.yml        | 2 ++
 .../user_selects_reviewer_from_mr_sidebar_after_search.yml     | 2 ++
 .../components/reviewers/reviewer_dropdown_spec.js             | 3 +++
 4 files changed, 8 insertions(+)

diff --git a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
index 709f937d8c1968..5870b07e8db971 100644
--- a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
+++ b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
@@ -170,6 +170,7 @@ export default {
 
         this.trackEvent(telemetryEvent, {
           value: listPosition,
+          selectable_count: selectableList.length,
         });
       });
     },
diff --git a/config/events/user_selects_reviewer_from_mr_sidebar.yml b/config/events/user_selects_reviewer_from_mr_sidebar.yml
index 37bc2342c91052..d7bf5374e929a8 100644
--- a/config/events/user_selects_reviewer_from_mr_sidebar.yml
+++ b/config/events/user_selects_reviewer_from_mr_sidebar.yml
@@ -9,6 +9,8 @@ identifiers:
 additional_properties:
   value:
     description: List position of the selected user
+  selectable_count:
+    description: The total number of selectable reviewers in the list this reviewer was selected from
 product_group: code_review
 product_categories:
 - code_review_workflow
diff --git a/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml b/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml
index 3dffff50784de5..1b2a9258572584 100644
--- a/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml
+++ b/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml
@@ -9,6 +9,8 @@ identifiers:
 additional_properties:
   value:
     description: List position of the selected user
+  selectable_count:
+    description: The total number of selectable reviewers in the list this reviewer was selected from
 product_group: code_review
 product_categories:
 - code_review_workflow
diff --git a/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js b/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js
index 04e741730f4763..538fd17ce9cf9e 100644
--- a/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js
+++ b/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js
@@ -232,6 +232,7 @@ describe('Reviewer dropdown component', () => {
           'user_selects_reviewer_from_mr_sidebar',
           expect.objectContaining({
             value: 1,
+            extra: { selectable_count: 2 },
           }),
         );
       });
@@ -252,6 +253,7 @@ describe('Reviewer dropdown component', () => {
           'user_selects_reviewer_from_mr_sidebar',
           expect.objectContaining({
             value: 1,
+            extra: { selectable_count: 1 },
           }),
         );
       });
@@ -266,6 +268,7 @@ describe('Reviewer dropdown component', () => {
           'user_selects_reviewer_from_mr_sidebar_after_search',
           expect.objectContaining({
             value: 2,
+            extra: { selectable_count: 2 },
           }),
         );
       });
-- 
GitLab


From bfb4cc77620e0e2c31fb4cca9d925c38e53ebac7 Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Tue, 11 Feb 2025 11:17:15 -0700
Subject: [PATCH 6/8] Move tracking events to external constants file

MR review
---
 .../components/reviewers/reviewer_dropdown.vue             | 7 ++++---
 app/assets/javascripts/merge_requests/constants.js         | 3 +++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
index 5870b07e8db971..fb357d7f21fd4a 100644
--- a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
+++ b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
@@ -8,6 +8,9 @@ import { TYPENAME_MERGE_REQUEST } from '~/graphql_shared/constants';
 import { convertToGraphQLId } from '~/graphql_shared/utils';
 import userAutocompleteWithMRPermissionsQuery from '~/graphql_shared/queries/project_autocomplete_users_with_mr_permissions.query.graphql';
 import InviteMembersTrigger from '~/invite_members/components/invite_members_trigger.vue';
+
+import { SEARCH_SELECT_REVIEWER_EVENT, SELECT_REVIEWER_EVENT } from '../../constants';
+
 import UpdateReviewers from './update_reviewers.vue';
 import userPermissionsQuery from './queries/user_permissions.query.graphql';
 
@@ -154,9 +157,7 @@ export default {
       this.currentSelectedReviewers = [];
     },
     trackReviewersSelectEvent() {
-      const telemetryEvent = this.search
-        ? 'user_selects_reviewer_from_mr_sidebar_after_search'
-        : 'user_selects_reviewer_from_mr_sidebar';
+      const telemetryEvent = this.search ? SEARCH_SELECT_REVIEWER_EVENT : SELECT_REVIEWER_EVENT;
       const previousUsernames = toUsernames(this.selectedReviewers);
       const listUsernames = toUsernames(this.usersForList);
       // Reviewers are always shown first if they are in the list,
diff --git a/app/assets/javascripts/merge_requests/constants.js b/app/assets/javascripts/merge_requests/constants.js
index 83293ad5a364c2..05d39b28d2790c 100644
--- a/app/assets/javascripts/merge_requests/constants.js
+++ b/app/assets/javascripts/merge_requests/constants.js
@@ -1 +1,4 @@
 export const MAX_LIST_SIZE = 10;
+
+export const SELECT_REVIEWER_EVENT = 'user_selects_reviewer_from_mr_sidebar';
+export const SEARCH_SELECT_REVIEWER_EVENT = 'user_selects_reviewer_from_mr_sidebar_after_search';
-- 
GitLab


From f544500ad17da5218cd2e1a7c81428b7604588ec Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Tue, 11 Feb 2025 11:17:44 -0700
Subject: [PATCH 7/8] Rename extra field to selectable_reviewers_count

MR review
---
 .../merge_requests/components/reviewers/reviewer_dropdown.vue   | 2 +-
 config/events/user_selects_reviewer_from_mr_sidebar.yml         | 2 +-
 .../user_selects_reviewer_from_mr_sidebar_after_search.yml      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
index fb357d7f21fd4a..7cbb528de5bd7d 100644
--- a/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
+++ b/app/assets/javascripts/merge_requests/components/reviewers/reviewer_dropdown.vue
@@ -171,7 +171,7 @@ export default {
 
         this.trackEvent(telemetryEvent, {
           value: listPosition,
-          selectable_count: selectableList.length,
+          selectable_reviewers_count: selectableList.length,
         });
       });
     },
diff --git a/config/events/user_selects_reviewer_from_mr_sidebar.yml b/config/events/user_selects_reviewer_from_mr_sidebar.yml
index d7bf5374e929a8..c48d46748f3a7e 100644
--- a/config/events/user_selects_reviewer_from_mr_sidebar.yml
+++ b/config/events/user_selects_reviewer_from_mr_sidebar.yml
@@ -9,7 +9,7 @@ identifiers:
 additional_properties:
   value:
     description: List position of the selected user
-  selectable_count:
+  selectable_reviewers_count:
     description: The total number of selectable reviewers in the list this reviewer was selected from
 product_group: code_review
 product_categories:
diff --git a/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml b/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml
index 1b2a9258572584..1b5157e93ffeb7 100644
--- a/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml
+++ b/config/events/user_selects_reviewer_from_mr_sidebar_after_search.yml
@@ -9,7 +9,7 @@ identifiers:
 additional_properties:
   value:
     description: List position of the selected user
-  selectable_count:
+  selectable_reviewers_count:
     description: The total number of selectable reviewers in the list this reviewer was selected from
 product_group: code_review
 product_categories:
-- 
GitLab


From 4fe325795c9d7bad2fa58b8ff858f1c6222bda95 Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Tue, 11 Feb 2025 11:19:33 -0700
Subject: [PATCH 8/8] Switch from mockTracking to useMockInternalEventsTracking
 and bindInternalEventDocument

---
 .../reviewers/reviewer_dropdown_spec.js       | 37 ++++++++++---------
 1 file changed, 20 insertions(+), 17 deletions(-)

diff --git a/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js b/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js
index 538fd17ce9cf9e..240b00c71f21bc 100644
--- a/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js
+++ b/spec/frontend/merge_requests/components/reviewers/reviewer_dropdown_spec.js
@@ -5,12 +5,15 @@ import { shallowMount } from '@vue/test-utils';
 import createMockApollo from 'helpers/mock_apollo_helper';
 import waitForPromises from 'helpers/wait_for_promises';
 import { mockTracking, triggerEvent } from 'helpers/tracking_helper';
+import { useMockInternalEventsTracking } from 'helpers/tracking_internal_events_helper';
 import ReviewerDropdown from '~/merge_requests/components/reviewers/reviewer_dropdown.vue';
 import UpdateReviewers from '~/merge_requests/components/reviewers/update_reviewers.vue';
 import userPermissionsQuery from '~/merge_requests/components/reviewers/queries/user_permissions.query.graphql';
 import userAutocompleteWithMRPermissionsQuery from '~/graphql_shared/queries/project_autocomplete_users_with_mr_permissions.query.graphql';
 import setReviewersMutation from '~/merge_requests/components/reviewers/queries/set_reviewers.mutation.graphql';
 
+const { bindInternalEventDocument } = useMockInternalEventsTracking();
+
 let wrapper;
 let autocompleteUsersMock;
 let setReviewersMutationMock;
@@ -211,7 +214,7 @@ describe('Reviewer dropdown component', () => {
     });
 
     describe('tracking when the dropdown is closed', () => {
-      let trackingSpy;
+      let trackEventSpy;
 
       beforeEach(async () => {
         createComponent(true, {
@@ -220,20 +223,20 @@ describe('Reviewer dropdown component', () => {
 
         await waitForPromises();
 
-        trackingSpy = mockTracking(undefined, window.document, jest.spyOn);
+        ({ trackEventSpy } = bindInternalEventDocument(wrapper.element));
       });
 
       it('tracks which position any selected users were in as a telemetry event', () => {
         findDropdown().vm.$emit('select', ['root']);
         findDropdown().vm.$emit('hidden');
 
-        expect(trackingSpy).toHaveBeenCalledWith(
-          undefined,
+        expect(trackEventSpy).toHaveBeenCalledWith(
           'user_selects_reviewer_from_mr_sidebar',
-          expect.objectContaining({
+          {
             value: 1,
-            extra: { selectable_count: 2 },
-          }),
+            selectable_reviewers_count: 2,
+          },
+          undefined,
         );
       });
 
@@ -248,13 +251,13 @@ describe('Reviewer dropdown component', () => {
         findDropdown().vm.$emit('select', ['bob']);
         findDropdown().vm.$emit('hidden');
 
-        expect(trackingSpy).toHaveBeenCalledWith(
-          undefined,
+        expect(trackEventSpy).toHaveBeenCalledWith(
           'user_selects_reviewer_from_mr_sidebar',
-          expect.objectContaining({
+          {
             value: 1,
-            extra: { selectable_count: 1 },
-          }),
+            selectable_reviewers_count: 1,
+          },
+          undefined,
         );
       });
 
@@ -263,13 +266,13 @@ describe('Reviewer dropdown component', () => {
         findDropdown().vm.$emit('select', ['bob']);
         findDropdown().vm.$emit('hidden');
 
-        expect(trackingSpy).toHaveBeenCalledWith(
-          undefined,
+        expect(trackEventSpy).toHaveBeenCalledWith(
           'user_selects_reviewer_from_mr_sidebar_after_search',
-          expect.objectContaining({
+          {
             value: 2,
-            extra: { selectable_count: 2 },
-          }),
+            selectable_reviewers_count: 2,
+          },
+          undefined,
         );
       });
     });
-- 
GitLab