From 7dbedb9fa660716e9d5ce3e7480c993fd7b2952e Mon Sep 17 00:00:00 2001 From: Alana Bellucci Date: Thu, 20 Mar 2025 12:00:31 -0600 Subject: [PATCH 1/2] Updating REST API endpoint `pre_receive_secret_detection_enabled` is deprecated --- .../17-9-pre_receive_secret_detection_enabled-REST-API.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/data/deprecations/17-9-pre_receive_secret_detection_enabled-REST-API.yml b/data/deprecations/17-9-pre_receive_secret_detection_enabled-REST-API.yml index 7d99337a06017d..7b28b2678e2f51 100644 --- a/data/deprecations/17-9-pre_receive_secret_detection_enabled-REST-API.yml +++ b/data/deprecations/17-9-pre_receive_secret_detection_enabled-REST-API.yml @@ -1,7 +1,6 @@ - title: "REST API endpoint `pre_receive_secret_detection_enabled` is deprecated" - removal_milestone: "18.0" announcement_milestone: "17.9" - breaking_change: true + breaking_change: false window: "3" reporter: abellucci stage: application_security_testing -- GitLab From 84d4ca39cb72027fff5b2a1d3c00ffbad622756e Mon Sep 17 00:00:00 2001 From: phillipwells Date: Thu, 20 Mar 2025 13:26:42 -0500 Subject: [PATCH 2/2] Update deprecations docs --- .../17-9-pre_receive_secret_detection_enabled-REST-API.yml | 2 +- doc/update/breaking_windows.md | 1 - doc/update/deprecations.md | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/data/deprecations/17-9-pre_receive_secret_detection_enabled-REST-API.yml b/data/deprecations/17-9-pre_receive_secret_detection_enabled-REST-API.yml index 7b28b2678e2f51..0e780d624aea79 100644 --- a/data/deprecations/17-9-pre_receive_secret_detection_enabled-REST-API.yml +++ b/data/deprecations/17-9-pre_receive_secret_detection_enabled-REST-API.yml @@ -1,7 +1,7 @@ - title: "REST API endpoint `pre_receive_secret_detection_enabled` is deprecated" announcement_milestone: "17.9" + removal_milestone: "18.0" breaking_change: false - window: "3" reporter: abellucci stage: application_security_testing issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/514413 diff --git a/doc/update/breaking_windows.md b/doc/update/breaking_windows.md index 7731b58f42e9f8..91924a176bb99f 100644 --- a/doc/update/breaking_windows.md +++ b/doc/update/breaking_windows.md @@ -95,7 +95,6 @@ This window takes place on May 5 - 7, 2025 from 09:00 UTC to 22:00 UTC. | [Increased default security for use of pipeline variables](https://gitlab.com/gitlab-org/gitlab/-/issues/502382) | Medium | Verify | Project | | [Amazon S3 Signature Version 2](https://gitlab.com/gitlab-org/container-registry/-/issues/1449) | Low | Package | Project | | [Dependency Proxy token scope enforcement](https://gitlab.com/gitlab-org/gitlab/-/issues/426887) | High | Package | Group | -| [REST API endpoint `pre_receive_secret_detection_enabled` is deprecated](https://gitlab.com/gitlab-org/gitlab/-/issues/514413) | Medium | Application_security_testing | Instance | | [Remove duoProAssignedUsersCount GraphQL field](https://gitlab.com/gitlab-org/gitlab/-/issues/498671) | Low | Plan | Group, project | | [S3 storage driver (AWS SDK v1) for the container registry](https://gitlab.com/gitlab-org/gitlab/-/issues/523095) | Low | Package | Instance | | [Remove `previousStageJobsOrNeeds` from GraphQL](https://gitlab.com/gitlab-org/gitlab/-/issues/424417) | Low | Verify | Instance | diff --git a/doc/update/deprecations.md b/doc/update/deprecations.md index 066f790fa888b2..079221c5542d17 100644 --- a/doc/update/deprecations.md +++ b/doc/update/deprecations.md @@ -1524,14 +1524,14 @@ to ensure the correct locations are being used to mirror the required scanner im -
+
### REST API endpoint `pre_receive_secret_detection_enabled` is deprecated
- Announced in GitLab 17.9 -- Removal in GitLab 18.0 ([breaking change](https://docs.gitlab.com/update/terminology/#breaking-change)) +- Removal in GitLab 18.0 - To discuss this change or learn more, see the [deprecation issue](https://gitlab.com/gitlab-org/gitlab/-/issues/514413).
-- GitLab