From 3d1dcae5c2c96ab70964f5560eceaf9b4fdc5c04 Mon Sep 17 00:00:00 2001 From: Alex Pennells Date: Tue, 5 Nov 2024 10:46:11 -0500 Subject: [PATCH] Remove `vsa_standalone_settings_page` feature flag Removes the feature flag and code related to the old modal UX. Changelog: removed EE: true --- .../javascripts/analytics/shared/utils.js | 2 - .../group/value_stream_analytics/index.md | 10 - .../components/value_stream_empty_state.vue | 23 +- .../components/value_stream_form.vue | 51 -- .../components/value_stream_form_content.vue | 460 ------------- .../components/value_stream_select.vue | 47 +- .../store/actions/value_streams.js | 10 +- .../cycle_analytics/vsa_settings/index.js | 5 +- .../value_streams_controller.rb | 4 - .../ee/projects/cycle_analytics_controller.rb | 6 - .../value_streams_controller.rb | 4 - .../analytics/cycle_analytics_controller.rb | 2 - .../beta/vsa_standalone_settings_page.yml | 9 - .../multiple_value_streams_spec.rb | 32 - .../value_stream_empty_state_spec.js | 29 - .../value_stream_form_content_spec.js | 644 ------------------ .../components/value_stream_form_spec.js | 101 --- .../components/value_stream_select_spec.js | 85 +-- .../store/actions/value_streams_spec.js | 21 +- qa/qa/ee/page/value_stream_analytics.rb | 11 +- 20 files changed, 17 insertions(+), 1539 deletions(-) delete mode 100644 ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_form.vue delete mode 100644 ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_form_content.vue delete mode 100644 ee/config/feature_flags/beta/vsa_standalone_settings_page.yml delete mode 100644 ee/spec/frontend/analytics/cycle_analytics/components/value_stream_form_content_spec.js delete mode 100644 ee/spec/frontend/analytics/cycle_analytics/components/value_stream_form_spec.js diff --git a/app/assets/javascripts/analytics/shared/utils.js b/app/assets/javascripts/analytics/shared/utils.js index 98ad20b9b14bae..57556daf6f2e11 100644 --- a/app/assets/javascripts/analytics/shared/utils.js +++ b/app/assets/javascripts/analytics/shared/utils.js @@ -148,6 +148,4 @@ export const extractVSAFeaturesFromGON = () => ({ cycleAnalyticsForGroups: Boolean(gon?.licensed_features?.cycleAnalyticsForGroups), cycleAnalyticsForProjects: Boolean(gon?.licensed_features?.cycleAnalyticsForProjects), groupLevelAnalyticsDashboard: Boolean(gon?.licensed_features?.groupLevelAnalyticsDashboard), - // feature flags - vsaStandaloneSettingsPage: Boolean(gon?.features?.vsaStandaloneSettingsPage), }); diff --git a/doc/user/group/value_stream_analytics/index.md b/doc/user/group/value_stream_analytics/index.md index 626b153ed20757..5ddd8cd4ba190a 100644 --- a/doc/user/group/value_stream_analytics/index.md +++ b/doc/user/group/value_stream_analytics/index.md @@ -449,11 +449,6 @@ DETAILS: **Tier:** Premium, Ultimate **Offering:** GitLab.com, Self-managed, GitLab Dedicated -> - **New value stream** feature [changed](https://gitlab.com/gitlab-org/gitlab/-/issues/381002) from a dialog to a page in GitLab 16.11 [with a flag](../../../administration/feature_flags.md) named `vsa_standalone_settings_page`. Disabled by default. - -FLAG: -On self-managed GitLab, by default the **New value stream** feature is not available. To make it available, an administrator can enable the [feature flag](../../../administration/feature_flags.md) named `vsa_standalone_settings_page`. On GitLab.com and GitLab Dedicated, this feature is not available. This feature is not ready for production use. - ### Create a value stream with GitLab default stages When you create a value stream, you can use GitLab default stages and hide or re-order them. You can also @@ -520,11 +515,6 @@ DETAILS: **Tier:** Premium, Ultimate **Offering:** GitLab.com, Self-managed, GitLab Dedicated -> - **Edit value stream** feature [changed](https://gitlab.com/gitlab-org/gitlab/-/issues/381002) from a dialog to a page in GitLab 16.11 [with a flag](../../../administration/feature_flags.md) named `vsa_standalone_settings_page`. Disabled by default. - -FLAG: -On self-managed GitLab, by default the **Edit value stream** feature is not available. To make it available, an administrator can enable the [feature flag](../../../administration/feature_flags.md) named `vsa_standalone_settings_page`. On GitLab.com and GitLab Dedicated, this feature is not available. This feature is not ready for production use. - After you create a value stream, you can customize it to suit your purposes. To edit a value stream: 1. On the left sidebar, select **Search or go to** and find your project or group. diff --git a/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_empty_state.vue b/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_empty_state.vue index cb12a88fead031..550966f513aecc 100644 --- a/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_empty_state.vue +++ b/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_empty_state.vue @@ -1,8 +1,7 @@ - diff --git a/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_form_content.vue b/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_form_content.vue deleted file mode 100644 index 2a46a0bd82f251..00000000000000 --- a/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_form_content.vue +++ /dev/null @@ -1,460 +0,0 @@ - - diff --git a/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_select.vue b/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_select.vue index 7cad17a44a15d4..621093c851cd4c 100644 --- a/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_select.vue +++ b/ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_select.vue @@ -12,8 +12,6 @@ import { mapState, mapActions } from 'vuex'; import { slugifyWithUnderscore } from '~/lib/utils/text_utility'; import { sprintf, __, s__ } from '~/locale'; import Tracking from '~/tracking'; -import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; -import ValueStreamForm from './value_stream_form.vue'; const i18n = { DELETE_NAME: s__('DeleteValueStream|Delete %{name}'), @@ -34,12 +32,11 @@ export default { GlCollapsibleListbox, GlModal, GlSprintf, - ValueStreamForm, }, directives: { GlModalDirective, }, - mixins: [Tracking.mixin(), glFeatureFlagsMixin()], + mixins: [Tracking.mixin()], inject: ['newValueStreamPath', 'editValueStreamPath'], props: { canEdit: { @@ -48,12 +45,6 @@ export default { default: false, }, }, - data() { - return { - showForm: false, - isEditing: false, - }; - }, computed: { ...mapState({ isDeleting: 'isDeletingValueStream', @@ -83,20 +74,11 @@ export default { name: this.selectedValueStreamName, }); }, - isVSAStandaloneSettingsPageEnabled() { - return this.glFeatures?.vsaStandaloneSettingsPage; - }, - createValueStreamButtonHref() { - return this.isVSAStandaloneSettingsPageEnabled ? this.newValueStreamPath : null; - }, editValueStreamButtonHref() { - if (!this.isVSAStandaloneSettingsPageEnabled || !this.selectedValueStreamId) return null; + if (!this.selectedValueStreamId) return null; return this.editValueStreamPath.replace(':id', this.selectedValueStreamId); }, - valueStreamFormModalId() { - return !this.isVSAStandaloneSettingsPageEnabled && 'value-stream-form-modal'; - }, }, methods: { ...mapActions(['setSelectedValueStream', 'deleteValueStream']), @@ -120,20 +102,6 @@ export default { } }); }, - onCreate() { - if (!this.isVSAStandaloneSettingsPageEnabled) { - this.showForm = true; - } - - this.isEditing = false; - }, - onEdit() { - if (!this.isVSAStandaloneSettingsPageEnabled) { - this.showForm = true; - } - - this.isEditing = true; - }, slugify(valueStreamTitle) { return slugifyWithUnderscore(valueStreamTitle); }, @@ -155,14 +123,12 @@ export default {