diff --git a/app/assets/javascripts/projects/pipelines/charts/components/pipeline_charts.vue b/app/assets/javascripts/projects/pipelines/charts/components/pipeline_charts.vue index 6422b4ac8d889b526dad9fa0935f2eae4cdf1dd1..20ae0a7fc83e561229a21049d3d8cdd9a0acad1b 100644 --- a/app/assets/javascripts/projects/pipelines/charts/components/pipeline_charts.vue +++ b/app/assets/javascripts/projects/pipelines/charts/components/pipeline_charts.vue @@ -324,48 +324,38 @@ export default { failure.text }}
-

{{ s__('PipelineCharts|CI/CD Analytics') }}

+

{{ s__('PipelineCharts|CI/CD Analytics') }}

-

{{ s__('PipelineCharts|Overall statistics') }}

-
-
- - -
-
- {{ __('Pipeline durations for the last 30 commits') }} - -
-
- + + +

{{ __('Pipelines charts') }}

+ + + + +

{{ __('Pipeline durations for the last 30 commits') }}

+ diff --git a/app/assets/javascripts/projects/pipelines/charts/components/statistics_list.vue b/app/assets/javascripts/projects/pipelines/charts/components/statistics_list.vue index f921b2dfdd63c477e025cec988dabb919d921b77..714e0ff8c1f8e3de50d66379ad308676ad52899c 100644 --- a/app/assets/javascripts/projects/pipelines/charts/components/statistics_list.vue +++ b/app/assets/javascripts/projects/pipelines/charts/components/statistics_list.vue @@ -1,13 +1,15 @@ diff --git a/locale/gitlab.pot b/locale/gitlab.pot index 63c0e7aeabf985b699558ce9765e575b07359eb6..1228992607fc6eb7418deaff88de74aa9bedebed 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -1662,11 +1662,6 @@ msgid_plural "%{merge_requests} open merge requests" msgstr[0] "" msgstr[1] "" -msgid "1 pipeline" -msgid_plural "%d pipelines" -msgstr[0] "" -msgstr[1] "" - msgid "1 role" msgid_plural "%d roles" msgstr[0] "" @@ -36038,22 +36033,19 @@ msgstr "" msgid "PipelineCharts|CI/CD Analytics" msgstr "" -msgid "PipelineCharts|Failed:" +msgid "PipelineCharts|Failed pipelines" msgstr "" -msgid "PipelineCharts|Overall statistics" +msgid "PipelineCharts|Success ratio" msgstr "" -msgid "PipelineCharts|Success ratio:" -msgstr "" - -msgid "PipelineCharts|Successful:" +msgid "PipelineCharts|Successful pipelines" msgstr "" msgid "PipelineCharts|There was an error parsing the data for the charts." msgstr "" -msgid "PipelineCharts|Total:" +msgid "PipelineCharts|Total pipelines" msgstr "" msgid "PipelineEditorFileTree|Configuration files added with the include keyword" @@ -36842,6 +36834,9 @@ msgstr "" msgid "Pipeline|Running" msgstr "" +msgid "Pipeline|See details" +msgstr "" + msgid "Pipeline|Skipped" msgstr "" diff --git a/spec/features/projects/graph_spec.rb b/spec/features/projects/graph_spec.rb index effe743ac81e270f199bd0716b25683548fbdeae..dbafd236b21ffa756266a94eecdc6239294b2149 100644 --- a/spec/features/projects/graph_spec.rb +++ b/spec/features/projects/graph_spec.rb @@ -95,7 +95,7 @@ end it 'renders CI graphs' do - expect(page).to have_content 'Overall' + expect(page).to have_content 'CI/CD Analytics' expect(page).to have_content 'Last week' expect(page).to have_content 'Last month' expect(page).to have_content 'Last year' diff --git a/spec/frontend/projects/pipelines/charts/components/__snapshots__/statistics_list_spec.js.snap b/spec/frontend/projects/pipelines/charts/components/__snapshots__/statistics_list_spec.js.snap index a2877a9f17c78c261174e01b8ba6395377a2ff1e..c47579185e1a4069636022bb36e90919c89474c4 100644 --- a/spec/frontend/projects/pipelines/charts/components/__snapshots__/statistics_list_spec.js.snap +++ b/spec/frontend/projects/pipelines/charts/components/__snapshots__/statistics_list_spec.js.snap @@ -1,40 +1,66 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`StatisticsList displays the counts data with labels 1`] = ` -
    -
  • - - Total: - - - 40,000 pipelines - -
  • -
  • - - Successful: - - - 20,000 pipelines - -
  • -
  • - - Failed: - +
    +
    + +
    +
    + +
    +
    + +
    +
    + - 20,000 pipelines + See details -
  • -
  • - - Success ratio: - - - 50.00% - -
  • -
+ + `; diff --git a/spec/frontend/projects/pipelines/charts/components/statistics_list_spec.js b/spec/frontend/projects/pipelines/charts/components/statistics_list_spec.js index 24dbc628ce693942452beaadbb3037a692fce444..02560fa3fa12b97478274d273dad1566c64a9d15 100644 --- a/spec/frontend/projects/pipelines/charts/components/statistics_list_spec.js +++ b/spec/frontend/projects/pipelines/charts/components/statistics_list_spec.js @@ -28,4 +28,18 @@ describe('StatisticsList', () => { it('displays failed pipelines link', () => { expect(findFailedPipelinesLink().attributes('href')).toBe(failedPipelinesLink); }); + + describe('with no failed piplines link', () => { + beforeEach(() => { + wrapper = shallowMount(Component, { + propsData: { + counts, + }, + }); + }); + + it('hides the failed pipelines link', () => { + expect(findFailedPipelinesLink().exists()).toBe(false); + }); + }); });