From d8e43c2d9945088cbb3392f1cf6765dfafd75569 Mon Sep 17 00:00:00 2001 From: Adam Hegyi Date: Wed, 6 Mar 2024 13:13:48 +0100 Subject: [PATCH] Remove issues_completed_analytics_feature_flag FF This change removes the issues_completed_analytics_feature_flag feature flag. Changelog: removed --- doc/user/group/issues_analytics/index.md | 4 +--- ee/app/controllers/groups/issues_analytics_controller.rb | 3 --- .../projects/analytics/issues_analytics_controller.rb | 3 --- .../issues_completed_analytics_feature_flag.yml | 8 -------- 4 files changed, 1 insertion(+), 17 deletions(-) delete mode 100644 ee/config/feature_flags/development/issues_completed_analytics_feature_flag.yml diff --git a/doc/user/group/issues_analytics/index.md b/doc/user/group/issues_analytics/index.md index 2c05a6ed9d565a..96604956c6b801 100644 --- a/doc/user/group/issues_analytics/index.md +++ b/doc/user/group/issues_analytics/index.md @@ -50,9 +50,7 @@ DETAILS: > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/233905/) in GitLab 16.3 [with a flag](../../../administration/feature_flags.md) named `issues_completed_analytics_feature_flag`. Disabled by default. > - [Enabled on GitLab.com and self-managed](https://gitlab.com/gitlab-org/gitlab/-/issues/437542) in GitLab 16.8. - -FLAG: -On self-managed GitLab, by default this feature is available. To hide the feature, an administrator can [disable the feature flag](../../../administration/feature_flags.md) named `issues_completed_analytics_feature_flag`. On GitLab.com and GitLab Dedicated, this feature is available. +> - [Feature flag `issues_completed_analytics_feature_flag`](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/146766) removed in GitLab 16.10. Enhanced issue analytics display the additional metric "Issues closed", which represents the total number of resolved issues in your group over a selected period. You can use this metric to improve the overall turn-around time and value delivered to your customers. diff --git a/ee/app/controllers/groups/issues_analytics_controller.rb b/ee/app/controllers/groups/issues_analytics_controller.rb index 55085e5d295599..3609f7263597f4 100644 --- a/ee/app/controllers/groups/issues_analytics_controller.rb +++ b/ee/app/controllers/groups/issues_analytics_controller.rb @@ -6,9 +6,6 @@ class Groups::IssuesAnalyticsController < Groups::ApplicationController before_action :authorize_read_group! before_action :authorize_read_issue_analytics! - before_action do - push_frontend_feature_flag(:issues_completed_analytics_feature_flag, @group) - end track_event :show, name: 'g_analytics_issues', diff --git a/ee/app/controllers/projects/analytics/issues_analytics_controller.rb b/ee/app/controllers/projects/analytics/issues_analytics_controller.rb index da943f92b9e92f..af411d455bfe26 100644 --- a/ee/app/controllers/projects/analytics/issues_analytics_controller.rb +++ b/ee/app/controllers/projects/analytics/issues_analytics_controller.rb @@ -5,9 +5,6 @@ class Projects::Analytics::IssuesAnalyticsController < Projects::ApplicationCont include ProductAnalyticsTracking before_action :authorize_read_issue_analytics! - before_action do - push_frontend_feature_flag(:issues_completed_analytics_feature_flag, project) - end track_event :show, name: 'p_analytics_issues', diff --git a/ee/config/feature_flags/development/issues_completed_analytics_feature_flag.yml b/ee/config/feature_flags/development/issues_completed_analytics_feature_flag.yml deleted file mode 100644 index 63f7a2108a6754..00000000000000 --- a/ee/config/feature_flags/development/issues_completed_analytics_feature_flag.yml +++ /dev/null @@ -1,8 +0,0 @@ ---- -name: issues_completed_analytics_feature_flag -introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/128399 -rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/420928 -milestone: '16.3' -type: development -group: group::optimize -default_enabled: true -- GitLab