From f47c45dfbeb001518aef3cd5bcecb30959d58ece Mon Sep 17 00:00:00 2001
From: Julia Miocene <jmiocene@gitlab.com>
Date: Mon, 4 Mar 2024 22:22:58 +0100
Subject: [PATCH] Update service desk empty state illustration

Changelog: changed
---
 app/assets/images/service_desk_callout.svg                    | 1 -
 .../components/empty_state_without_any_issues.vue             | 4 ----
 app/helpers/issues_helper.rb                                  | 2 +-
 app/views/projects/issues/service_desk.html.haml              | 2 +-
 app/views/shared/promotions/_promote_servicedesk.html.haml    | 2 +-
 .../components/empty_state_without_any_issues_spec.js         | 2 --
 6 files changed, 3 insertions(+), 10 deletions(-)
 delete mode 100644 app/assets/images/service_desk_callout.svg

diff --git a/app/assets/images/service_desk_callout.svg b/app/assets/images/service_desk_callout.svg
deleted file mode 100644
index 2886388279ee43..00000000000000
--- a/app/assets/images/service_desk_callout.svg
+++ /dev/null
@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="78" height="82" viewBox="0 0 78 82"><g fill="none" fill-rule="evenodd"><path fill="#F9F9F9" d="M2.12 42c-.08.99-.12 1.99-.12 3 0 20.435 16.565 37 37 37s37-16.565 37-37c0-1.01-.04-2.01-.12-3C74.353 61.032 58.425 76 39 76 19.575 76 3.647 61.032 2.12 42z"/><path fill="#EEE" fill-rule="nonzero" d="M39 78C17.46 78 0 60.54 0 39S17.46 0 39 0s39 17.46 39 39-17.46 39-39 39zm0-4c19.33 0 35-15.67 35-35S58.33 4 39 4 4 19.67 4 39s15.67 35 35 35z"/><rect width="7" height="1" x="59" y="38" fill="#E1DBF2" rx=".5"/><path fill="#6B4FBB" d="M60.5 42a3.5 3.5 0 0 0 0-7v7z"/><rect width="7" height="1" x="12" y="38" fill="#E1DBF2" transform="matrix(-1 0 0 1 31 0)" rx=".5"/><path fill="#6B4FBB" d="M17.5 42a3.5 3.5 0 0 1 0-7v7z"/><path fill="#E1DBF1" fill-rule="nonzero" d="M39 58c10.493 0 19-8.507 19-19s-8.507-19-19-19-19 8.507-19 19 8.507 19 19 19zm0 4c-12.703 0-23-10.297-23-23s10.297-23 23-23 23 10.297 23 23-10.297 23-23 23z"/><path fill="#6B4FBB" d="M35 56a1 1 0 1 1 0-2 1 1 0 0 1 0 2zm4 0a1 1 0 1 1 0-2 1 1 0 0 1 0 2zm4 0a1 1 0 1 1 0-2 1 1 0 0 1 0 2z"/><path fill="#E1DBF1" fill-rule="nonzero" d="M26.5 40c0 4.143 3.355 7.5 7.494 7.5h10.012A7.497 7.497 0 0 0 51.5 40c0-4.143-3.355-7.5-7.494-7.5H33.994A7.497 7.497 0 0 0 26.5 40zm-3 0c0-5.799 4.698-10.5 10.494-10.5h10.012C49.802 29.5 54.5 34.2 54.5 40c0 5.799-4.698 10.5-10.494 10.5H33.994C28.198 50.5 23.5 45.8 23.5 40z"/><path fill="#6B4FBB" fill-rule="nonzero" d="M35.255 42.406a1 1 0 1 1 1.872-.703 2.001 2.001 0 0 0 3.76-.038 1 1 0 1 1 1.886.665 4 4 0 0 1-7.518.076zM31.5 40a1.5 1.5 0 1 1 0-3 1.5 1.5 0 0 1 0 3zm15 0a1.5 1.5 0 1 1 0-3 1.5 1.5 0 0 1 0 3z"/><path fill="#6B4FBB" d="M38 22h2a1 1 0 0 1 0 2h-2a1 1 0 0 1 0-2zm0 3h2a1 1 0 0 1 0 2h-2a1 1 0 0 1 0-2z" style="mix-blend-mode:multiply"/></g></svg>
\ No newline at end of file
diff --git a/app/assets/javascripts/issues/service_desk/components/empty_state_without_any_issues.vue b/app/assets/javascripts/issues/service_desk/components/empty_state_without_any_issues.vue
index ea866dfb1612cd..453d9d1bcda9b7 100644
--- a/app/assets/javascripts/issues/service_desk/components/empty_state_without_any_issues.vue
+++ b/app/assets/javascripts/issues/service_desk/components/empty_state_without_any_issues.vue
@@ -42,8 +42,6 @@ export default {
     <gl-empty-state
       :title="$options.i18n.infoBannerTitle"
       :svg-path="emptyStateSvgPath"
-      :svg-height="null"
-      content-class="gl-max-w-80!"
       data-testid="issues-service-desk-empty-state"
     >
       <template #description>
@@ -62,10 +60,8 @@ export default {
     v-else
     :title="$options.i18n.infoBannerTitle"
     :svg-path="emptyStateSvgPath"
-    :svg-height="null"
     :primary-button-text="$options.i18n.noIssuesSignedOutButtonText"
     :primary-button-link="signInPath"
-    content-class="gl-max-w-80!"
     data-testid="issues-service-desk-empty-state"
   >
     <template #description>
diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index a9bafa3b6e8490..9c6554d5cded5a 100644
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -135,7 +135,7 @@ def common_issues_list_data(namespace, current_user)
     {
       autocomplete_award_emojis_path: autocomplete_award_emojis_path,
       calendar_path: url_for(safe_params.merge(calendar_url_options)),
-      empty_state_svg_path: image_path('illustrations/empty-state/empty-issues-md.svg'),
+      empty_state_svg_path: image_path('illustrations/empty-state/empty-service-desk-md.svg'),
       full_path: namespace.full_path,
       initial_sort: current_user&.user_preference&.issues_sort,
       is_issue_repositioning_disabled: issue_repositioning_disabled?.to_s,
diff --git a/app/views/projects/issues/service_desk.html.haml b/app/views/projects/issues/service_desk.html.haml
index f3e3b009fffb59..c1174e78e5a244 100644
--- a/app/views/projects/issues/service_desk.html.haml
+++ b/app/views/projects/issues/service_desk.html.haml
@@ -11,7 +11,7 @@
     service_desk_email_address: @project.service_desk_address,
     can_admin_issues: can?(current_user, :admin_issue, @project).to_s,
     can_edit_project_settings: can?(current_user, :admin_project, @project).to_s,
-    service_desk_callout_svg_path: image_path('service_desk_callout.svg'),
+    service_desk_callout_svg_path: image_path('illustrations/service-desk-sm.svg'),
     service_desk_settings_path: edit_project_path(@project, anchor: 'js-service-desk'),
     service_desk_help_path: help_page_path('user/project/service_desk/index'),
     is_service_desk_supported: Gitlab::ServiceDesk.supported?.to_s,
diff --git a/app/views/shared/promotions/_promote_servicedesk.html.haml b/app/views/shared/promotions/_promote_servicedesk.html.haml
index 24071ed0da4c8e..f53b570f6b2f4b 100644
--- a/app/views/shared/promotions/_promote_servicedesk.html.haml
+++ b/app/views/shared/promotions/_promote_servicedesk.html.haml
@@ -1,6 +1,6 @@
 = render Pajamas::BannerComponent.new(banner_options: {class: 'js-service-desk-callout', data: {uid: 'promote_service_desk_dismissed'}, id: 'promote_service_desk'},
   close_options: {'aria-label' => s_('Promotions|Dismiss Service Desk promotion'), class: 'js-close-callout'},
-  svg_path: 'illustrations/service_desk_callout.svg',
+  svg_path: 'illustrations/service-desk-sm.svg',
   button_text: s_('Promotions|Configure Service Desk'), button_link: help_page_path('user/project/service_desk.html', anchor: 'configuring-service-desk')) do |c|
   - c.with_title do
     = _('Improve customer support with Service Desk')
diff --git a/spec/frontend/issues/service_desk/components/empty_state_without_any_issues_spec.js b/spec/frontend/issues/service_desk/components/empty_state_without_any_issues_spec.js
index 7f281d6fbfef3a..3e59c17c9cd058 100644
--- a/spec/frontend/issues/service_desk/components/empty_state_without_any_issues_spec.js
+++ b/spec/frontend/issues/service_desk/components/empty_state_without_any_issues_spec.js
@@ -42,7 +42,6 @@ describe('EmptyStateWithoutAnyIssues component', () => {
       expect(findGlEmptyState().props()).toMatchObject({
         title: infoBannerTitle,
         svgPath: defaultProvide.emptyStateSvgPath,
-        contentClass: 'gl-max-w-80!',
       });
     });
 
@@ -78,7 +77,6 @@ describe('EmptyStateWithoutAnyIssues component', () => {
         svgPath: defaultProvide.emptyStateSvgPath,
         primaryButtonText: noIssuesSignedOutButtonText,
         primaryButtonLink: defaultProvide.signInPath,
-        contentClass: 'gl-max-w-80!',
       });
     });
 
-- 
GitLab