From 61f1a3895438bbc353221c94bc8bf91c49dc6109 Mon Sep 17 00:00:00 2001 From: Sascha Eggenberger Date: Thu, 5 Oct 2023 13:39:54 +0200 Subject: [PATCH 1/2] Refactor CiIcon Refactores CiIcon as SSoT and migrates CiBadgeLink towards it. Changelog: changed --- .../components/job_artifacts_table.vue | 6 +- .../components/details/ci_resource_header.vue | 11 +- .../ci/common/private/job_name_component.vue | 2 +- .../ci/job_details/components/job_header.vue | 6 +- .../components/sidebar/job_container_item.vue | 4 +- .../components/sidebar/stages_dropdown.vue | 8 +- .../components/job_cells/status_cell.vue | 6 +- .../graph/components/job_item.vue | 6 +- .../graph/components/linked_pipeline.vue | 8 +- .../header/pipeline_details_header.vue | 11 +- .../jobs/components/failed_jobs_table.vue | 6 +- .../components/header/pipeline_status.vue | 13 +- .../legacy_pipeline_stage.vue | 13 +- .../linked_pipelines_mini_list.vue | 8 +- .../cells/pipeline_schedule_last_pipeline.vue | 7 +- .../components/pipeline_status_badge.vue | 13 +- .../runner/components/runner_jobs_table.vue | 6 +- .../graphql/show/runner_jobs.query.graphql | 2 +- .../components/environment_item.vue | 2 +- .../ide/components/ide_status_bar.vue | 1 - .../components/jobs/detail/description.vue | 2 - .../ide/components/pipelines/list.vue | 2 +- .../components/related_issuable_item.vue | 2 +- .../components/commit_box_pipeline_status.vue | 12 +- .../components/commit_pipeline_status.vue | 9 +- .../repository/components/last_commit.vue | 8 +- .../terraform/components/states_table.vue | 8 +- .../components/mr_widget_pipeline.vue | 12 +- .../vue_shared/components/ci_badge_link.vue | 157 ----------------- .../vue_shared/components/ci_icon.vue | 129 ++++++++++---- .../stylesheets/page_bundles/build.scss | 8 - app/helpers/ci/status_helper.rb | 91 +++++----- app/views/ci/status/_badge.html.haml | 13 -- app/views/ci/status/_icon.html.haml | 11 +- app/views/projects/branches/_branch.html.haml | 2 +- app/views/projects/ci/builds/_build.html.haml | 2 +- .../_generic_commit_status.html.haml | 2 +- .../issues/_related_branches.html.haml | 4 +- app/views/projects/jobs/_header.html.haml | 2 +- app/views/projects/tags/_tag.html.haml | 2 +- .../runner/components/runner_job_failure.vue | 6 +- .../components/tabs/base_tab.vue | 6 +- .../components/project_pipeline.vue | 15 +- .../components/runner_job_failure_spec.js | 9 +- locale/gitlab.pot | 6 - qa/qa/ee/page/operations_dashboard.rb | 4 +- .../{ci_badge_link.rb => ci_icon.rb} | 10 +- qa/qa/page/project/job/show.rb | 2 +- qa/qa/page/project/pipeline/index.rb | 4 +- qa/qa/page/project/pipeline/show.rb | 2 +- spec/features/admin/admin_jobs_spec.rb | 2 +- spec/features/commits_spec.rb | 2 +- spec/features/dashboard/projects_spec.rb | 4 +- .../user_sees_merge_request_pipelines_spec.rb | 14 +- .../merge_request/user_sees_pipelines_spec.rb | 2 +- .../commit/user_sees_pipelines_tab_spec.rb | 2 +- .../projects/jobs/user_browses_jobs_spec.rb | 8 +- spec/features/projects/jobs_spec.rb | 2 +- .../projects/pipelines/pipeline_spec.rb | 18 +- .../projects/pipelines/pipelines_spec.rb | 16 +- .../components/job_artifacts_table_spec.js | 9 +- .../details/ci_resource_header_spec.js | 7 +- .../ci/common/pipelines_table_spec.js | 10 +- .../job_details/components/job_header_spec.js | 6 +- .../sidebar/stages_dropdown_spec.js | 5 +- .../jobs_page/components/jobs_table_spec.js | 6 +- .../graph/components/job_item_spec.js | 20 +-- .../header/pipeline_details_header_spec.js | 4 +- .../legacy_pipeline_stage_spec.js | 4 +- .../pipeline_schedule_last_pipeline_spec.js | 12 +- .../commit_box_pipeline_status_spec.js | 12 +- .../jobs/detail/description_spec.js | 4 - .../frontend/ide/components/jobs/item_spec.js | 2 +- .../__snapshots__/last_commit_spec.js.snap | 4 +- .../components/ci_badge_link_spec.js | 158 ------------------ .../vue_shared/components/ci_icon_spec.js | 42 +---- spec/helpers/ci/status_helper_spec.rb | 86 ++++------ spec/views/ci/status/_badge.html.haml_spec.rb | 92 ---------- .../commits/_commit.html.haml_spec.rb | 6 +- 79 files changed, 388 insertions(+), 852 deletions(-) delete mode 100644 app/assets/javascripts/vue_shared/components/ci_badge_link.vue delete mode 100644 app/views/ci/status/_badge.html.haml rename qa/qa/page/component/{ci_badge_link.rb => ci_icon.rb} (86%) delete mode 100644 spec/frontend/vue_shared/components/ci_badge_link_spec.js delete mode 100644 spec/views/ci/status/_badge.html.haml_spec.rb diff --git a/app/assets/javascripts/ci/artifacts/components/job_artifacts_table.vue b/app/assets/javascripts/ci/artifacts/components/job_artifacts_table.vue index d8f9eb65236fd9..de37aa431e6079 100644 --- a/app/assets/javascripts/ci/artifacts/components/job_artifacts_table.vue +++ b/app/assets/javascripts/ci/artifacts/components/job_artifacts_table.vue @@ -10,7 +10,7 @@ import { GlFormCheckbox, GlTooltipDirective, } from '@gitlab/ui'; -import CiBadgeLink from '~/vue_shared/components/ci_badge_link.vue'; +import CiIcon from '~/vue_shared/components/ci_icon.vue'; import { createAlert } from '~/alert'; import { getIdFromGraphQLId, convertToGraphQLId } from '~/graphql_shared/utils'; import TimeAgo from '~/vue_shared/components/time_ago_tooltip.vue'; @@ -68,7 +68,7 @@ export default { GlPagination, GlFormCheckbox, TimeAgo, - CiBadgeLink, + CiIcon, JobCheckbox, ArtifactsBulkDelete, BulkDeleteModal, @@ -442,7 +442,7 @@ export default {