From 3762184436c054f5a80633f6df4b4dd5e0526aed Mon Sep 17 00:00:00 2001
From: Payton Burdette <pburdette@gitlab.com>
Date: Mon, 8 May 2023 14:40:11 -0400
Subject: [PATCH] Expose link to runner if admin

Expose link to runner in job sidebar
details if user is an admin.

Changelog: changed
---
 .../job/sidebar/sidebar_detail_row.vue        | 22 ++++++++++++---
 .../sidebar/sidebar_job_details_container.vue | 10 ++++++-
 app/serializers/runner_entity.rb              | 16 ++++++++++-
 .../components/job/sidebar_detail_row_spec.js | 27 +++++++++++++++----
 spec/serializers/runner_entity_spec.rb        | 18 +++++++++++++
 5 files changed, 82 insertions(+), 11 deletions(-)

diff --git a/app/assets/javascripts/jobs/components/job/sidebar/sidebar_detail_row.vue b/app/assets/javascripts/jobs/components/job/sidebar/sidebar_detail_row.vue
index 055673286601bc..0ba34eafa583a4 100644
--- a/app/assets/javascripts/jobs/components/job/sidebar/sidebar_detail_row.vue
+++ b/app/assets/javascripts/jobs/components/job/sidebar/sidebar_detail_row.vue
@@ -22,6 +22,11 @@ export default {
       required: false,
       default: '',
     },
+    path: {
+      type: String,
+      required: false,
+      default: '',
+    },
   },
   computed: {
     hasTitle() {
@@ -35,10 +40,19 @@ export default {
 </script>
 <template>
   <p class="gl-display-flex gl-justify-content-space-between gl-mb-2">
-    <span v-if="hasTitle"
-      ><b>{{ title }}:</b> {{ value }}</span
-    >
-    <gl-link v-if="hasHelpURL" :href="helpUrl" target="_blank">
+    <span v-if="hasTitle">
+      <b>{{ title }}:</b>
+      <gl-link
+        v-if="path"
+        :href="path"
+        class="gl-text-blue-600!"
+        data-testid="job-sidebar-value-link"
+      >
+        {{ value }}
+      </gl-link>
+      <span v-else>{{ value }}</span>
+    </span>
+    <gl-link v-if="hasHelpURL" :href="helpUrl" target="_blank" data-testid="job-sidebar-help-link">
       <gl-icon name="question-o" />
     </gl-link>
   </p>
diff --git a/app/assets/javascripts/jobs/components/job/sidebar/sidebar_job_details_container.vue b/app/assets/javascripts/jobs/components/job/sidebar/sidebar_job_details_container.vue
index 8300a22cb67aba..3cd90eb3bcaee0 100644
--- a/app/assets/javascripts/jobs/components/job/sidebar/sidebar_job_details_container.vue
+++ b/app/assets/javascripts/jobs/components/job/sidebar/sidebar_job_details_container.vue
@@ -70,6 +70,9 @@ export default {
         timeoutSource: this.job.metadata.timeout_source,
       });
     },
+    runnerAdminPath() {
+      return this.job?.runner?.admin_path || '';
+    },
   },
   i18n: {
     COVERAGE: __('Coverage'),
@@ -104,7 +107,12 @@ export default {
       data-testid="job-timeout"
       :title="$options.i18n.TIMEOUT"
     />
-    <detail-row v-if="job.runner" :value="runnerId" :title="$options.i18n.RUNNER" />
+    <detail-row
+      v-if="job.runner"
+      :value="runnerId"
+      :title="$options.i18n.RUNNER"
+      :path="runnerAdminPath"
+    />
     <detail-row v-if="job.coverage" :value="coverage" :title="$options.i18n.COVERAGE" />
 
     <p v-if="hasTags" class="build-detail-row" data-testid="job-tags">
diff --git a/app/serializers/runner_entity.rb b/app/serializers/runner_entity.rb
index 6d6ba920a3bfe2..cf0b2e2c3f6f64 100644
--- a/app/serializers/runner_entity.rb
+++ b/app/serializers/runner_entity.rb
@@ -9,6 +9,10 @@ class RunnerEntity < Grape::Entity
     edit_project_runner_path(project, runner)
   end
 
+  expose :admin_path, if: -> (*) { can_admin_runner? } do |runner|
+    Gitlab::Routing.url_helpers.admin_runner_url(runner)
+  end
+
   private
 
   alias_method :runner, :object
@@ -17,7 +21,17 @@ def project
     request.project
   end
 
+  def current_user
+    request.current_user
+  end
+
   def can_edit_runner?
-    can?(request.current_user, :update_runner, runner) && runner.project_type?
+    can?(current_user, :update_runner, runner) && runner.project_type?
+  end
+
+  # can_admin_all_resources? is used here because the
+  # path exposed is only available to admins
+  def can_admin_runner?
+    current_user&.can_admin_all_resources?
   end
 end
diff --git a/spec/frontend/jobs/components/job/sidebar_detail_row_spec.js b/spec/frontend/jobs/components/job/sidebar_detail_row_spec.js
index dd5a9e3491d7a9..fd27004816a7c3 100644
--- a/spec/frontend/jobs/components/job/sidebar_detail_row_spec.js
+++ b/spec/frontend/jobs/components/job/sidebar_detail_row_spec.js
@@ -1,5 +1,4 @@
-import { GlLink } from '@gitlab/ui';
-import { shallowMount } from '@vue/test-utils';
+import { shallowMountExtended } from 'helpers/vue_test_utils_helper';
 import SidebarDetailRow from '~/jobs/components/job/sidebar/sidebar_detail_row.vue';
 
 describe('Sidebar detail row', () => {
@@ -8,18 +7,20 @@ describe('Sidebar detail row', () => {
   const title = 'this is the title';
   const value = 'this is the value';
   const helpUrl = 'https://docs.gitlab.com/runner/register/index.html';
+  const path = 'path/to/value';
 
-  const findHelpLink = () => wrapper.findComponent(GlLink);
+  const findHelpLink = () => wrapper.findByTestId('job-sidebar-help-link');
+  const findValueLink = () => wrapper.findByTestId('job-sidebar-value-link');
 
   const createComponent = (props) => {
-    wrapper = shallowMount(SidebarDetailRow, {
+    wrapper = shallowMountExtended(SidebarDetailRow, {
       propsData: {
         ...props,
       },
     });
   };
 
-  describe('with title/value and without helpUrl', () => {
+  describe('with title/value and without helpUrl/path', () => {
     beforeEach(() => {
       createComponent({ title, value });
     });
@@ -31,6 +32,10 @@ describe('Sidebar detail row', () => {
     it('should not render the help link', () => {
       expect(findHelpLink().exists()).toBe(false);
     });
+
+    it('should not render the value link', () => {
+      expect(findValueLink().exists()).toBe(false);
+    });
   });
 
   describe('when helpUrl provided', () => {
@@ -47,4 +52,16 @@ describe('Sidebar detail row', () => {
       expect(findHelpLink().attributes('href')).toBe(helpUrl);
     });
   });
+
+  describe('when path is provided', () => {
+    it('should render link to value', () => {
+      createComponent({
+        path,
+        title,
+        value,
+      });
+
+      expect(findValueLink().attributes('href')).toBe(path);
+    });
+  });
 });
diff --git a/spec/serializers/runner_entity_spec.rb b/spec/serializers/runner_entity_spec.rb
index f34cb794834445..b94e1e225edf2f 100644
--- a/spec/serializers/runner_entity_spec.rb
+++ b/spec/serializers/runner_entity_spec.rb
@@ -22,5 +22,23 @@
       expect(subject).to include(:edit_path)
       expect(subject).to include(:short_sha)
     end
+
+    context 'without admin permissions' do
+      it 'does not contain admin_path field' do
+        expect(subject).not_to include(:admin_path)
+      end
+    end
+
+    context 'with admin permissions' do
+      let_it_be(:user) { create(:user, :admin) }
+
+      before do
+        allow(user).to receive(:can_admin_all_resources?).and_return(true)
+      end
+
+      it 'contains admin_path field' do
+        expect(subject).to include(:admin_path)
+      end
+    end
   end
 end
-- 
GitLab