From 4956b8db553deef386e55760f81942c2fab7e399 Mon Sep 17 00:00:00 2001 From: Sascha Eggenberger Date: Tue, 22 Aug 2023 08:05:23 +0000 Subject: [PATCH] Reduce the amount of variants for GitLab UI badges See also: - https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/3307 - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140231 Changelog: changed --- .../add_context_commits_modal_wrapper.vue | 2 +- .../abuse_report/components/report_header.vue | 8 +- .../components/stage_table.vue | 4 +- .../components/devops_score.vue | 2 +- .../badges/components/badge_list.vue | 2 +- .../batch_comments/components/draft_note.vue | 1 - .../components/drafts_count.vue | 2 +- .../ci/artifacts/components/artifact_row.vue | 4 +- .../components/details/ci_resource_header.vue | 1 - .../catalog/components/list/catalog_tabs.vue | 2 +- .../list/ci_resources_list_item.vue | 4 +- .../components/ci_variable_table.vue | 1 - .../sidebar/sidebar_job_details_container.vue | 2 +- .../ci/job_details/components/stuck_block.vue | 2 +- .../components/job_cells/job_cell.vue | 34 ++------ .../jobs_page/components/jobs_table_tabs.vue | 2 +- .../graph/components/job_item.vue | 1 - .../graph/components/linked_pipeline.vue | 2 +- .../header/components/header_badges.vue | 19 +---- .../pipeline_details/tabs/pipeline_tabs.vue | 6 +- .../components/ui/editor_tab.vue | 2 +- .../components/pipeline_schedules.vue | 2 +- .../components/pipeline_labels.vue | 22 +----- .../components/cells/runner_summary_cell.vue | 6 +- .../runner/components/runner_details_tabs.vue | 7 +- .../ci/runner/components/runner_tag.vue | 6 -- .../ci/runner/components/runner_tags.vue | 13 +--- .../ci/runner/components/runner_type_tabs.vue | 1 - .../agent_integration_status_row.vue | 1 - .../clusters/agents/components/show.vue | 4 +- .../code_navigation/components/popover.vue | 2 +- .../commit/components/signature_badge.vue | 2 +- .../custom_emoji/components/list.vue | 2 +- .../components/approvals_empty_state.vue | 2 +- .../components/design_notes/design_note.vue | 2 +- .../components/toolbar/index.vue | 1 - .../diffs/components/tree_list.vue | 2 +- .../components/environment_folder.vue | 2 +- .../components/environments_app.vue | 4 +- .../environments_app_skeleton_loader.vue | 4 +- .../components/kubernetes/kubernetes_pods.vue | 2 +- .../kubernetes/kubernetes_services.vue | 2 +- .../environment_details/index.vue | 4 +- .../folder/environments_folder_app.vue | 4 +- .../folder/environments_folder_view.vue | 2 +- .../components/gitlab_version_check_badge.vue | 6 -- .../javascripts/gitlab_version_check/index.js | 3 +- .../groups/components/group_item.vue | 2 +- .../ide/components/activity_bar.vue | 1 - .../ide/components/pipelines/list.vue | 6 +- .../components/import_status.vue | 2 +- .../components/import_status.vue | 2 +- .../overrides/components/integration_tabs.vue | 1 - .../issuable/components/status_badge.vue | 2 +- .../issues/show/components/sticky_header.vue | 8 +- .../components/workload_details.vue | 4 +- .../components/workload_table.vue | 9 +-- .../components/avatars/user_avatar.vue | 2 +- .../members/components/members_tabs.vue | 2 +- .../members/components/placeholders/app.vue | 4 +- .../components/table/members_table.vue | 2 +- .../components/table/role_details_drawer.vue | 2 +- .../components/collapsible_section.vue | 2 +- .../components/sticky_header.vue | 2 +- .../components/milestone_combobox.vue | 2 +- .../components/model_experiments_header.vue | 2 +- .../ml/model_registry/apps/show_ml_model.vue | 4 +- .../notes/components/note_header.vue | 3 +- .../components/details/package_title.vue | 2 - .../components/list/package_list_row.vue | 1 - .../package_registry/pages/details.vue | 6 +- .../shared/components/package_tags.vue | 2 - .../profile/components/followers_tab.vue | 2 +- .../profile/components/following_tab.vue | 2 +- .../profile/components/user_achievements.vue | 4 +- .../commit_box/info/components/refs_list.vue | 2 - .../branch_rules/components/branch_rule.vue | 4 +- .../ref/components/ref_selector.vue | 10 +-- .../releases/components/issuable_stats.vue | 2 +- .../components/release_block_assets.vue | 4 +- .../repository/components/table/row.vue | 4 +- .../components/feature_card_badge.vue | 2 +- .../assignees/sidebar_participant.vue | 2 +- .../assignees/user_name_with_status.vue | 2 +- .../super_sidebar/components/help_center.vue | 4 +- .../components/merge_request_menu.vue | 2 +- .../super_sidebar/components/nav_item.vue | 1 - .../super_sidebar/components/user_bar.vue | 1 - .../components/user_menu_profile_item.vue | 2 +- .../components/mr_widget_migrate_jenkins.vue | 1 - .../components/badges/beta_badge.stories.js | 2 +- .../components/badges/beta_badge.vue | 9 +-- .../badges/experiment_badge.stories.js | 2 +- .../components/badges/experiment_badge.vue | 9 +-- .../components/badges/hover_badge.vue | 7 +- .../vue_shared/components/ci_icon/ci_icon.vue | 1 - .../groups_list/groups_list_item.vue | 1 - .../vue_shared/components/imported_badge.vue | 7 +- .../vue_shared/components/navigation_tabs.vue | 2 +- .../paginated_table_with_search_and_tabs.vue | 2 +- .../project_list_item_inactive_badge.vue | 2 +- .../projects_list/projects_list_item.vue | 13 +--- .../components/user_access_role_badge.vue | 9 +-- .../components/user_popover/user_popover.vue | 2 +- .../components/users_table/user_avatar.vue | 4 +- .../list/components/issuable_item.vue | 2 +- .../list/components/issuable_tabs.vue | 1 - .../show/components/issuable_header.vue | 7 +- .../whats_new/components/feature.vue | 1 - .../design_preview/design_toolbar.vue | 1 - .../work_item_ancestors.vue | 2 +- .../components/work_item_state_badge.vue | 2 +- .../components/hierarchy.vue | 1 - app/assets/stylesheets/framework.scss | 1 - app/assets/stylesheets/framework/badges.scss | 78 ------------------- .../stylesheets/page_bundles/issuable.scss | 2 +- .../subscription_details_history.vue | 2 +- .../components/list/dashboard_list_item.vue | 8 +- .../code_review_analytics/components/app.vue | 2 +- .../components/stream/stream_item.vue | 1 - .../components/merge_train_tabs.vue | 4 +- .../pipeline_details/tabs/pipeline_tabs.vue | 4 +- .../runner_upgrade_status_badge.vue | 17 +--- .../components/policies_section.vue | 2 +- .../framework_info_drawer.vue | 6 +- .../components/deployment_timeline.vue | 1 - .../deployment_frequency_charts.vue | 4 +- .../components/geo_sites_filters.vue | 2 +- .../components/iteration_report_issues.vue | 2 +- .../components/iteration_report_tabs.vue | 2 +- .../components/summarize_code_changes.vue | 2 +- .../components/tabs/base_tab.vue | 2 +- .../pending_members/components/app.vue | 2 +- .../components/epic_health_status.vue | 6 +- .../components/issue_health_status.vue | 8 +- .../components/requirements_tabs.vue | 8 +- .../components/dast_configuration_header.vue | 2 +- .../components/pre_scan_verification_icon.vue | 2 +- .../components/dast_scan_type_badge.vue | 2 +- .../components/dast_site_validation_badge.vue | 2 +- .../vulnerability_list_status.vue | 4 +- .../vulnerability_report_tab.vue | 2 +- .../scan_execution/humanized_actions/tags.vue | 2 +- .../policy_editor/scan_filter_selector.vue | 1 - .../tracing/details/tracing_header.vue | 2 +- .../tracing/list/tracing_table.vue | 6 +- .../saas_add_on_eligible_user_list.vue | 2 +- .../components/subscription_seat_details.vue | 2 +- .../components/subscription_user_list.vue | 4 +- .../components/ai_commit_message.vue | 4 +- .../components/code_owners/code_owners.vue | 2 +- .../group_list_item_inactive_badge.vue | 2 +- .../project_list_item_inactive_badge.vue | 2 +- .../components/tier_badge/tier_badge.vue | 2 +- .../components/split_button.vue | 4 +- .../explain_vulnerability_deprecated.vue | 2 +- .../explain_vulnerability_drawer.vue | 2 +- .../components/agent_mapping.vue | 4 +- .../list/dashboard_list_item_spec.js | 1 - .../runner_upgrade_status_badge_spec.js | 6 -- .../environment_header_spec.js.snap | 1 - .../table/role_details_drawer_spec.js | 1 - .../vulnerability_list_status_spec.js | 2 +- .../__snapshots__/details_drawer_spec.js.snap | 2 +- .../components/split_button_spec.js | 2 - .../false_positive_badge_spec.js.snap | 1 - .../explain_vulnerability_deprecated_spec.js | 5 +- .../explain_vulnerability_drawer_spec.js | 5 +- .../workspace_state_indicator_spec.js | 1 - .../components/report_header_spec.js | 5 +- .../runner_job_status_badge_spec.js | 2 +- .../components/runner_managers_badge_spec.js | 6 -- .../components/runner_paused_badge_spec.js | 6 -- .../ci/runner/components/runner_tag_spec.js | 9 --- .../ci/runner/components/runner_tags_spec.js | 13 ---- .../agent_integration_status_row_spec.js | 1 - .../toolbar/__snapshots__/index_spec.js.snap | 1 - .../findings_drawer_spec.js.snap | 4 +- .../show/components/sticky_header_spec.js | 4 +- .../components/table/members_table_spec.js | 1 - .../collapsible_section_spec.js.snap | 1 - .../profile/components/followers_tab_spec.js | 3 +- .../profile/components/following_tab_spec.js | 3 +- .../__snapshots__/issuable_stats_spec.js.snap | 2 +- .../dynamic_content_spec.js.snap | 1 - .../__snapshots__/beta_badge_spec.js.snap | 2 +- .../experiment_badge_spec.js.snap | 2 +- .../components/badges/beta_badge_spec.js | 14 ---- .../badges/experiment_badge_spec.js | 14 ---- .../components/badges/hover_badge_spec.js | 12 --- .../components/ci_icon/ci_icon_spec.js | 1 - .../show/components/issuable_header_spec.js | 2 +- 192 files changed, 192 insertions(+), 593 deletions(-) delete mode 100644 app/assets/stylesheets/framework/badges.scss diff --git a/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_wrapper.vue b/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_wrapper.vue index b5239b437d683a..206e053192c273 100644 --- a/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_wrapper.vue +++ b/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_wrapper.vue @@ -337,7 +337,7 @@ export default { -import { GlBadge, GlIcon, GlAvatar, GlButton, GlLink } from '@gitlab/ui'; +import { GlBadge, GlAvatar, GlButton, GlLink } from '@gitlab/ui'; import { REPORT_HEADER_I18N, STATUS_OPEN, STATUS_CLOSED } from '../constants'; import ReportActions from './report_actions.vue'; @@ -7,7 +7,6 @@ export default { name: 'ReportHeader', components: { GlBadge, - GlIcon, GlAvatar, GlButton, GlLink, @@ -56,9 +55,8 @@ export default { class="gl-py-4 gl-border-b gl-display-flex gl-justify-content-space-between gl-flex-direction-column gl-sm-flex-direction-row" >
- - - {{ badgeText }} + + {{ badgeText }}

diff --git a/app/assets/javascripts/analytics/cycle_analytics/components/stage_table.vue b/app/assets/javascripts/analytics/cycle_analytics/components/stage_table.vue index 5c5d56625562f4..498fbf792f9bd7 100644 --- a/app/assets/javascripts/analytics/cycle_analytics/components/stage_table.vue +++ b/app/assets/javascripts/analytics/cycle_analytics/components/stage_table.vue @@ -211,9 +211,7 @@ export default { > diff --git a/app/assets/javascripts/ci/jobs_page/components/job_cells/job_cell.vue b/app/assets/javascripts/ci/jobs_page/components/job_cells/job_cell.vue index 01d409f68f6969..b72a9778e90663 100644 --- a/app/assets/javascripts/ci/jobs_page/components/job_cells/job_cell.vue +++ b/app/assets/javascripts/ci/jobs_page/components/job_cells/job_cell.vue @@ -6,7 +6,6 @@ import { SUCCESS_STATUS } from '../../../constants'; export default { iconSize: 12, - badgeSize: 'sm', i18n: { stuckText: s__('Jobs|Job is stuck. Check runners.'), }, @@ -123,42 +122,19 @@ export default {

- + {{ tag }} - {{ s__('Job|trigger token') }} - {{ s__('Job|allowed to fail') }} - {{ s__('Job|delayed') }} - + {{ s__('Job|manual') }}
diff --git a/app/assets/javascripts/ci/jobs_page/components/jobs_table_tabs.vue b/app/assets/javascripts/ci/jobs_page/components/jobs_table_tabs.vue index b753195da9ab93..7dbf6e7823a3d9 100644 --- a/app/assets/javascripts/ci/jobs_page/components/jobs_table_tabs.vue +++ b/app/assets/javascripts/ci/jobs_page/components/jobs_table_tabs.vue @@ -76,7 +76,7 @@ export default { {{ tab.text }} - + {{ tab.count }} diff --git a/app/assets/javascripts/ci/pipeline_details/graph/components/job_item.vue b/app/assets/javascripts/ci/pipeline_details/graph/components/job_item.vue index 801da4d5f56574..885f2a05538949 100644 --- a/app/assets/javascripts/ci/pipeline_details/graph/components/job_item.vue +++ b/app/assets/javascripts/ci/pipeline_details/graph/components/job_item.vue @@ -366,7 +366,6 @@ export default { v-if="isBridge" class="gl-mt-3 gl-ml-7" variant="info" - size="sm" data-testid="job-bridge-badge" > {{ $options.i18n.bridgeBadgeText }} diff --git a/app/assets/javascripts/ci/pipeline_details/graph/components/linked_pipeline.vue b/app/assets/javascripts/ci/pipeline_details/graph/components/linked_pipeline.vue index 1d23dbeb78566a..053c13e488821d 100644 --- a/app/assets/javascripts/ci/pipeline_details/graph/components/linked_pipeline.vue +++ b/app/assets/javascripts/ci/pipeline_details/graph/components/linked_pipeline.vue @@ -279,7 +279,7 @@ export default {
- + {{ label }}
diff --git a/app/assets/javascripts/ci/pipeline_details/header/components/header_badges.vue b/app/assets/javascripts/ci/pipeline_details/header/components/header_badges.vue index 0e08347ac6ad43..6ce8c874a79080 100644 --- a/app/assets/javascripts/ci/pipeline_details/header/components/header_badges.vue +++ b/app/assets/javascripts/ci/pipeline_details/header/components/header_badges.vue @@ -78,7 +78,6 @@ export default { v-gl-tooltip :title="__('This pipeline was created by a schedule')" variant="info" - size="sm" > {{ s__('Pipelines|Scheduled') }}
@@ -87,7 +86,6 @@ export default { v-gl-tooltip :title="__('This pipeline was created by an API call authenticated with a trigger token')" variant="info" - size="sm" > {{ __('trigger token') }} @@ -96,7 +94,6 @@ export default { v-gl-tooltip :title="__('This is a child pipeline within the parent pipeline')" variant="info" - size="sm" > - {{ __('stuck') }} + {{ + __('stuck') + }} {{ s__('Pipeline|merge request') }} @@ -193,7 +182,6 @@ export default { ) " variant="info" - size="sm" data-testid="pipeline-url-merged-results" >{{ s__('Pipeline|merged results') }} @@ -202,7 +190,6 @@ export default { v-gl-tooltip :title="__('Pipeline ran in fork of project')" variant="info" - size="sm" data-testid="pipeline-url-fork" >{{ __('fork') }} @@ -211,7 +198,6 @@ export default { v-gl-tooltip :title="__('This pipeline was triggered using the api')" variant="info" - size="sm" data-testid="pipeline-api-badge" >{{ s__('Pipeline|api') }} diff --git a/app/assets/javascripts/ci/runner/components/cells/runner_summary_cell.vue b/app/assets/javascripts/ci/runner/components/cells/runner_summary_cell.vue index 6d39b3872e7246..930876e62cbbba 100644 --- a/app/assets/javascripts/ci/runner/components/cells/runner_summary_cell.vue +++ b/app/assets/javascripts/ci/runner/components/cells/runner_summary_cell.vue @@ -84,14 +84,14 @@ export default { - + - +
- + diff --git a/app/assets/javascripts/ci/runner/components/runner_details_tabs.vue b/app/assets/javascripts/ci/runner/components/runner_details_tabs.vue index e4190a4dffd995..e054d7a0cf11c1 100644 --- a/app/assets/javascripts/ci/runner/components/runner_details_tabs.vue +++ b/app/assets/javascripts/ci/runner/components/runner_details_tabs.vue @@ -76,12 +76,7 @@ export default { diff --git a/app/assets/javascripts/code_navigation/components/popover.vue b/app/assets/javascripts/code_navigation/components/popover.vue index b558dbeb486319..79b8f62fdabd87 100644 --- a/app/assets/javascripts/code_navigation/components/popover.vue +++ b/app/assets/javascripts/code_navigation/components/popover.vue @@ -128,7 +128,7 @@ export default { - + {{ group.permission }} diff --git a/app/assets/javascripts/ide/components/activity_bar.vue b/app/assets/javascripts/ide/components/activity_bar.vue index 73620b573b41b0..903bba7b606fc7 100644 --- a/app/assets/javascripts/ide/components/activity_bar.vue +++ b/app/assets/javascripts/ide/components/activity_bar.vue @@ -88,7 +88,6 @@ export default { {{ stagedFiles.length }} diff --git a/app/assets/javascripts/ide/components/pipelines/list.vue b/app/assets/javascripts/ide/components/pipelines/list.vue index 5f0030b07951f5..419ae38549519b 100644 --- a/app/assets/javascripts/ide/components/pipelines/list.vue +++ b/app/assets/javascripts/ide/components/pipelines/list.vue @@ -91,16 +91,14 @@ export default { diff --git a/app/assets/javascripts/import_entities/components/import_status.vue b/app/assets/javascripts/import_entities/components/import_status.vue index b4c361182f344b..a2e29f5f7fe779 100644 --- a/app/assets/javascripts/import_entities/components/import_status.vue +++ b/app/assets/javascripts/import_entities/components/import_status.vue @@ -104,7 +104,7 @@ export default {