From 109ca056c13bef74d3d8d6f62bc87ec8d041401a Mon Sep 17 00:00:00 2001 From: Sascha Eggenberger Date: Tue, 20 Jun 2023 15:53:10 +0200 Subject: [PATCH] Adding reusable new card styles Moves the current overrides for the new card styles into reusable styles for consistency and better maintainability. This resulted in fixing wrong spacing used in Work items OKR empty state and the button alignment in the add form in the related items widget. Changelog: changed --- .../design_management/pages/index.vue | 20 ++-- .../components/related_merge_requests.vue | 84 +++++++++-------- .../components/related_issues_block.vue | 81 ++++++++-------- .../work_items/components/widget_wrapper.vue | 28 ++---- .../work_item_links/work_item_link_child.vue | 2 +- .../work_item_links/work_item_links.vue | 93 +++++++++--------- .../work_item_links/work_item_links_form.vue | 3 +- .../work_item_links/work_item_tree.vue | 8 +- app/assets/stylesheets/framework.scss | 1 + .../stylesheets/framework/new_card.scss | 94 +++++++++++++++++++ app/views/projects/branches/_panel.html.haml | 4 +- .../components/create_issue_form.vue | 33 +++---- .../components/related_items_tree_app.vue | 24 +++-- .../components/related_items_tree_body.vue | 2 +- .../components/related_items_tree_header.vue | 12 +-- .../components/tree_root.vue | 2 +- .../mixins/tree_dd_mixin.js | 2 +- .../components/related_items_tree.scss | 5 - ee/spec/features/epics/epic_issues_spec.rb | 4 +- .../features/epics/epic_related_epics_spec.rb | 4 +- ee/spec/features/epics/epic_show_spec.rb | 2 +- .../components/related_items_tree_app_spec.js | 3 +- .../related_items_tree_body_spec.js | 4 - .../components/tree_root_spec.js | 2 +- .../components/related_issues_block_spec.js | 4 +- 25 files changed, 298 insertions(+), 223 deletions(-) create mode 100644 app/assets/stylesheets/framework/new_card.scss diff --git a/app/assets/javascripts/design_management/pages/index.vue b/app/assets/javascripts/design_management/pages/index.vue index e7308aad785b8b..b55610721a9e05 100644 --- a/app/assets/javascripts/design_management/pages/index.vue +++ b/app/assets/javascripts/design_management/pages/index.vue @@ -146,12 +146,6 @@ export default { } return 'col-12'; }, - designContentWrapperClass() { - if (this.hasDesigns) { - return 'gl-bg-gray-10 gl-border gl-border-t-0 gl-rounded-bottom-left-base gl-rounded-bottom-right-base gl-px-5'; - } - return null; - }, }, mounted() { if (this.$route.path === '/designs') { @@ -359,6 +353,7 @@ export default {
@@ -371,11 +366,7 @@ export default { > {{ uploadError }} -
+
@@ -427,7 +418,12 @@ export default {
-
+
{{ $options.i18n.designLoadingError }} diff --git a/app/assets/javascripts/issues/related_merge_requests/components/related_merge_requests.vue b/app/assets/javascripts/issues/related_merge_requests/components/related_merge_requests.vue index 8490ffd33cd07d..de59210ff191e0 100644 --- a/app/assets/javascripts/issues/related_merge_requests/components/related_merge_requests.vue +++ b/app/assets/javascripts/issues/related_merge_requests/components/related_merge_requests.vue @@ -65,29 +65,29 @@ export default { diff --git a/app/assets/javascripts/related_issues/components/related_issues_block.vue b/app/assets/javascripts/related_issues/components/related_issues_block.vue index f672acda0624bf..6ccf53624cf0a9 100644 --- a/app/assets/javascripts/related_issues/components/related_issues_block.vue +++ b/app/assets/javascripts/related_issues/components/related_issues_block.vue @@ -184,21 +184,14 @@ export default {
-

+

{{ emptyStateMessage }} diff --git a/app/assets/javascripts/work_items/components/work_item_links/work_item_links_form.vue b/app/assets/javascripts/work_items/components/work_item_links/work_item_links_form.vue index 289a48b5eafde0..db649913602f33 100644 --- a/app/assets/javascripts/work_items/components/work_item_links/work_item_links_form.vue +++ b/app/assets/javascripts/work_items/components/work_item_links/work_item_links_form.vue @@ -347,7 +347,8 @@ export default { diff --git a/ee/app/assets/javascripts/related_items_tree/components/related_items_tree_app.vue b/ee/app/assets/javascripts/related_items_tree/components/related_items_tree_app.vue index 63c881440f9609..13c7b331a0861d 100644 --- a/ee/app/assets/javascripts/related_items_tree/components/related_items_tree_app.vue +++ b/ee/app/assets/javascripts/related_items_tree/components/related_items_tree_app.vue @@ -111,6 +111,17 @@ export default { enableIssuesAutoComplete() { return this.issuableType === TYPE_ISSUE && this.autoCompleteIssues; }, + isOpen() { + return ( + (!this.itemsFetchResultEmpty && this.showRelatedItems) || + this.showAddItemForm || + this.showCreateEpicForm || + this.showCreateIssueForm + ); + }, + isOpenString() { + return this.isOpen ? 'true' : 'false'; + }, }, mounted() { this.fetchItems({ @@ -181,16 +192,14 @@ export default {