From 8bc9ed118991d74ae02b19b95448b61a8aeba3c9 Mon Sep 17 00:00:00 2001
From: Marius Bobin <mbobin@gitlab.com>
Date: Tue, 21 Feb 2023 11:16:19 +0200
Subject: [PATCH] Update FKs between p_ci_builds_metadata partitions and
 ci_builds

It updates the foreign keys between the partitions of the p_ci_builds_metadata
routing table and ci_builds to include the partition_id column.

Changelog: added
---
 ...partitions_on_partition_id_and_build_id.rb | 41 +++++++++++++++++++
 db/schema_migrations/20230221125148           |  1 +
 db/structure.sql                              |  3 ++
 3 files changed, 45 insertions(+)
 create mode 100644 db/post_migrate/20230221125148_add_fk_to_p_ci_builds_metadata_partitions_on_partition_id_and_build_id.rb
 create mode 100644 db/schema_migrations/20230221125148

diff --git a/db/post_migrate/20230221125148_add_fk_to_p_ci_builds_metadata_partitions_on_partition_id_and_build_id.rb b/db/post_migrate/20230221125148_add_fk_to_p_ci_builds_metadata_partitions_on_partition_id_and_build_id.rb
new file mode 100644
index 00000000000000..9df03f03d2bc6c
--- /dev/null
+++ b/db/post_migrate/20230221125148_add_fk_to_p_ci_builds_metadata_partitions_on_partition_id_and_build_id.rb
@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+class AddFkToPCiBuildsMetadataPartitionsOnPartitionIdAndBuildId < Gitlab::Database::Migration[2.1]
+  disable_ddl_transaction!
+
+  SOURCE_TABLE_NAME = :p_ci_builds_metadata
+  TARGET_TABLE_NAME = :ci_builds
+  COLUMN = :build_id
+  TARGET_COLUMN = :id
+  FK_NAME = :fk_e20479742e_p
+  PARTITION_COLUMN = :partition_id
+
+  def up
+    Gitlab::Database::PostgresPartitionedTable.each_partition(SOURCE_TABLE_NAME) do |partition|
+      add_concurrent_foreign_key(
+        partition.identifier,
+        TARGET_TABLE_NAME,
+        column: [PARTITION_COLUMN, COLUMN],
+        target_column: [PARTITION_COLUMN, TARGET_COLUMN],
+        validate: false,
+        reverse_lock_order: true,
+        on_update: :cascade,
+        on_delete: :cascade,
+        name: FK_NAME
+      )
+    end
+  end
+
+  def down
+    Gitlab::Database::PostgresPartitionedTable.each_partition(SOURCE_TABLE_NAME) do |partition|
+      with_lock_retries do
+        remove_foreign_key_if_exists(
+          partition.identifier,
+          TARGET_TABLE_NAME,
+          name: FK_NAME,
+          reverse_lock_order: true
+        )
+      end
+    end
+  end
+end
diff --git a/db/schema_migrations/20230221125148 b/db/schema_migrations/20230221125148
new file mode 100644
index 00000000000000..35ec9b066bce4c
--- /dev/null
+++ b/db/schema_migrations/20230221125148
@@ -0,0 +1 @@
+f64a3cb1963dde07eaaae9d331ebf1e5e52050435b38f9b6727a53f04808b723
\ No newline at end of file
diff --git a/db/structure.sql b/db/structure.sql
index a732006ceb8b55..959fe01efa440d 100644
--- a/db/structure.sql
+++ b/db/structure.sql
@@ -34697,6 +34697,9 @@ ALTER TABLE ONLY ci_sources_pipelines
 ALTER TABLE p_ci_builds_metadata
     ADD CONSTRAINT fk_e20479742e FOREIGN KEY (build_id) REFERENCES ci_builds(id) ON DELETE CASCADE;
 
+ALTER TABLE ONLY ci_builds_metadata
+    ADD CONSTRAINT fk_e20479742e_p FOREIGN KEY (partition_id, build_id) REFERENCES ci_builds(partition_id, id) ON UPDATE CASCADE ON DELETE CASCADE NOT VALID;
+
 ALTER TABLE ONLY gitlab_subscriptions
     ADD CONSTRAINT fk_e2595d00a1 FOREIGN KEY (namespace_id) REFERENCES namespaces(id) ON DELETE CASCADE;
 
-- 
GitLab