From e236d988748be86fcd1c71fb4a679a4e99b6df6e Mon Sep 17 00:00:00 2001 From: Filipa Lacerda Date: Thu, 14 Mar 2019 10:19:12 +0000 Subject: [PATCH] Removes EE differences for environments index --- app/assets/javascripts/environments/index.js | 17 +++-------------- .../environments/mixins/canary_callout_mixin.js | 5 +++++ .../environments/mixins/canary_callout_mixin.js | 11 +++++++++++ 3 files changed, 19 insertions(+), 14 deletions(-) create mode 100644 app/assets/javascripts/environments/mixins/canary_callout_mixin.js diff --git a/app/assets/javascripts/environments/index.js b/app/assets/javascripts/environments/index.js index ca5f590f624616..b53d42f202bb59 100644 --- a/app/assets/javascripts/environments/index.js +++ b/app/assets/javascripts/environments/index.js @@ -1,12 +1,9 @@ import Vue from 'vue'; +import canaryCalloutMixin from 'ee_else_ce/environments/mixins/canary_callout_mixin'; import environmentsComponent from './components/environments_app.vue'; import { parseBoolean } from '../lib/utils/common_utils'; import Translate from '../vue_shared/translate'; -// ee-only start -import CanaryCalloutMixin from 'ee/environments/mixins/canary_callout_mixin'; // eslint-disable-line import/order -// ee-only end - Vue.use(Translate); export default () => @@ -15,9 +12,7 @@ export default () => components: { environmentsComponent, }, - // ee-only start - mixins: [CanaryCalloutMixin], - // ee-only end + mixins: [canaryCalloutMixin], data() { const environmentsData = document.querySelector(this.$options.el).dataset; @@ -39,13 +34,7 @@ export default () => cssContainerClass: this.cssContainerClass, canCreateEnvironment: this.canCreateEnvironment, canReadEnvironment: this.canReadEnvironment, - // ee-only start - canaryDeploymentFeatureId: this.canaryDeploymentFeatureId, - showCanaryDeploymentCallout: this.showCanaryDeploymentCallout, - userCalloutsPath: this.userCalloutsPath, - lockPromotionSvgPath: this.lockPromotionSvgPath, - helpCanaryDeploymentsPath: this.helpCanaryDeploymentsPath, - // ee-only end + ...this.canaryCalloutProps, }, }); }, diff --git a/app/assets/javascripts/environments/mixins/canary_callout_mixin.js b/app/assets/javascripts/environments/mixins/canary_callout_mixin.js new file mode 100644 index 00000000000000..f6d3d67b7779d7 --- /dev/null +++ b/app/assets/javascripts/environments/mixins/canary_callout_mixin.js @@ -0,0 +1,5 @@ +export default { + computed: { + canaryCalloutProps() {}, + }, +}; diff --git a/ee/app/assets/javascripts/environments/mixins/canary_callout_mixin.js b/ee/app/assets/javascripts/environments/mixins/canary_callout_mixin.js index ec4d54074ce856..398576a31cb11e 100644 --- a/ee/app/assets/javascripts/environments/mixins/canary_callout_mixin.js +++ b/ee/app/assets/javascripts/environments/mixins/canary_callout_mixin.js @@ -12,4 +12,15 @@ export default { helpCanaryDeploymentsPath: data.environmentsDataHelpCanaryDeploymentsPath, }; }, + computed: { + canaryCalloutProps() { + return { + canaryDeploymentFeatureId: this.canaryDeploymentFeatureId, + showCanaryDeploymentCallout: this.showCanaryDeploymentCallout, + userCalloutsPath: this.userCalloutsPath, + lockPromotionSvgPath: this.lockPromotionSvgPath, + helpCanaryDeploymentsPath: this.helpCanaryDeploymentsPath, + }; + }, + }, }; -- GitLab