From c0610c6ee84604ddd9d5251d89a0e0508bd83243 Mon Sep 17 00:00:00 2001 From: Chris Balane Date: Wed, 11 Jan 2023 00:06:21 +0000 Subject: [PATCH 1/8] Deprecate #385798 --- .../15-8-projects-API-ops-access-level.yml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 data/deprecations/15-8-projects-API-ops-access-level.yml diff --git a/data/deprecations/15-8-projects-API-ops-access-level.yml b/data/deprecations/15-8-projects-API-ops-access-level.yml new file mode 100644 index 00000000000000..3d16a55a9765db --- /dev/null +++ b/data/deprecations/15-8-projects-API-ops-access-level.yml @@ -0,0 +1,61 @@ +# This is a template for announcing a feature deprecation or other important planned change. +# +# Please refer to the deprecation guidelines to confirm your understanding of GitLab's definitions. +# https://docs.gitlab.com/ee/development/deprecation_guidelines/#terminology +# +# Deprecations and other future breaking changes must be announced at least +# three releases prior to removal. +# +# Breaking changes must happen in a major release. +# +# See the OPTIONAL END OF SUPPORT FIELDS section below if an End of Support period also applies. +# +# For more information please refer to the handbook documentation here: +# https://about.gitlab.com/handbook/marketing/blog/release-posts/#deprecations-and-other-planned-breaking-change-announcements +# +# Please delete this line and above before submitting your merge request. +# +# REQUIRED FIELDS +# +- title: "operations_access_level_ field in the Projects API is deprecated" # (required) Clearly explain the change, or planned change. For example, "The `confidential` field for a `Note` is deprecated" or "CI/CD job names will be limited to 250 characters." + announcement_milestone: "15.8" # (required) The milestone when this feature was first announced as deprecated. + announcement_date: "2023-01-22" # (required) The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "16.0" # (required) The milestone when this feature is planned to be removed + removal_date: # (required) The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + breaking_change: true # (required) Change to false if this is not a breaking change. + reporter: cbalane # (required) GitLab username of the person reporting the change + stage: Release # (required) String value of the stage that the feature was created in. e.g., Growth + issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/385798 # (required) Link to the deprecation issue in GitLab + body: | # (required) Do not modify this line, instead modify the lines below. + We are deprecating the operations_access_level field in the Projects API. This field has been replaced by fields to control specific features: releases_access_level, environments_access_level, feature_flags_access_level, infrastructure_access_level, monitor_access_level. + +# +# OPTIONAL END OF SUPPORT FIELDS +# +# If an End of Support period applies, the announcement should be shared with GitLab Support +# in the `#spt_managers` channel in Slack, and mention `@gitlab-com/support` in this MR. +# + end_of_support_milestone: # (optional) Use "XX.YY" format. The milestone when support for this feature will end. + end_of_support_date: # (optional) The date of the milestone release when support for this feature will end. + # + # OTHER OPTIONAL FIELDS + # + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg -- GitLab From 20cf1d47b6598f0b80315770999a6a86c870b6c1 Mon Sep 17 00:00:00 2001 From: Chris Balane Date: Wed, 11 Jan 2023 00:29:30 +0000 Subject: [PATCH 2/8] update removal date --- data/deprecations/15-8-projects-API-ops-access-level.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/deprecations/15-8-projects-API-ops-access-level.yml b/data/deprecations/15-8-projects-API-ops-access-level.yml index 3d16a55a9765db..5e2e7e3ac3d50f 100644 --- a/data/deprecations/15-8-projects-API-ops-access-level.yml +++ b/data/deprecations/15-8-projects-API-ops-access-level.yml @@ -21,7 +21,7 @@ announcement_milestone: "15.8" # (required) The milestone when this feature was first announced as deprecated. announcement_date: "2023-01-22" # (required) The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. removal_milestone: "16.0" # (required) The milestone when this feature is planned to be removed - removal_date: # (required) The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_date: 2023-05-22 # (required) The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # (required) Change to false if this is not a breaking change. reporter: cbalane # (required) GitLab username of the person reporting the change stage: Release # (required) String value of the stage that the feature was created in. e.g., Growth -- GitLab From 6692368a8c2b7f199115dc31cd7586dcac92a018 Mon Sep 17 00:00:00 2001 From: Chris Balane Date: Wed, 11 Jan 2023 00:29:48 +0000 Subject: [PATCH 3/8] update file name --- ...ps-access-level.yml => 15-8-projects-api-ops-access-level.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename data/deprecations/{15-8-projects-API-ops-access-level.yml => 15-8-projects-api-ops-access-level.yml} (100%) diff --git a/data/deprecations/15-8-projects-API-ops-access-level.yml b/data/deprecations/15-8-projects-api-ops-access-level.yml similarity index 100% rename from data/deprecations/15-8-projects-API-ops-access-level.yml rename to data/deprecations/15-8-projects-api-ops-access-level.yml -- GitLab From ee6864e4d11efa0b73ba92d85a5bd052e1544d43 Mon Sep 17 00:00:00 2001 From: Chris Balane Date: Wed, 11 Jan 2023 00:30:52 +0000 Subject: [PATCH 4/8] remove comment --- .../15-8-projects-api-ops-access-level.yml | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/data/deprecations/15-8-projects-api-ops-access-level.yml b/data/deprecations/15-8-projects-api-ops-access-level.yml index 5e2e7e3ac3d50f..fae174112be971 100644 --- a/data/deprecations/15-8-projects-api-ops-access-level.yml +++ b/data/deprecations/15-8-projects-api-ops-access-level.yml @@ -28,22 +28,6 @@ issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/385798 # (required) Link to the deprecation issue in GitLab body: | # (required) Do not modify this line, instead modify the lines below. We are deprecating the operations_access_level field in the Projects API. This field has been replaced by fields to control specific features: releases_access_level, environments_access_level, feature_flags_access_level, infrastructure_access_level, monitor_access_level. - # # OPTIONAL END OF SUPPORT FIELDS # -- GitLab From 6d31edaf78a2359f2b1ea38a19b6fa540e27ada5 Mon Sep 17 00:00:00 2001 From: Russell Dickenson Date: Tue, 17 Jan 2023 15:41:09 +0000 Subject: [PATCH 5/8] Apply 1 suggestion(s) to 1 file(s) --- data/deprecations/15-8-projects-api-ops-access-level.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/deprecations/15-8-projects-api-ops-access-level.yml b/data/deprecations/15-8-projects-api-ops-access-level.yml index fae174112be971..a555330fc9a94b 100644 --- a/data/deprecations/15-8-projects-api-ops-access-level.yml +++ b/data/deprecations/15-8-projects-api-ops-access-level.yml @@ -17,7 +17,7 @@ # # REQUIRED FIELDS # -- title: "operations_access_level_ field in the Projects API is deprecated" # (required) Clearly explain the change, or planned change. For example, "The `confidential` field for a `Note` is deprecated" or "CI/CD job names will be limited to 250 characters." +- title: "Projects API field `operations_access_level` is deprecated" # (required) Clearly explain the change, or planned change. For example, "The `confidential` field for a `Note` is deprecated" or "CI/CD job names will be limited to 250 characters." announcement_milestone: "15.8" # (required) The milestone when this feature was first announced as deprecated. announcement_date: "2023-01-22" # (required) The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. removal_milestone: "16.0" # (required) The milestone when this feature is planned to be removed -- GitLab From 378ef497fb197177a3a46179be50e22904eb9918 Mon Sep 17 00:00:00 2001 From: Russell Dickenson Date: Tue, 17 Jan 2023 15:41:14 +0000 Subject: [PATCH 6/8] Apply 1 suggestion(s) to 1 file(s) --- data/deprecations/15-8-projects-api-ops-access-level.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/deprecations/15-8-projects-api-ops-access-level.yml b/data/deprecations/15-8-projects-api-ops-access-level.yml index a555330fc9a94b..4e0fbbe63ab2b1 100644 --- a/data/deprecations/15-8-projects-api-ops-access-level.yml +++ b/data/deprecations/15-8-projects-api-ops-access-level.yml @@ -27,7 +27,7 @@ stage: Release # (required) String value of the stage that the feature was created in. e.g., Growth issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/385798 # (required) Link to the deprecation issue in GitLab body: | # (required) Do not modify this line, instead modify the lines below. - We are deprecating the operations_access_level field in the Projects API. This field has been replaced by fields to control specific features: releases_access_level, environments_access_level, feature_flags_access_level, infrastructure_access_level, monitor_access_level. + We are deprecating the `operations_access_level` field in the Projects API. This field has been replaced by fields to control specific features: `releases_access_level`, `environments_access_level`, `feature_flags_access_level`, `infrastructure_access_level`, and `monitor_access_level`. # # OPTIONAL END OF SUPPORT FIELDS # -- GitLab From f07df867f32e13ba95c9fe2cdcdb21591e91159a Mon Sep 17 00:00:00 2001 From: Russell Dickenson Date: Wed, 18 Jan 2023 09:09:40 +1000 Subject: [PATCH 7/8] Update deprecation notice --- doc/update/deprecations.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/doc/update/deprecations.md b/doc/update/deprecations.md index a6df6df0b7e644..f8f643adf1d603 100644 --- a/doc/update/deprecations.md +++ b/doc/update/deprecations.md @@ -341,6 +341,20 @@ Alternatives to using the `gitlab:import:repos` Rake task include:
+### Projects API field `operations_access_level` is deprecated + +Planned removal: GitLab 16.0 (2023-05-22) + +WARNING: +This is a [breaking change](https://docs.gitlab.com/ee/development/deprecation_guidelines/). +Review the details carefully before upgrading. + +We are deprecating the `operations_access_level` field in the Projects API. This field has been replaced by fields to control specific features: `releases_access_level`, `environments_access_level`, `feature_flags_access_level`, `infrastructure_access_level`, and `monitor_access_level`. + +
+ +
+ ### Support for third party registries Planned removal: GitLab 16.0 -- GitLab From e7a0633ee5d894ee7487c56462fb891a2996f533 Mon Sep 17 00:00:00 2001 From: Russell Dickenson Date: Wed, 18 Jan 2023 09:43:42 +1000 Subject: [PATCH 8/8] Update deprecation notice --- doc/update/deprecations.md | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/doc/update/deprecations.md b/doc/update/deprecations.md index f8f643adf1d603..26cf0f5d7d7cbd 100644 --- a/doc/update/deprecations.md +++ b/doc/update/deprecations.md @@ -313,6 +313,20 @@ When creating and updating users through the API, `null` was a valid value for t
+
+ +### Projects API field `operations_access_level` is deprecated + +Planned removal: GitLab 16.0 + +WARNING: +This is a [breaking change](https://docs.gitlab.com/ee/development/deprecation_guidelines/). +Review the details carefully before upgrading. + +We are deprecating the `operations_access_level` field in the Projects API. This field has been replaced by fields to control specific features: `releases_access_level`, `environments_access_level`, `feature_flags_access_level`, `infrastructure_access_level`, and `monitor_access_level`. + +
+
### Rake task for importing bare repositories @@ -341,20 +355,6 @@ Alternatives to using the `gitlab:import:repos` Rake task include:
-### Projects API field `operations_access_level` is deprecated - -Planned removal: GitLab 16.0 (2023-05-22) - -WARNING: -This is a [breaking change](https://docs.gitlab.com/ee/development/deprecation_guidelines/). -Review the details carefully before upgrading. - -We are deprecating the `operations_access_level` field in the Projects API. This field has been replaced by fields to control specific features: `releases_access_level`, `environments_access_level`, `feature_flags_access_level`, `infrastructure_access_level`, and `monitor_access_level`. - -
- -
- ### Support for third party registries Planned removal: GitLab 16.0 -- GitLab