From 4a2b34ffd3e7df6dd9287aa6b002ce0395c9eef5 Mon Sep 17 00:00:00 2001 From: Tim Rizzi Date: Tue, 3 Jan 2023 19:41:07 +0000 Subject: [PATCH 1/3] Deprecation notice for package settings permission --- ...5-8-raise-permissions-settings-package-stage.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 data/deprecations/15-8-raise-permissions-settings-package-stage.yml diff --git a/data/deprecations/15-8-raise-permissions-settings-package-stage.yml b/data/deprecations/15-8-raise-permissions-settings-package-stage.yml new file mode 100644 index 00000000000000..d1ae106d14b180 --- /dev/null +++ b/data/deprecations/15-8-raise-permissions-settings-package-stage.yml @@ -0,0 +1,13 @@ +- title: "Owner-level permissions are now required to update Package settings" # (required) Actionable title. e.g., The `confidential` field for a `Note` is deprecated. Use `internal` instead. + announcement_milestone: "15.8" # (required) The milestone when this feature was first announced as deprecated. + announcement_date: "2023-01-22" # (required) The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "16.0" # (required) The milestone when this feature is planned to be removed + removal_date: "2023-05-22" # (required) The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + breaking_change: true # (required) If this deprecation is a breaking change, set this value to true + reporter: trizzi # (required) GitLab username of the person reporting the deprecation + stage: Package # (required) String value of the stage that the feature was created in. e.g., Growth + issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/370471 # (required) Link to the deprecation issue in GitLab + body: | # (required) Do not modify this line, instead modify the lines below. + When using the UI, Owner-level privelidges are required to update a group's `Packages and registries` settings. This includes [allowing or preventing duplicate package uploads](https://docs.gitlab.com/ee/user/packages/maven_repository/#do-not-allow-duplicate-maven-packages), [package request forwading](https://docs.gitlab.com/ee/user/packages/maven_repository/#request-forwarding-to-maven-central), and [enabling lifecycle rules for the Dependency Proxy](https://docs.gitlab.com/ee/user/packages/dependency_proxy/reduce_dependency_proxy_storage.html). + + When using [GraphQL](https://docs.gitlab.com/ee/api/graphql/reference/), Owner or Maintainer permissions are accepted. However, in 16.0 we will require Owner privelidges to use GraphQL to adjust these settings. -- GitLab From fe0082e1aaa739c82322dfd9d4ee340206e95916 Mon Sep 17 00:00:00 2001 From: Jackie Porter Date: Wed, 4 Jan 2023 15:50:48 +0000 Subject: [PATCH 2/3] Fix typo in copy for deprecation notice --- .../15-8-raise-permissions-settings-package-stage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/deprecations/15-8-raise-permissions-settings-package-stage.yml b/data/deprecations/15-8-raise-permissions-settings-package-stage.yml index d1ae106d14b180..8f0dfaf853173c 100644 --- a/data/deprecations/15-8-raise-permissions-settings-package-stage.yml +++ b/data/deprecations/15-8-raise-permissions-settings-package-stage.yml @@ -8,6 +8,6 @@ stage: Package # (required) String value of the stage that the feature was created in. e.g., Growth issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/370471 # (required) Link to the deprecation issue in GitLab body: | # (required) Do not modify this line, instead modify the lines below. - When using the UI, Owner-level privelidges are required to update a group's `Packages and registries` settings. This includes [allowing or preventing duplicate package uploads](https://docs.gitlab.com/ee/user/packages/maven_repository/#do-not-allow-duplicate-maven-packages), [package request forwading](https://docs.gitlab.com/ee/user/packages/maven_repository/#request-forwarding-to-maven-central), and [enabling lifecycle rules for the Dependency Proxy](https://docs.gitlab.com/ee/user/packages/dependency_proxy/reduce_dependency_proxy_storage.html). + When using the UI, Owner-level privileges are required to update a group's `Packages and registries` settings. This includes [allowing or preventing duplicate package uploads](https://docs.gitlab.com/ee/user/packages/maven_repository/#do-not-allow-duplicate-maven-packages), [package request forwarding](https://docs.gitlab.com/ee/user/packages/maven_repository/#request-forwarding-to-maven-central), and [enabling lifecycle rules for the Dependency Proxy](https://docs.gitlab.com/ee/user/packages/dependency_proxy/reduce_dependency_proxy_storage.html). When using [GraphQL](https://docs.gitlab.com/ee/api/graphql/reference/), Owner or Maintainer permissions are accepted. However, in 16.0 we will require Owner privelidges to use GraphQL to adjust these settings. -- GitLab From 661f13ec9a85a0f2c3c54239e61ed53a67667261 Mon Sep 17 00:00:00 2001 From: ccornell Date: Thu, 5 Jan 2023 13:06:17 -0800 Subject: [PATCH 3/3] updated text and recompiled --- ...-raise-permissions-settings-package-stage.yml | 6 +++--- doc/update/deprecations.md | 16 ++++++++++++++++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/data/deprecations/15-8-raise-permissions-settings-package-stage.yml b/data/deprecations/15-8-raise-permissions-settings-package-stage.yml index 8f0dfaf853173c..deafda38369a18 100644 --- a/data/deprecations/15-8-raise-permissions-settings-package-stage.yml +++ b/data/deprecations/15-8-raise-permissions-settings-package-stage.yml @@ -1,4 +1,4 @@ -- title: "Owner-level permissions are now required to update Package settings" # (required) Actionable title. e.g., The `confidential` field for a `Note` is deprecated. Use `internal` instead. +- title: "Owner permissions are required to update Package settings" # (required) Actionable title. e.g., The `confidential` field for a `Note` is deprecated. Use `internal` instead. announcement_milestone: "15.8" # (required) The milestone when this feature was first announced as deprecated. announcement_date: "2023-01-22" # (required) The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. removal_milestone: "16.0" # (required) The milestone when this feature is planned to be removed @@ -8,6 +8,6 @@ stage: Package # (required) String value of the stage that the feature was created in. e.g., Growth issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/370471 # (required) Link to the deprecation issue in GitLab body: | # (required) Do not modify this line, instead modify the lines below. - When using the UI, Owner-level privileges are required to update a group's `Packages and registries` settings. This includes [allowing or preventing duplicate package uploads](https://docs.gitlab.com/ee/user/packages/maven_repository/#do-not-allow-duplicate-maven-packages), [package request forwarding](https://docs.gitlab.com/ee/user/packages/maven_repository/#request-forwarding-to-maven-central), and [enabling lifecycle rules for the Dependency Proxy](https://docs.gitlab.com/ee/user/packages/dependency_proxy/reduce_dependency_proxy_storage.html). + You must have Owner permissions to use the GitLab UI to update the `Packages and registries` settings for your groups. This includes [allowing or preventing duplicate package uploads](https://docs.gitlab.com/ee/user/packages/maven_repository/#do-not-allow-duplicate-maven-packages), [package request forwarding](https://docs.gitlab.com/ee/user/packages/maven_repository/#request-forwarding-to-maven-central), and [enabling lifecycle rules for the Dependency Proxy](https://docs.gitlab.com/ee/user/packages/dependency_proxy/reduce_dependency_proxy_storage.html). Currently, you can use the GraphQL API with Owner or Maintainer permissions to update these settings. - When using [GraphQL](https://docs.gitlab.com/ee/api/graphql/reference/), Owner or Maintainer permissions are accepted. However, in 16.0 we will require Owner privelidges to use GraphQL to adjust these settings. + In GitLab 16.0 and later, you must have Owner permissions to use the GraphQL API to change the `Packages and registries` settings. diff --git a/doc/update/deprecations.md b/doc/update/deprecations.md index 086a8b86419e9b..1600db02922803 100644 --- a/doc/update/deprecations.md +++ b/doc/update/deprecations.md @@ -100,6 +100,22 @@ The Container Registry pull-through cache is deprecated in GitLab 15.8 and will
+### Owner permissions are required to update Package settings + +Planned removal: GitLab 16.0 (2023-05-22) + +WARNING: +This is a [breaking change](https://docs.gitlab.com/ee/development/deprecation_guidelines/). +Review the details carefully before upgrading. + +You must have Owner permissions to use the GitLab UI to update the `Packages and registries` settings for your groups. This includes [allowing or preventing duplicate package uploads](https://docs.gitlab.com/ee/user/packages/maven_repository/#do-not-allow-duplicate-maven-packages), [package request forwarding](https://docs.gitlab.com/ee/user/packages/maven_repository/#request-forwarding-to-maven-central), and [enabling lifecycle rules for the Dependency Proxy](https://docs.gitlab.com/ee/user/packages/dependency_proxy/reduce_dependency_proxy_storage.html). Currently, you can use the GraphQL API with Owner or Maintainer permissions to update these settings. + +In GitLab 16.0 and later, you must have Owner permissions to use the GraphQL API to change the `Packages and registries` settings. + +
+ +
+ ### Support for third party registries Planned removal: GitLab 16.0 (2023-05-22) -- GitLab