From c8098a258e765a286e9e5799ba040949506f846f Mon Sep 17 00:00:00 2001 From: David Elizondo Date: Mon, 5 Dec 2022 22:42:33 +0000 Subject: [PATCH] Add correct event type information for user update service When editing the user information, now the event_type attribute of audit events contains a meaninful value and not the default value of audit_operation. Changelog: changed EE: true --- ee/app/services/ee/users/update_service.rb | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/ee/app/services/ee/users/update_service.rb b/ee/app/services/ee/users/update_service.rb index eaa3957eda4694..58014d21d98b6d 100644 --- a/ee/app/services/ee/users/update_service.rb +++ b/ee/app/services/ee/users/update_service.rb @@ -21,10 +21,17 @@ def initialize(current_user, params = {}) def notify_success(user_exists) notify_new_user(@user, nil) unless user_exists # rubocop:disable Gitlab/ModuleWithInstanceVariables - audit_changes(:email, as: 'email address') - audit_changes(:encrypted_password, as: 'password', skip_changes: true) - audit_changes(:username, as: 'username') - audit_changes(:admin, as: 'admin status') + audit_changes(:email, as: 'email address', + event_type: 'user_email_address_updated') + + audit_changes(:encrypted_password, as: 'password', + skip_changes: true, event_type: 'user_password_updated') + + audit_changes(:username, as: 'username', + event_type: 'user_username_updated') + + audit_changes(:admin, as: 'admin status', + event_type: 'user_admin_status_updated') success end -- GitLab