diff --git a/.gitlab/merge_request_templates/New Version of gitlab-styles.md b/.gitlab/merge_request_templates/New Version of gitlab-styles.md index 220626169004a117ba79ee4ddcffa691d945b752..5e7f23196500ad3aab1b0125230128dd9b2fd02d 100644 --- a/.gitlab/merge_request_templates/New Version of gitlab-styles.md +++ b/.gitlab/merge_request_templates/New Version of gitlab-styles.md @@ -33,9 +33,7 @@ This MR can be reused to upgrade `gitlab-styles` in this project after a new ver - [ ] (Optional) Regenerate TODOs for new/changed cop rules - [ ] Make sure CI passes :green_heart: - [ ] Let the MR being reviewed again and merged - - [ ] Make sure CI passes :green_heart: - - [ ] Let the MR being reviewed again and merged - - [ ] (Optional) Refine this [MR template](https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/New%20Version%20of%20gitlab-styles.md). + - [ ] (Optional) Refine this [MR template](https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/New%20Version%20of%20gitlab-styles.md). ## MR acceptance checklist diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml new file mode 100644 index 0000000000000000000000000000000000000000..deaaa1da8a965987070fe0c9150c495e3e1b24cb --- /dev/null +++ b/.rubocop_todo/layout/array_alignment.yml @@ -0,0 +1,365 @@ +--- +# Cop supports --autocorrect. +Layout/ArrayAlignment: + Details: grace period + Exclude: + - 'app/controllers/admin/application_settings_controller.rb' + - 'app/controllers/admin/broadcast_messages_controller.rb' + - 'app/controllers/admin/plan_limits_controller.rb' + - 'app/controllers/concerns/observability/content_security_policy.rb' + - 'app/controllers/profiles_controller.rb' + - 'app/controllers/projects/feature_flags_controller.rb' + - 'app/controllers/projects/labels_controller.rb' + - 'app/controllers/projects/protected_branches_controller.rb' + - 'app/controllers/projects/settings/ci_cd_controller.rb' + - 'app/controllers/projects_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/finders/user_groups_counter.rb' + - 'app/graphql/resolvers/concerns/issues/sort_arguments.rb' + - 'app/graphql/types/permission_types/merge_request.rb' + - 'app/helpers/merge_requests_helper.rb' + - 'app/helpers/namespaces_helper.rb' + - 'app/helpers/search_helper.rb' + - 'app/helpers/submodule_helper.rb' + - 'app/models/ci/bridge.rb' + - 'app/models/ci/build.rb' + - 'app/models/concerns/ci/partitionable/switch.rb' + - 'app/models/container_repository.rb' + - 'app/models/deploy_token.rb' + - 'app/models/dev_ops_report/metric.rb' + - 'app/models/group.rb' + - 'app/models/integration.rb' + - 'app/models/integrations/hangouts_chat.rb' + - 'app/models/integrations/microsoft_teams.rb' + - 'app/models/integrations/pumble.rb' + - 'app/models/integrations/unify_circuit.rb' + - 'app/models/integrations/webex_teams.rb' + - 'app/models/issue.rb' + - 'app/models/repository.rb' + - 'app/models/snippet_repository.rb' + - 'app/models/user.rb' + - 'app/models/wiki.rb' + - 'app/services/ci/create_pipeline_service.rb' + - 'app/services/commits/create_service.rb' + - 'app/services/labels/transfer_service.rb' + - 'app/services/namespaces/package_settings/update_service.rb' + - 'app/services/packages/rpm/parse_package_service.rb' + - 'app/services/projects/participants_service.rb' + - 'app/services/web_hook_service.rb' + - 'config/application.rb' + - 'config/initializers/0_marginalia.rb' + - 'config/initializers/direct_upload_support.rb' + - 'db/post_migrate/20220728134255_update_index_vulnerabilities_common_finder.rb' + - 'ee/app/controllers/admin/push_rules_controller.rb' + - 'ee/app/controllers/ee/admin/application_settings_controller.rb' + - 'ee/app/controllers/ee/projects/merge_requests_controller.rb' + - 'ee/app/controllers/groups/protected_branches_controller.rb' + - 'ee/app/controllers/groups/push_rules_controller.rb' + - 'ee/app/controllers/projects/push_rules_controller.rb' + - 'ee/app/finders/autocomplete/project_invited_groups_finder.rb' + - 'ee/app/finders/ee/issues_finder/params.rb' + - 'ee/app/finders/geo/project_registry_finder.rb' + - 'ee/app/graphql/ee/resolvers/project_pipelines_resolver.rb' + - 'ee/app/helpers/ee/routing/projects_helper.rb' + - 'ee/app/models/concerns/geo/verification_state.rb' + - 'ee/app/models/dast_site_profile.rb' + - 'ee/app/models/dora/base_metric.rb' + - 'ee/app/models/ee/application_setting.rb' + - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/geo/event_log.rb' + - 'ee/app/models/gitlab_subscription_history.rb' + - 'ee/app/models/ip_restriction.rb' + - 'ee/app/models/license.rb' + - 'ee/app/models/protected_environment.rb' + - 'ee/app/models/security/finding.rb' + - 'ee/app/services/ee/users/authorized_build_service.rb' + - 'ee/app/services/jira/requests/issues/list_service.rb' + - 'ee/app/services/protected_environments/base_service.rb' + - 'ee/app/services/security/security_orchestration_policies/create_pipeline_service.rb' + - 'ee/app/services/vulnerabilities/create_service_base.rb' + - 'ee/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary.rb' + - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' + - 'ee/spec/controllers/admin/licenses/usage_exports_controller_spec.rb' + - 'ee/spec/factories/dependencies.rb' + - 'ee/spec/features/boards/boards_licensed_features_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' + - 'ee/spec/features/groups/group_roadmap_spec.rb' + - 'ee/spec/finders/namespaces/billed_users_finder_spec.rb' + - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/frontend/fixtures/search.rb' + - 'ee/spec/graphql/resolvers/analytics/contribution_analytics/contributions_resolver_spec.rb' + - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' + - 'ee/spec/graphql/types/dast_site_profile_type_spec.rb' + - 'ee/spec/graphql/types/permission_types/epic_spec.rb' + - 'ee/spec/graphql/types/permission_types/vulnerability_spec.rb' + - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' + - 'ee/spec/graphql/types/requirements_management/requirement_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_type_spec.rb' + - 'ee/spec/helpers/billing_plans_helper_spec.rb' + - 'ee/spec/helpers/boards_helper_spec.rb' + - 'ee/spec/helpers/ee/application_settings_helper_spec.rb' + - 'ee/spec/helpers/ee/environments_helper_spec.rb' + - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/project_changes_auditor_spec.rb' + - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' + - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' + - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' + - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/dependency_list/report_spec.rb' + - 'ee/spec/lib/gitlab/graphql/loaders/oncall_participant_loader_spec.rb' + - 'ee/spec/lib/gitlab/search/index_curator_spec.rb' + - 'ee/spec/lib/gitlab/visibility_level_spec.rb' + - 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb' + - 'ee/spec/models/analytics/cycle_analytics/group_value_stream_spec.rb' + - 'ee/spec/models/dora/base_metric_spec.rb' + - 'ee/spec/models/dora/daily_metrics_spec.rb' + - 'ee/spec/models/ee/group_spec.rb' + - 'ee/spec/models/ee/protected_ref_access_spec.rb' + - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/models/project_spec.rb' + - 'ee/spec/models/repository_spec.rb' + - 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb' + - 'ee/spec/models/security/scan_spec.rb' + - 'ee/spec/policies/group_policy_spec.rb' + - 'ee/spec/policies/project_policy_spec.rb' + - 'ee/spec/requests/api/dora/metrics_spec.rb' + - 'ee/spec/requests/api/graphql/group/epic/epic_ancestors_spec.rb' + - 'ee/spec/requests/api/graphql/group/epic/epic_children_spec.rb' + - 'ee/spec/requests/api/graphql/group/epics_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb' + - 'ee/spec/requests/api/ldap_group_links_spec.rb' + - 'ee/spec/requests/api/license_spec.rb' + - 'ee/spec/requests/api/members_spec.rb' + - 'ee/spec/requests/api/saml_group_links_spec.rb' + - 'ee/spec/serializers/dashboard_environment_entity_spec.rb' + - 'ee/spec/serializers/user_analytics_entity_spec.rb' + - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' + - 'ee/spec/services/audit_events/export_csv_service_spec.rb' + - 'ee/spec/services/ee/auto_merge_service_spec.rb' + - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' + - 'ee/spec/services/epic_issues/create_service_spec.rb' + - 'ee/spec/services/epics/epic_links/create_service_spec.rb' + - 'ee/spec/services/groups/seat_usage_export_service_spec.rb' + - 'ee/spec/services/incident_management/issuable_resource_links/zoom_link_service_spec.rb' + - 'ee/spec/services/security/dependency_list_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/scan_pipeline_service_spec.rb' + - 'ee/spec/services/security/token_revocation_service_spec.rb' + - 'ee/spec/support/helpers/vulnerability_exports_helpers.rb' + - 'ee/spec/support/shared_examples/finders/epics/findable_shared_examples.rb' + - 'ee/spec/support/shared_examples/policies/requirement_policy_shared_examples.rb' + - 'lib/api/api_guard.rb' + - 'lib/api/ci/runner.rb' + - 'lib/api/ci/runners.rb' + - 'lib/api/internal/base.rb' + - 'lib/api/statistics.rb' + - 'lib/gitlab/alert_management/payload/prometheus.rb' + - 'lib/gitlab/bitbucket_import/importer.rb' + - 'lib/gitlab/chat/command.rb' + - 'lib/gitlab/checks/single_change_access.rb' + - 'lib/gitlab/ci/config/entry/default.rb' + - 'lib/gitlab/ci/config/entry/job.rb' + - 'lib/gitlab/ci/config/entry/processable.rb' + - 'lib/gitlab/ci/config/entry/reports.rb' + - 'lib/gitlab/ci/config/entry/root.rb' + - 'lib/gitlab/ci/config/external/processor.rb' + - 'lib/gitlab/ci/status/bridge/factory.rb' + - 'lib/gitlab/ci/status/build/factory.rb' + - 'lib/gitlab/ci/status/stage/factory.rb' + - 'lib/gitlab/cleanup/project_upload_file_finder.rb' + - 'lib/gitlab/conflict/file_collection.rb' + - 'lib/gitlab/content_security_policy/config_loader.rb' + - 'lib/gitlab/database/background_migration/batched_job.rb' + - 'lib/gitlab/email/message/in_product_marketing/team.rb' + - 'lib/gitlab/email/message/in_product_marketing/trial.rb' + - 'lib/gitlab/email/message/in_product_marketing/verify.rb' + - 'lib/gitlab/email/receiver.rb' + - 'lib/gitlab/etag_caching/router/rails.rb' + - 'lib/gitlab/git/diff.rb' + - 'lib/gitlab/import_export/importer.rb' + - 'lib/gitlab/instrumentation/redis.rb' + - 'lib/gitlab/lograge/custom_options.rb' + - 'lib/gitlab/metrics/global_search_slis.rb' + - 'lib/gitlab/metrics/requests_rack_middleware.rb' + - 'lib/gitlab/metrics/samplers/threads_sampler.rb' + - 'lib/gitlab/object_hierarchy.rb' + - 'lib/gitlab/project_authorizations.rb' + - 'lib/gitlab/rack_attack/instrumented_cache_store.rb' + - 'lib/gitlab/reference_extractor.rb' + - 'lib/gitlab/sidekiq_middleware/size_limiter/validator.rb' + - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb' + - 'lib/gitlab/visibility_level.rb' + - 'lib/kramdown/parser/atlassian_document_format.rb' + - 'lib/tasks/cache.rake' + - 'qa/qa/specs/features/browser_ui/3_create/pages/new_static_page_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_audit_logs_2_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' + - 'qa/spec/specs/runner_spec.rb' + - 'rubocop/cop/gitlab/rspec/avoid_setup.rb' + - 'rubocop/cop/graphql/authorize_types.rb' + - 'spec/controllers/import/bulk_imports_controller_spec.rb' + - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' + - 'spec/factories/ci/builds.rb' + - 'spec/features/groups_spec.rb' + - 'spec/features/issuables/sorting_list_spec.rb' + - 'spec/features/oauth_login_spec.rb' + - 'spec/features/uploads/user_uploads_file_to_note_spec.rb' + - 'spec/finders/ci/pipelines_finder_spec.rb' + - 'spec/finders/ci/runners_finder_spec.rb' + - 'spec/finders/groups/accepting_project_transfers_finder_spec.rb' + - 'spec/finders/groups_finder_spec.rb' + - 'spec/finders/snippets_finder_spec.rb' + - 'spec/graphql/gitlab_schema_spec.rb' + - 'spec/graphql/mutations/commits/create_spec.rb' + - 'spec/graphql/resolvers/ci/all_jobs_resolver_spec.rb' + - 'spec/graphql/resolvers/environments/nested_environments_resolver_spec.rb' + - 'spec/graphql/resolvers/project_issues_resolver_spec.rb' + - 'spec/graphql/types/blob_viewer_type_spec.rb' + - 'spec/graphql/types/boards/board_issue_input_type_spec.rb' + - 'spec/graphql/types/commit_signatures/verification_status_enum_spec.rb' + - 'spec/graphql/types/container_repository_details_type_spec.rb' + - 'spec/graphql/types/container_repository_type_spec.rb' + - 'spec/graphql/types/issuable_sort_enum_spec.rb' + - 'spec/graphql/types/issue_type_spec.rb' + - 'spec/graphql/types/project_type_spec.rb' + - 'spec/graphql/types/snippet_type_spec.rb' + - 'spec/graphql/types/snippets/blob_type_spec.rb' + - 'spec/graphql/types/snippets/blob_viewer_type_spec.rb' + - 'spec/helpers/blame_helper_spec.rb' + - 'spec/helpers/ci/pipelines_helper_spec.rb' + - 'spec/helpers/labels_helper_spec.rb' + - 'spec/helpers/releases_helper_spec.rb' + - 'spec/lib/banzai/filter/color_filter_spec.rb' + - 'spec/lib/banzai/reference_parser/design_parser_spec.rb' + - 'spec/lib/container_registry/path_spec.rb' + - 'spec/lib/gitlab/auth/saml/user_spec.rb' + - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' + - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' + - 'spec/lib/gitlab/backtrace_cleaner_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/bridge_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/default_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/id_token_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/job_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/ports_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/root_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/services_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/remote_spec.rb' + - 'spec/lib/gitlab/ci/config/external/mapper/filter_spec.rb' + - 'spec/lib/gitlab/ci/config/external/mapper/location_expander_spec.rb' + - 'spec/lib/gitlab/ci/config/external/mapper/matcher_spec.rb' + - 'spec/lib/gitlab/ci/config/external/mapper/normalizer_spec.rb' + - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' + - 'spec/lib/gitlab/ci/config_spec.rb' + - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/build/associations_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/seed_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/duration_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/preloader_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/seed/stage_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/aggregated_report_spec.rb' + - 'spec/lib/gitlab/ci/secure_files/mobile_provision_spec.rb' + - 'spec/lib/gitlab/ci/secure_files/x509_name_spec.rb' + - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb' + - 'spec/lib/gitlab/ci/status/build/factory_spec.rb' + - 'spec/lib/gitlab/ci/variables/builder_spec.rb' + - 'spec/lib/gitlab/ci/variables/collection_spec.rb' + - 'spec/lib/gitlab/ci/variables/helpers_spec.rb' + - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/service_discovery/sampler_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/sticking_spec.rb' + - 'spec/lib/gitlab/database/tables_sorted_by_foreign_keys_spec.rb' + - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' + - 'spec/lib/gitlab/diff/inline_diff_spec.rb' + - 'spec/lib/gitlab/diff/lines_unfolder_spec.rb' + - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' + - 'spec/lib/gitlab/git/push_spec.rb' + - 'spec/lib/gitlab/git_access_spec.rb' + - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' + - 'spec/lib/gitlab/graphql/loaders/batch_model_loader_spec.rb' + - 'spec/lib/gitlab/i18n/po_linter_spec.rb' + - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' + - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' + - 'spec/lib/gitlab/issuable_sorter_spec.rb' + - 'spec/lib/gitlab/kroki_spec.rb' + - 'spec/lib/gitlab/language_detection_spec.rb' + - 'spec/lib/gitlab/markup_helper_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' + - 'spec/lib/gitlab/patch/prependable_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' + - 'spec/lib/gitlab/reference_extractor_spec.rb' + - 'spec/lib/gitlab/serializer/ci/variables_spec.rb' + - 'spec/lib/gitlab/sidekiq_config/worker_spec.rb' + - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb' + - 'spec/lib/gitlab/ssh_public_key_spec.rb' + - 'spec/lib/gitlab/usage_data/topology_spec.rb' + - 'spec/lib/gitlab/utils/merge_hash_spec.rb' + - 'spec/lib/gitlab/visibility_level_spec.rb' + - 'spec/models/application_setting_spec.rb' + - 'spec/models/ci/bridge_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/group_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/processable_spec.rb' + - 'spec/models/commit_status_spec.rb' + - 'spec/models/concerns/ci/has_status_spec.rb' + - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/design_management/version_spec.rb' + - 'spec/models/discussion_spec.rb' + - 'spec/models/external_pull_request_spec.rb' + - 'spec/models/group_group_link_spec.rb' + - 'spec/models/incident_management/timeline_event_tag_spec.rb' + - 'spec/models/integrations/irker_spec.rb' + - 'spec/models/issue_spec.rb' + - 'spec/models/namespace/package_setting_spec.rb' + - 'spec/models/operations/feature_flags/strategy_spec.rb' + - 'spec/models/operations/feature_flags/user_list_spec.rb' + - 'spec/models/project_group_link_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/models/snippet_repository_spec.rb' + - 'spec/models/user_preference_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/models/web_ide_terminal_spec.rb' + - 'spec/policies/merge_request_policy_spec.rb' + - 'spec/policies/project_policy_spec.rb' + - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/graphql/group_query_spec.rb' + - 'spec/requests/api/graphql/jobs_query_spec.rb' + - 'spec/requests/api/graphql/project/languages_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/requests/api/releases_spec.rb' + - 'spec/requests/api/settings_spec.rb' + - 'spec/requests/api/snippets_spec.rb' + - 'spec/serializers/fork_namespace_entity_spec.rb' + - 'spec/serializers/group_child_entity_spec.rb' + - 'spec/services/auto_merge_service_spec.rb' + - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/ci/enqueue_job_service_spec.rb' + - 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb' + - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' + - 'spec/services/ci/play_build_service_spec.rb' + - 'spec/services/feature_flags/create_service_spec.rb' + - 'spec/services/issues/referenced_merge_requests_service_spec.rb' + - 'spec/services/merge_requests/conflicts/resolve_service_spec.rb' + - 'spec/services/projects/detect_repository_languages_service_spec.rb' + - 'spec/services/security/merge_reports_service_spec.rb' + - 'spec/services/spam/spam_verdict_service_spec.rb' + - 'spec/support/helpers/kubernetes_helpers.rb' + - 'spec/support/helpers/login_helpers.rb' + - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' + - 'spec/support/shared_examples/lib/email/email_shared_examples.rb' + - 'spec/support/shared_examples/lib/wikis_api_examples.rb' + - 'spec/support/shared_examples/models/label_note_shared_examples.rb' + - 'spec/support/shared_examples/models/mentionable_shared_examples.rb' + - 'spec/workers/pages_domain_ssl_renewal_cron_worker_spec.rb' diff --git a/.rubocop_todo/layout/first_argument_indentation.yml b/.rubocop_todo/layout/first_argument_indentation.yml new file mode 100644 index 0000000000000000000000000000000000000000..fb364356a97912ec546d5aa875e34f6d0d6570c7 --- /dev/null +++ b/.rubocop_todo/layout/first_argument_indentation.yml @@ -0,0 +1,26 @@ +--- +# Cop supports --autocorrect. +Layout/FirstArgumentIndentation: + Details: grace period + Exclude: + - 'app/models/customer_relations/contact.rb' + - 'app/models/cycle_analytics/project_level_stage_adapter.rb' + - 'app/models/users/user_follow_user.rb' + - 'ee/lib/ee/gitlab/scim/group/deprovisioning_service.rb' + - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb' + - 'ee/spec/controllers/registrations/company_controller_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb' + - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' + - 'ee/spec/services/security/report_summary_service_spec.rb' + - 'spec/components/previews/pajamas/alert_component_preview.rb' + - 'spec/components/previews/pajamas/banner_component_preview.rb' + - 'spec/components/previews/pajamas/button_component_preview.rb' + - 'spec/controllers/import/bitbucket_controller_spec.rb' + - 'spec/lib/gitlab/application_rate_limiter_spec.rb' + - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' + - 'spec/lib/gitlab/import_export/shared_spec.rb' + - 'spec/models/loose_foreign_keys/deleted_record_spec.rb' + - 'spec/requests/api/graphql/ci/jobs_spec.rb' + - 'spec/services/protected_branches/api_service_spec.rb' + - 'spec/support/shared_examples/features/search/redacted_search_results_shared_examples.rb' + - 'spec/support/shared_examples/quick_actions/issuable/max_issuable_examples.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml new file mode 100644 index 0000000000000000000000000000000000000000..d108792ac08e99f9cd97e564ac6e3fd325bf9028 --- /dev/null +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -0,0 +1,90 @@ +--- +# Cop supports --autocorrect. +Layout/FirstArrayElementIndentation: + Details: grace period + Exclude: + - 'app/controllers/admin/broadcast_messages_controller.rb' + - 'app/controllers/admin/plan_limits_controller.rb' + - 'app/finders/user_groups_counter.rb' + - 'app/helpers/search_helper.rb' + - 'app/models/container_repository.rb' + - 'app/models/group.rb' + - 'app/models/integration.rb' + - 'app/models/user.rb' + - 'app/services/labels/transfer_service.rb' + - 'ee/app/finders/autocomplete/project_invited_groups_finder.rb' + - 'ee/app/finders/geo/project_registry_finder.rb' + - 'ee/app/models/ee/application_setting.rb' + - 'ee/app/models/protected_environment.rb' + - 'ee/app/services/vulnerabilities/create_service_base.rb' + - 'ee/lib/ee/api/helpers/award_emoji.rb' + - 'ee/spec/controllers/admin/licenses/usage_exports_controller_spec.rb' + - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' + - 'ee/spec/features/boards/boards_licensed_features_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' + - 'ee/spec/features/groups/group_roadmap_spec.rb' + - 'ee/spec/finders/namespaces/billed_users_finder_spec.rb' + - 'ee/spec/frontend/fixtures/dast_profiles.rb' + - 'ee/spec/frontend/fixtures/search.rb' + - 'ee/spec/graphql/resolvers/analytics/contribution_analytics/contributions_resolver_spec.rb' + - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' + - 'ee/spec/graphql/types/dast_site_profile_type_spec.rb' + - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' + - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' + - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/Jobs/browser_performance_testing_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb' + - 'ee/spec/models/analytics/cycle_analytics/group_value_stream_spec.rb' + - 'ee/spec/models/ee/group_spec.rb' + - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' + - 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb' + - 'ee/spec/policies/project_policy_spec.rb' + - 'ee/spec/requests/api/graphql/analytics/contribution_analytics/contributions_spec.rb' + - 'ee/spec/requests/api/graphql/group/epics_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb' + - 'ee/spec/requests/api/graphql/project/merge_requests_spec.rb' + - 'ee/spec/requests/api/ldap_group_links_spec.rb' + - 'ee/spec/requests/api/members_spec.rb' + - 'ee/spec/requests/api/saml_group_links_spec.rb' + - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' + - 'ee/spec/services/audit_events/export_csv_service_spec.rb' + - 'ee/spec/services/groups/seat_usage_export_service_spec.rb' + - 'lib/gitlab/email/message/in_product_marketing/team.rb' + - 'lib/gitlab/email/message/in_product_marketing/trial.rb' + - 'lib/gitlab/email/message/in_product_marketing/verify.rb' + - 'lib/gitlab/object_hierarchy.rb' + - 'lib/gitlab/project_authorizations.rb' + - 'qa/qa/specs/features/api/12_systems/gitaly/automatic_failover_and_recovery_spec.rb' + - 'qa/qa/specs/features/api/12_systems/gitaly/changing_repository_storage_spec.rb' + - 'qa/qa/specs/features/api/12_systems/gitaly/praefect_dataloss_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/infrastructure_registry/terraform_module_registry_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb' + - 'qa/qa/specs/features/ee/api/9_data_stores/elasticsearch/index_tests/main_index/blob_index_spec.rb' + - 'qa/qa/specs/features/ee/api/9_data_stores/elasticsearch/nightly_elasticsearch_test_spec.rb' + - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/finders/groups/accepting_project_transfers_finder_spec.rb' + - 'spec/graphql/mutations/commits/create_spec.rb' + - 'spec/graphql/resolvers/environments/nested_environments_resolver_spec.rb' + - 'spec/graphql/types/commit_signatures/verification_status_enum_spec.rb' + - 'spec/lib/gitlab/analytics/usage_trends/workers_argument_builder_spec.rb' + - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' + - 'spec/lib/gitlab/backtrace_cleaner_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/id_token_spec.rb' + - 'spec/lib/gitlab/ci/secure_files/x509_name_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/service_discovery/sampler_spec.rb' + - 'spec/lib/gitlab/diff/inline_diff_spec.rb' + - 'spec/lib/gitlab/github_import/importer/diff_notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/lfs_objects_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' + - 'spec/lib/gitlab/usage_data/topology_spec.rb' + - 'spec/models/group_group_link_spec.rb' + - 'spec/models/project_group_link_spec.rb' + - 'spec/models/user_preference_spec.rb' + - 'spec/services/issues/referenced_merge_requests_service_spec.rb' + - 'spec/services/security/merge_reports_service_spec.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index e1ac4ccb650669fda03da60de9b6af3df83f676f..a4b520add75ebb83997afd0c06a08450f8812fcc 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -1,292 +1,159 @@ --- # Cop supports --autocorrect. Layout/FirstHashElementIndentation: + Details: grace period Exclude: - - 'app/helpers/avatars_helper.rb' - - 'app/helpers/breadcrumbs_helper.rb' - - 'app/helpers/broadcast_messages_helper.rb' + - 'app/controllers/admin/system_info_controller.rb' + - 'app/controllers/concerns/milestone_actions.rb' + - 'app/controllers/concerns/render_service_results.rb' + - 'app/controllers/concerns/sourcegraph_decorator.rb' + - 'app/controllers/projects/badges_controller.rb' + - 'app/controllers/projects/merge_requests_controller.rb' + - 'app/controllers/repositories/lfs_locks_api_controller.rb' + - 'app/experiments/concerns/project_commit_count.rb' + - 'app/graphql/mutations/notes/create/diff_note.rb' + - 'app/graphql/mutations/notes/create/image_diff_note.rb' + - 'app/graphql/mutations/notes/create/note.rb' + - 'app/graphql/resolvers/ci/runner_projects_resolver.rb' + - 'app/graphql/resolvers/group_packages_resolver.rb' - 'app/helpers/commits_helper.rb' - - 'app/helpers/environments_helper.rb' - - 'app/helpers/keyset_helper.rb' - - 'app/helpers/listbox_helper.rb' - - 'app/helpers/page_layout_helper.rb' - 'app/helpers/projects/project_members_helper.rb' - 'app/helpers/search_helper.rb' - - 'app/helpers/sorting_helper.rb' - 'app/helpers/ssh_keys_helper.rb' - 'app/helpers/tags_helper.rb' - - 'app/helpers/tree_helper.rb' - - 'app/helpers/users_helper.rb' - - 'app/mailers/emails/issues.rb' - - 'app/mailers/emails/merge_requests.rb' - 'app/models/application_setting.rb' - - 'app/models/ci/build.rb' - 'app/models/ci/build_metadata.rb' - - 'app/models/ci/runner.rb' - 'app/models/clusters/applications/crossplane.rb' - - 'app/models/clusters/platforms/kubernetes.rb' - - 'app/models/concerns/cross_database_modification.rb' - - 'app/models/concerns/featurable.rb' - 'app/models/concerns/has_wiki_page_slug_attributes.rb' - - 'app/models/concerns/integrations/enable_ssl_verification.rb' - 'app/models/concerns/subscribable.rb' - 'app/models/concerns/taskable.rb' - 'app/models/diff_note.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/jira_connect_installation.rb' + - 'app/models/merge_request.rb' - 'app/models/milestone.rb' - - 'app/models/note.rb' - 'app/models/operations/feature_flags/strategy.rb' - 'app/models/project.rb' - - 'app/models/wiki.rb' - 'app/presenters/ci/build_metadata_presenter.rb' - - 'app/presenters/packages/helm/index_presenter.rb' - - 'app/serializers/cluster_serializer.rb' - 'app/serializers/detailed_status_entity.rb' - - 'app/services/award_emojis/base_service.rb' - - 'app/services/ci/runners/reconcile_existing_runner_versions_service.rb' - - 'app/services/google_cloud/create_service_accounts_service.rb' - - 'app/services/members/create_service.rb' - - 'app/services/notification_service.rb' - - 'app/services/packages/composer/create_package_service.rb' - - 'app/services/pages/delete_service.rb' - - 'app/services/projects/after_rename_service.rb' - - 'app/services/projects/create_service.rb' - - 'app/services/projects/destroy_service.rb' - - 'app/services/projects/transfer_service.rb' - - 'app/services/projects/update_pages_service.rb' - - 'app/services/projects/update_service.rb' - - 'app/services/resource_events/change_milestone_service.rb' + - 'app/services/audit_events/build_service.rb' - 'app/services/spam/ham_service.rb' - - 'app/services/timelogs/base_service.rb' - - 'app/validators/addressable_url_validator.rb' - - 'app/workers/concerns/cluster_cleanup_methods.rb' + - 'app/services/work_items/widgets/milestone_service/base_service.rb' + - 'app/validators/bytesize_validator.rb' - 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/notification_alert_component.rb' - - 'ee/app/controllers/groups/analytics/tasks_by_type_controller.rb' - 'ee/app/graphql/mutations/boards/epic_lists/destroy.rb' - 'ee/app/graphql/mutations/boards/epics/create.rb' - 'ee/app/graphql/mutations/iterations/cadences/update.rb' - 'ee/app/graphql/mutations/iterations/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - - 'ee/app/graphql/mutations/projects/set_compliance_framework.rb' - - 'ee/app/graphql/mutations/security_policy/commit_scan_execution_policy.rb' - - 'ee/app/helpers/ee/application_settings_helper.rb' - - 'ee/app/helpers/ee/ci/jobs_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' - - 'ee/app/helpers/ee/namespaces_helper.rb' - - 'ee/app/helpers/ee/projects_helper.rb' - - 'ee/app/helpers/ee/sidebars_helper.rb' - - 'ee/app/helpers/ee/tree_helper.rb' + - 'ee/app/helpers/ee/trial_helper.rb' - 'ee/app/helpers/incident_management/escalation_policy_helper.rb' - - 'ee/app/helpers/paid_feature_callout_helper.rb' - - 'ee/app/helpers/projects/on_demand_scans_helper.rb' - - 'ee/app/helpers/projects/security/dast_profiles_helper.rb' - - 'ee/app/mailers/ee/emails/issues.rb' - 'ee/app/models/ee/list.rb' - - 'ee/app/serializers/ee/environment_serializer.rb' - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - - 'ee/app/services/app_sec/dast/site_profiles/update_service.rb' - - 'ee/app/services/ee/auth/container_registry_authentication_service.rb' - - 'ee/app/services/ee/ci/register_job_service.rb' - - 'ee/app/services/ee/issues/export_csv_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/gitlab_subscriptions/plan_upgrade_service.rb' - - 'ee/app/services/incident_management/issuable_resource_links/base_service.rb' - - 'ee/app/services/jira/requests/issues/list_service.rb' + - 'ee/app/services/iterations/create_service.rb' + - 'ee/app/services/registrations/base_namespace_create_service.rb' + - 'ee/app/services/resource_events/change_iteration_service.rb' - 'ee/app/services/security/token_revocation_service.rb' - 'ee/app/services/timebox_report_service.rb' - - 'ee/app/workers/elastic_delete_project_worker.rb' - - 'ee/app/workers/groups/create_event_worker.rb' - - 'ee/lib/api/epic_links.rb' - - 'ee/lib/ee/api/geo.rb' - 'ee/lib/ee/container_registry/client.rb' - - 'ee/lib/ee/gitlab/application_rate_limiter.rb' - 'ee/lib/ee/gitlab/ci/parsers.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/elastic/latest/issue_class_proxy.rb' - - 'ee/lib/gitlab/geo/project_log_helpers.rb' + - 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb' + - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb' - - 'ee/lib/gitlab/status_page/storage/s3_multipart_upload.rb' - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/variables_controller_spec.rb' - - 'ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' - 'ee/spec/controllers/groups/issues_controller_spec.rb' - - 'ee/spec/controllers/projects/feature_flag_issues_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - - 'ee/spec/controllers/projects/licenses_controller_spec.rb' + - 'ee/spec/controllers/projects/repositories_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/security/projects_controller_spec.rb' - - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' + - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/factories/dependencies.rb' - 'ee/spec/factories/licenses.rb' - 'ee/spec/finders/epics_finder_spec.rb' - - 'ee/spec/frontend/fixtures/dast_profiles.rb' - - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' + - 'ee/spec/finders/namespaces/free_user_cap/users_finder_spec.rb' + - 'ee/spec/frontend/fixtures/oncall_schedule.rb' - 'ee/spec/frontend/fixtures/search.rb' - - 'ee/spec/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb' + - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/destroy_spec.rb' + - 'ee/spec/graphql/types/asset_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' - - 'ee/spec/helpers/ee/access_tokens_helper_spec.rb' - - 'ee/spec/helpers/ee/groups_helper_spec.rb' - - 'ee/spec/helpers/ee/labels_helper_spec.rb' - - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/security/sast_configuration_helper_spec.rb' - - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - - 'ee/spec/helpers/groups/sso_helper_spec.rb' - - 'ee/spec/helpers/nav/new_dropdown_helper_spec.rb' - - 'ee/spec/helpers/projects_helper_spec.rb' - - 'ee/spec/helpers/search_helper_spec.rb' - - 'ee/spec/helpers/security_helper_spec.rb' - - 'ee/spec/helpers/trial_registrations/reassurances_helper_spec.rb' + - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' + - 'ee/spec/helpers/billing_plans_helper_spec.rb' + - 'ee/spec/helpers/groups/security_features_helper_spec.rb' + - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' + - 'ee/spec/initializers/fog_google_https_private_urls_spec.rb' + - 'ee/spec/lib/audit/compliance_framework_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/project_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/project_ci_cd_setting_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/project_setting_changes_auditor_spec.rb' - 'ee/spec/lib/container_registry/client_spec.rb' - - 'ee/spec/lib/ee/backup/repositories_spec.rb' - - 'ee/spec/lib/ee/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' + - 'ee/spec/lib/ee/api/entities/experiment_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/config/entry/bridge_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb' - - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/membership_updater_spec.rb' - - 'ee/spec/lib/gitlab/auth/saml/membership_updater_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb' - - 'ee/spec/lib/gitlab/ci/config/entry/job_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/coverage_fuzzing/report_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/security/finding_spec.rb' - - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' - - 'ee/spec/lib/gitlab/contribution_analytics/data_collector_spec.rb' - - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' - - 'ee/spec/lib/gitlab/web_ide/config/entry/schemas_spec.rb' - - 'ee/spec/lib/system_check/app/search_check_spec.rb' - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' - 'ee/spec/mailers/emails/requirements_spec.rb' - - 'ee/spec/models/analytics/cycle_analytics/project_stage_spec.rb' - - 'ee/spec/models/concerns/elastic/application_versioned_search_spec.rb' - - 'ee/spec/models/concerns/elastic/merge_request_spec.rb' - - 'ee/spec/models/concerns/elastic/milestone_spec.rb' - - 'ee/spec/models/concerns/elastic/snippet_spec.rb' - - 'ee/spec/models/security/finding_spec.rb' + - 'ee/spec/models/concerns/elastic/issue_spec.rb' + - 'ee/spec/models/concerns/elastic/note_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - - 'ee/spec/requests/api/experiments_spec.rb' - - 'ee/spec/requests/api/geo_spec.rb' - - 'ee/spec/requests/api/graphql/app_sec/fuzzing/api/ci_configuration_type_spec.rb' - - 'ee/spec/requests/api/graphql/app_sec/fuzzing/coverage/corpus_type_spec.rb' - - 'ee/spec/requests/api/graphql/ci/minutes/usage_spec.rb' - - 'ee/spec/requests/api/graphql/milestone_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/gitlab_subscriptions/activate_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/timelogs/create_spec.rb' - - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb' - - 'ee/spec/requests/api/members_spec.rb' - 'ee/spec/requests/api/merge_requests_spec.rb' + - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' - 'ee/spec/requests/groups/group_members_controller_spec.rb' - - 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb' - - 'ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb' - - 'ee/spec/serializers/license_entity_spec.rb' - - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb' - - 'ee/spec/serializers/security/vulnerability_report_data_entity_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/data_loader_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profile_schedules/audit/update_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/audit/update_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_profiles/audit/update_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_profiles/create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/site_profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/fuzzing/api/ci_configuration_create_service_spec.rb' - - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb' - - 'ee/spec/services/approval_rules/create_service_spec.rb' - - 'ee/spec/services/approval_rules/update_service_spec.rb' - - 'ee/spec/services/audit_event_service_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service_spec.rb' + - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb' + - 'ee/spec/services/deploy_keys/create_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/create_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' - - 'ee/spec/services/ee/post_receive_service_spec.rb' + - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb' + - 'ee/spec/services/ee/projects/deploy_tokens/destroy_service_spec.rb' + - 'ee/spec/services/ee/projects/unlink_fork_service_spec.rb' - 'ee/spec/services/external_status_checks/create_service_spec.rb' - - 'ee/spec/services/geo/node_status_request_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/check_future_renewal_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/create_trial_or_lead_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/reconciliations/check_seat_usage_alerts_eligibility_service_spec.rb' + - 'ee/spec/services/external_status_checks/destroy_service_spec.rb' - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/destroy_service_spec.rb' - 'ee/spec/services/iterations/create_service_spec.rb' - 'ee/spec/services/projects/create_service_spec.rb' + - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb' + - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' - 'ee/spec/services/projects/transfer_service_spec.rb' - - 'ee/spec/services/security/report_summary_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' - 'ee/spec/services/security/token_revocation_service_spec.rb' - 'ee/spec/services/security/track_scan_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - - 'ee/spec/services/users/abuse/git_abuse/namespace_throttle_service_spec.rb' - - 'ee/spec/support/helpers/ee/login_helpers.rb' - - 'ee/spec/support/shared_contexts/fixtures/analytics_shared_context.rb' - - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/namespace_storage_limit_alert_shared_examples.rb' - - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - - 'ee/spec/workers/analytics/cycle_analytics/consistency_worker_spec.rb' - - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb' - - 'ee/spec/workers/gitlab_subscriptions/notify_seats_exceeded_worker_spec.rb' - - 'lib/api/admin/instance_clusters.rb' - - 'lib/api/group_clusters.rb' - - 'lib/api/project_clusters.rb' - - 'lib/atlassian/jira_connect/client.rb' - - 'lib/banzai/filter/commit_trailers_filter.rb' - 'lib/banzai/filter/playable_link_filter.rb' - - 'lib/banzai/reference_parser/user_parser.rb' - - 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb' - - 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb' + - 'lib/gitlab/application_rate_limiter.rb' - 'lib/gitlab/asciidoc.rb' - 'lib/gitlab/asciidoc/include_processor.rb' - 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb' - 'lib/gitlab/ci/config/entry/processable.rb' - - 'lib/gitlab/database/query_analyzers/gitlab_schemas_metrics.rb' - - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/github_import/importer/diff_note_importer.rb' - - 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/graphql/query_analyzers/ast/logger_analyzer.rb' + - 'lib/gitlab/database/migrations/observers/query_details.rb' + - 'lib/gitlab/database/migrations/observers/transaction_duration.rb' - 'lib/gitlab/hook_data/issue_builder.rb' - 'lib/gitlab/hook_data/release_builder.rb' - - 'lib/gitlab/kubernetes.rb' - - 'lib/gitlab/kubernetes/namespace.rb' - - 'lib/gitlab/kubernetes/rollout_instances.rb' - - 'lib/gitlab/legacy_github_import/client.rb' - - 'lib/gitlab/push_options.rb' - 'lib/gitlab/quick_actions/issuable_actions.rb' - - 'lib/gitlab/usage_data_counters/track_unique_events.rb' - - 'lib/object_storage/direct_upload.rb' - - 'lib/tasks/tanuki_emoji.rake' - - 'qa/qa/ee/resource/board/board_list/project/assignee_board_list.rb' - - 'qa/qa/ee/resource/board/board_list/project/milestone_board_list.rb' - 'qa/qa/resource/snippet.rb' + - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_release_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/commit_to_templated_project_spec.rb' - 'qa/qa/specs/features/api/5_package/container_registry_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_omnibus_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb' @@ -299,17 +166,10 @@ Layout/FirstHashElementIndentation: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' - - 'spec/components/diffs/stats_component_spec.rb' - - 'spec/components/pajamas/component_spec.rb' - - 'spec/config/object_store_settings_spec.rb' - - 'spec/config/smime_signature_settings_spec.rb' - - 'spec/controllers/application_controller_spec.rb' - - 'spec/controllers/concerns/import_url_params_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/5_package/dependency_proxy_sso_spec.rb' + - 'qa/spec/support/formatters/test_metrics_formatter_spec.rb' - 'spec/controllers/concerns/issuable_collections_spec.rb' - 'spec/controllers/groups/group_members_controller_spec.rb' - - 'spec/controllers/groups/packages_controller_spec.rb' - - 'spec/controllers/groups/registry/repositories_controller_spec.rb' - - 'spec/controllers/import/available_namespaces_controller_spec.rb' - 'spec/controllers/import/manifest_controller_spec.rb' - 'spec/controllers/projects/boards_controller_spec.rb' - 'spec/controllers/projects/branches_controller_spec.rb' @@ -318,260 +178,105 @@ Layout/FirstHashElementIndentation: - 'spec/controllers/projects/design_management/designs/raw_images_controller_spec.rb' - 'spec/controllers/projects/design_management/designs/resized_image_controller_spec.rb' - 'spec/controllers/projects/environments_controller_spec.rb' - - 'spec/controllers/projects/feature_flags_controller_spec.rb' - - 'spec/controllers/projects/grafana_api_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests_controller_spec.rb' - 'spec/controllers/projects/milestones_controller_spec.rb' - 'spec/controllers/projects/notes_controller_spec.rb' - - 'spec/controllers/projects/packages/packages_controller_spec.rb' - - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' - 'spec/controllers/projects/project_members_controller_spec.rb' - 'spec/controllers/projects/registry/repositories_controller_spec.rb' - 'spec/controllers/projects/registry/tags_controller_spec.rb' + - 'spec/controllers/projects/tags_controller_spec.rb' - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/factories/ci/builds.rb' - 'spec/factories/packages/debian/file_metadatum.rb' - - 'spec/features/gitlab_experiments_spec.rb' - 'spec/frontend/fixtures/autocomplete_sources.rb' - - 'spec/frontend/fixtures/blob.rb' - - 'spec/frontend/fixtures/jobs.rb' - - 'spec/frontend/fixtures/runner.rb' - - 'spec/graphql/mutations/release_asset_links/create_spec.rb' - - 'spec/graphql/resolvers/concerns/caching_array_resolver_spec.rb' - - 'spec/graphql/resolvers/crm/organizations_resolver_spec.rb' - 'spec/graphql/types/ci/detailed_status_type_spec.rb' - - 'spec/helpers/access_tokens_helper_spec.rb' - - 'spec/helpers/admin/application_settings/settings_helper_spec.rb' - - 'spec/helpers/admin/deploy_key_helper_spec.rb' - - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - - 'spec/helpers/ci/builds_helper_spec.rb' - - 'spec/helpers/ci/jobs_helper_spec.rb' - - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' - - 'spec/helpers/deploy_tokens_helper_spec.rb' - - 'spec/helpers/groups/settings_helper_spec.rb' - - 'spec/helpers/groups_helper_spec.rb' - - 'spec/helpers/issuables_helper_spec.rb' - - 'spec/helpers/namespaces_helper_spec.rb' - - 'spec/helpers/page_layout_helper_spec.rb' - - 'spec/helpers/projects/cluster_agents_helper_spec.rb' - - 'spec/helpers/projects/pipeline_helper_spec.rb' - - 'spec/helpers/releases_helper_spec.rb' + - 'spec/helpers/groups/observability_helper_spec.rb' + - 'spec/helpers/learn_gitlab_helper_spec.rb' + - 'spec/helpers/projects/pages_helper_spec.rb' - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - - 'spec/helpers/search_helper_spec.rb' - - 'spec/helpers/sorting_helper_spec.rb' - - 'spec/initializers/direct_upload_support_spec.rb' - - 'spec/lib/api/entities/bulk_imports/export_status_spec.rb' - - 'spec/lib/api/entities/design_management/design_spec.rb' - - 'spec/lib/api/entities/merge_request_approvals_spec.rb' + - 'spec/initializers/rack_multipart_patch_spec.rb' - 'spec/lib/api/entities/personal_access_token_spec.rb' - - 'spec/lib/atlassian/jira_connect/client_spec.rb' - - 'spec/lib/backup/database_spec.rb' - - 'spec/lib/backup/repositories_spec.rb' - - 'spec/lib/banzai/filter/audio_link_filter_spec.rb' - - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - - 'spec/lib/banzai/filter/video_link_filter_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/milestones_pipeline_spec.rb' - - 'spec/lib/bulk_imports/groups/pipelines/project_entities_pipeline_spec.rb' - - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/stage_spec.rb' - - 'spec/lib/bulk_imports/groups/transformers/group_attributes_transformer_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/container_expiration_policy_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - 'spec/lib/container_registry/client_spec.rb' - - 'spec/lib/feature/definition_spec.rb' - - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' - - 'spec/lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher_spec.rb' - - 'spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' - - 'spec/lib/gitlab/analytics/cycle_analytics/records_fetcher_spec.rb' - - 'spec/lib/gitlab/api_authentication/builder_spec.rb' + - 'spec/lib/gitlab/application_rate_limiter_spec.rb' - 'spec/lib/gitlab/asciidoc_spec.rb' - - 'spec/lib/gitlab/auth/ldap/config_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - - 'spec/lib/gitlab/auth/request_authenticator_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - - 'spec/lib/gitlab/changes_list_spec.rb' - - 'spec/lib/gitlab/checks/changes_access_spec.rb' - - 'spec/lib/gitlab/ci/build/cache_spec.rb' - - 'spec/lib/gitlab/ci/build/step_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/bridge_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/product/variables_spec.rb' - - 'spec/lib/gitlab/ci/config/yaml/tags/resolver_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' + - 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build/cache_spec.rb' - - 'spec/lib/gitlab/ci/reports/coverage_report_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/identifier_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - - 'spec/lib/gitlab/ci/reports/terraform_reports_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' - 'spec/lib/gitlab/data_builder/build_spec.rb' - 'spec/lib/gitlab/data_builder/issuable_spec.rb' - 'spec/lib/gitlab/data_builder/pipeline_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - - 'spec/lib/gitlab/database_spec.rb' - - 'spec/lib/gitlab/error_tracking/error_repository/open_api_strategy_spec.rb' - - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/git/conflict/file_spec.rb' - - 'spec/lib/gitlab/git/hook_env_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/gitaly_client/operation_service_spec.rb' - - 'spec/lib/gitlab/gitaly_client_spec.rb' - - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' - - 'spec/lib/gitlab/github_import/logger_spec.rb' - - 'spec/lib/gitlab/github_import/object_counter_spec.rb' - - 'spec/lib/gitlab/gpg_spec.rb' - - 'spec/lib/gitlab/graphql/query_analyzers/ast/logger_analyzer_spec.rb' - - 'spec/lib/gitlab/graphql/tracers/logger_tracer_spec.rb' - - 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - - 'spec/lib/gitlab/i18n_spec.rb' - - 'spec/lib/gitlab/import/logger_spec.rb' + - 'spec/lib/gitlab/git/gitmodules_parser_spec.rb' - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' - 'spec/lib/gitlab/instrumentation_helper_spec.rb' - - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - - 'spec/lib/gitlab/kubernetes/rollout_instances_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb' - - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/order_by_columns_spec.rb' - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - - 'spec/lib/gitlab/prometheus_client_spec.rb' - - 'spec/lib/gitlab/push_options_spec.rb' - - 'spec/lib/gitlab/submodule_links_spec.rb' - - 'spec/lib/gitlab/usage_data/topology_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - - 'spec/lib/gitlab/web_ide/config/entry/global_spec.rb' + - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb' + - 'spec/lib/gitlab/workhorse_spec.rb' - 'spec/lib/mattermost/team_spec.rb' - - 'spec/lib/microsoft_teams/activity_spec.rb' - - 'spec/lib/peek/views/memory_spec.rb' + - 'spec/lib/peek/views/redis_detailed_spec.rb' - 'spec/mailers/emails/merge_requests_spec.rb' - - 'spec/models/active_session_spec.rb' - - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/ci_platform_metric_spec.rb' - - 'spec/models/clusters/applications/prometheus_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/gpg_key_spec.rb' - - 'spec/models/instance_configuration_spec.rb' - - 'spec/models/integrations/base_chat_notification_spec.rb' - - 'spec/models/integrations/chat_message/deployment_message_spec.rb' - - 'spec/models/integrations/chat_message/issue_message_spec.rb' + - 'spec/models/ci/build_spec.rb' - 'spec/models/integrations/chat_message/merge_message_spec.rb' - - 'spec/models/integrations/chat_message/note_message_spec.rb' - - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - - 'spec/models/integrations/chat_message/push_message_spec.rb' - - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - - 'spec/models/integrations/prometheus_spec.rb' - - 'spec/models/loose_foreign_keys/modification_tracker_spec.rb' - - 'spec/models/merge_request_diff_commit_spec.rb' - - 'spec/models/note_spec.rb' - - 'spec/models/remote_mirror_spec.rb' + - 'spec/models/pages/lookup_path_spec.rb' + - 'spec/requests/api/ci/pipelines_spec.rb' - 'spec/requests/api/ci/runner/runners_post_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' - - 'spec/requests/api/feature_flags_spec.rb' - - 'spec/requests/api/feature_flags_user_lists_spec.rb' - 'spec/requests/api/graphql/ci/config_spec.rb' - - 'spec/requests/api/graphql/ci/group_variables_spec.rb' - - 'spec/requests/api/graphql/ci/instance_variables_spec.rb' - - 'spec/requests/api/graphql/ci/project_variables_spec.rb' - - 'spec/requests/api/graphql/group/milestones_spec.rb' - 'spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb' - - 'spec/requests/api/graphql/mutations/timelogs/create_spec.rb' - - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' - - 'spec/requests/api/graphql/project/release_spec.rb' - - 'spec/requests/api/graphql/project_query_spec.rb' - - 'spec/requests/api/internal/base_spec.rb' - - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/project_import_spec.rb' - - 'spec/requests/api/project_snapshots_spec.rb' - - 'spec/requests/api/projects_spec.rb' + - 'spec/requests/api/graphql/project/fork_details_spec.rb' + - 'spec/requests/api/ml/mlflow_spec.rb' - 'spec/requests/api/releases_spec.rb' - - 'spec/requests/api/repositories_spec.rb' - - 'spec/requests/api/settings_spec.rb' - 'spec/requests/api/task_completion_status_spec.rb' - - 'spec/requests/api/unleash_spec.rb' - - 'spec/requests/git_http_spec.rb' - 'spec/requests/groups/email_campaigns_controller_spec.rb' - - 'spec/requests/jira_authorizations_spec.rb' - - 'spec/requests/jira_connect/installations_controller_spec.rb' - - 'spec/requests/lfs_http_spec.rb' - - 'spec/serializers/blob_entity_spec.rb' - - 'spec/serializers/integrations/harbor_serializers/artifact_entity_spec.rb' - - 'spec/serializers/integrations/harbor_serializers/repository_entity_spec.rb' - - 'spec/serializers/integrations/harbor_serializers/tag_entity_spec.rb' - - 'spec/services/bulk_imports/create_pipeline_trackers_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb' - - 'spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb' - - 'spec/services/ci/create_pipeline_service_spec.rb' - - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - - 'spec/services/ci/play_manual_stage_service_spec.rb' - - 'spec/services/ci/runners/reconcile_existing_runner_versions_service_spec.rb' - - 'spec/services/clusters/agents/create_service_spec.rb' - - 'spec/services/clusters/aws/authorize_role_service_spec.rb' + - 'spec/requests/projects/merge_requests/creations_spec.rb' + - 'spec/requests/pwa_controller_spec.rb' + - 'spec/rubocop/cop/usage_data/distinct_count_by_large_foreign_key_spec.rb' + - 'spec/rubocop/cop/usage_data/histogram_with_large_table_spec.rb' + - 'spec/rubocop/cop/usage_data/instrumentation_superclass_spec.rb' + - 'spec/rubocop/cop/usage_data/large_table_spec.rb' + - 'spec/services/ci/pipeline_artifacts/coverage_report_service_spec.rb' + - 'spec/services/ci/register_job_service_spec.rb' - 'spec/services/clusters/update_service_spec.rb' - - 'spec/services/commits/tag_service_spec.rb' - - 'spec/services/database/consistency_check_service_spec.rb' - - 'spec/services/git/branch_push_service_spec.rb' - - 'spec/services/google_cloud/create_cloudsql_instance_service_spec.rb' - - 'spec/services/import/fogbugz_service_spec.rb' + - 'spec/services/google_cloud/get_cloudsql_instances_service_spec.rb' - 'spec/services/import/github_service_spec.rb' - - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' - - 'spec/services/markdown_content_rewriter_service_spec.rb' - - 'spec/services/merge_requests/build_service_spec.rb' - - 'spec/services/merge_requests/create_service_spec.rb' - - 'spec/services/merge_requests/get_urls_service_spec.rb' - - 'spec/services/merge_requests/refresh_service_spec.rb' - - 'spec/services/merge_requests/update_service_spec.rb' - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' - 'spec/services/notes/render_service_spec.rb' - 'spec/services/packages/debian/parse_debian822_service_spec.rb' - 'spec/services/projects/container_repository/delete_tags_service_spec.rb' - 'spec/services/projects/create_from_template_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - - 'spec/services/projects/operations/update_service_spec.rb' - - 'spec/services/projects/update_service_spec.rb' + - 'spec/services/quick_actions/interpret_service_spec.rb' - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - - 'spec/services/snippets/count_service_spec.rb' - 'spec/sidekiq_cluster/sidekiq_cluster_spec.rb' - - 'spec/support/atlassian/jira_connect/schemata.rb' + - 'spec/spam/concerns/has_spam_action_response_fields_spec.rb' - 'spec/support/helpers/kubernetes_helpers.rb' - - 'spec/support/helpers/login_helpers.rb' - - 'spec/support/helpers/prometheus_helpers.rb' - - 'spec/support/helpers/stub_object_storage.rb' - 'spec/support/helpers/wiki_helpers.rb' - 'spec/support/migrations_helpers/namespaces_helper.rb' - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb' - - 'spec/support/shared_contexts/fixtures/analytics_shared_context.rb' - 'spec/support/shared_contexts/lib/container_registry/client_shared_context.rb' - - 'spec/support/shared_examples/graphql/spam_protection_shared_examples.rb' - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb' - 'spec/support/shared_examples/harbor/repositories_controller_shared_examples.rb' - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb' - - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' - - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' - - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' - - 'spec/support_specs/graphql/arguments_spec.rb' - - 'spec/support_specs/graphql/field_selection_spec.rb' - - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' + - 'spec/support/shared_examples/requests/api/npm_packages_shared_examples.rb' + - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' - - 'spec/views/projects/issues/_issue.html.haml_spec.rb' - - 'spec/workers/ci/runners/reconcile_existing_runner_versions_cron_worker_spec.rb' - - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' + - 'spec/views/layouts/_head.html.haml_spec.rb' diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml index 7aa46e3fd05005cee5a5826292a8908d264ca525..f58e3fe0d600f8ce072653b13cd73fab1d492125 100644 --- a/.rubocop_todo/layout/hash_alignment.yml +++ b/.rubocop_todo/layout/hash_alignment.yml @@ -1,6 +1,6 @@ --- # Cop supports --autocorrect. Layout/HashAlignment: + Details: grace period Exclude: - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - - 'spec/serializers/environment_serializer_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_leading_space.yml b/.rubocop_todo/layout/line_continuation_leading_space.yml new file mode 100644 index 0000000000000000000000000000000000000000..14ab2e15857f5509e933bc2b4663c67acb344c9f --- /dev/null +++ b/.rubocop_todo/layout/line_continuation_leading_space.yml @@ -0,0 +1,75 @@ +--- +Layout/LineContinuationLeadingSpace: + Details: grace period + Exclude: + - 'app/graphql/resolvers/issues/base_resolver.rb' + - 'app/graphql/resolvers/work_items/types_resolver.rb' + - 'app/graphql/types/query_type.rb' + - 'app/helpers/application_settings_helper.rb' + - 'app/helpers/preferences_helper.rb' + - 'app/models/environment.rb' + - 'app/services/projects/container_repository/destroy_service.rb' + - 'config/initializers_before_autoloader/003_gc_compact.rb' + - 'ee/app/graphql/ee/mutations/issues/create.rb' + - 'ee/app/graphql/ee/types/merge_request_type.rb' + - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb' + - 'ee/app/models/ci/minutes/notification.rb' + - 'ee/app/models/ee/group_group_link.rb' + - 'ee/app/models/ee/project_group_link.rb' + - 'ee/app/models/protected_environment.rb' + - 'ee/app/services/system_notes/epics_service.rb' + - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' + - 'ee/lib/ee/gitlab/git_access.rb' + - 'ee/lib/slack/block_kit/app_home_opened.rb' + - 'ee/lib/tasks/gitlab/geo.rake' + - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' + - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb' + - 'ee/spec/features/groups/members/manage_groups_spec.rb' + - 'ee/spec/features/pending_group_memberships_spec.rb' + - 'ee/spec/features/projects/members/manage_groups_spec.rb' + - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' + - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb' + - 'ee/spec/lib/gitlab/git_access_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_ci_environments_approval_required_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_deployment_approvals_metric_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environments_required_approvals_average_metric_spec.rb' + - 'lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations.rb' + - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb' + - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' + - 'lib/gitlab/github_import/importer/events/changed_reviewer.rb' + - 'lib/gitlab/import_export/project/import_task.rb' + - 'lib/gitlab/reference_counter.rb' + - 'lib/gitlab/tracking/standard_context.rb' + - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb' + - 'rubocop/cop/graphql/descriptions.rb' + - 'rubocop/cop/migration/add_columns_to_wide_tables.rb' + - 'rubocop/cop/migration/background_migrations.rb' + - 'rubocop/cop/migration/update_column_in_batches.rb' + - 'scripts/lib/glfm/parse_examples.rb' + - 'scripts/qa/testcases-check' + - 'spec/features/groups/show_spec.rb' + - 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb' + - 'spec/lib/gitlab/ci/ansi2html_spec.rb' + - 'spec/lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator_spec.rb' + - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' + - 'spec/lib/gitlab/reference_counter_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_cta_clicked_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_sent_metric_spec.rb' + - 'spec/lib/system_check/incoming_email/imap_authentication_check_spec.rb' + - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' + - 'spec/services/feature_flags/update_service_spec.rb' + - 'spec/services/issues/build_service_spec.rb' + - 'spec/support/matchers/have_gitlab_http_status.rb' + - 'spec/support/shared_examples/features/sidebar_shared_examples.rb' + - 'spec/support/shared_examples/lib/email/email_shared_examples.rb' diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml new file mode 100644 index 0000000000000000000000000000000000000000..248922d73978e5ff619efe1a2032b944a319bacd --- /dev/null +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -0,0 +1,224 @@ +--- +# Cop supports --autocorrect. +Layout/LineContinuationSpacing: + Details: grace period + Exclude: + - 'app/controllers/concerns/controller_with_cross_project_access_check.rb' + - 'app/controllers/concerns/verifies_with_email.rb' + - 'app/controllers/projects/google_cloud/databases_controller.rb' + - 'app/graphql/gitlab_schema.rb' + - 'app/graphql/mutations/boards/issues/issue_move_list.rb' + - 'app/graphql/types/environment_type.rb' + - 'app/helpers/application_settings_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/tags_helper.rb' + - 'app/helpers/tree_helper.rb' + - 'app/models/concerns/spammable.rb' + - 'app/models/environment.rb' + - 'app/models/integrations/base_third_party_wiki.rb' + - 'app/models/integrations/teamcity.rb' + - 'app/models/members/member_role.rb' + - 'app/models/work_items/parent_link.rb' + - 'app/services/feature_flags/update_service.rb' + - 'app/services/issues/build_service.rb' + - 'app/services/merge_requests/merge_service.rb' + - 'app/services/uploads/destroy_service.rb' + - 'app/services/users/email_verification/validate_token_service.rb' + - 'config/initializers_before_autoloader/003_gc_compact.rb' + - 'ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb' + - 'ee/app/components/namespaces/storage/user_pre_enforcement_alert_component.rb' + - 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb' + - 'ee/app/controllers/users/identity_verification_controller.rb' + - 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb' + - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb' + - 'ee/app/graphql/mutations/security_policy/assign_security_policy_project.rb' + - 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb' + - 'ee/app/graphql/resolvers/vulnerabilities_resolver.rb' + - 'ee/app/graphql/resolvers/vulnerability_severities_count_resolver.rb' + - 'ee/app/graphql/types/geo/geo_node_type.rb' + - 'ee/app/graphql/types/requirements_management/requirement_type.rb' + - 'ee/app/helpers/push_rules_helper.rb' + - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/group_group_link.rb' + - 'ee/app/models/ee/project_group_link.rb' + - 'ee/app/models/ee/vulnerability.rb' + - 'ee/app/models/incident_management/oncall_shift.rb' + - 'ee/app/services/audit_events/protected_branch_audit_event_service.rb' + - 'ee/app/services/boards/epic_lists/destroy_service.rb' + - 'ee/app/services/epics/epic_links/create_service.rb' + - 'ee/app/services/group_saml/saml_group_links/create_service.rb' + - 'ee/app/services/phone_verification/telesign_client/base_service.rb' + - 'ee/app/services/phone_verification/telesign_client/risk_score_service.rb' + - 'ee/app/services/phone_verification/users/send_verification_code_service.rb' + - 'ee/app/services/phone_verification/users/verify_code_service.rb' + - 'ee/lib/api/experiments.rb' + - 'ee/lib/api/ldap_group_links.rb' + - 'ee/lib/api/vulnerability_findings.rb' + - 'ee/lib/ee/gitlab/auth/ldap/access.rb' + - 'ee/lib/ee/gitlab/ci/pipeline/quota/activity.rb' + - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' + - 'ee/lib/ee/gitlab/git_access.rb' + - 'ee/lib/tasks/gitlab/geo.rake' + - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb' + - 'ee/spec/controllers/groups/group_members_controller_spec.rb' + - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' + - 'ee/spec/features/admin/admin_emails_spec.rb' + - 'ee/spec/features/admin/licenses/admin_adds_license_spec.rb' + - 'ee/spec/features/groups/group_overview_spec.rb' + - 'ee/spec/features/groups/members/manage_groups_spec.rb' + - 'ee/spec/features/groups_spec.rb' + - 'ee/spec/features/projects/members/manage_groups_spec.rb' + - 'ee/spec/features/protected_branches_spec.rb' + - 'ee/spec/features/protected_tags_spec.rb' + - 'ee/spec/features/registrations/email_confirmation_spec.rb' + - 'ee/spec/features/users/identity_verification_spec.rb' + - 'ee/spec/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb' + - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/destroy_spec.rb' + - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb' + - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb' + - 'ee/spec/helpers/ee/labels_helper_spec.rb' + - 'ee/spec/helpers/push_rules_helper_spec.rb' + - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' + - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb' + - 'ee/spec/lib/gitlab/git_access_spec.rb' + - 'ee/spec/mailers/ee/emails/identity_verification_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epics/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epics/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/issues/set_epic_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/issues/set_weight_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/projects/initialize_product_analytics_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/projects/set_compliance_framework_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/requirements_management/create_requirement_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security/finding/create_issue_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/users/abuse/namespace_bans/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/finding_dismiss_spec.rb' + - 'ee/spec/requests/users/identity_verification_controller_spec.rb' + - 'ee/spec/services/boards/epic_lists/destroy_service_spec.rb' + - 'ee/spec/services/epic_issues/create_service_spec.rb' + - 'ee/spec/services/epics/epic_links/create_service_spec.rb' + - 'ee/spec/services/phone_verification/telesign_client/risk_score_service_spec.rb' + - 'ee/spec/services/phone_verification/telesign_client/send_verification_code_service_spec.rb' + - 'ee/spec/services/phone_verification/users/send_verification_code_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/ci_configuration_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/legacy_ci_configuration_service_spec.rb' + - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' + - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb' + - 'lib/api/dependency_proxy.rb' + - 'lib/api/error_tracking/client_keys.rb' + - 'lib/api/error_tracking/project_settings.rb' + - 'lib/api/go_proxy.rb' + - 'lib/api/groups.rb' + - 'lib/api/issue_links.rb' + - 'lib/api/metrics/dashboard/annotations.rb' + - 'lib/api/ml/mlflow.rb' + - 'lib/gitlab/auth/user_access_denied_reason.rb' + - 'lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations.rb' + - 'lib/gitlab/checks/tag_check.rb' + - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb' + - 'lib/gitlab/config_checker/puma_rugged_checker.rb' + - 'lib/gitlab/database/background_migration/batched_migration_runner.rb' + - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers.rb' + - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base.rb' + - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb' + - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_projects.rb' + - 'lib/gitlab/database/shared_model.rb' + - 'lib/gitlab/i18n/po_linter.rb' + - 'qa/qa/specs/features/ee/api/9_data_stores/elasticsearch/nightly_elasticsearch_test_spec.rb' + - 'qa/qa/support/matchers/eventually_matcher.rb' + - 'qa/qa/support/page_error_checker.rb' + - 'qa/qa/tools/test_resources_handler.rb' + - 'qa/spec/resource/user_spec.rb' + - 'qa/spec/support/page_error_checker_spec.rb' + - 'rubocop/cop/graphql/authorize_types.rb' + - 'rubocop/cop/graphql/descriptions.rb' + - 'rubocop/cop/graphql/graphql_name_position.rb' + - 'rubocop/cop/migration/background_migrations.rb' + - 'rubocop/cop/performance/ar_exists_and_present_blank.rb' + - 'rubocop/cop/redis_queue_usage.rb' + - 'scripts/create-pipeline-failure-incident.rb' + - 'scripts/generate-failed-pipeline-slack-message.rb' + - 'scripts/qa/testcases-check' + - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' + - 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb' + - 'spec/features/projects/files/user_browses_files_spec.rb' + - 'spec/features/projects/files/user_creates_directory_spec.rb' + - 'spec/features/projects/files/user_creates_files_spec.rb' + - 'spec/features/projects/files/user_deletes_files_spec.rb' + - 'spec/features/projects/files/user_edits_files_spec.rb' + - 'spec/features/projects/files/user_replaces_files_spec.rb' + - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' + - 'spec/features/u2f_spec.rb' + - 'spec/features/users/email_verification_on_login_spec.rb' + - 'spec/features/users/login_spec.rb' + - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' + - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb' + - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' + - 'spec/lib/gitlab/ci/trace/stream_spec.rb' + - 'spec/lib/gitlab/closing_issue_extractor_spec.rb' + - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' + - 'spec/lib/gitlab/git_access_spec.rb' + - 'spec/lib/gitlab/github_import/markdown_text_spec.rb' + - 'spec/lib/gitlab/github_import/representation/issue_event_spec.rb' + - 'spec/lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_cta_clicked_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_sent_metric_spec.rb' + - 'spec/lib/gitlab/utils/gzip_spec.rb' + - 'spec/lib/system_check/incoming_email/imap_authentication_check_spec.rb' + - 'spec/mailers/emails/identity_verification_spec.rb' + - 'spec/models/diff_note_spec.rb' + - 'spec/models/integrations/base_third_party_wiki_spec.rb' + - 'spec/models/integrations/chat_message/merge_message_spec.rb' + - 'spec/models/integrations/chat_message/push_message_spec.rb' + - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' + - 'spec/models/member_spec.rb' + - 'spec/models/members/member_role_spec.rb' + - 'spec/models/operations/feature_flags_client_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' + - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' + - 'spec/requests/api/graphql/mutations/uploads/delete_spec.rb' + - 'spec/requests/api/group_labels_spec.rb' + - 'spec/requests/api/groups_spec.rb' + - 'spec/requests/api/labels_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/requests/api/users_spec.rb' + - 'spec/requests/verifies_with_email_spec.rb' + - 'spec/services/feature_flags/update_service_spec.rb' + - 'spec/services/issues/build_service_spec.rb' + - 'spec/services/merge_requests/merge_service_spec.rb' + - 'spec/services/snippets/create_service_spec.rb' + - 'spec/services/uploads/destroy_service_spec.rb' + - 'spec/services/users/email_verification/validate_token_service_spec.rb' + - 'spec/services/users/migrate_records_to_ghost_user_service_spec.rb' + - 'spec/support/helpers/redis_without_keys.rb' + - 'spec/support/shared_examples/features/project_upload_files_shared_examples.rb' + - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb' + - 'spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/diff_discussions_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/mutations/subscription_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/resolvable_discussions_shared_examples.rb' + - 'spec/uploaders/file_mover_spec.rb' + - 'spec/views/devise/shared/_signup_box.html.haml_spec.rb' + - 'spec/views/projects/issues/show.html.haml_spec.rb' + - 'spec/views/projects/pages/show.html.haml_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml new file mode 100644 index 0000000000000000000000000000000000000000..b774d92d4ee74ef0b169c1f74a4fe6eb43fa6440 --- /dev/null +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -0,0 +1,358 @@ +--- +# Cop supports --autocorrect. +Layout/LineEndStringConcatenationIndentation: + Details: grace period + Exclude: + - 'app/controllers/admin/application_settings_controller.rb' + - 'app/controllers/concerns/verifies_with_email.rb' + - 'app/finders/snippets_finder.rb' + - 'app/graphql/mutations/ci/project_ci_cd_settings_update.rb' + - 'app/graphql/mutations/ci/runner/bulk_delete.rb' + - 'app/graphql/mutations/environments/canary_ingress/update.rb' + - 'app/graphql/resolvers/ci/runner_projects_resolver.rb' + - 'app/graphql/resolvers/projects_resolver.rb' + - 'app/graphql/types/ci/ci_cd_setting_type.rb' + - 'app/graphql/types/ci/config/include_type.rb' + - 'app/graphql/types/ci/runner_membership_filter_enum.rb' + - 'app/graphql/types/ci/runner_status_enum.rb' + - 'app/graphql/types/issue_type.rb' + - 'app/graphql/types/user_interface.rb' + - 'app/helpers/application_settings_helper.rb' + - 'app/helpers/members_helper.rb' + - 'app/helpers/preferences_helper.rb' + - 'app/helpers/projects/project_members_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/mailers/emails/projects.rb' + - 'app/models/application_setting.rb' + - 'app/models/concerns/bulk_insert_safe.rb' + - 'app/models/concerns/spammable.rb' + - 'app/models/environment.rb' + - 'app/models/integrations/pivotaltracker.rb' + - 'app/models/members/member_role.rb' + - 'app/models/merge_request_diff_commit.rb' + - 'app/models/postgresql/replication_slot.rb' + - 'app/presenters/packages/npm/package_presenter.rb' + - 'app/services/commits/change_service.rb' + - 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb' + - 'app/services/feature_flags/update_service.rb' + - 'app/services/projects/after_rename_service.rb' + - 'app/services/projects/container_repository/destroy_service.rb' + - 'app/services/repositories/changelog_service.rb' + - 'app/services/users/email_verification/validate_token_service.rb' + - 'app/workers/run_pipeline_schedule_worker.rb' + - 'config/initializers/validate_database_config.rb' + - 'config/initializers/wikicloth_disable_lua_patch.rb' + - 'config/initializers/wikicloth_redos_patch.rb' + - 'config/initializers/wikicloth_ruby_3_patch.rb' + - 'config/initializers_before_autoloader/003_gc_compact.rb' + - 'danger/ci_templates/Dangerfile' + - 'danger/database/Dangerfile' + - 'db/post_migrate/20210606143426_add_index_for_container_registry_access_level.rb' + - 'db/post_migrate/20220425121410_add_temporary_index_for_backfill_integrations_enable_ssl_verification.rb' + - 'db/post_migrate/20220525131624_drop_temporary_index_for_backfill_integrations_enable_ssl_verification.rb' + - 'db/post_migrate/20220920081631_prepare_ci_builds_metadata_for_partitioning_primary_key.rb' + - 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb' + - 'ee/app/controllers/admin/licenses_controller.rb' + - 'ee/app/controllers/concerns/insights_actions.rb' + - 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb' + - 'ee/app/controllers/users/identity_verification_controller.rb' + - 'ee/app/finders/geo/framework_registry_finder.rb' + - 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb' + - 'ee/app/graphql/mutations/dast_scanner_profiles/create.rb' + - 'ee/app/graphql/mutations/issues/set_epic.rb' + - 'ee/app/graphql/mutations/issues/set_escalation_policy.rb' + - 'ee/app/graphql/mutations/issues/set_weight.rb' + - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb' + - 'ee/app/graphql/mutations/security_policy/assign_security_policy_project.rb' + - 'ee/app/graphql/resolvers/analytics/contribution_analytics/contributions_resolver.rb' + - 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb' + - 'ee/app/graphql/types/pipeline_security_report_finding_type.rb' + - 'ee/app/helpers/push_rules_helper.rb' + - 'ee/app/models/app_sec/fuzzing/api/ci_configuration.rb' + - 'ee/app/models/ci/minutes/notification.rb' + - 'ee/app/models/ee/group_group_link.rb' + - 'ee/app/models/ee/namespace/storage/notification.rb' + - 'ee/app/models/ee/vulnerability.rb' + - 'ee/app/services/boards/epic_lists/destroy_service.rb' + - 'ee/app/services/ee/admin/set_feature_flag_service.rb' + - 'ee/app/services/ee/auth/container_registry_authentication_service.rb' + - 'ee/app/services/ee/issues/move_service.rb' + - 'ee/app/services/ee/resource_access_tokens/revoke_service.rb' + - 'ee/app/services/merge_trains/create_pipeline_service.rb' + - 'ee/app/services/system_notes/epics_service.rb' + - 'ee/app/workers/concerns/elastic/migration_obsolete.rb' + - 'ee/elastic/migrate/20220613120500_migrate_commits_to_separate_index.rb' + - 'ee/lib/api/experiments.rb' + - 'ee/lib/api/ldap_group_links.rb' + - 'ee/lib/ee/gitlab/auth/ldap/access.rb' + - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' + - 'ee/lib/ee/gitlab/git_access.rb' + - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb' + - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' + - 'ee/lib/slack/block_kit/app_home_opened.rb' + - 'ee/lib/tasks/gitlab/geo.rake' + - 'ee/spec/components/namespaces/free_user_cap/enforcement_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/enforcement_at_limit_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/non_owner_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/usage_quota_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb' + - 'ee/spec/controllers/admin/licenses_controller_spec.rb' + - 'ee/spec/controllers/groups/group_members_controller_spec.rb' + - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' + - 'ee/spec/features/admin/admin_emails_spec.rb' + - 'ee/spec/features/admin/licenses/admin_adds_license_spec.rb' + - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' + - 'ee/spec/features/groups/group_overview_spec.rb' + - 'ee/spec/features/groups/members/manage_groups_spec.rb' + - 'ee/spec/features/groups_spec.rb' + - 'ee/spec/features/pending_group_memberships_spec.rb' + - 'ee/spec/features/projects/members/manage_groups_spec.rb' + - 'ee/spec/features/registrations/email_confirmation_spec.rb' + - 'ee/spec/features/users/identity_verification_spec.rb' + - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/destroy_spec.rb' + - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb' + - 'ee/spec/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' + - 'ee/spec/helpers/ee/labels_helper_spec.rb' + - 'ee/spec/helpers/push_rules_helper_spec.rb' + - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' + - 'ee/spec/lib/ee/gitlab/namespace_storage_size_error_message_spec.rb' + - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/api_security_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/api_security_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/container_scanning_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dast_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/license_scanning_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/license_scanning_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/sast_iac_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/sast_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/secret_detection_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/secret_detection_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/manual_quarterly_co_term_banner_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_deployment_approvals_metric_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environments_required_approvals_average_metric_spec.rb' + - 'ee/spec/mailers/ee/emails/identity_verification_spec.rb' + - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/update_epic_user_preferences_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security/finding/create_issue_spec.rb' + - 'ee/spec/requests/users/identity_verification_controller_spec.rb' + - 'ee/spec/services/boards/epic_lists/destroy_service_spec.rb' + - 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb' + - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb' + - 'ee/spec/services/epics/epic_links/create_service_spec.rb' + - 'ee/spec/services/geo/container_repository_sync_spec.rb' + - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' + - 'ee/spec/services/users/abuse/git_abuse/application_throttle_service_spec.rb' + - 'ee/spec/support/shared_examples/finders/geo/framework_registry_finder_shared_examples.rb' + - 'ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/license_shared_examples.rb' + - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' + - 'ee/spec/views/groups/billings/index.html.haml_spec.rb' + - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb' + - 'lib/api/ci/runners.rb' + - 'lib/api/dependency_proxy.rb' + - 'lib/api/error_tracking/client_keys.rb' + - 'lib/api/error_tracking/project_settings.rb' + - 'lib/api/go_proxy.rb' + - 'lib/api/helpers/pagination_strategies.rb' + - 'lib/api/issue_links.rb' + - 'lib/api/metrics/dashboard/annotations.rb' + - 'lib/backup/manager.rb' + - 'lib/banzai/filter/spaced_link_filter.rb' + - 'lib/feature/definition.rb' + - 'lib/gitlab/audit/type/definition.rb' + - 'lib/gitlab/auth.rb' + - 'lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations.rb' + - 'lib/gitlab/changelog/config.rb' + - 'lib/gitlab/checks/tag_check.rb' + - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb' + - 'lib/gitlab/ci/pipeline/chain/populate.rb' + - 'lib/gitlab/ci/pipeline/seed/build.rb' + - 'lib/gitlab/config_checker/puma_rugged_checker.rb' + - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/database/migration_helpers/restrict_gitlab_schema.rb' + - 'lib/gitlab/database/migrations/background_migration_helpers.rb' + - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb' + - 'lib/gitlab/database/partitioning/partition_manager.rb' + - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' + - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' + - 'lib/gitlab/database/schema_helpers.rb' + - 'lib/gitlab/database/shared_model.rb' + - 'lib/gitlab/github_import/importer/events/changed_reviewer.rb' + - 'lib/gitlab/graphql/authorize/authorize_resource.rb' + - 'lib/gitlab/i18n/po_linter.rb' + - 'lib/gitlab/import_export/project/import_task.rb' + - 'lib/gitlab/path_regex.rb' + - 'lib/gitlab/reference_counter.rb' + - 'lib/gitlab/regex.rb' + - 'lib/gitlab/seeders/ci/runner/runner_fleet_seeder.rb' + - 'lib/gitlab/slash_commands/presenters/run.rb' + - 'lib/gitlab/tracking/standard_context.rb' + - 'lib/tasks/gitlab/db/validate_config.rake' + - 'lib/tasks/gitlab/storage.rake' + - 'qa/qa/ee/page/project/settings/services/jira.rb' + - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb' + - 'qa/qa/support/matchers/eventually_matcher.rb' + - 'qa/qa/support/system_logs/kibana.rb' + - 'qa/qa/tools/revoke_user_personal_access_tokens.rb' + - 'qa/spec/support/page_error_checker_spec.rb' + - 'qa/spec/support/system_logs/kibana_spec.rb' + - 'rubocop/cop/active_record_association_reload.rb' + - 'rubocop/cop/api/grape_array_missing_coerce.rb' + - 'rubocop/cop/avoid_becomes.rb' + - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' + - 'rubocop/cop/database/establish_connection.rb' + - 'rubocop/cop/destroy_all.rb' + - 'rubocop/cop/gitlab/avoid_feature_get.rb' + - 'rubocop/cop/gitlab/change_timezone.rb' + - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' + - 'rubocop/cop/gitlab/rails_logger.rb' + - 'rubocop/cop/gitlab/rspec/avoid_setup.rb' + - 'rubocop/cop/graphql/descriptions.rb' + - 'rubocop/cop/graphql/resolver_type.rb' + - 'rubocop/cop/group_public_or_visible_to_user.rb' + - 'rubocop/cop/ignored_columns.rb' + - 'rubocop/cop/inject_enterprise_edition_module.rb' + - 'rubocop/cop/migration/add_concurrent_index.rb' + - 'rubocop/cop/migration/add_limit_to_text_columns.rb' + - 'rubocop/cop/migration/create_table_with_foreign_keys.rb' + - 'rubocop/cop/migration/prevent_strings.rb' + - 'rubocop/cop/migration/remove_concurrent_index.rb' + - 'rubocop/cop/migration/update_column_in_batches.rb' + - 'rubocop/cop/migration/with_lock_retries_with_change.rb' + - 'rubocop/cop/performance/active_record_subtransaction_methods.rb' + - 'rubocop/cop/performance/active_record_subtransactions.rb' + - 'rubocop/cop/performance/ar_count_each.rb' + - 'rubocop/cop/performance/ar_exists_and_present_blank.rb' + - 'rubocop/cop/performance/readlines_each.rb' + - 'rubocop/cop/project_path_helper.rb' + - 'rubocop/cop/redis_queue_usage.rb' + - 'rubocop/cop/rspec/factory_bot/inline_association.rb' + - 'rubocop/cop/rspec/factory_bot/strategy_in_callback.rb' + - 'rubocop/cop/rspec/have_gitlab_http_status.rb' + - 'rubocop/cop/sidekiq_api_usage.rb' + - 'rubocop/cop/user_admin.rb' + - 'scripts/create-pipeline-failure-incident.rb' + - 'scripts/generate-failed-pipeline-slack-message.rb' + - 'scripts/lib/glfm/parse_examples.rb' + - 'scripts/lib/glfm/update_example_snapshots.rb' + - 'scripts/lib/glfm/update_specification.rb' + - 'scripts/lib/glfm/verify_all_generated_files_are_up_to_date.rb' + - 'scripts/packages/automated_cleanup.rb' + - 'spec/contracts/provider_specs/helpers/provider/contract_source_helper_spec.rb' + - 'spec/controllers/graphql_controller_spec.rb' + - 'spec/controllers/projects/deploy_keys_controller_spec.rb' + - 'spec/features/groups/show_spec.rb' + - 'spec/features/projects/files/user_browses_files_spec.rb' + - 'spec/features/projects/files/user_creates_directory_spec.rb' + - 'spec/features/projects/files/user_creates_files_spec.rb' + - 'spec/features/projects/files/user_deletes_files_spec.rb' + - 'spec/features/projects/files/user_replaces_files_spec.rb' + - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' + - 'spec/features/projects/pipelines/pipeline_spec.rb' + - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' + - 'spec/helpers/markup_helper_spec.rb' + - 'spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb' + - 'spec/lib/banzai/filter/truncate_visible_filter_spec.rb' + - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' + - 'spec/lib/gitlab/ci/ansi2html_spec.rb' + - 'spec/lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator_spec.rb' + - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb' + - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/code_quality_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_latest_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/test_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/npm_spec.rb' + - 'spec/lib/gitlab/ci/templates/themekit_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' + - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' + - 'spec/lib/gitlab/github_import/markdown_text_spec.rb' + - 'spec/lib/gitlab/github_import/representation/issue_event_spec.rb' + - 'spec/lib/gitlab/insecure_key_fingerprint_spec.rb' + - 'spec/lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' + - 'spec/lib/gitlab/reference_counter_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_cta_clicked_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_sent_metric_spec.rb' + - 'spec/lib/gitlab/utils/gzip_spec.rb' + - 'spec/mailers/emails/identity_verification_spec.rb' + - 'spec/mailers/emails/projects_spec.rb' + - 'spec/models/active_session_spec.rb' + - 'spec/models/integrations/chat_message/note_message_spec.rb' + - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' + - 'spec/models/integrations/chat_message/push_message_spec.rb' + - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' + - 'spec/models/member_spec.rb' + - 'spec/models/members/member_role_spec.rb' + - 'spec/models/operations/feature_flags_client_spec.rb' + - 'spec/models/ssh_host_key_spec.rb' + - 'spec/presenters/ci/pipeline_presenter_spec.rb' + - 'spec/presenters/deploy_key_presenter_spec.rb' + - 'spec/presenters/key_presenter_spec.rb' + - 'spec/presenters/releases/link_presenter_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_delete_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_play_spec.rb' + - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' + - 'spec/requests/api/releases_spec.rb' + - 'spec/requests/api/users_spec.rb' + - 'spec/requests/self_monitoring_project_spec.rb' + - 'spec/rubocop/cop/api/grape_array_missing_coerce_spec.rb' + - 'spec/rubocop/cop/group_public_or_visible_to_user_spec.rb' + - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' + - 'spec/scripts/lib/glfm/update_example_snapshots_spec.rb' + - 'spec/serializers/pipeline_serializer_spec.rb' + - 'spec/services/alert_management/alerts/update_service_spec.rb' + - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' + - 'spec/services/ci/create_pipeline_service/rules_spec.rb' + - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/ci/job_artifacts/delete_service_spec.rb' + - 'spec/services/preview_markdown_service_spec.rb' + - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb' + - 'spec/services/snippets/create_service_spec.rb' + - 'spec/services/users/email_verification/validate_token_service_spec.rb' + - 'spec/services/work_items/parent_links/create_service_spec.rb' + - 'spec/support/before_all_adapter.rb' + - 'spec/support/helpers/database/multiple_databases_helpers.rb' + - 'spec/support/helpers/redis_without_keys.rb' + - 'spec/support/matchers/have_gitlab_http_status.rb' + - 'spec/support/memory_instrumentation_helper.rb' + - 'spec/support/shared_examples/features/project_upload_files_shared_examples.rb' + - 'spec/support/shared_examples/lib/email/email_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' + - 'spec/support/shared_examples/requests/self_monitoring_shared_examples.rb' + - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' + - 'spec/uploaders/file_mover_spec.rb' + - 'spec/views/devise/shared/_signup_box.html.haml_spec.rb' + - 'spec/views/projects/pages/show.html.haml_spec.rb' + - 'spec/workers/integrations/irker_worker_spec.rb' diff --git a/.rubocop_todo/layout/parameter_alignment.yml b/.rubocop_todo/layout/parameter_alignment.yml new file mode 100644 index 0000000000000000000000000000000000000000..3942132a1b28897967f36a60f0878271d6f8683b --- /dev/null +++ b/.rubocop_todo/layout/parameter_alignment.yml @@ -0,0 +1,20 @@ +--- +# Cop supports --autocorrect. +Layout/ParameterAlignment: + Details: grace period + Exclude: + - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' + - 'lib/gitlab/cross_project_access.rb' + - 'lib/gitlab/data_builder/push.rb' + - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' + - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' + - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' + - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' + - 'spec/migrations/20210423160427_schedule_drop_invalid_vulnerabilities_spec.rb' + - 'spec/migrations/20210511142748_schedule_drop_invalid_vulnerabilities2_spec.rb' + - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' + - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' + - 'spec/support/helpers/content_security_policy_helpers.rb' + - 'spec/support/helpers/migrations_helpers/vulnerabilities_helper.rb' + - 'spec/support/helpers/repo_helpers.rb' + - 'spec/support/helpers/stub_object_storage.rb' diff --git a/.rubocop_todo/lint/ambiguous_regexp_literal.yml b/.rubocop_todo/lint/ambiguous_regexp_literal.yml new file mode 100644 index 0000000000000000000000000000000000000000..c3236776be2ffa3f313eb8f833e5ea12794ef526 --- /dev/null +++ b/.rubocop_todo/lint/ambiguous_regexp_literal.yml @@ -0,0 +1,95 @@ +--- +# Cop supports --autocorrect. +Lint/AmbiguousRegexpLiteral: + Details: grace period + Exclude: + - 'ee/lib/ee/gitlab/auth/ldap/group.rb' + - 'ee/spec/controllers/groups/sso_controller_spec.rb' + - 'ee/spec/controllers/projects/mirrors_controller_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/status/build/manual_spec.rb' + - 'ee/spec/lib/gitlab/insights/executors/dora_executor_spec.rb' + - 'ee/spec/lib/gitlab/web_ide/config/entry/schema_spec.rb' + - 'ee/spec/lib/gitlab/web_ide/config/entry/schemas_spec.rb' + - 'ee/spec/mailers/ee/emails/profile_spec.rb' + - 'ee/spec/models/push_rule_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' + - 'ee/spec/serializers/pipeline_serializer_spec.rb' + - 'ee/spec/services/analytics/cycle_analytics/aggregator_service_spec.rb' + - 'ee/spec/services/ee/members/create_service_spec.rb' + - 'ee/spec/services/group_saml/saml_group_links/create_service_spec.rb' + - 'ee/spec/views/admin/dashboard/index.html.haml_spec.rb' + - 'ee/spec/views/admin/users/_credit_card_info.html.haml_spec.rb' + - 'ee/spec/views/admin/users/show.html.haml_spec.rb' + - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' + - 'lib/api/features.rb' + - 'qa/spec/page/element_spec.rb' + - 'spec/components/pajamas/avatar_component_spec.rb' + - 'spec/features/atom/users_spec.rb' + - 'spec/features/issues/user_creates_branch_and_merge_request_spec.rb' + - 'spec/features/issues/user_creates_issue_spec.rb' + - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb' + - 'spec/helpers/labels_helper_spec.rb' + - 'spec/helpers/users_helper_spec.rb' + - 'spec/helpers/visibility_level_helper_spec.rb' + - 'spec/initializers/direct_upload_support_spec.rb' + - 'spec/initializers/validate_database_config_spec.rb' + - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' + - 'spec/lib/feature_spec.rb' + - 'spec/lib/gitlab/auth/user_access_denied_reason_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/bridge_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/image_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/imageable_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/job_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/key_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/policy_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/ports_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/reports/coverage_report_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/root_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/service_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/trigger_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/create_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/validate/abilities_spec.rb' + - 'spec/lib/gitlab/ci/status/build/manual_spec.rb' + - 'spec/lib/gitlab/composer/version_index_spec.rb' + - 'spec/lib/gitlab/config/entry/validator_spec.rb' + - 'spec/lib/gitlab/config/entry/validators_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/partitioning_spec.rb' + - 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb' + - 'spec/lib/gitlab/gitaly_client/with_feature_flag_actors_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v2/base_command_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v3/base_command_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/array_scope_columns_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' + - 'spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb' + - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' + - 'spec/lib/gitlab/web_ide/config/entry/global_spec.rb' + - 'spec/lib/gitlab/web_ide/config/entry/terminal_spec.rb' + - 'spec/lib/object_storage/direct_upload_spec.rb' + - 'spec/mailers/devise_mailer_spec.rb' + - 'spec/mailers/emails/profile_spec.rb' + - 'spec/models/concerns/as_cte_spec.rb' + - 'spec/models/concerns/sortable_spec.rb' + - 'spec/models/concerns/spammable_spec.rb' + - 'spec/models/group_spec.rb' + - 'spec/requests/api/deployments_spec.rb' + - 'spec/requests/api/graphql/gitlab_schema_spec.rb' + - 'spec/requests/api/helpers_spec.rb' + - 'spec/scripts/lib/glfm/update_specification_spec.rb' + - 'spec/serializers/commit_entity_spec.rb' + - 'spec/services/loose_foreign_keys/cleaner_service_spec.rb' + - 'spec/services/snippets/repository_validation_service_spec.rb' + - 'spec/services/system_notes/merge_requests_service_spec.rb' + - 'spec/support/shared_examples/features/content_editor_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/sql/set_operator_shared_examples.rb' + - 'spec/support_specs/database/multiple_databases_helpers_spec.rb' + - 'spec/tasks/gitlab/gitaly_rake_spec.rb' + - 'spec/tasks/gitlab/workhorse_rake_spec.rb' + - 'spec/views/devise/sessions/new.html.haml_spec.rb' diff --git a/.rubocop_todo/performance/concurrent_monotonic_time.yml b/.rubocop_todo/performance/concurrent_monotonic_time.yml new file mode 100644 index 0000000000000000000000000000000000000000..0e55eaf4a1861442a71f6fc26ecbd1a247b9bd4a --- /dev/null +++ b/.rubocop_todo/performance/concurrent_monotonic_time.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --autocorrect. +Performance/ConcurrentMonotonicTime: + Details: grace period + Exclude: + - 'lib/gitlab/database/connection_timer.rb' diff --git a/.rubocop_todo/performance/flat_map.yml b/.rubocop_todo/performance/flat_map.yml new file mode 100644 index 0000000000000000000000000000000000000000..32dce1bf317486663f9f2147fc1bbb3b59907d8c --- /dev/null +++ b/.rubocop_todo/performance/flat_map.yml @@ -0,0 +1,38 @@ +--- +# Cop supports --autocorrect. +Performance/FlatMap: + Details: grace period + Exclude: + - 'app/presenters/packages/nuget/service_index_presenter.rb' + - 'app/services/projects/apple_target_platform_detector_service.rb' + - 'ee/app/models/burndown.rb' + - 'ee/app/models/geo_node_status.rb' + - 'ee/app/serializers/dashboard_environments_serializer.rb' + - 'ee/app/services/elastic/process_bookkeeping_service.rb' + - 'ee/lib/elastic/latest/issue_class_proxy.rb' + - 'ee/spec/lib/elastic/latest/user_class_proxy_spec.rb' + - 'ee/spec/models/analytics/issues_analytics_spec.rb' + - 'ee/spec/requests/api/members_spec.rb' + - 'ee/spec/support/helpers/license_scanning_report_helpers.rb' + - 'ee/spec/support/shared_examples/finders/security/findings_finder_shared_examples.rb' + - 'lib/gitlab/ci/pipeline/chain/create_deployments.rb' + - 'lib/gitlab/ci/pipeline/chain/ensure_environments.rb' + - 'lib/gitlab/ci/pipeline/chain/ensure_resource_groups.rb' + - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' + - 'lib/gitlab/diff/file_collection/base.rb' + - 'lib/gitlab/instrumentation/redis_cluster_validator.rb' + - 'lib/gitlab/testing/request_inspector_middleware.rb' + - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' + - 'qa/qa/resource/base.rb' + - 'qa/qa/tools/ci/non_empty_suites.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/lib/bulk_imports/groups/stage_spec.rb' + - 'spec/lib/bulk_imports/projects/stage_spec.rb' + - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/requests/api/graphql/ci/pipelines_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' + - 'spec/services/git/process_ref_changes_service_spec.rb' + - 'spec/support/shared_examples/models/with_debian_distributions_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/issue_list_shared_examples.rb' diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml new file mode 100644 index 0000000000000000000000000000000000000000..57ebe25179860069d92973394f83789d949d3c00 --- /dev/null +++ b/.rubocop_todo/performance/map_compact.yml @@ -0,0 +1,148 @@ +--- +# Cop supports --autocorrect. +Performance/MapCompact: + Details: grace period + Exclude: + - 'app/graphql/resolvers/concerns/resolves_ids.rb' + - 'app/graphql/resolvers/todos_resolver.rb' + - 'app/helpers/issuables_description_templates_helper.rb' + - 'app/helpers/notifications_helper.rb' + - 'app/models/ci/build_dependencies.rb' + - 'app/models/ci/pipeline.rb' + - 'app/models/ci/runner.rb' + - 'app/models/ci_platform_metric.rb' + - 'app/models/concerns/mentionable/reference_regexes.rb' + - 'app/models/concerns/pg_full_text_searchable.rb' + - 'app/models/container_repository.rb' + - 'app/models/design_management/design_at_version.rb' + - 'app/models/design_management/version.rb' + - 'app/models/environment.rb' + - 'app/models/environment_status.rb' + - 'app/models/instance_configuration.rb' + - 'app/models/integrations/chat_message/pipeline_message.rb' + - 'app/models/repository.rb' + - 'app/models/resource_label_event.rb' + - 'app/models/snippet_repository.rb' + - 'app/models/web_ide_terminal.rb' + - 'app/presenters/packages/conan/package_presenter.rb' + - 'app/presenters/packages/nuget/packages_metadata_presenter.rb' + - 'app/presenters/packages/nuget/search_results_presenter.rb' + - 'app/serializers/analytics/cycle_analytics/event_entity.rb' + - 'app/services/auth/container_registry_authentication_service.rb' + - 'app/services/events/render_service.rb' + - 'app/services/feature_flags/update_service.rb' + - 'app/services/git/base_hooks_service.rb' + - 'app/services/google_cloud/fetch_google_ip_list_service.rb' + - 'app/services/jira_import/start_import_service.rb' + - 'app/services/jira_import/users_mapper_service.rb' + - 'app/services/labels/available_labels_service.rb' + - 'app/services/merge_requests/get_urls_service.rb' + - 'app/services/merge_requests/pushed_branches_service.rb' + - 'app/services/merge_requests/update_service.rb' + - 'app/services/packages/maven/find_or_create_package_service.rb' + - 'app/services/projects/container_repository/third_party/delete_tags_service.rb' + - 'app/services/projects/update_statistics_service.rb' + - 'app/services/quick_actions/interpret_service.rb' + - 'app/services/repositories/changelog_service.rb' + - 'app/services/todos/allowed_target_filter_service.rb' + - 'config/initializers/trusted_proxies.rb' + - 'config/initializers/wikicloth_redos_patch.rb' + - 'ee/app/finders/security/findings_finder.rb' + - 'ee/app/graphql/ee/types/issue_connection_type.rb' + - 'ee/app/models/app_sec/fuzzing/api/ci_configuration.rb' + - 'ee/app/models/burndown.rb' + - 'ee/app/models/concerns/ee/project_security_scanners_information.rb' + - 'ee/app/models/concerns/elastic/application_versioned_search.rb' + - 'ee/app/models/gitlab_subscriptions/features.rb' + - 'ee/app/models/sca/license_compliance.rb' + - 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb' + - 'ee/app/services/app_sec/dast/scan_configs/fetch_service.rb' + - 'ee/app/services/epic_issues/create_service.rb' + - 'ee/app/services/members/activate_service.rb' + - 'ee/app/services/security/override_uuids_service.rb' + - 'ee/app/services/security/store_scan_service.rb' + - 'ee/app/services/upcoming_reconciliations/update_service.rb' + - 'ee/app/services/vulnerabilities/findings/find_or_create_from_security_finding_service.rb' + - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' + - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb' + - 'ee/lib/ee/api/entities/experiment.rb' + - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' + - 'ee/lib/ee/gitlab/auth/ldap/person.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' + - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' + - 'ee/lib/elastic/latest/repository_instance_proxy.rb' + - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb' + - 'ee/lib/gitlab/ci/parsers/security/dast.rb' + - 'ee/lib/gitlab/ci/reports/license_scanning/report.rb' + - 'ee/lib/gitlab/ci/reports/metrics/reports_comparer.rb' + - 'ee/lib/gitlab/search/aggregation_parser.rb' + - 'ee/spec/models/analytics/issues_analytics_spec.rb' + - 'ee/spec/models/member_spec.rb' + - 'ee/spec/requests/api/audit_events_spec.rb' + - 'ee/spec/requests/api/search_spec.rb' + - 'haml_lint/linter/no_plain_nodes.rb' + - 'lib/api/entities/feature.rb' + - 'lib/api/entities/project.rb' + - 'lib/api/helpers/common_helpers.rb' + - 'lib/atlassian/jira_connect/client.rb' + - 'lib/atlassian/jira_connect/serializers/feature_flag_entity.rb' + - 'lib/banzai/filter/image_link_filter.rb' + - 'lib/banzai/filter/references/design_reference_filter.rb' + - 'lib/banzai/filter/references/label_reference_filter.rb' + - 'lib/banzai/filter/references/milestone_reference_filter.rb' + - 'lib/banzai/reference_parser/issuable_parser.rb' + - 'lib/error_tracking/sentry_client/pagination_parser.rb' + - 'lib/gitaly/server.rb' + - 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb' + - 'lib/gitlab/analytics/usage_trends/workers_argument_builder.rb' + - 'lib/gitlab/auth/ip_rate_limiter.rb' + - 'lib/gitlab/background_migration/backfill_project_repositories.rb' + - 'lib/gitlab/changes_list.rb' + - 'lib/gitlab/checks/changes_access.rb' + - 'lib/gitlab/ci/parsers/security/common.rb' + - 'lib/gitlab/ci/reports/security/aggregated_report.rb' + - 'lib/gitlab/ci/reports/security/finding.rb' + - 'lib/gitlab/ci/reports/test_suite_summary.rb' + - 'lib/gitlab/config/entry/validators.rb' + - 'lib/gitlab/database/load_balancing/service_discovery.rb' + - 'lib/gitlab/database/obsolete_ignored_columns.rb' + - 'lib/gitlab/email/receiver.rb' + - 'lib/gitlab/git/commit.rb' + - 'lib/gitlab/git/conflict/file.rb' + - 'lib/gitlab/git/rugged_impl/commit.rb' + - 'lib/gitlab/github_import/importer/pull_requests/review_request_importer.rb' + - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' + - 'lib/gitlab/issues/rebalancing/state.rb' + - 'lib/gitlab/jira_import/metadata_collector.rb' + - 'lib/gitlab/json_cache.rb' + - 'lib/gitlab/language_detection.rb' + - 'lib/gitlab/legacy_github_import/importer.rb' + - 'lib/gitlab/private_commit_email.rb' + - 'lib/gitlab/sql/pattern.rb' + - 'lib/gitlab/url_blocker.rb' + - 'lib/gitlab/verify/batch_verifier.rb' + - 'qa/qa/page/component/issuable/sidebar.rb' + - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_large_project_spec.rb' + - 'qa/qa/support/formatters/test_metrics_formatter.rb' + - 'qa/qa/tools/ci/ff_changes.rb' + - 'scripts/lint_templates_bash.rb' + - 'spec/controllers/every_controller_spec.rb' + - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' + - 'spec/lib/api/every_api_endpoint_spec.rb' + - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' + - 'spec/lib/gitlab/conflict/file_spec.rb' + - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/references_configuration_spec.rb' + - 'spec/models/deployment_spec.rb' + - 'spec/models/network/graph_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/requests/api/commits_spec.rb' + - 'spec/requests/api/groups_spec.rb' + - 'spec/requests/lfs_http_spec.rb' + - 'spec/serializers/diff_file_entity_spec.rb' + - 'spec/services/projects/container_repository/third_party/cleanup_tags_service_spec.rb' + - 'spec/support/helpers/dns_helpers.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/shared_examples/features/navbar_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/config/inheritable_shared_examples.rb' + - 'spec/support/shared_examples/models/label_note_shared_examples.rb' diff --git a/.rubocop_todo/performance/redundant_equality_comparison_block.yml b/.rubocop_todo/performance/redundant_equality_comparison_block.yml new file mode 100644 index 0000000000000000000000000000000000000000..44da9710249a4a7671d1fae33c91275d0b95ee1f --- /dev/null +++ b/.rubocop_todo/performance/redundant_equality_comparison_block.yml @@ -0,0 +1,23 @@ +--- +# Cop supports --autocorrect. +Performance/RedundantEqualityComparisonBlock: + Details: grace period + Exclude: + - 'app/graphql/types/work_item_id_type.rb' + - 'app/models/concerns/group_descendant.rb' + - 'app/models/concerns/id_in_ordered.rb' + - 'app/models/todo.rb' + - 'app/validators/feature_flag_strategies_validator.rb' + - 'ee/app/helpers/ee/dashboard_helper.rb' + - 'ee/lib/compliance_management/merge_request_approval_settings/resolver.rb' + - 'ee/lib/elastic/latest/user_instance_proxy.rb' + - 'ee/lib/gitlab/geo/geo_node_status_check.rb' + - 'ee/spec/lib/ee/sidebars/projects/panel_spec.rb' + - 'lib/gitlab/ci/config/yaml/tags/reference.rb' + - 'lib/gitlab/config/entry/validators.rb' + - 'lib/gitlab/i18n/translation_entry.rb' + - 'lib/gitlab/push_options.rb' + - 'lib/gitlab/utils/delegator_override.rb' + - 'lib/gitlab/view/presenter/base.rb' + - 'spec/lib/object_storage/direct_upload_spec.rb' + - 'spec/support/import_export/project_tree_expectations.rb' diff --git a/.rubocop_todo/performance/redundant_split_regexp_argument.yml b/.rubocop_todo/performance/redundant_split_regexp_argument.yml new file mode 100644 index 0000000000000000000000000000000000000000..0c0e12480d5617f154d12bf08cb2f7249cec4e0e --- /dev/null +++ b/.rubocop_todo/performance/redundant_split_regexp_argument.yml @@ -0,0 +1,8 @@ +--- +# Cop supports --autocorrect. +Performance/RedundantSplitRegexpArgument: + Details: grace period + Exclude: + - 'lib/file_size_validator.rb' + - 'lib/gitlab/git/raw_diff_change.rb' + - 'lib/kramdown/converter/commonmark.rb' diff --git a/.rubocop_todo/performance/string_identifier_argument.yml b/.rubocop_todo/performance/string_identifier_argument.yml new file mode 100644 index 0000000000000000000000000000000000000000..cf9b1fe5cf790a94566b0a91ed1635d805f29e5f --- /dev/null +++ b/.rubocop_todo/performance/string_identifier_argument.yml @@ -0,0 +1,39 @@ +--- +# Cop supports --autocorrect. +Performance/StringIdentifierArgument: + Details: grace period + Exclude: + - 'ee/lib/gitlab/ingestion/bulk_insertable_task.rb' + - 'ee/spec/lib/audit/base_changes_auditor_spec.rb' + - 'ee/spec/lib/gitlab/rack_attack_spec.rb' + - 'ee/spec/lib/gitlab/status_page/storage/s3_client_spec.rb' + - 'ee/spec/presenters/ci/minutes/usage_presenter_spec.rb' + - 'ee/spec/serializers/test_reports_comparer_entity_spec.rb' + - 'ee/spec/serializers/test_reports_comparer_serializer_spec.rb' + - 'ee/spec/serializers/test_suite_comparer_entity_spec.rb' + - 'lib/gitlab/background_migration/batched_migration_job.rb' + - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' + - 'lib/gitlab/git_access.rb' + - 'lib/gitlab/graphql/deprecations_base.rb' + - 'lib/gitlab/net_http_adapter.rb' + - 'lib/gitlab/sidekiq_config/cli_methods.rb' + - 'lib/gitlab/usage/metrics/instrumentations/base_metric.rb' + - 'metrics_server/settings_overrides.rb' + - 'qa/qa/resource/project.rb' + - 'qa/qa/vendor/jenkins/job.rb' + - 'sidekiq_cluster/cli.rb' + - 'spec/factories/wiki_pages.rb' + - 'spec/helpers/projects_helper_spec.rb' + - 'spec/lib/api/helpers/packages_helpers_spec.rb' + - 'spec/lib/banzai/filter/references/reference_filter_spec.rb' + - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' + - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' + - 'spec/lib/gitlab/database/partitioning_spec.rb' + - 'spec/lib/gitlab/http_spec.rb' + - 'spec/lib/gitlab/rack_attack_spec.rb' + - 'spec/lib/gitlab/submodule_links_spec.rb' + - 'spec/lib/gitlab/tracking_spec.rb' + - 'spec/lib/gitlab/utils/lazy_attributes_spec.rb' + - 'spec/services/merge_requests/refresh_service_spec.rb' + - 'spec/support/shared_examples/models/concerns/integrations/reset_secret_fields_shared_examples.rb' + - 'spec/support/shared_examples/quick_actions/issuable/close_quick_action_shared_examples.rb' diff --git a/Gemfile b/Gemfile index 417dc56637da3006e2a78b5c74172569df17b496..b1d6d5babdcddb0883699346a6ced5342dba575c 100644 --- a/Gemfile +++ b/Gemfile @@ -395,7 +395,7 @@ group :development, :test do gem 'spring', '~> 4.1.0' gem 'spring-commands-rspec', '~> 1.0.4' - gem 'gitlab-styles', '~> 9.1.0', require: false + gem 'gitlab-styles', '~> 9.2.0', require: false gem 'haml_lint', '~> 0.40.0', require: false gem 'bundler-audit', '~> 0.7.0.1', require: false diff --git a/Gemfile.checksum b/Gemfile.checksum index aa288566a452e5019c0d198d4e8f2c6e9b4743b3..1a42f26ffcde63ea236891fc449a7b2083580dfb 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -210,7 +210,7 @@ {"name":"gitlab-net-dns","version":"0.9.1","platform":"ruby","checksum":"bcd1a08dcb31b731e8ff602d828de619d2d9f53f5812f6abacf11c720873d4cb"}, {"name":"gitlab-omniauth-openid-connect","version":"0.10.0","platform":"ruby","checksum":"ea44a23ea93457057bba6a9912e883f5aefab36a941c6c58512c8a7095fb1153"}, {"name":"gitlab-sidekiq-fetcher","version":"0.9.0","platform":"ruby","checksum":"54041aec059f20c8e6dfce394e1b60e0c0a9c7cef32da912a58abbd333e13897"}, -{"name":"gitlab-styles","version":"9.1.0","platform":"ruby","checksum":"46fd4e9f7fc74b0dfdb0bd7aa2f5796fb4d5b01e5886d7779726f8b53a3c02b2"}, +{"name":"gitlab-styles","version":"9.2.0","platform":"ruby","checksum":"7106e7fb2de01f0c4a8d074ccff5c1f37502eab98cc51c8b5dd72a081785cea4"}, {"name":"gitlab_chronic_duration","version":"0.10.6.2","platform":"ruby","checksum":"6dda4cfe7dca9b958f163ac8835c3d9cc70cf8df8cbb89bb2fbf9ba4375105fb"}, {"name":"gitlab_omniauth-ldap","version":"2.2.0","platform":"ruby","checksum":"bb4d20acb3b123ed654a8f6a47d3fac673ece7ed0b6992edb92dca14bad2838c"}, {"name":"globalid","version":"1.0.0","platform":"ruby","checksum":"1253641b1dc3392721c964351773755d75135d3d3c5cc65d88b0a3880a60bed8"}, @@ -505,9 +505,9 @@ {"name":"rubocop-ast","version":"1.23.0","platform":"ruby","checksum":"fe4bafaa0a6ccf400849fb720f9dd2428b07b00fcdeeec33a8f1146e0c1e38e2"}, {"name":"rubocop-gitlab-security","version":"0.1.1","platform":"ruby","checksum":"96f6ed727847a5876ddfc89ee0399438a1aef7934db773c7efce907e2720006c"}, {"name":"rubocop-graphql","version":"0.18.0","platform":"ruby","checksum":"f1c43999fb9ef0e32b30e2ce2fa0ddb1f3a6215c85baf3fdf9753a0bb96bc998"}, -{"name":"rubocop-performance","version":"1.15.0","platform":"ruby","checksum":"8cd8ff22c567dfacf0292963c05f26c503638d0805a109e8c1f2a2a7955006c0"}, -{"name":"rubocop-rails","version":"2.17.2","platform":"ruby","checksum":"d14008d3a082f05300ff5f6cc21f8217f226ce0c1fc67e01b66bb5131f8f5b14"}, -{"name":"rubocop-rspec","version":"2.15.0","platform":"ruby","checksum":"a476c7671bbeabc9706068be0aa0443a559db6d2b84bfdc582fe65f64b1d455e"}, +{"name":"rubocop-performance","version":"1.15.1","platform":"ruby","checksum":"8d4f1839e7043364269d15b8191eadda29a4bb937ec29e74fdb074511d048d02"}, +{"name":"rubocop-rails","version":"2.17.3","platform":"ruby","checksum":"7d857aa339577c9e0e156cc3f5b68b63efc429eba39863cbd8a496c7f80e65af"}, +{"name":"rubocop-rspec","version":"2.16.0","platform":"ruby","checksum":"b33c5f048182bdb43885958f4115865d49438694fffac98b5406f70302e7ece6"}, {"name":"ruby-fogbugz","version":"0.3.0","platform":"ruby","checksum":"5e04cde474648f498a71cf1e1a7ab42c66b953862fbe224f793ec0a7a1d5f657"}, {"name":"ruby-magic","version":"0.5.4","platform":"ruby","checksum":"2c17b185130d10a83791f63a40baa358c4b138af37da3f4dab53690121c421d5"}, {"name":"ruby-progressbar","version":"1.11.0","platform":"ruby","checksum":"cc127db3866dc414ffccbf92928a241e585b3aa2b758a5563e74a6ee0f57d50a"}, diff --git a/Gemfile.lock b/Gemfile.lock index cfc1503b44a1fe9105ba6825bbf73616c945b119..361b3f952c16b394e2f0818dae0383717b9e330a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -598,7 +598,7 @@ GEM gitlab-sidekiq-fetcher (0.9.0) json (>= 2.5) sidekiq (~> 6.1) - gitlab-styles (9.1.0) + gitlab-styles (9.2.0) rubocop (~> 1.38.0) rubocop-gitlab-security (~> 0.1.1) rubocop-graphql (~> 0.14) @@ -1274,14 +1274,14 @@ GEM rubocop (>= 0.51) rubocop-graphql (0.18.0) rubocop (>= 0.87, < 2) - rubocop-performance (1.15.0) + rubocop-performance (1.15.1) rubocop (>= 1.7.0, < 2.0) rubocop-ast (>= 0.4.0) - rubocop-rails (2.17.2) + rubocop-rails (2.17.3) activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) - rubocop-rspec (2.15.0) + rubocop-rspec (2.16.0) rubocop (~> 1.33) ruby-fogbugz (0.3.0) crack (~> 0.4) @@ -1672,7 +1672,7 @@ DEPENDENCIES gitlab-net-dns (~> 0.9.1) gitlab-omniauth-openid-connect (~> 0.10.0) gitlab-sidekiq-fetcher (= 0.9.0) - gitlab-styles (~> 9.1.0) + gitlab-styles (~> 9.2.0) gitlab_chronic_duration (~> 0.10.6.2) gitlab_omniauth-ldap (~> 2.2.0) gon (~> 6.4.0) diff --git a/app/views/ci/group_variables/_index.html.haml b/app/views/ci/group_variables/_index.html.haml index eb49a9a0261a7bedebfcc4c50293d1d86b870a16..c8c970f3c2fad73c8c4b3770fff2458cdc699622 100644 --- a/app/views/ci/group_variables/_index.html.haml +++ b/app/views/ci/group_variables/_index.html.haml @@ -1,4 +1,4 @@ -- variables = @project.group.self_and_ancestors.map(&:variables).flatten +- variables = @project.group.self_and_ancestors.flat_map(&:variables) .ci-variable-table %table.gl-table.gl-w-full.gl-table-layout-fixed diff --git a/ee/app/views/shared/milestones/_issuables_weight.html.haml b/ee/app/views/shared/milestones/_issuables_weight.html.haml index 0dae0c47d1d7e869af5df6c9fb600ff218910b7b..3001702522aaed0890f12cef72e56e22be82b547 100644 --- a/ee/app/views/shared/milestones/_issuables_weight.html.haml +++ b/ee/app/views/shared/milestones/_issuables_weight.html.haml @@ -1,5 +1,5 @@ - issuables = local_assigns.fetch(:issuables) -- issuables_with_weight = issuables.select(&:weight_available?).map(&:weight).compact +- issuables_with_weight = issuables.select(&:weight_available?).filter_map(&:weight) - return if issuables_with_weight.empty?