Review requested dashboard is showing MRs that are updated since last review but not re-requested
Problem
When I'm assigned an MR to review and I approve it and later the author pushes more changes that revert my approval then the MR re-appears in my "Review requested" in the MR dashboard.
This is usually incorrect for my workflow (ie. I do not need to take action) because one or more of the following apply:
- The MR has not re-requested my review and they may be making more changes before my review
- The MR was actually finished with my review and passed along to another maintainer for subsequent reviews and I'm not needed to review it at all anymore
For some reason this seems like a new problem for me but based on discussions in Slack (internal) it is apparently not new behaviour.
Workaround
Since I rely on the "Review requested" to be my work queue I need to do something about it. I can either open the MR and just /submit_review
with nothing or I can unassign myself.
Solution
Something should only show up in "Review requested" if the author actually re-requested my review. It should also be in sync with the other feature on MRs which shows whether or not the review has been requested.