[go: up one dir, main page]

Skip to content

Duo Code Review - unify thumbs up/down and resolve comment

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Problem

Right now not everybody is clicking thumbs up/down on Duo Code Review comments. We want more of this data to help us improve the quality of code review.

We don't necessarily want to enforce this somehow because it will add friction and that might discourage people from using it.

Solution

Users are already required to click "Resolve" on any discussions from Duo Code Review. So there is already some level of required friction of 1 click per comment. We could possibly leverage this to get the feedback at the same time. We could do this in 2 possible ways:

  1. Split the "Resolve" button into 2 buttons, "Resolve as actioned" and "Resolve as ignored"
  2. Clicking the thumbs down button could resolve the discussion. Also optionally clicking 👍 could resolve it. And optionally change thumbs up to and have it resolve the discussion as a clear signal that it was actioned.
Edited by 🤖 GitLab Bot 🤖