[go: up one dir, main page]

Skip to content

[SPIKE] Add logic to Projects::AllBranchesRule::MergeRequestApprovalSetting to load require_reauthentication_to_approve

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

In Create Projects::BranchRules::MergeRequestAppro... (#504615 - closed) we created a new table to store the approval settings. For the All branches rule we need to fetch the project setting values instead.

We have renamed require_password_to_approve in Rename require_password_to_approve (#431346)

As I'm currently not 100% sure if we can just proxy project.project_settings.require_reauthentication_to_approve I have marked this issue as a spike.

Please check through that issue to ensure ignoring the old attribute in favor of require_reauthentication_to_approve is sufficient.

Desired outcomes

Either:

  1. we implement the method to return the correct value from the project settings
  2. we create a new issue with a plan on how to proceed
Edited by 🤖 GitLab Bot 🤖