[go: up one dir, main page]

Skip to content

Handle runtime error when attempting to access dns_zone on nil workspace_agent_config

MR: Pending

Description

We received a sentry report of a workspace model being associated to a nil workspace_agent_config when attempting to build the workspace URL (which is dependent on the config's dns_zone).

we believe this error to be as a result of a temporary intermittent state, as the workspace in question was terminated and this does not occur frequently in the logs.

proposed fix

We should make the URL method fail-safe and make it return an empty string if the agent_config is not present

follow-ups/open questions

  • Should we dig more into this intermittent state that allows for such errors ?
  • Should we always be in the habit of doing this if nil returns empty checks ?
  • Add this behaviour in other possible places it could occur ?

Acceptance Criteria

  • Return an empty string in the URL method if the agent config is missing

Technical Requirements

Design Requirements

Impact Assessment

User Story

Edited by Safwan Ahmed