compare changes with side-by-side could have an option to show inline for file adds/deletes
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Release notes
When viewing "compare changes" in side-by-side mode, changes that are complete file adds or deletes just waste screen real estate; there's nothing to see side-by-side and the nature of the "diff" is denoted by the green or red background color (among other indicators).
Just as with the "show whitespace changes" check box it would be nice to have an option to show file adds/deletes as inline while also showing side-by-side view for files that only have internal diffs.
Problem to solve
Trying to do a code review in side-by-side mode where the MR contains a mix of file additions (like extracting some code into a new library) and internal edits (like rewrite code to call the extracted library). Constantly changing the "new file" view to inline and then changing back to side-by-side for other files disrupts focus.
Intended users
Anyone doing code reviews (mostly developers).
User experience goal
The user should be able to review an MR in side-by-side mode but see file adds/deletes in the inline style (not wasting half the screen with a completely blank pane).
Proposal
My naive approach would be to add check box, alongside "show whitespace changes", that indicates the user wants to view file adds/deletes in inline style even when side-by-side mode is selected.
Further details
Allows someone to do a review and remain focused on the most relevant changes front and center (no wasted screen space).
Permissions and Security
This only affects the reviewer experience looking at an MR. If a person is doing an MR review they already have
Documentation
Probably just needs documentation similar to that of "show whitespace changes".
Availability & Testing
Probably just needs testing similar to that of "show whitespace changes".
Available Tier
Recommend for free tier; this is not a substantial paid-tier feature.
Feature Usage Metrics
Probably just needs metrics similar to that of "show whitespace changes".
What does success look like, and how can we measure that?
One metric of success: competitors copy this feture.
What is the type of buyer?
N/A.
Is this a cross-stage feature?
No.
What is the competitive advantage or differentiation for this feature?
Mostly for developer convenience.